test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java
author herrick
Wed, 16 Oct 2019 10:32:08 -0400
branchJDK-8200758-branch
changeset 58648 3bf53ffa9ae7
parent 58434 b00cbf427368
child 58696 61c44899b4eb
permissions -rw-r--r--
8232279 : Improve test helpers #2 Submitted-by: asemenyuk Reviewed-by: aherrick, almatvee
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     1
/*
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     2
 * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     4
 *
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     7
 * published by the Free Software Foundation.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     8
 *
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    13
 * accompanied this code).
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    14
 *
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    18
 *
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    21
 * questions.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    22
 */
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    23
package jdk.jpackage.test;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    24
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    25
import java.awt.Desktop;
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    26
import java.io.File;
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    27
import java.nio.file.Files;
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    28
import java.nio.file.Path;
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
    29
import java.util.*;
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    30
import java.util.function.BiConsumer;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    31
import java.util.function.Consumer;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    32
import java.util.function.Supplier;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    33
import java.util.stream.Collectors;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    34
import java.util.stream.Stream;
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
    35
import jdk.jpackage.test.Functional.ThrowingConsumer;
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
    36
import static jdk.jpackage.test.PackageType.*;
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    37
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    38
/**
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    39
 * Instance of PackageTest is for configuring and running a single jpackage
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    40
 * command to produce platform specific package bundle.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    41
 *
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
    42
 * Provides methods to hook up custom configuration of jpackage command and
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    43
 * verification of the output bundle.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    44
 */
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    45
public final class PackageTest {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    46
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    47
    /**
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    48
     * Default test configuration for jpackage command. Default jpackage command
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    49
     * initialization includes:
58147
45a9084fe981 8230521: rename --output/-o option and add default value (".")
herrick
parents: 58113
diff changeset
    50
     * <li>Set --input and --dest parameters.
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    51
     * <li>Set --name parameter. Value of the parameter is the name of the first
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    52
     * class with main function found in the callers stack. Defaults can be
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    53
     * overridden with custom initializers set with subsequent addInitializer()
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    54
     * function calls.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    55
     */
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    56
    public PackageTest() {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    57
        action = DEFAULT_ACTION;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    58
        forTypes();
58434
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
    59
        setExpectedExitCode(0);
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    60
        handlers = new HashMap<>();
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    61
        namedInitializers = new HashSet<>();
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    62
        currentTypes.forEach(v -> handlers.put(v, new Handler(v)));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    63
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    64
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    65
    public PackageTest forTypes(PackageType... types) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    66
        Collection<PackageType> newTypes;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    67
        if (types == null || types.length == 0) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    68
            newTypes = PackageType.NATIVE;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    69
        } else {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    70
            newTypes = Set.of(types);
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    71
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    72
        currentTypes = newTypes.stream().filter(type -> type.isSupported()).collect(
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    73
                Collectors.toUnmodifiableSet());
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    74
        return this;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    75
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    76
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    77
    public PackageTest forTypes(Collection<PackageType> types) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    78
        return forTypes(types.toArray(PackageType[]::new));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    79
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    80
58434
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
    81
    public PackageTest setExpectedExitCode(int v) {
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    82
        expectedJPackageExitCode = v;
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    83
        return this;
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    84
    }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    85
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
    86
    private PackageTest addInitializer(ThrowingConsumer<JPackageCommand> v, String id) {
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    87
        if (id != null) {
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    88
            if (namedInitializers.contains(id)) {
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    89
                return this;
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    90
            }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    91
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    92
            namedInitializers.add(id);
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    93
        }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
    94
        currentTypes.stream().forEach(type -> handlers.get(type).addInitializer(
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
    95
                ThrowingConsumer.toConsumer(v)));
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    96
        return this;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    97
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
    98
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
    99
    public PackageTest addInitializer(ThrowingConsumer<JPackageCommand> v) {
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   100
        return addInitializer(v, null);
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   101
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   102
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   103
    public PackageTest addBundleVerifier(
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   104
            BiConsumer<JPackageCommand, Executor.Result> v) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   105
        currentTypes.stream().forEach(
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   106
                type -> handlers.get(type).addBundleVerifier(v));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   107
        return this;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   108
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   109
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   110
    public PackageTest addBundleVerifier(ThrowingConsumer<JPackageCommand> v) {
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   111
        return addBundleVerifier(
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   112
                (cmd, unused) -> ThrowingConsumer.toConsumer(v).accept(cmd));
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   113
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   114
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   115
    public PackageTest addBundlePropertyVerifier(String propertyName,
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   116
            BiConsumer<String, String> pred) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   117
        return addBundleVerifier(cmd -> {
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   118
            pred.accept(propertyName,
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   119
                    LinuxHelper.getBundleProperty(cmd, propertyName));
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   120
        });
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   121
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   122
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   123
    public PackageTest addBundlePropertyVerifier(String propertyName,
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   124
            String expectedPropertyValue) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   125
        return addBundlePropertyVerifier(propertyName, (unused, v) -> {
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   126
            TKit.assertEquals(expectedPropertyValue, v, String.format(
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   127
                    "Check value of %s property is [%s]", propertyName, v));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   128
        });
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   129
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   130
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   131
    public PackageTest addBundleDesktopIntegrationVerifier(boolean integrated) {
58417
67ffaf3a2b75 8231280: Linux packages produced by jpackage should have correct dependencies
herrick
parents: 58416
diff changeset
   132
        forTypes(LINUX, () -> {
67ffaf3a2b75 8231280: Linux packages produced by jpackage should have correct dependencies
herrick
parents: 58416
diff changeset
   133
            LinuxHelper.addBundleDesktopIntegrationVerifier(this, integrated);
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   134
        });
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   135
        return this;
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   136
    }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   137
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   138
    public PackageTest addInstallVerifier(ThrowingConsumer<JPackageCommand> v) {
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   139
        currentTypes.stream().forEach(
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   140
                type -> handlers.get(type).addInstallVerifier(
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   141
                        ThrowingConsumer.toConsumer(v)));
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   142
        return this;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   143
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   144
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   145
    public PackageTest addUninstallVerifier(ThrowingConsumer<JPackageCommand> v) {
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   146
        currentTypes.stream().forEach(
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   147
                type -> handlers.get(type).addUninstallVerifier(
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   148
                        ThrowingConsumer.toConsumer(v)));
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   149
        return this;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   150
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   151
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   152
    static void withTestFileAssociationsFile(FileAssociations fa, ThrowingConsumer<Path> consumer) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   153
        final String testFileDefaultName = String.join(".", "test", fa.getSuffix());
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   154
        TKit.withTempFile(testFileDefaultName, fa.getSuffix(), testFile -> {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   155
            if (TKit.isLinux()) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   156
                LinuxHelper.initFileAssociationsTestFile(testFile);
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   157
            }
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   158
            consumer.accept(testFile);
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   159
        });
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   160
    }
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   161
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   162
    public PackageTest addHelloAppFileAssociationsVerifier(FileAssociations fa,
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   163
            String... faLauncherDefaultArgs) {
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   164
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   165
        addInitializer(cmd -> new HelloApp(null).addTo(cmd), "HelloApp");
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   166
        addInstallVerifier(cmd -> {
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   167
            if (cmd.isFakeRuntime("Not running file associations test")) {
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   168
                return;
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   169
            }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   170
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   171
            withTestFileAssociationsFile(fa, testFile -> {
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   172
                testFile = testFile.toAbsolutePath().normalize();
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   173
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   174
                final Path appOutput = Path.of(HelloApp.OUTPUT_FILENAME);
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   175
                Files.deleteIfExists(appOutput);
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   176
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   177
                TKit.trace(String.format("Use desktop to open [%s] file",
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   178
                        testFile));
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   179
                Desktop.getDesktop().open(testFile.toFile());
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   180
                TKit.waitForFileCreated(appOutput, 7);
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   181
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   182
                List<String> expectedArgs = new ArrayList<>(List.of(
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   183
                        faLauncherDefaultArgs));
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   184
                expectedArgs.add(testFile.toString());
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   185
58304
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   186
                // Wait a little bit after file has been created to
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   187
                // make sure there are no pending writes into it.
7a61351edad2 8231282 : Revisit --linux-deb-copyright option
herrick
parents: 58301
diff changeset
   188
                Thread.sleep(3000);
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   189
                HelloApp.verifyOutputFile(appOutput, expectedArgs);
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   190
            });
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   191
        });
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   192
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   193
        forTypes(PackageType.LINUX, () -> {
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   194
            LinuxHelper.addFileAssociationsVerifier(this, fa);
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   195
        });
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   196
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   197
        return this;
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   198
    }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   199
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   200
    PackageTest forTypes(Collection<PackageType> types, Runnable action) {
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   201
        Set<PackageType> oldTypes = Set.of(currentTypes.toArray(
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   202
                PackageType[]::new));
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   203
        try {
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   204
            forTypes(types);
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   205
            action.run();
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   206
        } finally {
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   207
            forTypes(oldTypes);
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   208
        }
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   209
        return this;
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   210
    }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   211
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   212
    PackageTest forTypes(PackageType type, Runnable action) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   213
        return forTypes(List.of(type), action);
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   214
    }
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   215
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   216
    public PackageTest configureHelloApp() {
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   217
        return configureHelloApp(null);
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   218
    }
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   219
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   220
    public PackageTest configureHelloApp(String encodedName) {
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   221
        addInitializer(
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   222
                cmd -> new HelloApp(JavaAppDesc.parse(encodedName)).addTo(cmd));
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   223
        addInstallVerifier(HelloApp::executeLauncherAndVerifyOutput);
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   224
        return this;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   225
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   226
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   227
    public void run() {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   228
        List<Handler> supportedHandlers = handlers.values().stream()
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   229
                .filter(entry -> !entry.isVoid())
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   230
                .collect(Collectors.toList());
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   231
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   232
        if (supportedHandlers.isEmpty()) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   233
            // No handlers with initializers found. Nothing to do.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   234
            return;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   235
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   236
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   237
        Supplier<JPackageCommand> initializer = new Supplier<>() {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   238
            @Override
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   239
            public JPackageCommand get() {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   240
                JPackageCommand cmd = new JPackageCommand().setDefaultInputOutput();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   241
                if (bundleOutputDir != null) {
58147
45a9084fe981 8230521: rename --output/-o option and add default value (".")
herrick
parents: 58113
diff changeset
   242
                    cmd.setArgumentValue("--dest", bundleOutputDir.toString());
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   243
                }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   244
                cmd.setDefaultAppName();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   245
                return cmd;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   246
            }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   247
        };
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   248
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   249
        supportedHandlers.forEach(handler -> handler.accept(initializer.get()));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   250
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   251
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   252
    public PackageTest setAction(Action value) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   253
        action = value;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   254
        return this;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   255
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   256
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   257
    public Action getAction() {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   258
        return action;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   259
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   260
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   261
    private class Handler implements Consumer<JPackageCommand> {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   262
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   263
        Handler(PackageType type) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   264
            if (!PackageType.NATIVE.contains(type)) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   265
                throw new IllegalArgumentException(
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   266
                        "Attempt to configure a test for image packaging");
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   267
            }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   268
            this.type = type;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   269
            initializers = new ArrayList<>();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   270
            bundleVerifiers = new ArrayList<>();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   271
            installVerifiers = new ArrayList<>();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   272
            uninstallVerifiers = new ArrayList<>();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   273
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   274
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   275
        boolean isVoid() {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   276
            return initializers.isEmpty();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   277
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   278
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   279
        void addInitializer(Consumer<JPackageCommand> v) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   280
            initializers.add(v);
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   281
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   282
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   283
        void addBundleVerifier(BiConsumer<JPackageCommand, Executor.Result> v) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   284
            bundleVerifiers.add(v);
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   285
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   286
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   287
        void addInstallVerifier(Consumer<JPackageCommand> v) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   288
            installVerifiers.add(v);
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   289
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   290
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   291
        void addUninstallVerifier(Consumer<JPackageCommand> v) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   292
            uninstallVerifiers.add(v);
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   293
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   294
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   295
        @Override
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   296
        public void accept(JPackageCommand cmd) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   297
            type.applyTo(cmd);
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   298
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   299
            initializers.stream().forEach(v -> v.accept(cmd));
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   300
            cmd.executePrerequisiteActions();
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   301
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   302
            switch (action) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   303
                case CREATE:
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   304
                    Executor.Result result = cmd.execute();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   305
                    result.assertExitCodeIs(expectedJPackageExitCode);
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   306
                    if (expectedJPackageExitCode == 0) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   307
                        TKit.assertFileExists(cmd.outputBundle());
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   308
                    } else {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   309
                        TKit.assertPathExists(cmd.outputBundle(), false);
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   310
                    }
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   311
                    verifyPackageBundle(cmd.createImmutableCopy(), result);
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   312
                    break;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   313
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   314
                case VERIFY_INSTALL:
58434
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   315
                    if (expectedJPackageExitCode == 0) {
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   316
                        verifyPackageInstalled(cmd.createImmutableCopy());
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   317
                    }
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   318
                    break;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   319
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   320
                case VERIFY_UNINSTALL:
58434
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   321
                    if (expectedJPackageExitCode == 0) {
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   322
                        verifyPackageUninstalled(cmd.createImmutableCopy());
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   323
                    }
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   324
                    break;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   325
            }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   326
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   327
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   328
        private void verifyPackageBundle(JPackageCommand cmd,
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   329
                Executor.Result result) {
58434
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   330
            if (expectedJPackageExitCode == 0) {
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   331
                if (PackageType.LINUX.contains(cmd.packageType())) {
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   332
                    LinuxHelper.verifyPackageBundleEssential(cmd);
b00cbf427368 8231721 : jpackage --install-dir should reject system dirs on Linux
herrick
parents: 58417
diff changeset
   333
                }
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   334
            }
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   335
            bundleVerifiers.stream().forEach(v -> v.accept(cmd, result));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   336
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   337
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   338
        private void verifyPackageInstalled(JPackageCommand cmd) {
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   339
            TKit.trace(String.format("Verify installed: %s",
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   340
                    cmd.getPrintableCommandLine()));
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   341
            TKit.assertDirectoryExists(cmd.appRuntimeDirectory());
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   342
            if (!cmd.isRuntime()) {
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   343
                TKit.assertExecutableFileExists(cmd.appLauncherPath());
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   344
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   345
                if (PackageType.WINDOWS.contains(cmd.packageType())) {
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   346
                    new WindowsHelper.AppVerifier(cmd);
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   347
                }
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   348
            }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   349
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   350
            installVerifiers.stream().forEach(v -> v.accept(cmd));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   351
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   352
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   353
        private void verifyPackageUninstalled(JPackageCommand cmd) {
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   354
            TKit.trace(String.format("Verify uninstalled: %s",
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   355
                    cmd.getPrintableCommandLine()));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   356
            if (!cmd.isRuntime()) {
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   357
                TKit.assertPathExists(cmd.appLauncherPath(), false);
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   358
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   359
                if (PackageType.WINDOWS.contains(cmd.packageType())) {
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   360
                    new WindowsHelper.AppVerifier(cmd);
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   361
                }
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   362
            }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   363
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58434
diff changeset
   364
            TKit.assertPathExists(cmd.appInstallationDirectory(), false);
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   365
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   366
            uninstallVerifiers.stream().forEach(v -> v.accept(cmd));
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   367
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   368
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   369
        private final PackageType type;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   370
        private final List<Consumer<JPackageCommand>> initializers;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   371
        private final List<BiConsumer<JPackageCommand, Executor.Result>> bundleVerifiers;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   372
        private final List<Consumer<JPackageCommand>> installVerifiers;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   373
        private final List<Consumer<JPackageCommand>> uninstallVerifiers;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   374
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   375
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   376
    private Collection<PackageType> currentTypes;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   377
    private int expectedJPackageExitCode;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   378
    private Map<PackageType, Handler> handlers;
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   379
    private Set<String> namedInitializers;
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   380
    private Action action;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   381
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   382
    /**
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   383
     * Test action.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   384
     */
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   385
    static public enum Action {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   386
        /**
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   387
         * Create bundle.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   388
         */
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   389
        CREATE,
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   390
        /**
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   391
         * Verify bundle installed.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   392
         */
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   393
        VERIFY_INSTALL,
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   394
        /**
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   395
         * Verify bundle uninstalled.
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   396
         */
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   397
        VERIFY_UNINSTALL;
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   398
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   399
        @Override
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   400
        public String toString() {
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   401
            return name().toLowerCase().replace('_', '-');
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   402
        }
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   403
    };
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   404
    private final static Action DEFAULT_ACTION;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   405
    private final static File bundleOutputDir;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   406
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   407
    static {
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   408
        final String propertyName = "output";
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   409
        String val = TKit.getConfigProperty(propertyName);
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   410
        if (val == null) {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   411
            bundleOutputDir = null;
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   412
        } else {
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   413
            bundleOutputDir = new File(val).getAbsoluteFile();
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   414
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   415
            if (!bundleOutputDir.isDirectory()) {
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   416
                throw new IllegalArgumentException(String.format("Invalid value of %s sytem property: [%s]. Should be existing directory",
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   417
                        TKit.getConfigPropertyName(propertyName),
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   418
                        bundleOutputDir));
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   419
            }
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   420
        }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   421
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   422
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   423
    static {
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   424
        final String propertyName = "action";
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   425
        String action = Optional.ofNullable(TKit.getConfigProperty(propertyName)).orElse(
58301
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   426
                Action.CREATE.toString()).toLowerCase();
e0efb29609bd 8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
herrick
parents: 58147
diff changeset
   427
        DEFAULT_ACTION = Stream.of(Action.values()).filter(
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   428
                a -> a.toString().equals(action)).findFirst().orElseThrow(() -> new IllegalArgumentException(String.format("Unrecognized value of %s property: [%s]",
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58304
diff changeset
   429
                                TKit.getConfigPropertyName(propertyName), action)));
58113
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   430
    }
885b0543f6e4 8230726: Improve jpackage jtreg tests
herrick
parents: 58036
diff changeset
   431
}