hotspot/src/share/vm/services/diagnosticArgument.cpp
author fparain
Wed, 25 Jan 2012 10:32:29 -0800
changeset 11596 3b9802e6c6a2
parent 11209 110525ac80b0
child 11776 519643dbbefb
permissions -rw-r--r--
7131346: Parsing of boolean arguments to diagnostic commands is broken Reviewed-by: dholmes, dcubed
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
11209
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     1
/*
11596
3b9802e6c6a2 7131346: Parsing of boolean arguments to diagnostic commands is broken
fparain
parents: 11209
diff changeset
     2
 * Copyright (c) 2011, 2012 Oracle and/or its affiliates. All rights reserved.
11209
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     4
 *
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     7
 * published by the Free Software Foundation.
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     8
 *
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    13
 * accompanied this code).
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    14
 *
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    18
 *
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    21
 * questions.
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    22
 *
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    23
 */
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    24
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    25
#include "precompiled.hpp"
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    26
#include "memory/allocation.inline.hpp"
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    27
#include "runtime/thread.hpp"
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    28
#include "services/diagnosticArgument.hpp"
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    29
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    30
void GenDCmdArgument::read_value(const char* str, size_t len, TRAPS) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    31
  if (is_set()) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    32
    THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(),
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    33
            "Duplicates in diagnostic command arguments");
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    34
  }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    35
  parse_value(str, len, CHECK);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    36
  set_is_set(true);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    37
}
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    38
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    39
template <> void DCmdArgument<jlong>::parse_value(const char* str,
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    40
                                                  size_t len, TRAPS) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    41
  if (sscanf(str, INT64_FORMAT, &_value) != 1) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    42
    THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(),
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    43
      "Integer parsing error in diagnostic command arguments");
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    44
  }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    45
}
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    46
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    47
template <> void DCmdArgument<jlong>::init_value(TRAPS) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    48
  if (has_default()) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    49
    this->parse_value(_default_string, strlen(_default_string), THREAD);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    50
    if (HAS_PENDING_EXCEPTION) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    51
      fatal("Default string must be parsable");
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    52
    }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    53
  } else {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    54
    set_value(0);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    55
  }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    56
}
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    57
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    58
template <> void DCmdArgument<jlong>::destroy_value() { }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    59
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    60
template <> void DCmdArgument<bool>::parse_value(const char* str,
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    61
                                                 size_t len, TRAPS) {
11596
3b9802e6c6a2 7131346: Parsing of boolean arguments to diagnostic commands is broken
fparain
parents: 11209
diff changeset
    62
  // len is the length of the current token starting at str
11209
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    63
  if (len == 0) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    64
    set_value(true);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    65
  } else {
11596
3b9802e6c6a2 7131346: Parsing of boolean arguments to diagnostic commands is broken
fparain
parents: 11209
diff changeset
    66
    if (len == strlen("true") && strncasecmp(str, "true", len) == 0) {
11209
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    67
       set_value(true);
11596
3b9802e6c6a2 7131346: Parsing of boolean arguments to diagnostic commands is broken
fparain
parents: 11209
diff changeset
    68
    } else if (len == strlen("false") && strncasecmp(str, "false", len) == 0) {
11209
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    69
       set_value(false);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    70
    } else {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    71
      THROW_MSG(vmSymbols::java_lang_IllegalArgumentException(),
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    72
        "Boolean parsing error in diagnostic command arguments");
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    73
    }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    74
  }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    75
}
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    76
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    77
template <> void DCmdArgument<bool>::init_value(TRAPS) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    78
  if (has_default()) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    79
    this->parse_value(_default_string, strlen(_default_string), THREAD);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    80
    if (HAS_PENDING_EXCEPTION) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    81
      fatal("Default string must be parsable");
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    82
    }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    83
  } else {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    84
    set_value(false);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    85
  }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    86
}
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    87
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    88
template <> void DCmdArgument<bool>::destroy_value() { }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    89
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    90
template <> void DCmdArgument<char*>::parse_value(const char* str,
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    91
                                                  size_t len, TRAPS) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    92
  _value = NEW_C_HEAP_ARRAY(char, len+1);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    93
  strncpy(_value, str, len);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    94
  _value[len] = 0;
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    95
}
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    96
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    97
template <> void DCmdArgument<char*>::init_value(TRAPS) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    98
  if (has_default()) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
    99
    this->parse_value(_default_string, strlen(_default_string), THREAD);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   100
    if (HAS_PENDING_EXCEPTION) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   101
      fatal("Default string must be parsable");
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   102
    }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   103
  } else {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   104
    set_value(NULL);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   105
  }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   106
}
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   107
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   108
template <> void DCmdArgument<char*>::destroy_value() {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   109
  if (_value != NULL) {
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   110
    FREE_C_HEAP_ARRAY(char, _value);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   111
    set_value(NULL);
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   112
  }
110525ac80b0 7104647: Adding a diagnostic command framework
fparain
parents:
diff changeset
   113
}