langtools/src/jdk.compiler/share/classes/com/sun/tools/sjavac/client/SjavacClient.java
author alundblad
Thu, 03 Mar 2016 15:53:51 +0100
changeset 36274 28fabde8c8ed
parent 36267 80c06d9873bd
child 36708 c524ead121da
permissions -rw-r--r--
8151141: Sjavac fails to fork server on Windows Summary: Reverted changeset 3269:80c06d9873bd. Reviewed-by: jlahoda
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
25605
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     1
/*
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
     2
 * Copyright (c) 2014, 2016, Oracle and/or its affiliates. All rights reserved.
25605
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     4
 *
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    10
 *
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    15
 * accompanied this code).
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    16
 *
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    20
 *
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    23
 * questions.
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    24
 */
c2d72342fe19 8050408: A few new Java src files for sjavac are missing copyright notices
jjg
parents: 25299
diff changeset
    25
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    26
package com.sun.tools.sjavac.client;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    27
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
    28
import java.io.BufferedReader;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    29
import java.io.File;
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    30
import java.io.IOException;
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
    31
import java.io.InputStreamReader;
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
    32
import java.io.OutputStreamWriter;
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    33
import java.io.PrintStream;
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
    34
import java.io.PrintWriter;
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
    35
import java.io.Reader;
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
    36
import java.io.Writer;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    37
import java.net.InetAddress;
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    38
import java.net.InetSocketAddress;
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    39
import java.net.Socket;
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    40
import java.util.ArrayList;
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    41
import java.util.Arrays;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    42
import java.util.List;
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    43
import java.util.Scanner;
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
    44
import java.util.stream.Stream;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    45
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    46
import com.sun.tools.sjavac.Log;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    47
import com.sun.tools.sjavac.Util;
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    48
import com.sun.tools.sjavac.options.OptionHelper;
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    49
import com.sun.tools.sjavac.options.Options;
32335
7df616378cf3 8048318: Refactor sjavac as a thin client
alundblad
parents: 31751
diff changeset
    50
import com.sun.tools.sjavac.server.CompilationSubResult;
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    51
import com.sun.tools.sjavac.server.PortFile;
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    52
import com.sun.tools.sjavac.server.Sjavac;
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    53
import com.sun.tools.sjavac.server.SjavacServer;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    54
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
    55
import static java.util.stream.Collectors.joining;
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
    56
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    57
/**
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    58
 * Sjavac implementation that delegates requests to a SjavacServer.
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    59
 *
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    60
 *  <p><b>This is NOT part of any supported API.
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    61
 *  If you write code that depends on this, you do so at your own risk.
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    62
 *  This code and its internal interfaces are subject to change or
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    63
 *  deletion without notice.</b>
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    64
 */
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    65
public class SjavacClient implements Sjavac {
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    66
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    67
    // The id can perhaps be used in the future by the javac server to reuse the
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    68
    // JavaCompiler instance for several compiles using the same id.
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    69
    private final String id;
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    70
    private final PortFile portFile;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    71
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    72
    // Default keepalive for server is 120 seconds.
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    73
    // I.e. it will accept 120 seconds of inactivity before quitting.
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    74
    private final int keepalive;
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    75
    private final int poolsize;
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    76
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    77
    // The sjavac option specifies how the server part of sjavac is spawned.
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    78
    // If you have the experimental sjavac in your path, you are done. If not, you have
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    79
    // to point to a com.sun.tools.sjavac.Main that supports --startserver
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    80
    // for example by setting: sjavac=java%20-jar%20...javac.jar%com.sun.tools.sjavac.Main
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    81
    private final String sjavacForkCmd;
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    82
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    83
    // Wait 2 seconds for response, before giving up on javac server.
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    84
    static int CONNECTION_TIMEOUT = 2000;
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    85
    static int MAX_CONNECT_ATTEMPTS = 3;
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
    86
    static int WAIT_BETWEEN_CONNECT_ATTEMPTS = 2000;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
    87
26088
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
    88
    // Store the server conf settings here.
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
    89
    private final String settings;
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
    90
36163
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
    91
    public SjavacClient(Options options) {
26088
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
    92
        String tmpServerConf = options.getServerConf();
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
    93
        String serverConf = (tmpServerConf!=null)? tmpServerConf : "";
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
    94
        String tmpId = Util.extractStringOption("id", serverConf);
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
    95
        id = (tmpId!=null) ? tmpId : "id"+(((new java.util.Random()).nextLong())&Long.MAX_VALUE);
32799
ee577901f4bb 8135131: Enable thin server mode in Sjavac
alundblad
parents: 32542
diff changeset
    96
        String defaultPortfile = options.getDestDir()
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    97
                                        .resolve("javac_server")
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    98
                                        .toAbsolutePath()
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
    99
                                        .toString();
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   100
        String portfileName = Util.extractStringOption("portfile", serverConf, defaultPortfile);
36163
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   101
        portFile = SjavacServer.getPortFile(portfileName);
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   102
        sjavacForkCmd = Util.extractStringOption("sjavac", serverConf, "sjavac");
26088
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   103
        int poolsize = Util.extractIntOption("poolsize", serverConf);
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   104
        keepalive = Util.extractIntOption("keepalive", serverConf, 120);
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   105
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   106
        this.poolsize = poolsize > 0 ? poolsize : Runtime.getRuntime().availableProcessors();
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   107
        settings = (serverConf.equals("")) ? "id="+id+",portfile="+portfileName : serverConf;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   108
    }
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   109
26088
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   110
    /**
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   111
     * Hand out the server settings.
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   112
     * @return The server settings, possibly a default value.
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   113
     */
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   114
    public String serverSettings() {
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   115
        return settings;
f479ca655ba1 8054474: Add --state-dir=bar to sjavac
ohrstrom
parents: 25605
diff changeset
   116
    }
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   117
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   118
    @Override
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   119
    public int compile(String[] args) {
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   120
        int result = -1;
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   121
        try (Socket socket = tryConnect()) {
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   122
            PrintWriter out = new PrintWriter(new OutputStreamWriter(socket.getOutputStream()));
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   123
            BufferedReader in = new BufferedReader(new InputStreamReader(socket.getInputStream()));
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   124
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   125
            // Send args array to server
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   126
            out.println(args.length);
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   127
            for (String arg : args)
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   128
                out.println(arg);
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   129
            out.flush();
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   130
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   131
            // Read server response line by line
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   132
            String line;
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   133
            while (null != (line = in.readLine())) {
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   134
                if (!line.contains(":")) {
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   135
                    throw new AssertionError("Could not parse protocol line: >>\"" + line + "\"<<");
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   136
                }
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   137
                String[] typeAndContent = line.split(":", 2);
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   138
                String type = typeAndContent[0];
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   139
                String content = typeAndContent[1];
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   140
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   141
                try {
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   142
                    Log.log(Log.Level.valueOf(type), "[server] " + content);
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   143
                    continue;
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   144
                } catch (IllegalArgumentException e) {
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   145
                    // Parsing of 'type' as log level failed.
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   146
                }
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   147
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   148
                if (type.equals(SjavacServer.LINE_TYPE_RC)) {
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   149
                    result = Integer.parseInt(content);
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   150
                }
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   151
            }
36163
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   152
        } catch (PortFileInaccessibleException e) {
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   153
            Log.error("Port file inaccessible.");
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   154
            result = CompilationSubResult.ERROR_FATAL;
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   155
        } catch (IOException ioe) {
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   156
            Log.error("IOException caught during compilation: " + ioe.getMessage());
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   157
            Log.debug(ioe);
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   158
            result = CompilationSubResult.ERROR_FATAL;
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   159
        } catch (InterruptedException ie) {
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   160
            Thread.currentThread().interrupt(); // Restore interrupt
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   161
            Log.error("Compilation interrupted.");
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   162
            Log.debug(ie);
32542
f4e4f4c4f9f4 8129114: Sjavac should stream back compiler output to the client as soon as it becomes available
alundblad
parents: 32335
diff changeset
   163
            result = CompilationSubResult.ERROR_FATAL;
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   164
        }
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   165
        return result;
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   166
    }
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   167
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   168
    /*
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   169
     * Makes MAX_CONNECT_ATTEMPTS attepmts to connect to server.
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   170
     */
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   171
    private Socket tryConnect() throws IOException, InterruptedException {
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   172
        makeSureServerIsRunning(portFile);
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   173
        int attempt = 0;
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   174
        while (true) {
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   175
            Log.info("Trying to connect. Attempt " + (++attempt) + " of " + MAX_CONNECT_ATTEMPTS);
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   176
            try {
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   177
                return makeConnectionAttempt();
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   178
            } catch (IOException ex) {
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   179
                Log.error("Connection attempt failed: " + ex.getMessage());
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   180
                if (attempt >= MAX_CONNECT_ATTEMPTS) {
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   181
                    Log.error("Giving up");
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   182
                    throw new IOException("Could not connect to server", ex);
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   183
                }
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   184
            }
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   185
            Thread.sleep(WAIT_BETWEEN_CONNECT_ATTEMPTS);
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   186
        }
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   187
    }
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   188
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   189
    private Socket makeConnectionAttempt() throws IOException {
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   190
        Socket socket = new Socket();
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   191
        InetAddress localhost = InetAddress.getByName(null);
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   192
        InetSocketAddress address = new InetSocketAddress(localhost, portFile.getPort());
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   193
        socket.connect(address, CONNECTION_TIMEOUT);
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   194
        Log.info("Connected");
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   195
        return socket;
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   196
    }
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   197
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   198
    /*
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   199
     * Will return immediately if a server already seems to be running,
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   200
     * otherwise fork a new server and block until it seems to be running.
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   201
     */
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   202
    private void makeSureServerIsRunning(PortFile portFile)
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   203
            throws IOException, InterruptedException {
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   204
36163
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   205
        if (portFile.exists()) {
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   206
            portFile.lock();
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   207
            portFile.getValues();
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   208
            portFile.unlock();
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   209
36163
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   210
            if (portFile.containsPortInfo()) {
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   211
                // Server seems to already be running
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   212
                return;
3d0d0a06fe92 8148498: The sjavac client should never create a port file
alundblad
parents: 36161
diff changeset
   213
            }
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   214
        }
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   215
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   216
        // Fork a new server and wait for it to start
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   217
        SjavacClient.fork(sjavacForkCmd,
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   218
                          portFile,
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   219
                          poolsize,
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   220
                          keepalive);
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   221
    }
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   222
26098
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   223
    @Override
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   224
    public void shutdown() {
32588700060b 8048457: Sjavac should not use portfiles, sockets, etc if background=false
alundblad
parents: 26088
diff changeset
   225
        // Nothing to clean up
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   226
    }
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   227
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   228
    /*
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   229
     * Fork a server process process and wait for server to come around
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   230
     */
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   231
    public static void fork(String sjavacCmd, PortFile portFile, int poolsize, int keepalive)
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   232
            throws IOException, InterruptedException {
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   233
        List<String> cmd = new ArrayList<>();
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   234
        cmd.addAll(Arrays.asList(OptionHelper.unescapeCmdArg(sjavacCmd).split(" ")));
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   235
        cmd.add("--startserver:"
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   236
              + "portfile=" + portFile.getFilename()
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   237
              + ",poolsize=" + poolsize
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   238
              + ",keepalive="+ keepalive);
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   239
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   240
        Process serverProcess;
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   241
        Log.info("Starting server. Command: " + String.join(" ", cmd));
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   242
        try {
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   243
            // If the cmd for some reason can't be executed (file is not found,
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   244
            // or is not executable for instance) this will throw an
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   245
            // IOException and p == null.
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   246
            serverProcess = new ProcessBuilder(cmd)
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   247
                    .redirectErrorStream(true)
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   248
                    .start();
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   249
        } catch (IOException ex) {
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   250
            // Message is typically something like:
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   251
            // Cannot run program "xyz": error=2, No such file or directory
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   252
            Log.error("Failed to create server process: " + ex.getMessage());
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   253
            Log.debug(ex);
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   254
            throw new IOException(ex);
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   255
        }
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   256
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   257
        // serverProcess != null at this point.
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   258
        try {
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   259
            // Throws an IOException if no valid values materialize
36274
28fabde8c8ed 8151141: Sjavac fails to fork server on Windows
alundblad
parents: 36267
diff changeset
   260
            portFile.waitForValidValues();
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   261
        } catch (IOException ex) {
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   262
            // Process was started, but server failed to initialize. This could
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   263
            // for instance be due to the JVM not finding the server class,
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   264
            // or the server running in to some exception early on.
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   265
            Log.error("Sjavac server failed to initialize: " + ex.getMessage());
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   266
            Log.error("Process output:");
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   267
            Reader serverStdoutStderr = new InputStreamReader(serverProcess.getInputStream());
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   268
            try (BufferedReader br = new BufferedReader(serverStdoutStderr)) {
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   269
                br.lines().forEach(Log::error);
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   270
            }
36161
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   271
            Log.error("<End of process output>");
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   272
            try {
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   273
                Log.error("Process exit code: " + serverProcess.exitValue());
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   274
            } catch (IllegalThreadStateException e) {
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   275
                // Server is presumably still running.
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   276
            }
a025c0619f25 8147569: Error messages from sjavac server does not always get relayed back to client
alundblad
parents: 32799
diff changeset
   277
            throw new IOException("Server failed to initialize: " + ex.getMessage(), ex);
27383
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   278
        }
716ed9a6d607 8042088: Sjavac spawns external processes in a unnecessarily complex and platform dependent way
alundblad
parents: 27226
diff changeset
   279
    }
25299
b4a7dcd657f5 8048594: The sjavac client/server protocol should be hidden behind an interface
alundblad
parents:
diff changeset
   280
}