author | coleenp |
Wed, 02 Aug 2017 10:52:50 -0400 | |
changeset 46742 | 24ec8a039c90 |
parent 45114 | 45644c5f6b8e |
child 46746 | ea379ebb9447 |
permissions | -rw-r--r-- |
1 | 1 |
/* |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
2 |
* Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
2332
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
2332
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
2332
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
13087 | 26 |
#include "classfile/altHashing.hpp" |
34659
3a7071043457
8143615: compactHashtable.hpp includes .inline.hpp file
iklam
parents:
34237
diff
changeset
|
27 |
#include "classfile/compactHashtable.inline.hpp" |
7397 | 28 |
#include "classfile/javaClasses.hpp" |
29 |
#include "classfile/symbolTable.hpp" |
|
30 |
#include "classfile/systemDictionary.hpp" |
|
30764 | 31 |
#include "gc/shared/collectedHeap.inline.hpp" |
32 |
#include "gc/shared/gcLocker.inline.hpp" |
|
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
33 |
#include "memory/allocation.inline.hpp" |
7397 | 34 |
#include "memory/filemap.hpp" |
37248 | 35 |
#include "memory/resourceArea.hpp" |
7397 | 36 |
#include "oops/oop.inline.hpp" |
40655
9f644073d3a0
8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp
dholmes
parents:
39713
diff
changeset
|
37 |
#include "runtime/atomic.hpp" |
7397 | 38 |
#include "runtime/mutexLocker.hpp" |
46742 | 39 |
#include "services/diagnosticCommand.hpp" |
7397 | 40 |
#include "utilities/hashtable.inline.hpp" |
1 | 41 |
|
42 |
// -------------------------------------------------------------------------- |
|
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
43 |
// the number of buckets a thread claims |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
44 |
const int ClaimChunkSize = 32; |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
45 |
|
1 | 46 |
SymbolTable* SymbolTable::_the_table = NULL; |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
47 |
// Static arena for symbols that are not deallocated |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
48 |
Arena* SymbolTable::_arena = NULL; |
13087 | 49 |
bool SymbolTable::_needs_rehashing = false; |
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
50 |
bool SymbolTable::_lookup_shared_first = false; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
51 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
52 |
CompactHashtable<Symbol*, char> SymbolTable::_shared_table; |
1 | 53 |
|
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
54 |
Symbol* SymbolTable::allocate_symbol(const u1* name, int len, bool c_heap, TRAPS) { |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
55 |
assert (len <= Symbol::max_length(), "should be checked by caller"); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
56 |
|
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
57 |
Symbol* sym; |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13199
diff
changeset
|
58 |
|
15934
104ff83451f1
8009829: CDS: JDK JPRT test fails crash in Symbol::equals()
coleenp
parents:
14742
diff
changeset
|
59 |
if (DumpSharedSpaces) { |
104ff83451f1
8009829: CDS: JDK JPRT test fails crash in Symbol::equals()
coleenp
parents:
14742
diff
changeset
|
60 |
// Allocate all symbols to CLD shared metaspace |
31790 | 61 |
sym = new (len, ClassLoaderData::the_null_class_loader_data(), THREAD) Symbol(name, len, PERM_REFCOUNT); |
15934
104ff83451f1
8009829: CDS: JDK JPRT test fails crash in Symbol::equals()
coleenp
parents:
14742
diff
changeset
|
62 |
} else if (c_heap) { |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
63 |
// refcount starts as 1 |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
64 |
sym = new (len, THREAD) Symbol(name, len, 1); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13199
diff
changeset
|
65 |
assert(sym != NULL, "new should call vm_exit_out_of_memory if C_HEAP is exhausted"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13199
diff
changeset
|
66 |
} else { |
15934
104ff83451f1
8009829: CDS: JDK JPRT test fails crash in Symbol::equals()
coleenp
parents:
14742
diff
changeset
|
67 |
// Allocate to global arena |
31790 | 68 |
sym = new (len, arena(), THREAD) Symbol(name, len, PERM_REFCOUNT); |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
69 |
} |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
70 |
return sym; |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
71 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
72 |
|
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
73 |
void SymbolTable::initialize_symbols(int arena_alloc_size) { |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
74 |
// Initialize the arena for global symbols, size passed in depends on CDS. |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
75 |
if (arena_alloc_size == 0) { |
25946 | 76 |
_arena = new (mtSymbol) Arena(mtSymbol); |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
77 |
} else { |
25946 | 78 |
_arena = new (mtSymbol) Arena(mtSymbol, arena_alloc_size); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
79 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
80 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
81 |
|
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
82 |
// Call function for all symbols in the symbol table. |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
83 |
void SymbolTable::symbols_do(SymbolClosure *cl) { |
28615
1fb960ea5a7e
8067982: Some jcmd /gc/heap_dump tests failed: hprof output contains warning or error.
jiangli
parents:
28363
diff
changeset
|
84 |
// all symbols from shared table |
1fb960ea5a7e
8067982: Some jcmd /gc/heap_dump tests failed: hprof output contains warning or error.
jiangli
parents:
28363
diff
changeset
|
85 |
_shared_table.symbols_do(cl); |
1fb960ea5a7e
8067982: Some jcmd /gc/heap_dump tests failed: hprof output contains warning or error.
jiangli
parents:
28363
diff
changeset
|
86 |
|
1fb960ea5a7e
8067982: Some jcmd /gc/heap_dump tests failed: hprof output contains warning or error.
jiangli
parents:
28363
diff
changeset
|
87 |
// all symbols from the dynamic table |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
88 |
const int n = the_table()->table_size(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
89 |
for (int i = 0; i < n; i++) { |
13195 | 90 |
for (HashtableEntry<Symbol*, mtSymbol>* p = the_table()->bucket(i); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
91 |
p != NULL; |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
92 |
p = p->next()) { |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
93 |
cl->do_symbol(p->literal_addr()); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
94 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
95 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
96 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
97 |
|
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
98 |
int SymbolTable::_symbols_removed = 0; |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
99 |
int SymbolTable::_symbols_counted = 0; |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
100 |
volatile int SymbolTable::_parallel_claimed_idx = 0; |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
101 |
|
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
102 |
void SymbolTable::buckets_unlink(int start_idx, int end_idx, BucketUnlinkContext* context) { |
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
103 |
for (int i = start_idx; i < end_idx; ++i) { |
13195 | 104 |
HashtableEntry<Symbol*, mtSymbol>** p = the_table()->bucket_addr(i); |
105 |
HashtableEntry<Symbol*, mtSymbol>* entry = the_table()->bucket(i); |
|
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
106 |
while (entry != NULL) { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
107 |
// Shared entries are normally at the end of the bucket and if we run into |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
108 |
// a shared entry, then there is nothing more to remove. However, if we |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
109 |
// have rehashed the table, then the shared entries are no longer at the |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
110 |
// end of the bucket. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
111 |
if (entry->is_shared() && !use_alternate_hashcode()) { |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
112 |
break; |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
113 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
114 |
Symbol* s = entry->literal(); |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
115 |
context->_num_processed++; |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
116 |
assert(s != NULL, "just checking"); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
117 |
// If reference count is zero, remove. |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
118 |
if (s->refcount() == 0) { |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
119 |
assert(!entry->is_shared(), "shared entries should be kept live"); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
120 |
delete s; |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
121 |
*p = entry->next(); |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
122 |
context->free_entry(entry); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
123 |
} else { |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
124 |
p = entry->next_addr(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
125 |
} |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
126 |
// get next entry |
13195 | 127 |
entry = (HashtableEntry<Symbol*, mtSymbol>*)HashtableEntry<Symbol*, mtSymbol>::make_ptr(*p); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
128 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
129 |
} |
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
130 |
} |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
131 |
|
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
132 |
// Remove unreferenced symbols from the symbol table |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
133 |
// This is done late during GC. |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
134 |
void SymbolTable::unlink(int* processed, int* removed) { |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
135 |
BucketUnlinkContext context; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
136 |
buckets_unlink(0, the_table()->table_size(), &context); |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
137 |
_the_table->bulk_free_entries(&context); |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
138 |
*processed = context._num_processed; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
139 |
*removed = context._num_removed; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
140 |
|
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
141 |
_symbols_removed = context._num_removed; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
142 |
_symbols_counted = context._num_processed; |
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
143 |
} |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
144 |
|
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
145 |
void SymbolTable::possibly_parallel_unlink(int* processed, int* removed) { |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
146 |
const int limit = the_table()->table_size(); |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
147 |
|
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
148 |
BucketUnlinkContext context; |
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
149 |
for (;;) { |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
150 |
// Grab next set of buckets to scan |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
151 |
int start_idx = Atomic::add(ClaimChunkSize, &_parallel_claimed_idx) - ClaimChunkSize; |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
152 |
if (start_idx >= limit) { |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
153 |
// End of table |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
154 |
break; |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
155 |
} |
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
156 |
|
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
157 |
int end_idx = MIN2(limit, start_idx + ClaimChunkSize); |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
158 |
buckets_unlink(start_idx, end_idx, &context); |
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
159 |
} |
45114
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
160 |
|
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
161 |
_the_table->bulk_free_entries(&context); |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
162 |
*processed = context._num_processed; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
163 |
*removed = context._num_removed; |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
164 |
|
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
165 |
Atomic::add(context._num_processed, &_symbols_counted); |
45644c5f6b8e
8180048: Interned string and symbol table leak memory during parallel unlinking
tschatzl
parents:
41289
diff
changeset
|
166 |
Atomic::add(context._num_removed, &_symbols_removed); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
167 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
168 |
|
13087 | 169 |
// Create a new table and using alternate hash code, populate the new table |
170 |
// with the existing strings. Set flag to use the alternate hash code afterwards. |
|
171 |
void SymbolTable::rehash_table() { |
|
37198
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
172 |
if (DumpSharedSpaces) { |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
173 |
tty->print_cr("Warning: rehash_table should not be called while dumping archive"); |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
174 |
return; |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
175 |
} |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
176 |
|
13087 | 177 |
assert(SafepointSynchronize::is_at_safepoint(), "must be at safepoint"); |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
178 |
// This should never happen with -Xshare:dump but it might in testing mode. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
179 |
if (DumpSharedSpaces) return; |
13087 | 180 |
// Create a new symbol table |
181 |
SymbolTable* new_table = new SymbolTable(); |
|
182 |
||
183 |
the_table()->move_to(new_table); |
|
184 |
||
185 |
// Delete the table and buckets (entries are reused in new table). |
|
186 |
delete _the_table; |
|
187 |
// Don't check if we need rehashing until the table gets unbalanced again. |
|
188 |
// Then rehash with a new global seed. |
|
189 |
_needs_rehashing = false; |
|
190 |
_the_table = new_table; |
|
191 |
} |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
192 |
|
1 | 193 |
// Lookup a symbol in a bucket. |
194 |
||
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
195 |
Symbol* SymbolTable::lookup_dynamic(int index, const char* name, |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
196 |
int len, unsigned int hash) { |
13087 | 197 |
int count = 0; |
13195 | 198 |
for (HashtableEntry<Symbol*, mtSymbol>* e = bucket(index); e != NULL; e = e->next()) { |
13087 | 199 |
count++; // count all entries in this bucket, not just ones with same hash |
1 | 200 |
if (e->hash() == hash) { |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
201 |
Symbol* sym = e->literal(); |
1 | 202 |
if (sym->equals(name, len)) { |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
203 |
// something is referencing this symbol now. |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
204 |
sym->increment_refcount(); |
1 | 205 |
return sym; |
206 |
} |
|
207 |
} |
|
208 |
} |
|
13087 | 209 |
// If the bucket size is too deep check if this hash code is insufficient. |
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
25946
diff
changeset
|
210 |
if (count >= rehash_count && !needs_rehashing()) { |
13087 | 211 |
_needs_rehashing = check_rehash_table(count); |
212 |
} |
|
1 | 213 |
return NULL; |
214 |
} |
|
215 |
||
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
216 |
Symbol* SymbolTable::lookup_shared(const char* name, |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
217 |
int len, unsigned int hash) { |
37198
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
218 |
if (use_alternate_hashcode()) { |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
219 |
// hash_code parameter may use alternate hashing algorithm but the shared table |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
220 |
// always uses the same original hash code. |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
221 |
hash = hash_shared_symbol(name, len); |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
222 |
} |
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
223 |
return _shared_table.lookup(name, hash, len); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
224 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
225 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
226 |
Symbol* SymbolTable::lookup(int index, const char* name, |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
227 |
int len, unsigned int hash) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
228 |
Symbol* sym; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
229 |
if (_lookup_shared_first) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
230 |
sym = lookup_shared(name, len, hash); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
231 |
if (sym != NULL) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
232 |
return sym; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
233 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
234 |
_lookup_shared_first = false; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
235 |
return lookup_dynamic(index, name, len, hash); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
236 |
} else { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
237 |
sym = lookup_dynamic(index, name, len, hash); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
238 |
if (sym != NULL) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
239 |
return sym; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
240 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
241 |
sym = lookup_shared(name, len, hash); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
242 |
if (sym != NULL) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
243 |
_lookup_shared_first = true; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
244 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
245 |
return sym; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
246 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
247 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
248 |
|
39713 | 249 |
u4 SymbolTable::encode_shared(Symbol* sym) { |
250 |
assert(DumpSharedSpaces, "called only during dump time"); |
|
251 |
uintx base_address = uintx(MetaspaceShared::shared_rs()->base()); |
|
252 |
uintx offset = uintx(sym) - base_address; |
|
253 |
assert(offset < 0x7fffffff, "sanity"); |
|
254 |
return u4(offset); |
|
255 |
} |
|
256 |
||
257 |
Symbol* SymbolTable::decode_shared(u4 offset) { |
|
258 |
assert(!DumpSharedSpaces, "called only during runtime"); |
|
259 |
uintx base_address = _shared_table.base_address(); |
|
260 |
Symbol* sym = (Symbol*)(base_address + offset); |
|
261 |
||
262 |
#ifndef PRODUCT |
|
263 |
const char* s = (const char*)sym->bytes(); |
|
264 |
int len = sym->utf8_length(); |
|
265 |
unsigned int hash = hash_symbol(s, len); |
|
266 |
assert(sym == lookup_shared(s, len, hash), "must be shared symbol"); |
|
267 |
#endif |
|
268 |
||
269 |
return sym; |
|
270 |
} |
|
271 |
||
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
272 |
// Pick hashing algorithm. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
273 |
unsigned int SymbolTable::hash_symbol(const char* s, int len) { |
13087 | 274 |
return use_alternate_hashcode() ? |
275 |
AltHashing::murmur3_32(seed(), (const jbyte*)s, len) : |
|
33628 | 276 |
java_lang_String::hash_code((const jbyte*)s, len); |
13087 | 277 |
} |
278 |
||
37198
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
279 |
unsigned int SymbolTable::hash_shared_symbol(const char* s, int len) { |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
280 |
return java_lang_String::hash_code((const jbyte*)s, len); |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
281 |
} |
b96542d1afa1
8152380: Shared symbol table should never use alternate hashcode
iklam
parents:
35898
diff
changeset
|
282 |
|
1 | 283 |
|
284 |
// We take care not to be blocking while holding the |
|
285 |
// SymbolTable_lock. Otherwise, the system might deadlock, since the |
|
286 |
// symboltable is used during compilation (VM_thread) The lock free |
|
287 |
// synchronization is simplified by the fact that we do not delete |
|
288 |
// entries in the symbol table during normal execution (only during |
|
289 |
// safepoints). |
|
290 |
||
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
291 |
Symbol* SymbolTable::lookup(const char* name, int len, TRAPS) { |
1 | 292 |
unsigned int hashValue = hash_symbol(name, len); |
293 |
int index = the_table()->hash_to_index(hashValue); |
|
294 |
||
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
295 |
Symbol* s = the_table()->lookup(index, name, len, hashValue); |
1 | 296 |
|
297 |
// Found |
|
298 |
if (s != NULL) return s; |
|
299 |
||
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
300 |
// Grab SymbolTable_lock first. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
301 |
MutexLocker ml(SymbolTable_lock, THREAD); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
302 |
|
1 | 303 |
// Otherwise, add to symbol to table |
27677 | 304 |
return the_table()->basic_add(index, (u1*)name, len, hashValue, true, THREAD); |
1 | 305 |
} |
306 |
||
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
307 |
Symbol* SymbolTable::lookup(const Symbol* sym, int begin, int end, TRAPS) { |
1 | 308 |
char* buffer; |
309 |
int index, len; |
|
310 |
unsigned int hashValue; |
|
311 |
char* name; |
|
312 |
{ |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
34659
diff
changeset
|
313 |
debug_only(NoSafepointVerifier nsv;) |
1 | 314 |
|
315 |
name = (char*)sym->base() + begin; |
|
316 |
len = end - begin; |
|
317 |
hashValue = hash_symbol(name, len); |
|
318 |
index = the_table()->hash_to_index(hashValue); |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
319 |
Symbol* s = the_table()->lookup(index, name, len, hashValue); |
1 | 320 |
|
321 |
// Found |
|
322 |
if (s != NULL) return s; |
|
323 |
} |
|
324 |
||
325 |
// Otherwise, add to symbol to table. Copy to a C string first. |
|
326 |
char stack_buf[128]; |
|
327 |
ResourceMark rm(THREAD); |
|
328 |
if (len <= 128) { |
|
329 |
buffer = stack_buf; |
|
330 |
} else { |
|
331 |
buffer = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, len); |
|
332 |
} |
|
333 |
for (int i=0; i<len; i++) { |
|
334 |
buffer[i] = name[i]; |
|
335 |
} |
|
336 |
// Make sure there is no safepoint in the code above since name can't move. |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
34659
diff
changeset
|
337 |
// We can't include the code in NoSafepointVerifier because of the |
1 | 338 |
// ResourceMark. |
339 |
||
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
340 |
// Grab SymbolTable_lock first. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
341 |
MutexLocker ml(SymbolTable_lock, THREAD); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
342 |
|
27677 | 343 |
return the_table()->basic_add(index, (u1*)buffer, len, hashValue, true, THREAD); |
1 | 344 |
} |
345 |
||
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
346 |
Symbol* SymbolTable::lookup_only(const char* name, int len, |
1 | 347 |
unsigned int& hash) { |
348 |
hash = hash_symbol(name, len); |
|
349 |
int index = the_table()->hash_to_index(hash); |
|
350 |
||
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
351 |
Symbol* s = the_table()->lookup(index, name, len, hash); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
352 |
return s; |
1 | 353 |
} |
354 |
||
11480
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
355 |
// Look up the address of the literal in the SymbolTable for this Symbol* |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
356 |
// Do not create any new symbols |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
357 |
// Do not increment the reference count to keep this alive |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
358 |
Symbol** SymbolTable::lookup_symbol_addr(Symbol* sym){ |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
359 |
unsigned int hash = hash_symbol((char*)sym->bytes(), sym->utf8_length()); |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
360 |
int index = the_table()->hash_to_index(hash); |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
361 |
|
13195 | 362 |
for (HashtableEntry<Symbol*, mtSymbol>* e = the_table()->bucket(index); e != NULL; e = e->next()) { |
11480
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
363 |
if (e->hash() == hash) { |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
364 |
Symbol* literal_sym = e->literal(); |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
365 |
if (sym == literal_sym) { |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
366 |
return e->literal_addr(); |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
367 |
} |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
368 |
} |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
369 |
} |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
370 |
return NULL; |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
371 |
} |
1bf714e8adb4
7115199: Add event tracing hooks and Java Flight Recorder infrastructure
phh
parents:
8885
diff
changeset
|
372 |
|
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
373 |
// Suggestion: Push unicode-based lookup all the way into the hashing |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
374 |
// and probing logic, so there is no need for convert_to_utf8 until |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
375 |
// an actual new Symbol* is created. |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
376 |
Symbol* SymbolTable::lookup_unicode(const jchar* name, int utf16_length, TRAPS) { |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
377 |
int utf8_length = UNICODE::utf8_length((jchar*) name, utf16_length); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
378 |
char stack_buf[128]; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
379 |
if (utf8_length < (int) sizeof(stack_buf)) { |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
380 |
char* chars = stack_buf; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
381 |
UNICODE::convert_to_utf8(name, utf16_length, chars); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
382 |
return lookup(chars, utf8_length, THREAD); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
383 |
} else { |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
384 |
ResourceMark rm(THREAD); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
385 |
char* chars = NEW_RESOURCE_ARRAY(char, utf8_length + 1);; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
386 |
UNICODE::convert_to_utf8(name, utf16_length, chars); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
387 |
return lookup(chars, utf8_length, THREAD); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
388 |
} |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
389 |
} |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
390 |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
391 |
Symbol* SymbolTable::lookup_only_unicode(const jchar* name, int utf16_length, |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
392 |
unsigned int& hash) { |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
393 |
int utf8_length = UNICODE::utf8_length((jchar*) name, utf16_length); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
394 |
char stack_buf[128]; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
395 |
if (utf8_length < (int) sizeof(stack_buf)) { |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
396 |
char* chars = stack_buf; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
397 |
UNICODE::convert_to_utf8(name, utf16_length, chars); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
398 |
return lookup_only(chars, utf8_length, hash); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
399 |
} else { |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
400 |
ResourceMark rm; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
401 |
char* chars = NEW_RESOURCE_ARRAY(char, utf8_length + 1);; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
402 |
UNICODE::convert_to_utf8(name, utf16_length, chars); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
403 |
return lookup_only(chars, utf8_length, hash); |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
404 |
} |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
405 |
} |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2131
diff
changeset
|
406 |
|
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33148
diff
changeset
|
407 |
void SymbolTable::add(ClassLoaderData* loader_data, const constantPoolHandle& cp, |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
408 |
int names_count, |
1 | 409 |
const char** names, int* lengths, int* cp_indices, |
410 |
unsigned int* hashValues, TRAPS) { |
|
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
411 |
// Grab SymbolTable_lock first. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
412 |
MutexLocker ml(SymbolTable_lock, THREAD); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
413 |
|
1 | 414 |
SymbolTable* table = the_table(); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13199
diff
changeset
|
415 |
bool added = table->basic_add(loader_data, cp, names_count, names, lengths, |
1 | 416 |
cp_indices, hashValues, CHECK); |
417 |
if (!added) { |
|
418 |
// do it the hard way |
|
419 |
for (int i=0; i<names_count; i++) { |
|
420 |
int index = table->hash_to_index(hashValues[i]); |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13199
diff
changeset
|
421 |
bool c_heap = !loader_data->is_the_null_class_loader_data(); |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
422 |
Symbol* sym = table->basic_add(index, (u1*)names[i], lengths[i], hashValues[i], c_heap, CHECK); |
1 | 423 |
cp->symbol_at_put(cp_indices[i], sym); |
424 |
} |
|
425 |
} |
|
426 |
} |
|
427 |
||
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
428 |
Symbol* SymbolTable::new_permanent_symbol(const char* name, TRAPS) { |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
429 |
unsigned int hash; |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
430 |
Symbol* result = SymbolTable::lookup_only((char*)name, (int)strlen(name), hash); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
431 |
if (result != NULL) { |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
432 |
return result; |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
433 |
} |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
434 |
// Grab SymbolTable_lock first. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
435 |
MutexLocker ml(SymbolTable_lock, THREAD); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
436 |
|
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
437 |
SymbolTable* table = the_table(); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
438 |
int index = table->hash_to_index(hash); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
439 |
return table->basic_add(index, (u1*)name, (int)strlen(name), hash, false, THREAD); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
440 |
} |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
441 |
|
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
442 |
Symbol* SymbolTable::basic_add(int index_arg, u1 *name, int len, |
13087 | 443 |
unsigned int hashValue_arg, bool c_heap, TRAPS) { |
20079 | 444 |
assert(!Universe::heap()->is_in_reserved(name), |
1 | 445 |
"proposed name of symbol must be stable"); |
446 |
||
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
447 |
// Don't allow symbols to be created which cannot fit in a Symbol*. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
448 |
if (len > Symbol::max_length()) { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
449 |
THROW_MSG_0(vmSymbols::java_lang_InternalError(), |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
450 |
"name is too long to represent"); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
451 |
} |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
452 |
|
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
453 |
// Cannot hit a safepoint in this function because the "this" pointer can move. |
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
34659
diff
changeset
|
454 |
NoSafepointVerifier nsv; |
1 | 455 |
|
13087 | 456 |
// Check if the symbol table has been rehashed, if so, need to recalculate |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
457 |
// the hash value and index. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
458 |
unsigned int hashValue; |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
459 |
int index; |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
460 |
if (use_alternate_hashcode()) { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
461 |
hashValue = hash_symbol((const char*)name, len); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
462 |
index = hash_to_index(hashValue); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
463 |
} else { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
464 |
hashValue = hashValue_arg; |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
465 |
index = index_arg; |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
466 |
} |
13087 | 467 |
|
1 | 468 |
// Since look-up was done lock-free, we need to check if another |
469 |
// thread beat us in the race to insert the symbol. |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
470 |
Symbol* test = lookup(index, (char*)name, len, hashValue); |
1 | 471 |
if (test != NULL) { |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
472 |
// A race occurred and another thread introduced the symbol. |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
473 |
assert(test->refcount() != 0, "lookup should have incremented the count"); |
1 | 474 |
return test; |
475 |
} |
|
476 |
||
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
477 |
// Create a new symbol. |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
478 |
Symbol* sym = allocate_symbol(name, len, c_heap, CHECK_NULL); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
479 |
assert(sym->equals((char*)name, len), "symbol must be properly initialized"); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
480 |
|
13195 | 481 |
HashtableEntry<Symbol*, mtSymbol>* entry = new_entry(hashValue, sym); |
1 | 482 |
add_entry(index, entry); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
483 |
return sym; |
1 | 484 |
} |
485 |
||
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
486 |
// This version of basic_add adds symbols in batch from the constant pool |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
487 |
// parsing. |
33593
60764a78fa5c
8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents:
33148
diff
changeset
|
488 |
bool SymbolTable::basic_add(ClassLoaderData* loader_data, const constantPoolHandle& cp, |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
489 |
int names_count, |
1 | 490 |
const char** names, int* lengths, |
491 |
int* cp_indices, unsigned int* hashValues, |
|
492 |
TRAPS) { |
|
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
493 |
|
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
494 |
// Check symbol names are not too long. If any are too long, don't add any. |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
495 |
for (int i = 0; i< names_count; i++) { |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
496 |
if (lengths[i] > Symbol::max_length()) { |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
497 |
THROW_MSG_0(vmSymbols::java_lang_InternalError(), |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
498 |
"name is too long to represent"); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
499 |
} |
1 | 500 |
} |
501 |
||
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
502 |
// Cannot hit a safepoint in this function because the "this" pointer can move. |
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
34659
diff
changeset
|
503 |
NoSafepointVerifier nsv; |
1 | 504 |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
505 |
for (int i=0; i<names_count; i++) { |
13087 | 506 |
// Check if the symbol table has been rehashed, if so, need to recalculate |
507 |
// the hash value. |
|
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
508 |
unsigned int hashValue; |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
509 |
if (use_alternate_hashcode()) { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
510 |
hashValue = hash_symbol(names[i], lengths[i]); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
511 |
} else { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
512 |
hashValue = hashValues[i]; |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
513 |
} |
1 | 514 |
// Since look-up was done lock-free, we need to check if another |
515 |
// thread beat us in the race to insert the symbol. |
|
13087 | 516 |
int index = hash_to_index(hashValue); |
517 |
Symbol* test = lookup(index, names[i], lengths[i], hashValue); |
|
1 | 518 |
if (test != NULL) { |
2131 | 519 |
// A race occurred and another thread introduced the symbol, this one |
1 | 520 |
// will be dropped and collected. Use test instead. |
521 |
cp->symbol_at_put(cp_indices[i], test); |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
522 |
assert(test->refcount() != 0, "lookup should have incremented the count"); |
1 | 523 |
} else { |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
524 |
// Create a new symbol. The null class loader is never unloaded so these |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
525 |
// are allocated specially in a permanent arena. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13199
diff
changeset
|
526 |
bool c_heap = !loader_data->is_the_null_class_loader_data(); |
12263
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
527 |
Symbol* sym = allocate_symbol((const u1*)names[i], lengths[i], c_heap, CHECK_(false)); |
d20640f4f8fe
7150058: Allocate symbols from null boot loader to an arena for NMT
coleenp
parents:
11480
diff
changeset
|
528 |
assert(sym->equals(names[i], lengths[i]), "symbol must be properly initialized"); // why wouldn't it be??? |
13195 | 529 |
HashtableEntry<Symbol*, mtSymbol>* entry = new_entry(hashValue, sym); |
1 | 530 |
add_entry(index, entry); |
531 |
cp->symbol_at_put(cp_indices[i], sym); |
|
532 |
} |
|
533 |
} |
|
534 |
return true; |
|
535 |
} |
|
536 |
||
537 |
||
538 |
void SymbolTable::verify() { |
|
539 |
for (int i = 0; i < the_table()->table_size(); ++i) { |
|
13195 | 540 |
HashtableEntry<Symbol*, mtSymbol>* p = the_table()->bucket(i); |
1 | 541 |
for ( ; p != NULL; p = p->next()) { |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
542 |
Symbol* s = (Symbol*)(p->literal()); |
1 | 543 |
guarantee(s != NULL, "symbol is NULL"); |
544 |
unsigned int h = hash_symbol((char*)s->bytes(), s->utf8_length()); |
|
545 |
guarantee(p->hash() == h, "broken hash in symbol table entry"); |
|
546 |
guarantee(the_table()->hash_to_index(h) == i, |
|
547 |
"wrong index in symbol table"); |
|
548 |
} |
|
549 |
} |
|
550 |
} |
|
551 |
||
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
552 |
void SymbolTable::dump(outputStream* st, bool verbose) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
553 |
if (!verbose) { |
46742 | 554 |
the_table()->print_table_statistics(st, "SymbolTable"); |
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
555 |
} else { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
556 |
st->print_cr("VERSION: 1.0"); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
557 |
for (int i = 0; i < the_table()->table_size(); ++i) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
558 |
HashtableEntry<Symbol*, mtSymbol>* p = the_table()->bucket(i); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
559 |
for ( ; p != NULL; p = p->next()) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
560 |
Symbol* s = (Symbol*)(p->literal()); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
561 |
const char* utf8_string = (const char*)s->bytes(); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
562 |
int utf8_length = s->utf8_length(); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
563 |
st->print("%d %d: ", utf8_length, s->refcount()); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
564 |
HashtableTextDump::put_utf8(st, utf8_string, utf8_length); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
565 |
st->cr(); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
566 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
567 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
568 |
} |
13087 | 569 |
} |
570 |
||
37995 | 571 |
void SymbolTable::serialize(SerializeClosure* soc) { |
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
572 |
#if INCLUDE_CDS |
37995 | 573 |
_shared_table.reset(); |
574 |
if (soc->writing()) { |
|
575 |
int num_buckets = the_table()->number_of_entries() / |
|
576 |
SharedSymbolTableBucketSize; |
|
577 |
CompactSymbolTableWriter writer(num_buckets, |
|
578 |
&MetaspaceShared::stats()->symbol); |
|
579 |
for (int i = 0; i < the_table()->table_size(); ++i) { |
|
580 |
HashtableEntry<Symbol*, mtSymbol>* p = the_table()->bucket(i); |
|
581 |
for ( ; p != NULL; p = p->next()) { |
|
582 |
Symbol* s = (Symbol*)(p->literal()); |
|
583 |
unsigned int fixed_hash = hash_shared_symbol((char*)s->bytes(), s->utf8_length()); |
|
584 |
assert(fixed_hash == p->hash(), "must not rehash during dumping"); |
|
585 |
writer.add(fixed_hash, s); |
|
586 |
} |
|
587 |
} |
|
588 |
||
589 |
writer.dump(&_shared_table); |
|
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
590 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
591 |
|
37995 | 592 |
_shared_table.set_type(CompactHashtable<Symbol*, char>::_symbol_table); |
593 |
_shared_table.serialize(soc); |
|
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
594 |
|
37995 | 595 |
if (soc->writing()) { |
596 |
// Verify table is correct |
|
597 |
Symbol* sym = vmSymbols::java_lang_Object(); |
|
598 |
const char* name = (const char*)sym->bytes(); |
|
599 |
int len = sym->utf8_length(); |
|
600 |
unsigned int hash = hash_symbol(name, len); |
|
601 |
assert(sym == _shared_table.lookup(name, hash, len), "sanity"); |
|
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
602 |
|
37995 | 603 |
// Sanity. Make sure we don't use the shared table at dump time |
604 |
_shared_table.reset(); |
|
605 |
} |
|
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
606 |
#endif |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
607 |
} |
1 | 608 |
|
609 |
//--------------------------------------------------------------------------- |
|
610 |
// Non-product code |
|
611 |
||
612 |
#ifndef PRODUCT |
|
613 |
||
614 |
void SymbolTable::print_histogram() { |
|
615 |
MutexLocker ml(SymbolTable_lock); |
|
616 |
const int results_length = 100; |
|
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
617 |
int counts[results_length]; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
618 |
int sizes[results_length]; |
1 | 619 |
int i,j; |
620 |
||
621 |
// initialize results to zero |
|
622 |
for (j = 0; j < results_length; j++) { |
|
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
623 |
counts[j] = 0; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
624 |
sizes[j] = 0; |
1 | 625 |
} |
626 |
||
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
627 |
int total_size = 0; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
628 |
int total_count = 0; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
629 |
int total_length = 0; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
630 |
int max_length = 0; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
631 |
int out_of_range_count = 0; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
632 |
int out_of_range_size = 0; |
1 | 633 |
for (i = 0; i < the_table()->table_size(); i++) { |
13195 | 634 |
HashtableEntry<Symbol*, mtSymbol>* p = the_table()->bucket(i); |
1 | 635 |
for ( ; p != NULL; p = p->next()) { |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
636 |
int size = p->literal()->size(); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
637 |
int len = p->literal()->utf8_length(); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
638 |
if (len < results_length) { |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
639 |
counts[len]++; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
640 |
sizes[len] += size; |
1 | 641 |
} else { |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
642 |
out_of_range_count++; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
643 |
out_of_range_size += size; |
1 | 644 |
} |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
645 |
total_count++; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
646 |
total_size += size; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
647 |
total_length += len; |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
648 |
max_length = MAX2(max_length, len); |
1 | 649 |
} |
650 |
} |
|
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
651 |
tty->print_cr("Symbol Table Histogram:"); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
652 |
tty->print_cr(" Total number of symbols %7d", total_count); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
653 |
tty->print_cr(" Total size in memory %7dK", |
35898
ddc274f0052f
8145628: hotspot metadata classes shouldn't use HeapWordSize or heap related macros like align_object_size
coleenp
parents:
35497
diff
changeset
|
654 |
(total_size*wordSize)/1024); |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
655 |
tty->print_cr(" Total counted %7d", _symbols_counted); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
656 |
tty->print_cr(" Total removed %7d", _symbols_removed); |
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
657 |
if (_symbols_counted > 0) { |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
658 |
tty->print_cr(" Percent removed %3.2f", |
22545
b93a7f0e9b9d
8027476: Improve performance of Stringtable unlink
tschatzl
parents:
20283
diff
changeset
|
659 |
((float)_symbols_removed/(float)_symbols_counted)* 100); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
660 |
} |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
661 |
tty->print_cr(" Reference counts %7d", Symbol::_total_count); |
33148
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
31790
diff
changeset
|
662 |
tty->print_cr(" Symbol arena used " SIZE_FORMAT_W(7) "K", arena()->used()/1024); |
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
31790
diff
changeset
|
663 |
tty->print_cr(" Symbol arena size " SIZE_FORMAT_W(7) "K", arena()->size_in_bytes()/1024); |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
664 |
tty->print_cr(" Total symbol length %7d", total_length); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
665 |
tty->print_cr(" Maximum symbol length %7d", max_length); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
666 |
tty->print_cr(" Average symbol length %7.2f", ((float) total_length / (float) total_count)); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
667 |
tty->print_cr(" Symbol length histogram:"); |
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
668 |
tty->print_cr(" %6s %10s %10s", "Length", "#Symbols", "Size"); |
1 | 669 |
for (i = 0; i < results_length; i++) { |
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
670 |
if (counts[i] > 0) { |
35898
ddc274f0052f
8145628: hotspot metadata classes shouldn't use HeapWordSize or heap related macros like align_object_size
coleenp
parents:
35497
diff
changeset
|
671 |
tty->print_cr(" %6d %10d %10dK", i, counts[i], (sizes[i]*wordSize)/1024); |
1 | 672 |
} |
673 |
} |
|
26923
60c1555c25c5
8057925: PrintSymbolTableSizeHistogram prints misleading output
shade
parents:
26421
diff
changeset
|
674 |
tty->print_cr(" >=%6d %10d %10dK\n", results_length, |
35898
ddc274f0052f
8145628: hotspot metadata classes shouldn't use HeapWordSize or heap related macros like align_object_size
coleenp
parents:
35497
diff
changeset
|
675 |
out_of_range_count, (out_of_range_size*wordSize)/1024); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
676 |
} |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
677 |
|
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
678 |
void SymbolTable::print() { |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
679 |
for (int i = 0; i < the_table()->table_size(); ++i) { |
13195 | 680 |
HashtableEntry<Symbol*, mtSymbol>** p = the_table()->bucket_addr(i); |
681 |
HashtableEntry<Symbol*, mtSymbol>* entry = the_table()->bucket(i); |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
682 |
if (entry != NULL) { |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
683 |
while (entry != NULL) { |
33148
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
31790
diff
changeset
|
684 |
tty->print(PTR_FORMAT " ", p2i(entry->literal())); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
685 |
entry->literal()->print(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
686 |
tty->print(" %d", entry->literal()->refcount()); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
687 |
p = entry->next_addr(); |
13195 | 688 |
entry = (HashtableEntry<Symbol*, mtSymbol>*)HashtableEntry<Symbol*, mtSymbol>::make_ptr(*p); |
1 | 689 |
} |
690 |
tty->cr(); |
|
691 |
} |
|
692 |
} |
|
693 |
} |
|
694 |
#endif // PRODUCT |
|
28363
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
695 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
696 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
697 |
// Utility for dumping symbols |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
698 |
SymboltableDCmd::SymboltableDCmd(outputStream* output, bool heap) : |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
699 |
DCmdWithParser(output, heap), |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
700 |
_verbose("-verbose", "Dump the content of each symbol in the table", |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
701 |
"BOOLEAN", false, "false") { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
702 |
_dcmdparser.add_dcmd_option(&_verbose); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
703 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
704 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
705 |
void SymboltableDCmd::execute(DCmdSource source, TRAPS) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
706 |
VM_DumpHashtable dumper(output(), VM_DumpHashtable::DumpSymbols, |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
707 |
_verbose.value()); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
708 |
VMThread::execute(&dumper); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
709 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
710 |
|
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
711 |
int SymboltableDCmd::num_arguments() { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
712 |
ResourceMark rm; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
713 |
SymboltableDCmd* dcmd = new SymboltableDCmd(NULL, false); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
714 |
if (dcmd != NULL) { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
715 |
DCmdMark mark(dcmd); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
716 |
return dcmd->_dcmdparser.num_arguments(); |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
717 |
} else { |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
718 |
return 0; |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
719 |
} |
047115468f16
8059510: Compact symbol table layout inside shared archive.
jiangli
parents:
27677
diff
changeset
|
720 |
} |