author | darcy |
Fri, 03 Jan 2014 10:38:23 -0800 | |
changeset 22101 | 231247ddf41a |
parent 21946 | b4cb3bbeb52a |
permissions | -rw-r--r-- |
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
1 |
/* |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
2 |
* Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
4 |
* |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
8 |
* |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
13 |
* accompanied this code). |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
14 |
* |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
18 |
* |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
21 |
* questions. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
22 |
*/ |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
23 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
24 |
import java.util.*; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
25 |
import java.util.function.*; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
26 |
import java.util.stream.*; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
27 |
|
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
28 |
import static java.lang.Double.*; |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
29 |
|
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
30 |
/* |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
31 |
* @test |
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
32 |
* @bug 8006572 8030212 |
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
33 |
* @summary Test for use of non-naive summation in stream-related sum and average operations. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
34 |
*/ |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
35 |
public class TestDoubleSumAverage { |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
36 |
public static void main(String... args) { |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
37 |
int failures = 0; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
38 |
|
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
39 |
failures += testZeroAverageOfNonEmptyStream(); |
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
40 |
failures += testForCompenstation(); |
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
41 |
failures += testNonfiniteSum(); |
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
42 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
43 |
if (failures > 0) { |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
44 |
throw new RuntimeException("Found " + failures + " numerical failure(s)."); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
45 |
} |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
46 |
} |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
47 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
48 |
/** |
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
49 |
* Test to verify that a non-empty stream with a zero average is non-empty. |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
50 |
*/ |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
51 |
private static int testZeroAverageOfNonEmptyStream() { |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
52 |
Supplier<DoubleStream> ds = () -> DoubleStream.iterate(0.0, e -> 0.0).limit(10); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
53 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
54 |
return compareUlpDifference(0.0, ds.get().average().getAsDouble(), 0); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
55 |
} |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
56 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
57 |
/** |
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
58 |
* Compute the sum and average of a sequence of double values in |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
59 |
* various ways and report an error if naive summation is used. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
60 |
*/ |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
61 |
private static int testForCompenstation() { |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
62 |
int failures = 0; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
63 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
64 |
/* |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
65 |
* The exact sum of the test stream is 1 + 1e6*ulp(1.0) but a |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
66 |
* naive summation algorithm will return 1.0 since (1.0 + |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
67 |
* ulp(1.0)/2) will round to 1.0 again. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
68 |
*/ |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
69 |
double base = 1.0; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
70 |
double increment = Math.ulp(base)/2.0; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
71 |
int count = 1_000_001; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
72 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
73 |
double expectedSum = base + (increment * (count - 1)); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
74 |
double expectedAvg = expectedSum / count; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
75 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
76 |
// Factory for double a stream of [base, increment, ..., increment] limited to a size of count |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
77 |
Supplier<DoubleStream> ds = () -> DoubleStream.iterate(base, e -> increment).limit(count); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
78 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
79 |
DoubleSummaryStatistics stats = ds.get().collect(DoubleSummaryStatistics::new, |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
80 |
DoubleSummaryStatistics::accept, |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
81 |
DoubleSummaryStatistics::combine); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
82 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
83 |
failures += compareUlpDifference(expectedSum, stats.getSum(), 3); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
84 |
failures += compareUlpDifference(expectedAvg, stats.getAverage(), 3); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
85 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
86 |
failures += compareUlpDifference(expectedSum, |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
87 |
ds.get().sum(), 3); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
88 |
failures += compareUlpDifference(expectedAvg, |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
89 |
ds.get().average().getAsDouble(), 3); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
90 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
91 |
failures += compareUlpDifference(expectedSum, |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
92 |
ds.get().boxed().collect(Collectors.summingDouble(d -> d)), 3); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
93 |
failures += compareUlpDifference(expectedAvg, |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
94 |
ds.get().boxed().collect(Collectors.averagingDouble(d -> d)),3); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
95 |
return failures; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
96 |
} |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
97 |
|
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
98 |
private static int testNonfiniteSum() { |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
99 |
int failures = 0; |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
100 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
101 |
Map<Supplier<DoubleStream>, Double> testCases = new LinkedHashMap<>(); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
102 |
testCases.put(() -> DoubleStream.of(MAX_VALUE, MAX_VALUE), POSITIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
103 |
testCases.put(() -> DoubleStream.of(-MAX_VALUE, -MAX_VALUE), NEGATIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
104 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
105 |
testCases.put(() -> DoubleStream.of(1.0d, POSITIVE_INFINITY, 1.0d), POSITIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
106 |
testCases.put(() -> DoubleStream.of(POSITIVE_INFINITY), POSITIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
107 |
testCases.put(() -> DoubleStream.of(POSITIVE_INFINITY, POSITIVE_INFINITY), POSITIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
108 |
testCases.put(() -> DoubleStream.of(POSITIVE_INFINITY, POSITIVE_INFINITY, 0.0), POSITIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
109 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
110 |
testCases.put(() -> DoubleStream.of(1.0d, NEGATIVE_INFINITY, 1.0d), NEGATIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
111 |
testCases.put(() -> DoubleStream.of(NEGATIVE_INFINITY), NEGATIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
112 |
testCases.put(() -> DoubleStream.of(NEGATIVE_INFINITY, NEGATIVE_INFINITY), NEGATIVE_INFINITY); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
113 |
testCases.put(() -> DoubleStream.of(NEGATIVE_INFINITY, NEGATIVE_INFINITY, 0.0), NEGATIVE_INFINITY); |
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
114 |
|
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
115 |
testCases.put(() -> DoubleStream.of(1.0d, NaN, 1.0d), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
116 |
testCases.put(() -> DoubleStream.of(NaN), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
117 |
testCases.put(() -> DoubleStream.of(1.0d, NEGATIVE_INFINITY, POSITIVE_INFINITY, 1.0d), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
118 |
testCases.put(() -> DoubleStream.of(1.0d, POSITIVE_INFINITY, NEGATIVE_INFINITY, 1.0d), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
119 |
testCases.put(() -> DoubleStream.of(POSITIVE_INFINITY, NaN), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
120 |
testCases.put(() -> DoubleStream.of(NEGATIVE_INFINITY, NaN), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
121 |
testCases.put(() -> DoubleStream.of(NaN, POSITIVE_INFINITY), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
122 |
testCases.put(() -> DoubleStream.of(NaN, NEGATIVE_INFINITY), NaN); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
123 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
124 |
for(Map.Entry<Supplier<DoubleStream>, Double> testCase : testCases.entrySet()) { |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
125 |
Supplier<DoubleStream> ds = testCase.getKey(); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
126 |
double expected = testCase.getValue(); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
127 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
128 |
DoubleSummaryStatistics stats = ds.get().collect(DoubleSummaryStatistics::new, |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
129 |
DoubleSummaryStatistics::accept, |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
130 |
DoubleSummaryStatistics::combine); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
131 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
132 |
failures += compareUlpDifference(expected, stats.getSum(), 0); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
133 |
failures += compareUlpDifference(expected, stats.getAverage(), 0); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
134 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
135 |
failures += compareUlpDifference(expected, ds.get().sum(), 0); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
136 |
failures += compareUlpDifference(expected, ds.get().average().getAsDouble(), 0); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
137 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
138 |
failures += compareUlpDifference(expected, ds.get().boxed().collect(Collectors.summingDouble(d -> d)), 0); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
139 |
failures += compareUlpDifference(expected, ds.get().boxed().collect(Collectors.averagingDouble(d -> d)), 0); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
140 |
} |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
141 |
|
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
142 |
return failures; |
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
143 |
} |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
144 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
145 |
/** |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
146 |
* Compute the ulp difference of two double values and compare against an error threshold. |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
147 |
*/ |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
148 |
private static int compareUlpDifference(double expected, double computed, double threshold) { |
22101
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
149 |
if (!Double.isFinite(expected)) { |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
150 |
// Handle NaN and infinity cases |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
151 |
if (Double.compare(expected, computed) == 0) |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
152 |
return 0; |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
153 |
else { |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
154 |
System.err.printf("Unexpected sum, %g rather than %g.%n", |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
155 |
computed, expected); |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
156 |
return 1; |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
157 |
} |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
158 |
} |
231247ddf41a
8030212: Several api.java.util.stream tests got "NaN" value instead of "Infinity" or "-Infinity"
darcy
parents:
21946
diff
changeset
|
159 |
|
21946
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
160 |
double ulpDifference = Math.abs(expected - computed) / Math.ulp(expected); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
161 |
|
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
162 |
if (ulpDifference > threshold) { |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
163 |
System.err.printf("Numerical summation error too large, %g ulps rather than %g.%n", |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
164 |
ulpDifference, threshold); |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
165 |
return 1; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
166 |
} else |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
167 |
return 0; |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
168 |
} |
b4cb3bbeb52a
8006572: DoubleStream.sum() & DoubleSummaryStats implementations that reduce numerical errors
darcy
parents:
diff
changeset
|
169 |
} |