langtools/test/tools/javac/linenumbers/NullCheckLineNumberTest.java
author jlahoda
Wed, 31 May 2017 14:51:02 +0200
changeset 45316 170696ddb377
permissions -rw-r--r--
8172880: Incorrect line number for NPE generated by instance-bound method reference Summary: Synthetic null checks should have a LineNumberTable entry. Reviewed-by: mcimadamore
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
45316
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     1
/*
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     2
 * @test /nodynamiccopyright/
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     3
 * @bug 8172880
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     4
 * @summary  Wrong LineNumberTable for synthetic null checks
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     5
 * @modules jdk.jdeps/com.sun.tools.classfile
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     6
 */
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     7
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     8
import com.sun.tools.classfile.ClassFile;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
     9
import com.sun.tools.classfile.ConstantPoolException;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    10
import com.sun.tools.classfile.Method;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    11
import com.sun.tools.classfile.Attribute;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    12
import com.sun.tools.classfile.Code_attribute;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    13
import com.sun.tools.classfile.LineNumberTable_attribute;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    14
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    15
import java.io.IOException;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    16
import java.util.AbstractMap.SimpleEntry;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    17
import java.util.Arrays;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    18
import java.util.List;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    19
import java.util.Map.Entry;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    20
import java.util.Objects;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    21
import java.util.stream.Collectors;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    22
import java.util.stream.Stream;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    23
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    24
public class NullCheckLineNumberTest {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    25
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    26
    //test data:
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    27
    static class Test {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    28
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    29
        public Test() {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    30
            String a = "", b = null;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    31
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    32
            Stream.of("x")
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    33
                  .filter(a::equals)
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    34
                  .filter(b::equals)
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    35
                  .count();
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    36
        }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    37
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    38
    }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    39
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    40
    public static void main(String[] args) throws Exception {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    41
        List<Entry> actualEntries = findEntries();
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    42
        List<Entry> expectedEntries = List.of(
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    43
                new SimpleEntry<>(29, 0),
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    44
                new SimpleEntry<>(30, 4),
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    45
                new SimpleEntry<>(32, 9),
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    46
                new SimpleEntry<>(33, 16),
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    47
                new SimpleEntry<>(34, 32),
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    48
                new SimpleEntry<>(35, 46),
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    49
                new SimpleEntry<>(36, 52)
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    50
        );
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    51
        if (!Objects.equals(actualEntries, expectedEntries)) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    52
            error(String.format("Unexpected LineNumberTable: %s", actualEntries.toString()));
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    53
        }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    54
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    55
        try {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    56
            new Test();
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    57
        } catch (NullPointerException npe) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    58
            if (Arrays.stream(npe.getStackTrace())
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    59
                      .noneMatch(se -> se.getFileName().contains("NullCheckLineNumberTest") &&
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    60
                                       se.getLineNumber() == 34)) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    61
                throw new AssertionError("Should go through line 34!");
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    62
            }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    63
        }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    64
    }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    65
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    66
    static List<Entry> findEntries() throws IOException, ConstantPoolException {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    67
        ClassFile self = ClassFile.read(NullCheckLineNumberTest.Test.class.getResourceAsStream("NullCheckLineNumberTest$Test.class"));
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    68
        for (Method m : self.methods) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    69
            if ("<init>".equals(m.getName(self.constant_pool))) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    70
                Code_attribute code_attribute = (Code_attribute)m.attributes.get(Attribute.Code);
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    71
                for (Attribute at : code_attribute.attributes) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    72
                    if (Attribute.LineNumberTable.equals(at.getName(self.constant_pool))) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    73
                        return Arrays.stream(((LineNumberTable_attribute)at).line_number_table)
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    74
                                     .map(e -> new SimpleEntry<> (e.line_number, e.start_pc))
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    75
                                     .collect(Collectors.toList());
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    76
                    }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    77
                }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    78
            }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    79
        }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    80
        return null;
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    81
    }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    82
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    83
    static void error(String msg) {
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    84
        throw new AssertionError(msg);
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    85
    }
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    86
170696ddb377 8172880: Incorrect line number for NPE generated by instance-bound method reference
jlahoda
parents:
diff changeset
    87
}