hotspot/src/share/vm/opto/ifnode.cpp
author jprovino
Mon, 04 Apr 2016 12:57:48 -0400
changeset 37248 11a660dbbb8e
parent 36336 7006dd73b206
child 44241 99010d3fcc97
permissions -rw-r--r--
8132524: Missing includes to resourceArea.hpp Summary: Files that use ResourceMark are missing the include of resourceArea.hpp Reviewed-by: tschatzl, jwilhelm
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
37248
11a660dbbb8e 8132524: Missing includes to resourceArea.hpp
jprovino
parents: 36336
diff changeset
     2
 * Copyright (c) 2000, 2016, Oracle and/or its affiliates. All rights reserved.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4582
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4582
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4582
diff changeset
    21
 * questions.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    25
#include "precompiled.hpp"
34151
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
    26
#include "ci/ciTypeFlow.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    27
#include "memory/allocation.inline.hpp"
37248
11a660dbbb8e 8132524: Missing includes to resourceArea.hpp
jprovino
parents: 36336
diff changeset
    28
#include "memory/resourceArea.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    29
#include "opto/addnode.hpp"
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
    30
#include "opto/castnode.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    31
#include "opto/cfgnode.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    32
#include "opto/connode.hpp"
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
    33
#include "opto/loopnode.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    34
#include "opto/phaseX.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    35
#include "opto/runtime.hpp"
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
    36
#include "opto/rootnode.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    37
#include "opto/subnode.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 5901
diff changeset
    38
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    39
// Portions of code courtesy of Clifford Click
489c9b5090e2 Initial load
duke
parents:
diff changeset
    40
489c9b5090e2 Initial load
duke
parents:
diff changeset
    41
// Optimization - Graph Style
489c9b5090e2 Initial load
duke
parents:
diff changeset
    42
489c9b5090e2 Initial load
duke
parents:
diff changeset
    43
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
    44
#ifndef PRODUCT
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    45
extern int explicit_null_checks_elided;
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
    46
#endif
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    47
489c9b5090e2 Initial load
duke
parents:
diff changeset
    48
//=============================================================================
489c9b5090e2 Initial load
duke
parents:
diff changeset
    49
//------------------------------Value------------------------------------------
489c9b5090e2 Initial load
duke
parents:
diff changeset
    50
// Return a tuple for whichever arm of the IF is reachable
35551
36ef3841fb34 8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents: 34181
diff changeset
    51
const Type* IfNode::Value(PhaseGVN* phase) const {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    52
  if( !in(0) ) return Type::TOP;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    53
  if( phase->type(in(0)) == Type::TOP )
489c9b5090e2 Initial load
duke
parents:
diff changeset
    54
    return Type::TOP;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    55
  const Type *t = phase->type(in(1));
489c9b5090e2 Initial load
duke
parents:
diff changeset
    56
  if( t == Type::TOP )          // data is undefined
489c9b5090e2 Initial load
duke
parents:
diff changeset
    57
    return TypeTuple::IFNEITHER; // unreachable altogether
489c9b5090e2 Initial load
duke
parents:
diff changeset
    58
  if( t == TypeInt::ZERO )      // zero, or false
489c9b5090e2 Initial load
duke
parents:
diff changeset
    59
    return TypeTuple::IFFALSE;  // only false branch is reachable
489c9b5090e2 Initial load
duke
parents:
diff changeset
    60
  if( t == TypeInt::ONE )       // 1, or true
489c9b5090e2 Initial load
duke
parents:
diff changeset
    61
    return TypeTuple::IFTRUE;   // only true branch is reachable
489c9b5090e2 Initial load
duke
parents:
diff changeset
    62
  assert( t == TypeInt::BOOL, "expected boolean type" );
489c9b5090e2 Initial load
duke
parents:
diff changeset
    63
489c9b5090e2 Initial load
duke
parents:
diff changeset
    64
  return TypeTuple::IFBOTH;     // No progress
489c9b5090e2 Initial load
duke
parents:
diff changeset
    65
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
const RegMask &IfNode::out_RegMask() const {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
  return RegMask::Empty;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    69
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    70
489c9b5090e2 Initial load
duke
parents:
diff changeset
    71
//------------------------------split_if---------------------------------------
489c9b5090e2 Initial load
duke
parents:
diff changeset
    72
// Look for places where we merge constants, then test on the merged value.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    73
// If the IF test will be constant folded on the path with the constant, we
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
// win by splitting the IF to before the merge point.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    75
static Node* split_if(IfNode *iff, PhaseIterGVN *igvn) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    76
  // I could be a lot more general here, but I'm trying to squeeze this
489c9b5090e2 Initial load
duke
parents:
diff changeset
    77
  // in before the Christmas '98 break so I'm gonna be kinda restrictive
489c9b5090e2 Initial load
duke
parents:
diff changeset
    78
  // on the patterns I accept.  CNC
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
489c9b5090e2 Initial load
duke
parents:
diff changeset
    80
  // Look for a compare of a constant and a merged value
489c9b5090e2 Initial load
duke
parents:
diff changeset
    81
  Node *i1 = iff->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    82
  if( !i1->is_Bool() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
  BoolNode *b = i1->as_Bool();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    84
  Node *cmp = b->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
  if( !cmp->is_Cmp() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    86
  i1 = cmp->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    87
  if( i1 == NULL || !i1->is_Phi() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    88
  PhiNode *phi = i1->as_Phi();
489c9b5090e2 Initial load
duke
parents:
diff changeset
    89
  if( phi->is_copy() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    90
  Node *con2 = cmp->in(2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    91
  if( !con2->is_Con() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    92
  // See that the merge point contains some constants
489c9b5090e2 Initial load
duke
parents:
diff changeset
    93
  Node *con1=NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    94
  uint i4;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    95
  for( i4 = 1; i4 < phi->req(); i4++ ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    96
    con1 = phi->in(i4);
2131
98f9cef66a34 6810672: Comment typos
twisti
parents: 1217
diff changeset
    97
    if( !con1 ) return NULL;    // Do not optimize partially collapsed merges
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    98
    if( con1->is_Con() ) break; // Found a constant
489c9b5090e2 Initial load
duke
parents:
diff changeset
    99
    // Also allow null-vs-not-null checks
489c9b5090e2 Initial load
duke
parents:
diff changeset
   100
    const TypePtr *tp = igvn->type(con1)->isa_ptr();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   101
    if( tp && tp->_ptr == TypePtr::NotNull )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   102
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   103
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   104
  if( i4 >= phi->req() ) return NULL; // Found no constants
489c9b5090e2 Initial load
duke
parents:
diff changeset
   105
489c9b5090e2 Initial load
duke
parents:
diff changeset
   106
  igvn->C->set_has_split_ifs(true); // Has chance for split-if
489c9b5090e2 Initial load
duke
parents:
diff changeset
   107
489c9b5090e2 Initial load
duke
parents:
diff changeset
   108
  // Make sure that the compare can be constant folded away
489c9b5090e2 Initial load
duke
parents:
diff changeset
   109
  Node *cmp2 = cmp->clone();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   110
  cmp2->set_req(1,con1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   111
  cmp2->set_req(2,con2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   112
  const Type *t = cmp2->Value(igvn);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   113
  // This compare is dead, so whack it!
489c9b5090e2 Initial load
duke
parents:
diff changeset
   114
  igvn->remove_dead_node(cmp2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   115
  if( !t->singleton() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   116
489c9b5090e2 Initial load
duke
parents:
diff changeset
   117
  // No intervening control, like a simple Call
489c9b5090e2 Initial load
duke
parents:
diff changeset
   118
  Node *r = iff->in(0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   119
  if( !r->is_Region() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   120
  if( phi->region() != r ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   121
  // No other users of the cmp/bool
489c9b5090e2 Initial load
duke
parents:
diff changeset
   122
  if (b->outcnt() != 1 || cmp->outcnt() != 1) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   123
    //tty->print_cr("many users of cmp/bool");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   124
    return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   125
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   126
489c9b5090e2 Initial load
duke
parents:
diff changeset
   127
  // Make sure we can determine where all the uses of merged values go
489c9b5090e2 Initial load
duke
parents:
diff changeset
   128
  for (DUIterator_Fast jmax, j = r->fast_outs(jmax); j < jmax; j++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   129
    Node* u = r->fast_out(j);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   130
    if( u == r ) continue;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   131
    if( u == iff ) continue;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   132
    if( u->outcnt() == 0 ) continue; // use is dead & ignorable
489c9b5090e2 Initial load
duke
parents:
diff changeset
   133
    if( !u->is_Phi() ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   134
      /*
489c9b5090e2 Initial load
duke
parents:
diff changeset
   135
      if( u->is_Start() ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   136
        tty->print_cr("Region has inlined start use");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   137
      } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   138
        tty->print_cr("Region has odd use");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   139
        u->dump(2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   140
      }*/
489c9b5090e2 Initial load
duke
parents:
diff changeset
   141
      return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   142
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   143
    if( u != phi ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   144
      // CNC - do not allow any other merged value
489c9b5090e2 Initial load
duke
parents:
diff changeset
   145
      //tty->print_cr("Merging another value");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   146
      //u->dump(2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   147
      return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   148
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   149
    // Make sure we can account for all Phi uses
489c9b5090e2 Initial load
duke
parents:
diff changeset
   150
    for (DUIterator_Fast kmax, k = u->fast_outs(kmax); k < kmax; k++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   151
      Node* v = u->fast_out(k); // User of the phi
489c9b5090e2 Initial load
duke
parents:
diff changeset
   152
      // CNC - Allow only really simple patterns.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   153
      // In particular I disallow AddP of the Phi, a fairly common pattern
28927
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   154
      if (v == cmp) continue;  // The compare is OK
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   155
      if (v->is_ConstraintCast()) {
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   156
        // If the cast is derived from data flow edges, it may not have a control edge.
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   157
        // If so, it should be safe to split. But follow-up code can not deal with
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   158
        // this (l. 359). So skip.
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   159
        if (v->in(0) == NULL) {
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   160
          return NULL;
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   161
        }
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   162
        if (v->in(0)->in(0) == iff) {
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   163
          continue;               // CastPP/II of the IfNode is OK
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   164
        }
48e4a707e777 8071996: split_if accesses NULL region of ConstraintCast
goetz
parents: 28486
diff changeset
   165
      }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   166
      // Disabled following code because I cannot tell if exactly one
489c9b5090e2 Initial load
duke
parents:
diff changeset
   167
      // path dominates without a real dominator check. CNC 9/9/1999
489c9b5090e2 Initial load
duke
parents:
diff changeset
   168
      //uint vop = v->Opcode();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   169
      //if( vop == Op_Phi ) {     // Phi from another merge point might be OK
489c9b5090e2 Initial load
duke
parents:
diff changeset
   170
      //  Node *r = v->in(0);     // Get controlling point
489c9b5090e2 Initial load
duke
parents:
diff changeset
   171
      //  if( !r ) return NULL;   // Degraded to a copy
489c9b5090e2 Initial load
duke
parents:
diff changeset
   172
      //  // Find exactly one path in (either True or False doms, but not IFF)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   173
      //  int cnt = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   174
      //  for( uint i = 1; i < r->req(); i++ )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   175
      //    if( r->in(i) && r->in(i)->in(0) == iff )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   176
      //      cnt++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   177
      //  if( cnt == 1 ) continue; // Exactly one of True or False guards Phi
489c9b5090e2 Initial load
duke
parents:
diff changeset
   178
      //}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   179
      if( !v->is_Call() ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   180
        /*
489c9b5090e2 Initial load
duke
parents:
diff changeset
   181
        if( v->Opcode() == Op_AddP ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   182
          tty->print_cr("Phi has AddP use");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   183
        } else if( v->Opcode() == Op_CastPP ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   184
          tty->print_cr("Phi has CastPP use");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   185
        } else if( v->Opcode() == Op_CastII ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   186
          tty->print_cr("Phi has CastII use");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   187
        } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   188
          tty->print_cr("Phi has use I cant be bothered with");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   189
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   190
        */
489c9b5090e2 Initial load
duke
parents:
diff changeset
   191
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   192
      return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   193
489c9b5090e2 Initial load
duke
parents:
diff changeset
   194
      /* CNC - Cut out all the fancy acceptance tests
489c9b5090e2 Initial load
duke
parents:
diff changeset
   195
      // Can we clone this use when doing the transformation?
489c9b5090e2 Initial load
duke
parents:
diff changeset
   196
      // If all uses are from Phis at this merge or constants, then YES.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   197
      if( !v->in(0) && v != cmp ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   198
        tty->print_cr("Phi has free-floating use");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   199
        v->dump(2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   200
        return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   201
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   202
      for( uint l = 1; l < v->req(); l++ ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   203
        if( (!v->in(l)->is_Phi() || v->in(l)->in(0) != r) &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   204
            !v->in(l)->is_Con() ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   205
          tty->print_cr("Phi has use");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   206
          v->dump(2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   207
          return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   208
        } // End of if Phi-use input is neither Phi nor Constant
489c9b5090e2 Initial load
duke
parents:
diff changeset
   209
      } // End of for all inputs to Phi-use
489c9b5090e2 Initial load
duke
parents:
diff changeset
   210
      */
489c9b5090e2 Initial load
duke
parents:
diff changeset
   211
    } // End of for all uses of Phi
489c9b5090e2 Initial load
duke
parents:
diff changeset
   212
  } // End of for all uses of Region
489c9b5090e2 Initial load
duke
parents:
diff changeset
   213
489c9b5090e2 Initial load
duke
parents:
diff changeset
   214
  // Only do this if the IF node is in a sane state
489c9b5090e2 Initial load
duke
parents:
diff changeset
   215
  if (iff->outcnt() != 2)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   216
    return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   217
489c9b5090e2 Initial load
duke
parents:
diff changeset
   218
  // Got a hit!  Do the Mondo Hack!
489c9b5090e2 Initial load
duke
parents:
diff changeset
   219
  //
489c9b5090e2 Initial load
duke
parents:
diff changeset
   220
  //ABC  a1c   def   ghi            B     1     e     h   A C   a c   d f   g i
489c9b5090e2 Initial load
duke
parents:
diff changeset
   221
  // R - Phi - Phi - Phi            Rc - Phi - Phi - Phi   Rx - Phi - Phi - Phi
489c9b5090e2 Initial load
duke
parents:
diff changeset
   222
  //     cmp - 2                         cmp - 2               cmp - 2
489c9b5090e2 Initial load
duke
parents:
diff changeset
   223
  //       bool                            bool_c                bool_x
489c9b5090e2 Initial load
duke
parents:
diff changeset
   224
  //       if                               if_c                  if_x
489c9b5090e2 Initial load
duke
parents:
diff changeset
   225
  //      T  F                              T  F                  T  F
489c9b5090e2 Initial load
duke
parents:
diff changeset
   226
  // ..s..    ..t ..                   ..s..    ..t..        ..s..    ..t..
489c9b5090e2 Initial load
duke
parents:
diff changeset
   227
  //
2131
98f9cef66a34 6810672: Comment typos
twisti
parents: 1217
diff changeset
   228
  // Split the paths coming into the merge point into 2 separate groups of
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   229
  // merges.  On the left will be all the paths feeding constants into the
489c9b5090e2 Initial load
duke
parents:
diff changeset
   230
  // Cmp's Phi.  On the right will be the remaining paths.  The Cmp's Phi
489c9b5090e2 Initial load
duke
parents:
diff changeset
   231
  // will fold up into a constant; this will let the Cmp fold up as well as
489c9b5090e2 Initial load
duke
parents:
diff changeset
   232
  // all the control flow.  Below the original IF we have 2 control
489c9b5090e2 Initial load
duke
parents:
diff changeset
   233
  // dependent regions, 's' and 't'.  Now we will merge the two paths
489c9b5090e2 Initial load
duke
parents:
diff changeset
   234
  // just prior to 's' and 't' from the two IFs.  At least 1 path (and quite
489c9b5090e2 Initial load
duke
parents:
diff changeset
   235
  // likely 2 or more) will promptly constant fold away.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   236
  PhaseGVN *phase = igvn;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   237
489c9b5090e2 Initial load
duke
parents:
diff changeset
   238
  // Make a region merging constants and a region merging the rest
489c9b5090e2 Initial load
duke
parents:
diff changeset
   239
  uint req_c = 0;
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   240
  Node* predicate_proj = NULL;
30309
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   241
  int nb_predicate_proj = 0;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   242
  for (uint ii = 1; ii < r->req(); ii++) {
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   243
    if (phi->in(ii) == con1) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   244
      req_c++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   245
    }
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   246
    Node* proj = PhaseIdealLoop::find_predicate(r->in(ii));
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   247
    if (proj != NULL) {
30309
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   248
      nb_predicate_proj++;
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   249
      predicate_proj = proj;
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   250
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   251
  }
30309
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   252
  if (nb_predicate_proj > 1) {
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   253
    // Can happen in case of loop unswitching and when the loop is
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   254
    // optimized out: it's not a loop anymore so we don't care about
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   255
    // predicates.
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   256
    assert(!r->is_Loop(), "this must not be a loop anymore");
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   257
    predicate_proj = NULL;
da3efc8ed2cb 8078426: mb/jvm/compiler/InterfaceCalls/testAC2 - assert(predicate_proj == 0L) failed: only one predicate entry expected
roland
parents: 30183
diff changeset
   258
  }
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   259
  Node* predicate_c = NULL;
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   260
  Node* predicate_x = NULL;
9446
748a37b25d10 5091921: Sign flip issues in loop optimizer
kvn
parents: 9101
diff changeset
   261
  bool counted_loop = r->is_CountedLoop();
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   262
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   263
  Node *region_c = new RegionNode(req_c + 1);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   264
  Node *phi_c    = con1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   265
  uint  len      = r->req();
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   266
  Node *region_x = new RegionNode(len - req_c);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   267
  Node *phi_x    = PhiNode::make_blank(region_x, phi);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   268
  for (uint i = 1, i_c = 1, i_x = 1; i < len; i++) {
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   269
    if (phi->in(i) == con1) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   270
      region_c->init_req( i_c++, r  ->in(i) );
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   271
      if (r->in(i) == predicate_proj)
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   272
        predicate_c = predicate_proj;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   273
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   274
      region_x->init_req( i_x,   r  ->in(i) );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   275
      phi_x   ->init_req( i_x++, phi->in(i) );
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   276
      if (r->in(i) == predicate_proj)
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   277
        predicate_x = predicate_proj;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   278
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   279
  }
10258
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   280
  if (predicate_c != NULL && (req_c > 1)) {
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   281
    assert(predicate_x == NULL, "only one predicate entry expected");
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   282
    predicate_c = NULL; // Do not clone predicate below merge point
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   283
  }
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   284
  if (predicate_x != NULL && ((len - req_c) > 2)) {
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   285
    assert(predicate_c == NULL, "only one predicate entry expected");
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   286
    predicate_x = NULL; // Do not clone predicate below merge point
10c77b8c8d3e 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post
kvn
parents: 10253
diff changeset
   287
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   288
489c9b5090e2 Initial load
duke
parents:
diff changeset
   289
  // Register the new RegionNodes but do not transform them.  Cannot
2131
98f9cef66a34 6810672: Comment typos
twisti
parents: 1217
diff changeset
   290
  // transform until the entire Region/Phi conglomerate has been hacked
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   291
  // as a single huge transform.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   292
  igvn->register_new_node_with_optimizer( region_c );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   293
  igvn->register_new_node_with_optimizer( region_x );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   294
  // Prevent the untimely death of phi_x.  Currently he has no uses.  He is
489c9b5090e2 Initial load
duke
parents:
diff changeset
   295
  // about to get one.  If this only use goes away, then phi_x will look dead.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   296
  // However, he will be picking up some more uses down below.
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   297
  Node *hook = new Node(4);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   298
  hook->init_req(0, phi_x);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   299
  hook->init_req(1, phi_c);
4016
9c11d6d519f7 6889300: assert(i != k || is_new || i->outcnt() > 0, "don't return dead nodes")
kvn
parents: 3268
diff changeset
   300
  phi_x = phase->transform( phi_x );
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   301
489c9b5090e2 Initial load
duke
parents:
diff changeset
   302
  // Make the compare
489c9b5090e2 Initial load
duke
parents:
diff changeset
   303
  Node *cmp_c = phase->makecon(t);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   304
  Node *cmp_x = cmp->clone();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   305
  cmp_x->set_req(1,phi_x);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   306
  cmp_x->set_req(2,con2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   307
  cmp_x = phase->transform(cmp_x);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   308
  // Make the bool
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   309
  Node *b_c = phase->transform(new BoolNode(cmp_c,b->_test._test));
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   310
  Node *b_x = phase->transform(new BoolNode(cmp_x,b->_test._test));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   311
  // Make the IfNode
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   312
  IfNode* iff_c = iff->clone()->as_If();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   313
  iff_c->set_req(0, region_c);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   314
  iff_c->set_req(1, b_c);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   315
  igvn->set_type_bottom(iff_c);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   316
  igvn->_worklist.push(iff_c);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   317
  hook->init_req(2, iff_c);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   318
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   319
  IfNode* iff_x = iff->clone()->as_If();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   320
  iff_x->set_req(0, region_x);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   321
  iff_x->set_req(1, b_x);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   322
  igvn->set_type_bottom(iff_x);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   323
  igvn->_worklist.push(iff_x);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   324
  hook->init_req(3, iff_x);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   325
489c9b5090e2 Initial load
duke
parents:
diff changeset
   326
  // Make the true/false arms
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   327
  Node *iff_c_t = phase->transform(new IfTrueNode (iff_c));
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   328
  Node *iff_c_f = phase->transform(new IfFalseNode(iff_c));
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   329
  if (predicate_c != NULL) {
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   330
    assert(predicate_x == NULL, "only one predicate entry expected");
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   331
    // Clone loop predicates to each path
9446
748a37b25d10 5091921: Sign flip issues in loop optimizer
kvn
parents: 9101
diff changeset
   332
    iff_c_t = igvn->clone_loop_predicates(predicate_c, iff_c_t, !counted_loop);
748a37b25d10 5091921: Sign flip issues in loop optimizer
kvn
parents: 9101
diff changeset
   333
    iff_c_f = igvn->clone_loop_predicates(predicate_c, iff_c_f, !counted_loop);
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   334
  }
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   335
  Node *iff_x_t = phase->transform(new IfTrueNode (iff_x));
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   336
  Node *iff_x_f = phase->transform(new IfFalseNode(iff_x));
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   337
  if (predicate_x != NULL) {
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   338
    assert(predicate_c == NULL, "only one predicate entry expected");
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   339
    // Clone loop predicates to each path
9446
748a37b25d10 5091921: Sign flip issues in loop optimizer
kvn
parents: 9101
diff changeset
   340
    iff_x_t = igvn->clone_loop_predicates(predicate_x, iff_x_t, !counted_loop);
748a37b25d10 5091921: Sign flip issues in loop optimizer
kvn
parents: 9101
diff changeset
   341
    iff_x_f = igvn->clone_loop_predicates(predicate_x, iff_x_f, !counted_loop);
9101
ff58f9a8e31c 7004535: Clone loop predicate during loop unswitch
kvn
parents: 7397
diff changeset
   342
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   343
489c9b5090e2 Initial load
duke
parents:
diff changeset
   344
  // Merge the TRUE paths
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   345
  Node *region_s = new RegionNode(3);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   346
  igvn->_worklist.push(region_s);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   347
  region_s->init_req(1, iff_c_t);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   348
  region_s->init_req(2, iff_x_t);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   349
  igvn->register_new_node_with_optimizer( region_s );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   350
489c9b5090e2 Initial load
duke
parents:
diff changeset
   351
  // Merge the FALSE paths
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   352
  Node *region_f = new RegionNode(3);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   353
  igvn->_worklist.push(region_f);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   354
  region_f->init_req(1, iff_c_f);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   355
  region_f->init_req(2, iff_x_f);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   356
  igvn->register_new_node_with_optimizer( region_f );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   357
489c9b5090e2 Initial load
duke
parents:
diff changeset
   358
  igvn->hash_delete(cmp);// Remove soon-to-be-dead node from hash table.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   359
  cmp->set_req(1,NULL);  // Whack the inputs to cmp because it will be dead
489c9b5090e2 Initial load
duke
parents:
diff changeset
   360
  cmp->set_req(2,NULL);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   361
  // Check for all uses of the Phi and give them a new home.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   362
  // The 'cmp' got cloned, but CastPP/IIs need to be moved.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   363
  Node *phi_s = NULL;     // do not construct unless needed
489c9b5090e2 Initial load
duke
parents:
diff changeset
   364
  Node *phi_f = NULL;     // do not construct unless needed
489c9b5090e2 Initial load
duke
parents:
diff changeset
   365
  for (DUIterator_Last i2min, i2 = phi->last_outs(i2min); i2 >= i2min; --i2) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   366
    Node* v = phi->last_out(i2);// User of the phi
12958
009b6c9586d8 7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents: 10258
diff changeset
   367
    igvn->rehash_node_delayed(v); // Have to fixup other Phi users
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   368
    uint vop = v->Opcode();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   369
    Node *proj = NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   370
    if( vop == Op_Phi ) {       // Remote merge point
489c9b5090e2 Initial load
duke
parents:
diff changeset
   371
      Node *r = v->in(0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   372
      for (uint i3 = 1; i3 < r->req(); i3++)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   373
        if (r->in(i3) && r->in(i3)->in(0) == iff) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   374
          proj = r->in(i3);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   375
          break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   376
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   377
    } else if( v->is_ConstraintCast() ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   378
      proj = v->in(0);          // Controlling projection
489c9b5090e2 Initial load
duke
parents:
diff changeset
   379
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   380
      assert( 0, "do not know how to handle this guy" );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   381
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   382
489c9b5090e2 Initial load
duke
parents:
diff changeset
   383
    Node *proj_path_data, *proj_path_ctrl;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   384
    if( proj->Opcode() == Op_IfTrue ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   385
      if( phi_s == NULL ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   386
        // Only construct phi_s if needed, otherwise provides
489c9b5090e2 Initial load
duke
parents:
diff changeset
   387
        // interfering use.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   388
        phi_s = PhiNode::make_blank(region_s,phi);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   389
        phi_s->init_req( 1, phi_c );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   390
        phi_s->init_req( 2, phi_x );
4016
9c11d6d519f7 6889300: assert(i != k || is_new || i->outcnt() > 0, "don't return dead nodes")
kvn
parents: 3268
diff changeset
   391
        hook->add_req(phi_s);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   392
        phi_s = phase->transform(phi_s);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   393
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   394
      proj_path_data = phi_s;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   395
      proj_path_ctrl = region_s;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   396
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   397
      if( phi_f == NULL ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   398
        // Only construct phi_f if needed, otherwise provides
489c9b5090e2 Initial load
duke
parents:
diff changeset
   399
        // interfering use.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   400
        phi_f = PhiNode::make_blank(region_f,phi);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   401
        phi_f->init_req( 1, phi_c );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   402
        phi_f->init_req( 2, phi_x );
4016
9c11d6d519f7 6889300: assert(i != k || is_new || i->outcnt() > 0, "don't return dead nodes")
kvn
parents: 3268
diff changeset
   403
        hook->add_req(phi_f);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   404
        phi_f = phase->transform(phi_f);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   405
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   406
      proj_path_data = phi_f;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   407
      proj_path_ctrl = region_f;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   408
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   409
489c9b5090e2 Initial load
duke
parents:
diff changeset
   410
    // Fixup 'v' for for the split
489c9b5090e2 Initial load
duke
parents:
diff changeset
   411
    if( vop == Op_Phi ) {       // Remote merge point
489c9b5090e2 Initial load
duke
parents:
diff changeset
   412
      uint i;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   413
      for( i = 1; i < v->req(); i++ )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   414
        if( v->in(i) == phi )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   415
          break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   416
      v->set_req(i, proj_path_data );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   417
    } else if( v->is_ConstraintCast() ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   418
      v->set_req(0, proj_path_ctrl );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   419
      v->set_req(1, proj_path_data );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   420
    } else
489c9b5090e2 Initial load
duke
parents:
diff changeset
   421
      ShouldNotReachHere();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   422
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   423
489c9b5090e2 Initial load
duke
parents:
diff changeset
   424
  // Now replace the original iff's True/False with region_s/region_t.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   425
  // This makes the original iff go dead.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   426
  for (DUIterator_Last i3min, i3 = iff->last_outs(i3min); i3 >= i3min; --i3) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   427
    Node* p = iff->last_out(i3);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   428
    assert( p->Opcode() == Op_IfTrue || p->Opcode() == Op_IfFalse, "" );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   429
    Node *u = (p->Opcode() == Op_IfTrue) ? region_s : region_f;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   430
    // Replace p with u
489c9b5090e2 Initial load
duke
parents:
diff changeset
   431
    igvn->add_users_to_worklist(p);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   432
    for (DUIterator_Last lmin, l = p->last_outs(lmin); l >= lmin;) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   433
      Node* x = p->last_out(l);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   434
      igvn->hash_delete(x);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   435
      uint uses_found = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   436
      for( uint j = 0; j < x->req(); j++ ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   437
        if( x->in(j) == p ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   438
          x->set_req(j, u);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   439
          uses_found++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   440
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   441
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   442
      l -= uses_found;    // we deleted 1 or more copies of this edge
489c9b5090e2 Initial load
duke
parents:
diff changeset
   443
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   444
    igvn->remove_dead_node(p);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   445
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   446
489c9b5090e2 Initial load
duke
parents:
diff changeset
   447
  // Force the original merge dead
489c9b5090e2 Initial load
duke
parents:
diff changeset
   448
  igvn->hash_delete(r);
3268
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   449
  // First, remove region's dead users.
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   450
  for (DUIterator_Last lmin, l = r->last_outs(lmin); l >= lmin;) {
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   451
    Node* u = r->last_out(l);
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   452
    if( u == r ) {
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   453
      r->set_req(0, NULL);
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   454
    } else {
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   455
      assert(u->outcnt() == 0, "only dead users");
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   456
      igvn->remove_dead_node(u);
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   457
    }
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   458
    l -= 1;
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   459
  }
f034e0c86895 6851742: (EA) allocation elimination doesn't work with UseG1GC
kvn
parents: 2131
diff changeset
   460
  igvn->remove_dead_node(r);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   461
489c9b5090e2 Initial load
duke
parents:
diff changeset
   462
  // Now remove the bogus extra edges used to keep things alive
489c9b5090e2 Initial load
duke
parents:
diff changeset
   463
  igvn->remove_dead_node( hook );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   464
489c9b5090e2 Initial load
duke
parents:
diff changeset
   465
  // Must return either the original node (now dead) or a new node
489c9b5090e2 Initial load
duke
parents:
diff changeset
   466
  // (Do not return a top here, since that would break the uniqueness of top.)
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   467
  return new ConINode(TypeInt::ZERO);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   468
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   469
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   470
// if this IfNode follows a range check pattern return the projection
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   471
// for the failed path
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   472
ProjNode* IfNode::range_check_trap_proj(int& flip_test, Node*& l, Node*& r) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   473
  Node* b = in(1);
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   474
  if (b == NULL || !b->is_Bool())  return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   475
  BoolNode* bn = b->as_Bool();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   476
  Node* cmp = bn->in(1);
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   477
  if (cmp == NULL)  return NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   478
  if (cmp->Opcode() != Op_CmpU)  return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   479
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   480
  l = cmp->in(1);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   481
  r = cmp->in(2);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   482
  flip_test = 1;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   483
  if (bn->_test._test == BoolTest::le) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   484
    l = cmp->in(2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   485
    r = cmp->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   486
    flip_test = 2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   487
  } else if (bn->_test._test != BoolTest::lt) {
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   488
    return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   489
  }
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   490
  if (l->is_top())  return NULL;   // Top input means dead test
34180
f0ec91019db2 8042997: Make intrinsic some or all check index/range methods
roland
parents: 34164
diff changeset
   491
  if (r->Opcode() != Op_LoadRange && !is_RangeCheck())  return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   492
489c9b5090e2 Initial load
duke
parents:
diff changeset
   493
  // We have recognized one of these forms:
489c9b5090e2 Initial load
duke
parents:
diff changeset
   494
  //  Flip 1:  If (Bool[<] CmpU(l, LoadRange)) ...
489c9b5090e2 Initial load
duke
parents:
diff changeset
   495
  //  Flip 2:  If (Bool[<=] CmpU(LoadRange, l)) ...
489c9b5090e2 Initial load
duke
parents:
diff changeset
   496
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   497
  ProjNode* iftrap = proj_out(flip_test == 2 ? true : false);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   498
  return iftrap;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   499
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   500
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   501
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   502
//------------------------------is_range_check---------------------------------
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   503
// Return 0 if not a range check.  Return 1 if a range check and set index and
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   504
// offset.  Return 2 if we had to negate the test.  Index is NULL if the check
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   505
// is versus a constant.
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   506
int RangeCheckNode::is_range_check(Node* &range, Node* &index, jint &offset) {
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   507
  int flip_test = 0;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   508
  Node* l = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   509
  Node* r = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   510
  ProjNode* iftrap = range_check_trap_proj(flip_test, l, r);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   511
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   512
  if (iftrap == NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   513
    return 0;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   514
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   515
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   516
  // Make sure it's a real range check by requiring an uncommon trap
489c9b5090e2 Initial load
duke
parents:
diff changeset
   517
  // along the OOB path.  Otherwise, it's possible that the user wrote
489c9b5090e2 Initial load
duke
parents:
diff changeset
   518
  // something which optimized to look like a range check but behaves
489c9b5090e2 Initial load
duke
parents:
diff changeset
   519
  // in some other way.
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   520
  if (iftrap->is_uncommon_trap_proj(Deoptimization::Reason_range_check) == NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   521
    return 0;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   522
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   523
489c9b5090e2 Initial load
duke
parents:
diff changeset
   524
  // Look for index+offset form
489c9b5090e2 Initial load
duke
parents:
diff changeset
   525
  Node* ind = l;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   526
  jint  off = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   527
  if (l->is_top()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   528
    return 0;
26173
4275dfc46177 8054883: Segmentation error while running program
iveresov
parents: 24923
diff changeset
   529
  } else if (l->Opcode() == Op_AddI) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   530
    if ((off = l->in(1)->find_int_con(0)) != 0) {
34180
f0ec91019db2 8042997: Make intrinsic some or all check index/range methods
roland
parents: 34164
diff changeset
   531
      ind = l->in(2)->uncast();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   532
    } else if ((off = l->in(2)->find_int_con(0)) != 0) {
34180
f0ec91019db2 8042997: Make intrinsic some or all check index/range methods
roland
parents: 34164
diff changeset
   533
      ind = l->in(1)->uncast();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   534
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   535
  } else if ((off = l->find_int_con(-1)) >= 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   536
    // constant offset with no variable index
489c9b5090e2 Initial load
duke
parents:
diff changeset
   537
    ind = NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   538
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   539
    // variable index with no constant offset (or dead negative index)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   540
    off = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   541
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   542
489c9b5090e2 Initial load
duke
parents:
diff changeset
   543
  // Return all the values:
489c9b5090e2 Initial load
duke
parents:
diff changeset
   544
  index  = ind;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   545
  offset = off;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   546
  range  = r;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   547
  return flip_test;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   548
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   549
489c9b5090e2 Initial load
duke
parents:
diff changeset
   550
//------------------------------adjust_check-----------------------------------
489c9b5090e2 Initial load
duke
parents:
diff changeset
   551
// Adjust (widen) a prior range check
489c9b5090e2 Initial load
duke
parents:
diff changeset
   552
static void adjust_check(Node* proj, Node* range, Node* index,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   553
                         int flip, jint off_lo, PhaseIterGVN* igvn) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   554
  PhaseGVN *gvn = igvn;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   555
  // Break apart the old check
489c9b5090e2 Initial load
duke
parents:
diff changeset
   556
  Node *iff = proj->in(0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   557
  Node *bol = iff->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   558
  if( bol->is_top() ) return;   // In case a partially dead range check appears
489c9b5090e2 Initial load
duke
parents:
diff changeset
   559
  // bail (or bomb[ASSERT/DEBUG]) if NOT projection-->IfNode-->BoolNode
489c9b5090e2 Initial load
duke
parents:
diff changeset
   560
  DEBUG_ONLY( if( !bol->is_Bool() ) { proj->dump(3); fatal("Expect projection-->IfNode-->BoolNode"); } )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   561
  if( !bol->is_Bool() ) return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   562
489c9b5090e2 Initial load
duke
parents:
diff changeset
   563
  Node *cmp = bol->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   564
  // Compute a new check
489c9b5090e2 Initial load
duke
parents:
diff changeset
   565
  Node *new_add = gvn->intcon(off_lo);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   566
  if( index ) {
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   567
    new_add = off_lo ? gvn->transform(new AddINode( index, new_add )) : index;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   568
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   569
  Node *new_cmp = (flip == 1)
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   570
    ? new CmpUNode( new_add, range )
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   571
    : new CmpUNode( range, new_add );
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   572
  new_cmp = gvn->transform(new_cmp);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   573
  // See if no need to adjust the existing check
489c9b5090e2 Initial load
duke
parents:
diff changeset
   574
  if( new_cmp == cmp ) return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   575
  // Else, adjust existing check
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 24479
diff changeset
   576
  Node *new_bol = gvn->transform( new BoolNode( new_cmp, bol->as_Bool()->_test._test ) );
12958
009b6c9586d8 7173340: C2: code cleanup: use PhaseIterGVN::replace_edge(Node*, int, Node*) where applicable
kvn
parents: 10258
diff changeset
   577
  igvn->rehash_node_delayed( iff );
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   578
  iff->set_req_X( 1, new_bol, igvn );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   579
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   580
489c9b5090e2 Initial load
duke
parents:
diff changeset
   581
//------------------------------up_one_dom-------------------------------------
489c9b5090e2 Initial load
duke
parents:
diff changeset
   582
// Walk up the dominator tree one step.  Return NULL at root or true
489c9b5090e2 Initial load
duke
parents:
diff changeset
   583
// complex merges.  Skips through small diamonds.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   584
Node* IfNode::up_one_dom(Node *curr, bool linear_only) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   585
  Node *dom = curr->in(0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   586
  if( !dom )                    // Found a Region degraded to a copy?
489c9b5090e2 Initial load
duke
parents:
diff changeset
   587
    return curr->nonnull_req(); // Skip thru it
489c9b5090e2 Initial load
duke
parents:
diff changeset
   588
489c9b5090e2 Initial load
duke
parents:
diff changeset
   589
  if( curr != dom )             // Normal walk up one step?
489c9b5090e2 Initial load
duke
parents:
diff changeset
   590
    return dom;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   591
489c9b5090e2 Initial load
duke
parents:
diff changeset
   592
  // Use linear_only if we are still parsing, since we cannot
489c9b5090e2 Initial load
duke
parents:
diff changeset
   593
  // trust the regions to be fully filled in.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   594
  if (linear_only)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   595
    return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   596
4582
1a6662d11385 6915110: IfNode::up_one_dom moves beyond RootNode bug in src/share/vm/opto/ifnode.cpp
kvn
parents: 4020
diff changeset
   597
  if( dom->is_Root() )
1a6662d11385 6915110: IfNode::up_one_dom moves beyond RootNode bug in src/share/vm/opto/ifnode.cpp
kvn
parents: 4020
diff changeset
   598
    return NULL;
1a6662d11385 6915110: IfNode::up_one_dom moves beyond RootNode bug in src/share/vm/opto/ifnode.cpp
kvn
parents: 4020
diff changeset
   599
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   600
  // Else hit a Region.  Check for a loop header
489c9b5090e2 Initial load
duke
parents:
diff changeset
   601
  if( dom->is_Loop() )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   602
    return dom->in(1);          // Skip up thru loops
489c9b5090e2 Initial load
duke
parents:
diff changeset
   603
489c9b5090e2 Initial load
duke
parents:
diff changeset
   604
  // Check for small diamonds
489c9b5090e2 Initial load
duke
parents:
diff changeset
   605
  Node *din1, *din2, *din3, *din4;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   606
  if( dom->req() == 3 &&        // 2-path merge point
489c9b5090e2 Initial load
duke
parents:
diff changeset
   607
      (din1 = dom ->in(1)) &&   // Left  path exists
489c9b5090e2 Initial load
duke
parents:
diff changeset
   608
      (din2 = dom ->in(2)) &&   // Right path exists
489c9b5090e2 Initial load
duke
parents:
diff changeset
   609
      (din3 = din1->in(0)) &&   // Left  path up one
489c9b5090e2 Initial load
duke
parents:
diff changeset
   610
      (din4 = din2->in(0)) ) {  // Right path up one
489c9b5090e2 Initial load
duke
parents:
diff changeset
   611
    if( din3->is_Call() &&      // Handle a slow-path call on either arm
489c9b5090e2 Initial load
duke
parents:
diff changeset
   612
        (din3 = din3->in(0)) )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   613
      din3 = din3->in(0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   614
    if( din4->is_Call() &&      // Handle a slow-path call on either arm
489c9b5090e2 Initial load
duke
parents:
diff changeset
   615
        (din4 = din4->in(0)) )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   616
      din4 = din4->in(0);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   617
    if( din3 == din4 && din3->is_If() )
489c9b5090e2 Initial load
duke
parents:
diff changeset
   618
      return din3;              // Skip around diamonds
489c9b5090e2 Initial load
duke
parents:
diff changeset
   619
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   620
489c9b5090e2 Initial load
duke
parents:
diff changeset
   621
  // Give up the search at true merges
489c9b5090e2 Initial load
duke
parents:
diff changeset
   622
  return NULL;                  // Dead loop?  Or hit root?
489c9b5090e2 Initial load
duke
parents:
diff changeset
   623
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   624
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   625
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   626
//------------------------------filtered_int_type--------------------------------
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   627
// Return a possibly more restrictive type for val based on condition control flow for an if
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   628
const TypeInt* IfNode::filtered_int_type(PhaseGVN* gvn, Node *val, Node* if_proj) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   629
  assert(if_proj &&
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   630
         (if_proj->Opcode() == Op_IfTrue || if_proj->Opcode() == Op_IfFalse), "expecting an if projection");
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   631
  if (if_proj->in(0) && if_proj->in(0)->is_If()) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   632
    IfNode* iff = if_proj->in(0)->as_If();
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   633
    if (iff->in(1) && iff->in(1)->is_Bool()) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   634
      BoolNode* bol = iff->in(1)->as_Bool();
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   635
      if (bol->in(1) && bol->in(1)->is_Cmp()) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   636
        const CmpNode* cmp  = bol->in(1)->as_Cmp();
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   637
        if (cmp->in(1) == val) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   638
          const TypeInt* cmp2_t = gvn->type(cmp->in(2))->isa_int();
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   639
          if (cmp2_t != NULL) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   640
            jint lo = cmp2_t->_lo;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   641
            jint hi = cmp2_t->_hi;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   642
            BoolTest::mask msk = if_proj->Opcode() == Op_IfTrue ? bol->_test._test : bol->_test.negate();
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   643
            switch (msk) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   644
            case BoolTest::ne:
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   645
              // Can't refine type
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   646
              return NULL;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   647
            case BoolTest::eq:
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   648
              return cmp2_t;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   649
            case BoolTest::lt:
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   650
              lo = TypeInt::INT->_lo;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   651
              if (hi - 1 < hi) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   652
                hi = hi - 1;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   653
              }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   654
              break;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   655
            case BoolTest::le:
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   656
              lo = TypeInt::INT->_lo;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   657
              break;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   658
            case BoolTest::gt:
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   659
              if (lo + 1 > lo) {
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   660
                lo = lo + 1;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   661
              }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   662
              hi = TypeInt::INT->_hi;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   663
              break;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   664
            case BoolTest::ge:
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   665
              // lo unchanged
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   666
              hi = TypeInt::INT->_hi;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   667
              break;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   668
            }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   669
            const TypeInt* rtn_t = TypeInt::make(lo, hi, cmp2_t->_widen);
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   670
            return rtn_t;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   671
          }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   672
        }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   673
      }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   674
    }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   675
  }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   676
  return NULL;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   677
}
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   678
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   679
//------------------------------fold_compares----------------------------
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   680
// See if a pair of CmpIs can be converted into a CmpU.  In some cases
2131
98f9cef66a34 6810672: Comment typos
twisti
parents: 1217
diff changeset
   681
// the direction of this if is determined by the preceding if so it
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   682
// can be eliminate entirely.
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   683
//
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   684
// Given an if testing (CmpI n v) check for an immediately control
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   685
// dependent if that is testing (CmpI n v2) and has one projection
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   686
// leading to this if and the other projection leading to a region
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   687
// that merges one of this ifs control projections.
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   688
//
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   689
//                   If
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   690
//                  / |
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   691
//                 /  |
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   692
//                /   |
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   693
//              If    |
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   694
//              /\    |
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   695
//             /  \   |
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   696
//            /    \  |
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   697
//           /    Region
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   698
//
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   699
// Or given an if testing (CmpI n v) check for a dominating if that is
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   700
// testing (CmpI n v2), both having one projection leading to an
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   701
// uncommon trap. Allow Another independent guard in between to cover
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   702
// an explicit range check:
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   703
// if (index < 0 || index >= array.length) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   704
// which may need a null check to guard the LoadRange
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   705
//
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   706
//                   If
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   707
//                  / \
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   708
//                 /   \
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   709
//                /     \
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   710
//              If      unc
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   711
//              /\
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   712
//             /  \
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   713
//            /    \
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   714
//           /      unc
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   715
//
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   716
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   717
// Is the comparison for this If suitable for folding?
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   718
bool IfNode::cmpi_folds(PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   719
  return in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   720
    in(1)->is_Bool() &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   721
    in(1)->in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   722
    in(1)->in(1)->Opcode() == Op_CmpI &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   723
    in(1)->in(1)->in(2) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   724
    in(1)->in(1)->in(2) != igvn->C->top() &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   725
    (in(1)->as_Bool()->_test.is_less() ||
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   726
     in(1)->as_Bool()->_test.is_greater());
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   727
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   728
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   729
// Is a dominating control suitable for folding with this if?
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   730
bool IfNode::is_ctrl_folds(Node* ctrl, PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   731
  return ctrl != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   732
    ctrl->is_Proj() &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   733
    ctrl->in(0) != NULL &&
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   734
    ctrl->in(0)->Opcode() == Op_If &&
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   735
    ctrl->in(0)->outcnt() == 2 &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   736
    ctrl->in(0)->as_If()->cmpi_folds(igvn) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   737
    // Must compare same value
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   738
    ctrl->in(0)->in(1)->in(1)->in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   739
    ctrl->in(0)->in(1)->in(1)->in(1) == in(1)->in(1)->in(1);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   740
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   741
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   742
// Do this If and the dominating If share a region?
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   743
bool IfNode::has_shared_region(ProjNode* proj, ProjNode*& success, ProjNode*& fail) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   744
  ProjNode* otherproj = proj->other_if_proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   745
  Node* otherproj_ctrl_use = otherproj->unique_ctrl_out();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   746
  RegionNode* region = (otherproj_ctrl_use != NULL && otherproj_ctrl_use->is_Region()) ? otherproj_ctrl_use->as_Region() : NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   747
  success = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   748
  fail = NULL;
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   749
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   750
  if (otherproj->outcnt() == 1 && region != NULL && !region->has_phi()) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   751
    for (int i = 0; i < 2; i++) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   752
      ProjNode* proj = proj_out(i);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   753
      if (success == NULL && proj->outcnt() == 1 && proj->unique_out() == region) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   754
        success = proj;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   755
      } else if (fail == NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   756
        fail = proj;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   757
      } else {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   758
        success = fail = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   759
      }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   760
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   761
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   762
  return success != NULL && fail != NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   763
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   764
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   765
// Return projection that leads to an uncommon trap if any
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   766
ProjNode* IfNode::uncommon_trap_proj(CallStaticJavaNode*& call) const {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   767
  for (int i = 0; i < 2; i++) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   768
    call = proj_out(i)->is_uncommon_trap_proj(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   769
    if (call != NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   770
      return proj_out(i);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   771
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   772
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   773
  return NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   774
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   775
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   776
// Do this If and the dominating If both branch out to an uncommon trap
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   777
bool IfNode::has_only_uncommon_traps(ProjNode* proj, ProjNode*& success, ProjNode*& fail, PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   778
  ProjNode* otherproj = proj->other_if_proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   779
  CallStaticJavaNode* dom_unc = otherproj->is_uncommon_trap_proj(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   780
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   781
  if (otherproj->outcnt() == 1 && dom_unc != NULL) {
34151
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   782
    // We need to re-execute the folded Ifs after deoptimization from the merged traps
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   783
    if (!dom_unc->jvms()->should_reexecute()) {
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   784
      return false;
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   785
    }
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   786
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   787
    CallStaticJavaNode* unc = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   788
    ProjNode* unc_proj = uncommon_trap_proj(unc);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   789
    if (unc_proj != NULL && unc_proj->outcnt() == 1) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   790
      if (dom_unc == unc) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   791
        // Allow the uncommon trap to be shared through a region
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   792
        RegionNode* r = unc->in(0)->as_Region();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   793
        if (r->outcnt() != 2 || r->req() != 3 || r->find_edge(otherproj) == -1 || r->find_edge(unc_proj) == -1) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   794
          return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   795
        }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   796
        assert(r->has_phi() == NULL, "simple region shouldn't have a phi");
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   797
      } else if (dom_unc->in(0) != otherproj || unc->in(0) != unc_proj) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   798
        return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   799
      }
34151
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   800
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   801
      // Different methods and methods containing jsrs are not supported.
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   802
      ciMethod* method = unc->jvms()->method();
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   803
      ciMethod* dom_method = dom_unc->jvms()->method();
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   804
      if (method != dom_method || method->has_jsrs()) {
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   805
        return false;
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   806
      }
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   807
      // Check that both traps are in the same activation of the method (instead
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   808
      // of two activations being inlined through different call sites) by verifying
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   809
      // that the call stacks are equal for both JVMStates.
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   810
      JVMState* dom_caller = dom_unc->jvms()->caller();
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   811
      JVMState* caller = unc->jvms()->caller();
34177
e19e45b065c6 8142500: missing null checks in IfNode::has_only_uncommon_traps
thartmann
parents: 34164
diff changeset
   812
      if ((dom_caller == NULL) != (caller == NULL)) {
e19e45b065c6 8142500: missing null checks in IfNode::has_only_uncommon_traps
thartmann
parents: 34164
diff changeset
   813
        // The current method must either be inlined into both dom_caller and
e19e45b065c6 8142500: missing null checks in IfNode::has_only_uncommon_traps
thartmann
parents: 34164
diff changeset
   814
        // caller or must not be inlined at all (top method). Bail out otherwise.
e19e45b065c6 8142500: missing null checks in IfNode::has_only_uncommon_traps
thartmann
parents: 34164
diff changeset
   815
        return false;
e19e45b065c6 8142500: missing null checks in IfNode::has_only_uncommon_traps
thartmann
parents: 34164
diff changeset
   816
      } else if (dom_caller != NULL && !dom_caller->same_calls_as(caller)) {
34151
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   817
        return false;
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   818
      }
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   819
      // Check that the bci of the dominating uncommon trap dominates the bci
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   820
      // of the dominated uncommon trap. Otherwise we may not re-execute
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   821
      // the dominated check after deoptimization from the merged uncommon trap.
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   822
      ciTypeFlow* flow = dom_method->get_flow_analysis();
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   823
      int bci = unc->jvms()->bci();
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   824
      int dom_bci = dom_unc->jvms()->bci();
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   825
      if (!flow->is_dominated_by(bci, dom_bci)) {
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   826
        return false;
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   827
      }
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   828
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   829
      // See merge_uncommon_traps: the reason of the uncommon trap
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   830
      // will be changed and the state of the dominating If will be
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   831
      // used. Checked that we didn't apply this transformation in a
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   832
      // previous compilation and it didn't cause too many traps
34151
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   833
      if (!igvn->C->too_many_traps(dom_method, dom_bci, Deoptimization::Reason_unstable_fused_if) &&
8e0bebdbc29e 8140574: C2 must re-execute checks after deoptimizing from merged uncommon traps
thartmann
parents: 32732
diff changeset
   834
          !igvn->C->too_many_traps(dom_method, dom_bci, Deoptimization::Reason_range_check)) {
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   835
        success = unc_proj;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   836
        fail = unc_proj->other_if_proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   837
        return true;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   838
      }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   839
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   840
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   841
  return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   842
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   843
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   844
// Check that the 2 CmpI can be folded into as single CmpU and proceed with the folding
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   845
bool IfNode::fold_compares_helper(ProjNode* proj, ProjNode* success, ProjNode* fail, PhaseIterGVN* igvn) {
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
   846
  Node* this_cmp = in(1)->in(1);
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   847
  BoolNode* this_bool = in(1)->as_Bool();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   848
  IfNode* dom_iff = proj->in(0)->as_If();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   849
  BoolNode* dom_bool = dom_iff->in(1)->as_Bool();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   850
  Node* lo = dom_iff->in(1)->in(1)->in(2);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   851
  Node* hi = this_cmp->in(2);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   852
  Node* n = this_cmp->in(1);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   853
  ProjNode* otherproj = proj->other_if_proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   854
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   855
  const TypeInt* lo_type = IfNode::filtered_int_type(igvn, n, otherproj);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   856
  const TypeInt* hi_type = IfNode::filtered_int_type(igvn, n, success);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   857
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   858
  BoolTest::mask lo_test = dom_bool->_test._test;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   859
  BoolTest::mask hi_test = this_bool->_test._test;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   860
  BoolTest::mask cond = hi_test;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   861
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   862
  // convert:
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   863
  //
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   864
  //          dom_bool = x {<,<=,>,>=} a
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   865
  //                           / \
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   866
  //     proj = {True,False}  /   \ otherproj = {False,True}
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   867
  //                         /
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   868
  //        this_bool = x {<,<=} b
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   869
  //                       / \
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   870
  //  fail = {True,False} /   \ success = {False,True}
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   871
  //                     /
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   872
  //
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   873
  // (Second test guaranteed canonicalized, first one may not have
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   874
  // been canonicalized yet)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   875
  //
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   876
  // into:
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   877
  //
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   878
  // cond = (x - lo) {<u,<=u,>u,>=u} adjusted_lim
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   879
  //                       / \
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   880
  //                 fail /   \ success
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   881
  //                     /
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   882
  //
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   883
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   884
  // Figure out which of the two tests sets the upper bound and which
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   885
  // sets the lower bound if any.
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   886
  Node* adjusted_lim = NULL;
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   887
  if (hi_type->_lo > lo_type->_hi && hi_type->_hi == max_jint && lo_type->_lo == min_jint) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   888
    assert((dom_bool->_test.is_less() && !proj->_con) ||
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   889
           (dom_bool->_test.is_greater() && proj->_con), "incorrect test");
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   890
    // this test was canonicalized
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   891
    assert(this_bool->_test.is_less() && fail->_con, "incorrect test");
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   892
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   893
    // this_bool = <
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   894
    //   dom_bool = >= (proj = True) or dom_bool = < (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   895
    //     x in [a, b[ on the fail (= True) projection, b > a-1 (because of hi_type->_lo > lo_type->_hi test above):
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   896
    //     lo = a, hi = b, adjusted_lim = b-a, cond = <u
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   897
    //   dom_bool = > (proj = True) or dom_bool = <= (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   898
    //     x in ]a, b[ on the fail (= True) projection, b > a:
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   899
    //     lo = a+1, hi = b, adjusted_lim = b-a-1, cond = <u
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   900
    // this_bool = <=
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   901
    //   dom_bool = >= (proj = True) or dom_bool = < (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   902
    //     x in [a, b] on the fail (= True) projection, b+1 > a-1:
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   903
    //     lo = a, hi = b, adjusted_lim = b-a+1, cond = <u
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   904
    //     lo = a, hi = b, adjusted_lim = b-a, cond = <=u doesn't work because b = a - 1 is possible, then b-a = -1
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   905
    //   dom_bool = > (proj = True) or dom_bool = <= (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   906
    //     x in ]a, b] on the fail (= True) projection b+1 > a:
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   907
    //     lo = a+1, hi = b, adjusted_lim = b-a, cond = <u
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   908
    //     lo = a+1, hi = b, adjusted_lim = b-a-1, cond = <=u doesn't work because a = b is possible, then b-a-1 = -1
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   909
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   910
    if (hi_test == BoolTest::lt) {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   911
      if (lo_test == BoolTest::gt || lo_test == BoolTest::le) {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   912
        lo = igvn->transform(new AddINode(lo, igvn->intcon(1)));
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   913
      }
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   914
    } else {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   915
      assert(hi_test == BoolTest::le, "bad test");
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   916
      if (lo_test == BoolTest::ge || lo_test == BoolTest::lt) {
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   917
        adjusted_lim = igvn->transform(new SubINode(hi, lo));
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   918
        adjusted_lim = igvn->transform(new AddINode(adjusted_lim, igvn->intcon(1)));
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   919
        cond = BoolTest::lt;
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   920
      } else {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   921
        assert(lo_test == BoolTest::gt || lo_test == BoolTest::le, "bad test");
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   922
        adjusted_lim = igvn->transform(new SubINode(hi, lo));
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   923
        lo = igvn->transform(new AddINode(lo, igvn->intcon(1)));
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   924
        cond = BoolTest::lt;
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   925
      }
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   926
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   927
  } else if (lo_type->_lo > hi_type->_hi && lo_type->_hi == max_jint && hi_type->_lo == min_jint) {
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   928
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   929
    // this_bool = <
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   930
    //   dom_bool = < (proj = True) or dom_bool = >= (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   931
    //     x in [b, a[ on the fail (= False) projection, a > b-1 (because of lo_type->_lo > hi_type->_hi above):
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   932
    //     lo = b, hi = a, adjusted_lim = a-b, cond = >=u
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   933
    //   dom_bool = <= (proj = True) or dom_bool = > (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   934
    //     x in [b, a] on the fail (= False) projection, a+1 > b-1:
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   935
    //     lo = b, hi = a, adjusted_lim = a-b+1, cond = >=u
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   936
    //     lo = b, hi = a, adjusted_lim = a-b, cond = >u doesn't work because a = b - 1 is possible, then b-a = -1
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   937
    // this_bool = <=
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   938
    //   dom_bool = < (proj = True) or dom_bool = >= (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   939
    //     x in ]b, a[ on the fail (= False) projection, a > b:
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   940
    //     lo = b+1, hi = a, adjusted_lim = a-b-1, cond = >=u
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   941
    //   dom_bool = <= (proj = True) or dom_bool = > (proj = False)
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   942
    //     x in ]b, a] on the fail (= False) projection, a+1 > b:
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   943
    //     lo = b+1, hi = a, adjusted_lim = a-b, cond = >=u
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   944
    //     lo = b+1, hi = a, adjusted_lim = a-b-1, cond = >u doesn't work because a = b is possible, then b-a-1 = -1
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   945
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   946
    swap(lo, hi);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   947
    swap(lo_type, hi_type);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   948
    swap(lo_test, hi_test);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   949
30631
483c444f36f4 8078436: java/util/stream/boottest/java/util/stream/UnorderedTest.java crashed with an assert in ifnode.cpp
roland
parents: 30629
diff changeset
   950
    assert((dom_bool->_test.is_less() && proj->_con) ||
483c444f36f4 8078436: java/util/stream/boottest/java/util/stream/UnorderedTest.java crashed with an assert in ifnode.cpp
roland
parents: 30629
diff changeset
   951
           (dom_bool->_test.is_greater() && !proj->_con), "incorrect test");
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   952
    // this test was canonicalized
30631
483c444f36f4 8078436: java/util/stream/boottest/java/util/stream/UnorderedTest.java crashed with an assert in ifnode.cpp
roland
parents: 30629
diff changeset
   953
    assert(this_bool->_test.is_less() && !fail->_con, "incorrect test");
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   954
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   955
    cond = (hi_test == BoolTest::le || hi_test == BoolTest::gt) ? BoolTest::gt : BoolTest::ge;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   956
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   957
    if (lo_test == BoolTest::lt) {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   958
      if (hi_test == BoolTest::lt || hi_test == BoolTest::ge) {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   959
        cond = BoolTest::ge;
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   960
      } else {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   961
        assert(hi_test == BoolTest::le || hi_test == BoolTest::gt, "bad test");
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   962
        adjusted_lim = igvn->transform(new SubINode(hi, lo));
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   963
        adjusted_lim = igvn->transform(new AddINode(adjusted_lim, igvn->intcon(1)));
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   964
        cond = BoolTest::ge;
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   965
      }
32732
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   966
    } else if (lo_test == BoolTest::le) {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   967
      if (hi_test == BoolTest::lt || hi_test == BoolTest::ge) {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   968
        lo = igvn->transform(new AddINode(lo, igvn->intcon(1)));
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   969
        cond = BoolTest::ge;
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   970
      } else {
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   971
        assert(hi_test == BoolTest::le || hi_test == BoolTest::gt, "bad test");
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   972
        adjusted_lim = igvn->transform(new SubINode(hi, lo));
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   973
        lo = igvn->transform(new AddINode(lo, igvn->intcon(1)));
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   974
        cond = BoolTest::ge;
9f4cf1523072 8135069: C2 replaces range checks by unsigned comparison with -1
roland
parents: 32084
diff changeset
   975
      }
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   976
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   977
  } else {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   978
    const TypeInt* failtype  = filtered_int_type(igvn, n, proj);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   979
    if (failtype != NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   980
      const TypeInt* type2 = filtered_int_type(igvn, n, fail);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   981
      if (type2 != NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   982
        failtype = failtype->join(type2)->is_int();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   983
        if (failtype->_lo > failtype->_hi) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   984
          // previous if determines the result of this if so
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   985
          // replace Bool with constant
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   986
          igvn->_worklist.push(in(1));
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
   987
          igvn->replace_input_of(this, 1, igvn->intcon(success->_con));
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   988
          return true;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   989
        }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   990
      }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   991
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   992
    lo = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   993
    hi = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   994
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   995
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   996
  if (lo && hi) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   997
    // Merge the two compares into a single unsigned compare by building (CmpU (n - lo) (hi - lo))
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
   998
    Node* adjusted_val = igvn->transform(new SubINode(n,  lo));
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
   999
    if (adjusted_lim == NULL) {
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
  1000
      adjusted_lim = igvn->transform(new SubINode(hi, lo));
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
  1001
    }
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1002
    Node* newcmp = igvn->transform(new CmpUNode(adjusted_val, adjusted_lim));
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1003
    Node* newbool = igvn->transform(new BoolNode(newcmp, cond));
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1004
31132
328ac96a30d6 8081823: C2 performs unsigned comparison against -1
roland
parents: 30631
diff changeset
  1005
    igvn->replace_input_of(dom_iff, 1, igvn->intcon(proj->_con));
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1006
    igvn->_worklist.push(in(1));
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1007
    igvn->replace_input_of(this, 1, newbool);
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1008
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1009
    return true;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1010
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1011
  return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1012
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1013
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1014
// Merge the branches that trap for this If and the dominating If into
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1015
// a single region that branches to the uncommon trap for the
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1016
// dominating If
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1017
Node* IfNode::merge_uncommon_traps(ProjNode* proj, ProjNode* success, ProjNode* fail, PhaseIterGVN* igvn) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1018
  Node* res = this;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1019
  assert(success->in(0) == this, "bad projection");
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1020
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1021
  ProjNode* otherproj = proj->other_if_proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1022
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1023
  CallStaticJavaNode* unc = success->is_uncommon_trap_proj(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1024
  CallStaticJavaNode* dom_unc = otherproj->is_uncommon_trap_proj(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1025
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1026
  if (unc != dom_unc) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1027
    Node* r = new RegionNode(3);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1028
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1029
    r->set_req(1, otherproj);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1030
    r->set_req(2, success);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1031
    r = igvn->transform(r);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1032
    assert(r->is_Region(), "can't go away");
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1033
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1034
    // Make both If trap at the state of the first If: once the CmpI
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1035
    // nodes are merged, if we trap we don't know which of the CmpI
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1036
    // nodes would have caused the trap so we have to restart
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1037
    // execution at the first one
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1038
    igvn->replace_input_of(dom_unc, 0, r);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1039
    igvn->replace_input_of(unc, 0, igvn->C->top());
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1040
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1041
  int trap_request = dom_unc->uncommon_trap_request();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1042
  Deoptimization::DeoptReason reason = Deoptimization::trap_request_reason(trap_request);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1043
  Deoptimization::DeoptAction action = Deoptimization::trap_request_action(trap_request);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1044
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1045
  int flip_test = 0;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1046
  Node* l = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1047
  Node* r = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1048
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1049
  if (success->in(0)->as_If()->range_check_trap_proj(flip_test, l, r) != NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1050
    // If this looks like a range check, change the trap to
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1051
    // Reason_range_check so the compiler recognizes it as a range
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1052
    // check and applies the corresponding optimizations
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1053
    trap_request = Deoptimization::make_trap_request(Deoptimization::Reason_range_check, action);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1054
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1055
    improve_address_types(l, r, fail, igvn);
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1056
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1057
    res = igvn->transform(new RangeCheckNode(in(0), in(1), _prob, _fcnt));
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1058
  } else if (unc != dom_unc) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1059
    // If we trap we won't know what CmpI would have caused the trap
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1060
    // so use a special trap reason to mark this pair of CmpI nodes as
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1061
    // bad candidate for folding. On recompilation we won't fold them
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1062
    // and we may trap again but this time we'll know what branch
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1063
    // traps
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1064
    trap_request = Deoptimization::make_trap_request(Deoptimization::Reason_unstable_fused_if, action);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1065
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1066
  igvn->replace_input_of(dom_unc, TypeFunc::Parms, igvn->intcon(trap_request));
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1067
  return res;
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1068
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1069
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1070
// If we are turning 2 CmpI nodes into a CmpU that follows the pattern
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1071
// of a rangecheck on index i, on 64 bit the compares may be followed
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1072
// by memory accesses using i as index. In that case, the CmpU tells
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1073
// us something about the values taken by i that can help the compiler
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1074
// (see Compile::conv_I2X_index())
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1075
void IfNode::improve_address_types(Node* l, Node* r, ProjNode* fail, PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1076
#ifdef _LP64
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1077
  ResourceMark rm;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1078
  Node_Stack stack(2);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1079
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1080
  assert(r->Opcode() == Op_LoadRange, "unexpected range check");
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1081
  const TypeInt* array_size = igvn->type(r)->is_int();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1082
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1083
  stack.push(l, 0);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1084
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1085
  while(stack.size() > 0) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1086
    Node* n = stack.node();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1087
    uint start = stack.index();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1088
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1089
    uint i = start;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1090
    for (; i < n->outcnt(); i++) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1091
      Node* use = n->raw_out(i);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1092
      if (stack.size() == 1) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1093
        if (use->Opcode() == Op_ConvI2L) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1094
          const TypeLong* bounds = use->as_Type()->type()->is_long();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1095
          if (bounds->_lo <= array_size->_lo && bounds->_hi >= array_size->_hi &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1096
              (bounds->_lo != array_size->_lo || bounds->_hi != array_size->_hi)) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1097
            stack.set_index(i+1);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1098
            stack.push(use, 0);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1099
            break;
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1100
          }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1101
        }
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1102
      } else if (use->is_Mem()) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1103
        Node* ctrl = use->in(0);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1104
        for (int i = 0; i < 10 && ctrl != NULL && ctrl != fail; i++) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1105
          ctrl = up_one_dom(ctrl);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1106
        }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1107
        if (ctrl == fail) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1108
          Node* init_n = stack.node_at(1);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1109
          assert(init_n->Opcode() == Op_ConvI2L, "unexpected first node");
35574
2b25eb88c8d6 6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents: 35552
diff changeset
  1110
          // Create a new narrow ConvI2L node that is dependent on the range check
2b25eb88c8d6 6675699: need comprehensive fix for unconstrained ConvI2L with narrowed type
thartmann
parents: 35552
diff changeset
  1111
          Node* new_n = igvn->C->conv_I2X_index(igvn, l, array_size, fail);
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1112
30629
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1113
          // The type of the ConvI2L may be widen and so the new
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1114
          // ConvI2L may not be better than an existing ConvI2L
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1115
          if (new_n != init_n) {
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1116
            for (uint j = 2; j < stack.size(); j++) {
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1117
              Node* n = stack.node_at(j);
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1118
              Node* clone = n->clone();
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1119
              int rep = clone->replace_edge(init_n, new_n);
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1120
              assert(rep > 0, "can't find expected node?");
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1121
              clone = igvn->transform(clone);
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1122
              init_n = n;
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1123
              new_n = clone;
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1124
            }
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1125
            igvn->hash_delete(use);
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1126
            int rep = use->replace_edge(init_n, new_n);
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1127
            assert(rep > 0, "can't find expected node?");
30629
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1128
            igvn->transform(use);
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1129
            if (init_n->outcnt() == 0) {
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1130
              igvn->_worklist.push(init_n);
b6e5ad2f18d5 8076188: Optimize arraycopy out for non escaping destination
roland
parents: 30309
diff changeset
  1131
            }
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1132
          }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1133
        }
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1134
      } else if (use->in(0) == NULL && (igvn->type(use)->isa_long() ||
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1135
                                        igvn->type(use)->isa_ptr())) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1136
        stack.set_index(i+1);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1137
        stack.push(use, 0);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1138
        break;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1139
      }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1140
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1141
    if (i == n->outcnt()) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1142
      stack.pop();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1143
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1144
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1145
#endif
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1146
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1147
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1148
bool IfNode::is_cmp_with_loadrange(ProjNode* proj) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1149
  if (in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1150
      in(1)->in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1151
      in(1)->in(1)->in(2) != NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1152
    Node* other = in(1)->in(1)->in(2);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1153
    if (other->Opcode() == Op_LoadRange &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1154
        ((other->in(0) != NULL && other->in(0) == proj) ||
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1155
         (other->in(0) == NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1156
          other->in(2) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1157
          other->in(2)->is_AddP() &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1158
          other->in(2)->in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1159
          other->in(2)->in(1)->Opcode() == Op_CastPP &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1160
          other->in(2)->in(1)->in(0) == proj))) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1161
      return true;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1162
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1163
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1164
  return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1165
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1166
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1167
bool IfNode::is_null_check(ProjNode* proj, PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1168
  Node* other = in(1)->in(1)->in(2);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1169
  if (other->in(MemNode::Address) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1170
      proj->in(0)->in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1171
      proj->in(0)->in(1)->is_Bool() &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1172
      proj->in(0)->in(1)->in(1) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1173
      proj->in(0)->in(1)->in(1)->Opcode() == Op_CmpP &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1174
      proj->in(0)->in(1)->in(1)->in(2) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1175
      proj->in(0)->in(1)->in(1)->in(1) == other->in(MemNode::Address)->in(AddPNode::Address)->uncast() &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1176
      igvn->type(proj->in(0)->in(1)->in(1)->in(2)) == TypePtr::NULL_PTR) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1177
    return true;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1178
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1179
  return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1180
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1181
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1182
// Check that the If that is in between the 2 integer comparisons has
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1183
// no side effect
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1184
bool IfNode::is_side_effect_free_test(ProjNode* proj, PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1185
  if (proj != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1186
      proj->is_uncommon_trap_if_pattern(Deoptimization::Reason_none) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1187
      proj->outcnt() <= 2) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1188
    if (proj->outcnt() == 1 ||
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1189
        // Allow simple null check from LoadRange
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1190
        (is_cmp_with_loadrange(proj) && is_null_check(proj, igvn))) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1191
      CallStaticJavaNode* unc = proj->is_uncommon_trap_if_pattern(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1192
      CallStaticJavaNode* dom_unc = proj->in(0)->in(0)->as_Proj()->is_uncommon_trap_if_pattern(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1193
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1194
      // reroute_side_effect_free_unc changes the state of this
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1195
      // uncommon trap to restart execution at the previous
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1196
      // CmpI. Check that this change in a previous compilation didn't
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1197
      // cause too many traps.
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1198
      int trap_request = unc->uncommon_trap_request();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1199
      Deoptimization::DeoptReason reason = Deoptimization::trap_request_reason(trap_request);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1200
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1201
      if (igvn->C->too_many_traps(dom_unc->jvms()->method(), dom_unc->jvms()->bci(), reason)) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1202
        return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1203
      }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1204
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1205
      return true;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1206
    }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1207
  }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1208
  return false;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1209
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1210
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1211
// Make the If between the 2 integer comparisons trap at the state of
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1212
// the first If: the last CmpI is the one replaced by a CmpU and the
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1213
// first CmpI is eliminated, so the test between the 2 CmpI nodes
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1214
// won't be guarded by the first CmpI anymore. It can trap in cases
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1215
// where the first CmpI would have prevented it from executing: on a
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1216
// trap, we need to restart execution at the state of the first CmpI
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1217
void IfNode::reroute_side_effect_free_unc(ProjNode* proj, ProjNode* dom_proj, PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1218
  CallStaticJavaNode* dom_unc = dom_proj->is_uncommon_trap_if_pattern(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1219
  ProjNode* otherproj = proj->other_if_proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1220
  CallStaticJavaNode* unc = proj->is_uncommon_trap_if_pattern(Deoptimization::Reason_none);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1221
  Node* call_proj = dom_unc->unique_ctrl_out();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1222
  Node* halt = call_proj->unique_ctrl_out();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1223
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1224
  Node* new_unc = dom_unc->clone();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1225
  call_proj = call_proj->clone();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1226
  halt = halt->clone();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1227
  Node* c = otherproj->clone();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1228
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1229
  c = igvn->transform(c);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1230
  new_unc->set_req(TypeFunc::Parms, unc->in(TypeFunc::Parms));
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1231
  new_unc->set_req(0, c);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1232
  new_unc = igvn->transform(new_unc);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1233
  call_proj->set_req(0, new_unc);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1234
  call_proj = igvn->transform(call_proj);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1235
  halt->set_req(0, call_proj);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1236
  halt = igvn->transform(halt);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1237
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1238
  igvn->replace_node(otherproj, igvn->C->top());
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1239
  igvn->C->root()->add_req(halt);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1240
}
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1241
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1242
Node* IfNode::fold_compares(PhaseIterGVN* igvn) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1243
  if (Opcode() != Op_If) return NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1244
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1245
  if (cmpi_folds(igvn)) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1246
    Node* ctrl = in(0);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1247
    if (is_ctrl_folds(ctrl, igvn) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1248
        ctrl->outcnt() == 1) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1249
      // A integer comparison immediately dominated by another integer
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1250
      // comparison
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1251
      ProjNode* success = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1252
      ProjNode* fail = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1253
      ProjNode* dom_cmp = ctrl->as_Proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1254
      if (has_shared_region(dom_cmp, success, fail) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1255
          // Next call modifies graph so must be last
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1256
          fold_compares_helper(dom_cmp, success, fail, igvn)) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1257
        return this;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1258
      }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1259
      if (has_only_uncommon_traps(dom_cmp, success, fail, igvn) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1260
          // Next call modifies graph so must be last
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1261
          fold_compares_helper(dom_cmp, success, fail, igvn)) {
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1262
        return merge_uncommon_traps(dom_cmp, success, fail, igvn);
30183
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1263
      }
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1264
      return NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1265
    } else if (ctrl->in(0) != NULL &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1266
               ctrl->in(0)->in(0) != NULL) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1267
      ProjNode* success = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1268
      ProjNode* fail = NULL;
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1269
      Node* dom = ctrl->in(0)->in(0);
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1270
      ProjNode* dom_cmp = dom->isa_Proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1271
      ProjNode* other_cmp = ctrl->isa_Proj();
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1272
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1273
      // Check if it's an integer comparison dominated by another
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1274
      // integer comparison with another test in between
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1275
      if (is_ctrl_folds(dom, igvn) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1276
          has_only_uncommon_traps(dom_cmp, success, fail, igvn) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1277
          is_side_effect_free_test(other_cmp, igvn) &&
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1278
          // Next call modifies graph so must be last
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1279
          fold_compares_helper(dom_cmp, success, fail, igvn)) {
a6588c0a3259 8073480: C2 should optimize explicit range checks
roland
parents: 28927
diff changeset
  1280
        reroute_side_effect_free_unc(other_cmp, dom_cmp, igvn);
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1281
        return merge_uncommon_traps(dom_cmp, success, fail, igvn);
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1282
      }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1283
    }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1284
  }
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1285
  return NULL;
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1286
}
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1287
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1288
//------------------------------remove_useless_bool----------------------------
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1289
// Check for people making a useless boolean: things like
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1290
// if( (x < y ? true : false) ) { ... }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1291
// Replace with if( x < y ) { ... }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1292
static Node *remove_useless_bool(IfNode *iff, PhaseGVN *phase) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1293
  Node *i1 = iff->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1294
  if( !i1->is_Bool() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1295
  BoolNode *bol = i1->as_Bool();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1296
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1297
  Node *cmp = bol->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1298
  if( cmp->Opcode() != Op_CmpI ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1299
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1300
  // Must be comparing against a bool
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1301
  const Type *cmp2_t = phase->type( cmp->in(2) );
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1302
  if( cmp2_t != TypeInt::ZERO &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1303
      cmp2_t != TypeInt::ONE )
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1304
    return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1305
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1306
  // Find a prior merge point merging the boolean
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1307
  i1 = cmp->in(1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1308
  if( !i1->is_Phi() ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1309
  PhiNode *phi = i1->as_Phi();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1310
  if( phase->type( phi ) != TypeInt::BOOL )
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1311
    return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1312
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1313
  // Check for diamond pattern
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1314
  int true_path = phi->is_diamond_phi();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1315
  if( true_path == 0 ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1316
958
4c4709e8b7ee 6712835: Server compiler fails with assertion (loop_count < K,"infinite loop in PhaseIterGVN::transform")
never
parents: 190
diff changeset
  1317
  // Make sure that iff and the control of the phi are different. This
4c4709e8b7ee 6712835: Server compiler fails with assertion (loop_count < K,"infinite loop in PhaseIterGVN::transform")
never
parents: 190
diff changeset
  1318
  // should really only happen for dead control flow since it requires
4c4709e8b7ee 6712835: Server compiler fails with assertion (loop_count < K,"infinite loop in PhaseIterGVN::transform")
never
parents: 190
diff changeset
  1319
  // an illegal cycle.
4c4709e8b7ee 6712835: Server compiler fails with assertion (loop_count < K,"infinite loop in PhaseIterGVN::transform")
never
parents: 190
diff changeset
  1320
  if (phi->in(0)->in(1)->in(0) == iff) return NULL;
4c4709e8b7ee 6712835: Server compiler fails with assertion (loop_count < K,"infinite loop in PhaseIterGVN::transform")
never
parents: 190
diff changeset
  1321
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1322
  // phi->region->if_proj->ifnode->bool->cmp
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1323
  BoolNode *bol2 = phi->in(0)->in(1)->in(0)->in(1)->as_Bool();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1324
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1325
  // Now get the 'sense' of the test correct so we can plug in
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1326
  // either iff2->in(1) or its complement.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1327
  int flip = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1328
  if( bol->_test._test == BoolTest::ne ) flip = 1-flip;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1329
  else if( bol->_test._test != BoolTest::eq ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1330
  if( cmp2_t == TypeInt::ZERO ) flip = 1-flip;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1331
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1332
  const Type *phi1_t = phase->type( phi->in(1) );
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1333
  const Type *phi2_t = phase->type( phi->in(2) );
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1334
  // Check for Phi(0,1) and flip
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1335
  if( phi1_t == TypeInt::ZERO ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1336
    if( phi2_t != TypeInt::ONE ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1337
    flip = 1-flip;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1338
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1339
    // Check for Phi(1,0)
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1340
    if( phi1_t != TypeInt::ONE  ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1341
    if( phi2_t != TypeInt::ZERO ) return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1342
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1343
  if( true_path == 2 ) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1344
    flip = 1-flip;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1345
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1346
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1347
  Node* new_bol = (flip ? phase->transform( bol2->negate(phase) ) : bol2);
958
4c4709e8b7ee 6712835: Server compiler fails with assertion (loop_count < K,"infinite loop in PhaseIterGVN::transform")
never
parents: 190
diff changeset
  1348
  assert(new_bol != iff->in(1), "must make progress");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1349
  iff->set_req(1, new_bol);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1350
  // Intervening diamond probably goes dead
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1351
  phase->C->set_major_progress();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1352
  return iff;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1353
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1354
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1355
static IfNode* idealize_test(PhaseGVN* phase, IfNode* iff);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1356
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1357
struct RangeCheck {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1358
  Node* ctl;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1359
  jint off;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1360
};
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1361
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1362
Node* IfNode::Ideal_common(PhaseGVN *phase, bool can_reshape) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1363
  if (remove_dead_region(phase, can_reshape))  return this;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1364
  // No Def-Use info?
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1365
  if (!can_reshape)  return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1366
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1367
  // Don't bother trying to transform a dead if
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1368
  if (in(0)->is_top())  return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1369
  // Don't bother trying to transform an if with a dead test
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1370
  if (in(1)->is_top())  return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1371
  // Another variation of a dead test
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1372
  if (in(1)->is_Con())  return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1373
  // Another variation of a dead if
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1374
  if (outcnt() < 2)  return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1375
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1376
  // Canonicalize the test.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1377
  Node* idt_if = idealize_test(phase, this);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1378
  if (idt_if != NULL)  return idt_if;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1379
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1380
  // Try to split the IF
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1381
  PhaseIterGVN *igvn = phase->is_IterGVN();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1382
  Node *s = split_if(this, igvn);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1383
  if (s != NULL)  return s;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1384
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1385
  return NodeSentinel;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1386
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1387
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1388
//------------------------------Ideal------------------------------------------
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1389
// Return a node which is more "ideal" than the current node.  Strip out
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1390
// control copies
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1391
Node* IfNode::Ideal(PhaseGVN *phase, bool can_reshape) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1392
  Node* res = Ideal_common(phase, can_reshape);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1393
  if (res != NodeSentinel) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1394
    return res;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1395
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1396
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1397
  // Check for people making a useless boolean: things like
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1398
  // if( (x < y ? true : false) ) { ... }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1399
  // Replace with if( x < y ) { ... }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1400
  Node *bol2 = remove_useless_bool(this, phase);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1401
  if( bol2 ) return bol2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1402
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1403
  if (in(0) == NULL) return NULL;     // Dead loop?
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1404
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1405
  PhaseIterGVN *igvn = phase->is_IterGVN();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1406
  Node* result = fold_compares(igvn);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1407
  if (result != NULL) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1408
    return result;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1409
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1410
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1411
  // Scan for an equivalent test
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1412
  Node *cmp;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1413
  int dist = 0;               // Cutoff limit for search
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1414
  int op = Opcode();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1415
  if( op == Op_If &&
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1416
      (cmp=in(1)->in(1))->Opcode() == Op_CmpP ) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1417
    if( cmp->in(2) != NULL && // make sure cmp is not already dead
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1418
        cmp->in(2)->bottom_type() == TypePtr::NULL_PTR ) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1419
      dist = 64;              // Limit for null-pointer scans
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1420
    } else {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1421
      dist = 4;               // Do not bother for random pointer tests
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1422
    }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1423
  } else {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1424
    dist = 4;                 // Limit for random junky scans
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1425
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1426
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1427
  Node* prev_dom = search_identical(dist);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1428
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1429
  if (prev_dom == NULL) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1430
    return NULL;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1431
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1432
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1433
  // Replace dominated IfNode
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1434
  return dominated_by(prev_dom, igvn);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1435
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1436
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1437
//------------------------------dominated_by-----------------------------------
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1438
Node* IfNode::dominated_by(Node* prev_dom, PhaseIterGVN *igvn) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1439
#ifndef PRODUCT
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1440
  if (TraceIterativeGVN) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1441
    tty->print("   Removing IfNode: "); this->dump();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1442
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1443
  if (VerifyOpto && !igvn->allow_progress()) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1444
    // Found an equivalent dominating test,
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1445
    // we can not guarantee reaching a fix-point for these during iterativeGVN
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1446
    // since intervening nodes may not change.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1447
    return NULL;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1448
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1449
#endif
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1450
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1451
  igvn->hash_delete(this);      // Remove self to prevent spurious V-N
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1452
  Node *idom = in(0);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1453
  // Need opcode to decide which way 'this' test goes
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1454
  int prev_op = prev_dom->Opcode();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1455
  Node *top = igvn->C->top(); // Shortcut to top
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1456
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1457
  // Loop predicates may have depending checks which should not
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1458
  // be skipped. For example, range check predicate has two checks
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1459
  // for lower and upper bounds.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1460
  ProjNode* unc_proj = proj_out(1 - prev_dom->as_Proj()->_con)->as_Proj();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1461
  if (unc_proj->is_uncommon_trap_proj(Deoptimization::Reason_predicate) != NULL)
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1462
   prev_dom = idom;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1463
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1464
  // Now walk the current IfNode's projections.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1465
  // Loop ends when 'this' has no more uses.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1466
  for (DUIterator_Last imin, i = last_outs(imin); i >= imin; --i) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1467
    Node *ifp = last_out(i);     // Get IfTrue/IfFalse
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1468
    igvn->add_users_to_worklist(ifp);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1469
    // Check which projection it is and set target.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1470
    // Data-target is either the dominating projection of the same type
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1471
    // or TOP if the dominating projection is of opposite type.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1472
    // Data-target will be used as the new control edge for the non-CFG
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1473
    // nodes like Casts and Loads.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1474
    Node *data_target = (ifp->Opcode() == prev_op) ? prev_dom : top;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1475
    // Control-target is just the If's immediate dominator or TOP.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1476
    Node *ctrl_target = (ifp->Opcode() == prev_op) ?     idom : top;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1477
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1478
    // For each child of an IfTrue/IfFalse projection, reroute.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1479
    // Loop ends when projection has no more uses.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1480
    for (DUIterator_Last jmin, j = ifp->last_outs(jmin); j >= jmin; --j) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1481
      Node* s = ifp->last_out(j);   // Get child of IfTrue/IfFalse
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1482
      if( !s->depends_only_on_test() ) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1483
        // Find the control input matching this def-use edge.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1484
        // For Regions it may not be in slot 0.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1485
        uint l;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1486
        for( l = 0; s->in(l) != ifp; l++ ) { }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1487
        igvn->replace_input_of(s, l, ctrl_target);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1488
      } else {                      // Else, for control producers,
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1489
        igvn->replace_input_of(s, 0, data_target); // Move child to data-target
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1490
      }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1491
    } // End for each child of a projection
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1492
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1493
    igvn->remove_dead_node(ifp);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1494
  } // End for each IfTrue/IfFalse child of If
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1495
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1496
  // Kill the IfNode
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1497
  igvn->remove_dead_node(this);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1498
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1499
  // Must return either the original node (now dead) or a new node
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1500
  // (Do not return a top here, since that would break the uniqueness of top.)
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1501
  return new ConINode(TypeInt::ZERO);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1502
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1503
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1504
Node* IfNode::search_identical(int dist) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1505
  // Setup to scan up the CFG looking for a dominating test
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1506
  Node* dom = in(0);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1507
  Node* prev_dom = this;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1508
  int op = Opcode();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1509
  // Search up the dominator tree for an If with an identical test
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1510
  while (dom->Opcode() != op    ||  // Not same opcode?
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1511
         dom->in(1)    != in(1) ||  // Not same input 1?
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1512
         (req() == 3 && dom->in(2) != in(2)) || // Not same input 2?
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1513
         prev_dom->in(0) != dom) {  // One path of test does not dominate?
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1514
    if (dist < 0) return NULL;
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1515
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1516
    dist--;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1517
    prev_dom = dom;
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1518
    dom = up_one_dom(dom);
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1519
    if (!dom) return NULL;
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1520
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1521
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1522
  // Check that we did not follow a loop back to ourselves
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1523
  if (this == dom) {
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1524
    return NULL;
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1525
  }
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1526
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1527
#ifndef PRODUCT
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1528
  if (dist > 2) { // Add to count of NULL checks elided
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1529
    explicit_null_checks_elided++;
36336
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1530
  }
7006dd73b206 8150720: Cleanup code around PrintOptoStatistics
redestad
parents: 35574
diff changeset
  1531
#endif
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1532
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1533
  return prev_dom;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1534
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1535
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1536
//------------------------------Identity---------------------------------------
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1537
// If the test is constant & we match, then we are the input Control
35551
36ef3841fb34 8146629: Make phase->is_IterGVN() accessible from Node::Identity and Node::Value
thartmann
parents: 34181
diff changeset
  1538
Node* IfProjNode::Identity(PhaseGVN* phase) {
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1539
  // Can only optimize if cannot go the other way
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1540
  const TypeTuple *t = phase->type(in(0))->is_tuple();
35552
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1541
  if (t == TypeTuple::IFNEITHER || (always_taken(t) &&
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1542
       // During parsing (GVN) we don't remove dead code aggressively.
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1543
       // Cut off dead branch and let PhaseRemoveUseless take care of it.
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1544
      (!phase->is_IterGVN() ||
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1545
       // During IGVN, first wait for the dead branch to be killed.
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1546
       // Otherwise, the IfNode's control will have two control uses (the IfNode
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1547
       // that doesn't go away because it still has uses and this branch of the
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1548
       // If) which breaks other optimizations. Node::has_special_unique_user()
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1549
       // will cause this node to be reprocessed once the dead branch is killed.
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 35551
diff changeset
  1550
       in(0)->outcnt() == 1))) {
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1551
    // IfNode control
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1552
    return in(0)->in(0);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1553
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1554
  // no progress
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1555
  return this;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1556
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1557
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1558
#ifndef PRODUCT
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1559
//-------------------------------related---------------------------------------
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1560
// An IfProjNode's related node set consists of its input (an IfNode) including
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1561
// the IfNode's condition, plus all of its outputs at level 1. In compact mode,
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1562
// the restrictions for IfNode apply (see IfNode::rel).
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1563
void IfProjNode::related(GrowableArray<Node*> *in_rel, GrowableArray<Node*> *out_rel, bool compact) const {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1564
  Node* ifNode = this->in(0);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1565
  in_rel->append(ifNode);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1566
  if (compact) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1567
    ifNode->collect_nodes(in_rel, 3, false, true);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1568
  } else {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1569
    ifNode->collect_nodes_in_all_data(in_rel, false);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1570
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1571
  this->collect_nodes(out_rel, -1, false, false);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1572
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1573
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1574
//------------------------------dump_spec--------------------------------------
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1575
void IfNode::dump_spec(outputStream *st) const {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1576
  st->print("P=%f, C=%f",_prob,_fcnt);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1577
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1578
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1579
//-------------------------------related---------------------------------------
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1580
// For an IfNode, the set of related output nodes is just the output nodes till
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1581
// depth 2, i.e, the IfTrue/IfFalse projection nodes plus the nodes they refer.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1582
// The related input nodes contain no control nodes, but all data nodes
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1583
// pertaining to the condition. In compact mode, the input nodes are collected
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1584
// up to a depth of 3.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1585
void IfNode::related(GrowableArray <Node *> *in_rel, GrowableArray <Node *> *out_rel, bool compact) const {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1586
  if (compact) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1587
    this->collect_nodes(in_rel, 3, false, true);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1588
  } else {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1589
    this->collect_nodes_in_all_data(in_rel, false);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1590
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1591
  this->collect_nodes(out_rel, -2, false, false);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1592
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1593
#endif
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1594
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1595
//------------------------------idealize_test----------------------------------
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1596
// Try to canonicalize tests better.  Peek at the Cmp/Bool/If sequence and
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1597
// come up with a canonical sequence.  Bools getting 'eq', 'gt' and 'ge' forms
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1598
// converted to 'ne', 'le' and 'lt' forms.  IfTrue/IfFalse get swapped as
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1599
// needed.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1600
static IfNode* idealize_test(PhaseGVN* phase, IfNode* iff) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1601
  assert(iff->in(0) != NULL, "If must be live");
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1602
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1603
  if (iff->outcnt() != 2)  return NULL; // Malformed projections.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1604
  Node* old_if_f = iff->proj_out(false);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1605
  Node* old_if_t = iff->proj_out(true);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1606
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1607
  // CountedLoopEnds want the back-control test to be TRUE, irregardless of
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1608
  // whether they are testing a 'gt' or 'lt' condition.  The 'gt' condition
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1609
  // happens in count-down loops
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1610
  if (iff->is_CountedLoopEnd())  return NULL;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1611
  if (!iff->in(1)->is_Bool())  return NULL; // Happens for partially optimized IF tests
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1612
  BoolNode *b = iff->in(1)->as_Bool();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1613
  BoolTest bt = b->_test;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1614
  // Test already in good order?
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1615
  if( bt.is_canonical() )
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1616
    return NULL;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1617
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1618
  // Flip test to be canonical.  Requires flipping the IfFalse/IfTrue and
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1619
  // cloning the IfNode.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1620
  Node* new_b = phase->transform( new BoolNode(b->in(1), bt.negate()) );
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1621
  if( !new_b->is_Bool() ) return NULL;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1622
  b = new_b->as_Bool();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1623
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1624
  PhaseIterGVN *igvn = phase->is_IterGVN();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1625
  assert( igvn, "Test is not canonical in parser?" );
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1626
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1627
  // The IF node never really changes, but it needs to be cloned
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1628
  iff = iff->clone()->as_If();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1629
  iff->set_req(1, b);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1630
  iff->_prob = 1.0-iff->_prob;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1631
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1632
  Node *prior = igvn->hash_find_insert(iff);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1633
  if( prior ) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1634
    igvn->remove_dead_node(iff);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1635
    iff = (IfNode*)prior;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1636
  } else {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1637
    // Cannot call transform on it just yet
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1638
    igvn->set_type_bottom(iff);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1639
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1640
  igvn->_worklist.push(iff);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1641
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1642
  // Now handle projections.  Cloning not required.
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1643
  Node* new_if_f = (Node*)(new IfFalseNode( iff ));
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1644
  Node* new_if_t = (Node*)(new IfTrueNode ( iff ));
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1645
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1646
  igvn->register_new_node_with_optimizer(new_if_f);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1647
  igvn->register_new_node_with_optimizer(new_if_t);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1648
  // Flip test, so flip trailing control
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1649
  igvn->replace_node(old_if_f, new_if_t);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1650
  igvn->replace_node(old_if_t, new_if_f);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1651
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1652
  // Progress
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1653
  return iff;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1654
}
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1655
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1656
Node* RangeCheckNode::Ideal(PhaseGVN *phase, bool can_reshape) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1657
  Node* res = Ideal_common(phase, can_reshape);
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1658
  if (res != NodeSentinel) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1659
    return res;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1660
  }
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1661
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1662
  PhaseIterGVN *igvn = phase->is_IterGVN();
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1663
  // Setup to scan up the CFG looking for a dominating test
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1664
  Node* prev_dom = this;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1665
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1666
  // Check for range-check vs other kinds of tests
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1667
  Node* index1;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1668
  Node* range1;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1669
  jint offset1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1670
  int flip1 = is_range_check(range1, index1, offset1);
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1671
  if (flip1) {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1672
    Node* dom = in(0);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1673
    // Try to remove extra range checks.  All 'up_one_dom' gives up at merges
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1674
    // so all checks we inspect post-dominate the top-most check we find.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1675
    // If we are going to fail the current check and we reach the top check
2131
98f9cef66a34 6810672: Comment typos
twisti
parents: 1217
diff changeset
  1676
    // then we are guaranteed to fail, so just start interpreting there.
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1677
    // We 'expand' the top 3 range checks to include all post-dominating
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1678
    // checks.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1679
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1680
    // The top 3 range checks seen
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1681
    const int NRC =3;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1682
    RangeCheck prev_checks[NRC];
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1683
    int nb_checks = 0;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1684
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1685
    // Low and high offsets seen so far
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1686
    jint off_lo = offset1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1687
    jint off_hi = offset1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1688
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1689
    bool found_immediate_dominator = false;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1690
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1691
    // Scan for the top checks and collect range of offsets
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1692
    for (int dist = 0; dist < 999; dist++) { // Range-Check scan limit
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1693
      if (dom->Opcode() == Op_RangeCheck &&  // Not same opcode?
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1694
          prev_dom->in(0) == dom) { // One path of test does dominate?
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1695
        if (dom == this) return NULL; // dead loop
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1696
        // See if this is a range check
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1697
        Node* index2;
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1698
        Node* range2;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1699
        jint offset2;
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1700
        int flip2 = dom->as_RangeCheck()->is_range_check(range2, index2, offset2);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1701
        // See if this is a _matching_ range check, checking against
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1702
        // the same array bounds.
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1703
        if (flip2 == flip1 && range2 == range1 && index2 == index1 &&
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1704
            dom->outcnt() == 2) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1705
          if (nb_checks == 0 && dom->in(1) == in(1)) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1706
            // Found an immediately dominating test at the same offset.
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1707
            // This kind of back-to-back test can be eliminated locally,
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1708
            // and there is no need to search further for dominating tests.
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1709
            assert(offset2 == offset1, "Same test but different offsets");
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1710
            found_immediate_dominator = true;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1711
            break;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1712
          }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1713
          // Gather expanded bounds
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1714
          off_lo = MIN2(off_lo,offset2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1715
          off_hi = MAX2(off_hi,offset2);
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1716
          // Record top NRC range checks
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1717
          prev_checks[nb_checks%NRC].ctl = prev_dom;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1718
          prev_checks[nb_checks%NRC].off = offset2;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1719
          nb_checks++;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1720
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1721
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1722
      prev_dom = dom;
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1723
      dom = up_one_dom(dom);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1724
      if (!dom) break;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1725
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1726
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1727
    if (!found_immediate_dominator) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1728
      // Attempt to widen the dominating range check to cover some later
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1729
      // ones.  Since range checks "fail" by uncommon-trapping to the
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1730
      // interpreter, widening a check can make us speculatively enter
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1731
      // the interpreter.  If we see range-check deopt's, do not widen!
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1732
      if (!phase->C->allow_range_check_smearing())  return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1733
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1734
      // Didn't find prior covering check, so cannot remove anything.
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1735
      if (nb_checks == 0) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1736
        return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1737
      }
28044
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1738
      // Constant indices only need to check the upper bound.
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1739
      // Non-constant indices must check both low and high.
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1740
      int chk0 = (nb_checks - 1) % NRC;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1741
      if (index1) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1742
        if (nb_checks == 1) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1743
          return NULL;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1744
        } else {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1745
          // If the top range check's constant is the min or max of
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1746
          // all constants we widen the next one to cover the whole
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1747
          // range of constants.
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1748
          RangeCheck rc0 = prev_checks[chk0];
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1749
          int chk1 = (nb_checks - 2) % NRC;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1750
          RangeCheck rc1 = prev_checks[chk1];
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1751
          if (rc0.off == off_lo) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1752
            adjust_check(rc1.ctl, range1, index1, flip1, off_hi, igvn);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1753
            prev_dom = rc1.ctl;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1754
          } else if (rc0.off == off_hi) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1755
            adjust_check(rc1.ctl, range1, index1, flip1, off_lo, igvn);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1756
            prev_dom = rc1.ctl;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1757
          } else {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1758
            // If the top test's constant is not the min or max of all
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1759
            // constants, we need 3 range checks. We must leave the
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1760
            // top test unchanged because widening it would allow the
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1761
            // accesses it protects to successfully read/write out of
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1762
            // bounds.
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1763
            if (nb_checks == 2) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1764
              return NULL;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1765
            }
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1766
            int chk2 = (nb_checks - 3) % NRC;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1767
            RangeCheck rc2 = prev_checks[chk2];
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1768
            // The top range check a+i covers interval: -a <= i < length-a
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1769
            // The second range check b+i covers interval: -b <= i < length-b
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1770
            if (rc1.off <= rc0.off) {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1771
              // if b <= a, we change the second range check to:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1772
              // -min_of_all_constants <= i < length-min_of_all_constants
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1773
              // Together top and second range checks now cover:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1774
              // -min_of_all_constants <= i < length-a
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1775
              // which is more restrictive than -b <= i < length-b:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1776
              // -b <= -min_of_all_constants <= i < length-a <= length-b
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1777
              // The third check is then changed to:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1778
              // -max_of_all_constants <= i < length-max_of_all_constants
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1779
              // so 2nd and 3rd checks restrict allowed values of i to:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1780
              // -min_of_all_constants <= i < length-max_of_all_constants
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1781
              adjust_check(rc1.ctl, range1, index1, flip1, off_lo, igvn);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1782
              adjust_check(rc2.ctl, range1, index1, flip1, off_hi, igvn);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1783
            } else {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1784
              // if b > a, we change the second range check to:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1785
              // -max_of_all_constants <= i < length-max_of_all_constants
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1786
              // Together top and second range checks now cover:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1787
              // -a <= i < length-max_of_all_constants
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1788
              // which is more restrictive than -b <= i < length-b:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1789
              // -b < -a <= i < length-max_of_all_constants <= length-b
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1790
              // The third check is then changed to:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1791
              // -max_of_all_constants <= i < length-max_of_all_constants
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1792
              // so 2nd and 3rd checks restrict allowed values of i to:
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1793
              // -min_of_all_constants <= i < length-max_of_all_constants
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1794
              adjust_check(rc1.ctl, range1, index1, flip1, off_hi, igvn);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1795
              adjust_check(rc2.ctl, range1, index1, flip1, off_lo, igvn);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1796
            }
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1797
            prev_dom = rc2.ctl;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1798
          }
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1799
        }
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1800
      } else {
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1801
        RangeCheck rc0 = prev_checks[chk0];
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1802
        // 'Widen' the offset of the 1st and only covering check
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1803
        adjust_check(rc0.ctl, range1, index1, flip1, off_hi, igvn);
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1804
        // Test is now covered by prior checks, dominate it out
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1805
        prev_dom = rc0.ctl;
ede40159fd3b 8066103: C2's range check smearing allows out of bound array accesses
roland
parents: 26173
diff changeset
  1806
      }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1807
    }
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1808
  } else {
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1809
    prev_dom = search_identical(4);
190
e9a0a9dcd4f6 6395208: Elide autoboxing for calls to HashMap.get(int) and HashMap.get(long)
never
parents: 1
diff changeset
  1810
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1811
    if (prev_dom == NULL) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1812
      return NULL;
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1813
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1814
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1815
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1816
  // Replace dominated IfNode
34164
a9e6034d7707 8137168: Replace IfNode with a new RangeCheckNode for range checks
roland
parents: 34151
diff changeset
  1817
  return dominated_by(prev_dom, igvn);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1818
}