hotspot/src/share/vm/classfile/packageEntry.cpp
author lfoltan
Thu, 16 Jun 2016 13:34:32 -0400
changeset 39290 0cc9f5028562
parent 38940 7de797f32b5f
child 39616 f82b1f888578
permissions -rw-r--r--
8156871: Possible concurrency issue with JVM_AddModuleExports Summary: Need for single PackageEntry flag to determine a package's unqualifed export state. Reviewed-by: acorn, ctornqvi, dholmes, jiangli
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     1
/*
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     2
 * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     4
 *
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     7
 * published by the Free Software Foundation.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     8
 *
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    13
 * accompanied this code).
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    14
 *
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    18
 *
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    21
 * questions.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    22
 *
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    23
 */
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    24
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    25
#include "precompiled.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    26
#include "classfile/moduleEntry.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    27
#include "classfile/packageEntry.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    28
#include "memory/resourceArea.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    29
#include "oops/symbol.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    30
#include "runtime/handles.inline.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    31
#include "trace/traceMacros.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    32
#include "utilities/events.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    33
#include "utilities/growableArray.hpp"
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    34
#include "utilities/hashtable.inline.hpp"
37503
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
    35
#include "utilities/ostream.hpp"
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    36
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    37
// Returns true if this package specifies m as a qualified export, including through an unnamed export
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    38
bool PackageEntry::is_qexported_to(ModuleEntry* m) const {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    39
  assert(m != NULL, "No module to lookup in this package's qualified exports list");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    40
  MutexLocker m1(Module_lock);
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    41
  if (is_exported_allUnnamed() && !m->is_named()) {
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    42
    return true;
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    43
  } else if (!has_qual_exports_list()) {
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    44
    return false;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    45
  } else {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    46
    return _qualified_exports->contains(m);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    47
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    48
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    49
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    50
// Add a module to the package's qualified export list.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    51
void PackageEntry::add_qexport(ModuleEntry* m) {
39290
0cc9f5028562 8156871: Possible concurrency issue with JVM_AddModuleExports
lfoltan
parents: 38940
diff changeset
    52
  assert(Module_lock->owned_by_self(), "should have the Module_lock");
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    53
  if (!has_qual_exports_list()) {
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    54
    // Lazily create a package's qualified exports list.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    55
    // Initial size is small, do not anticipate export lists to be large.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    56
    _qualified_exports =
38733
2b65f4db449e 8156156: Add module specific NMT MemoryType
hseigel
parents: 37503
diff changeset
    57
      new (ResourceObj::C_HEAP, mtModule) GrowableArray<ModuleEntry*>(QUAL_EXP_SIZE, true);
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    58
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    59
  _qualified_exports->append_if_missing(m);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    60
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    61
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    62
// Set the package's exported states based on the value of the ModuleEntry.
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    63
void PackageEntry::set_exported(ModuleEntry* m) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    64
  MutexLocker m1(Module_lock);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    65
  if (is_unqual_exported()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    66
    // An exception could be thrown, but choose to simply ignore.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    67
    // Illegal to convert an unqualified exported package to be qualifiedly exported
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    68
    return;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    69
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    70
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    71
  if (m == NULL) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    72
    // NULL indicates the package is being unqualifiedly exported
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    73
    if (has_qual_exports_list()) {
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    74
      // Legit to transition a package from being qualifiedly exported
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    75
      // to unqualified.  Clean up the qualified lists at the next
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    76
      // safepoint.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    77
      _exported_pending_delete = _qualified_exports;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    78
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    79
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    80
    // Mark package as unqualifiedly exported
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    81
    set_unqual_exported();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    82
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    83
  } else {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    84
    // Add the exported module
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    85
    add_qexport(m);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    86
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    87
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    88
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    89
void PackageEntry::set_is_exported_allUnnamed() {
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    90
  MutexLocker m1(Module_lock);
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    91
  if (!is_unqual_exported()) {
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    92
   _is_exported_allUnnamed = true;
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    93
  }
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    94
}
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
    95
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    96
// Remove dead module entries within the package's exported list.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    97
void PackageEntry::purge_qualified_exports() {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    98
  assert(SafepointSynchronize::is_at_safepoint(), "must be at safepoint");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
    99
  if (_qualified_exports != NULL) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   100
    // Go backwards because this removes entries that are dead.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   101
    int len = _qualified_exports->length();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   102
    for (int idx = len - 1; idx >= 0; idx--) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   103
      ModuleEntry* module_idx = _qualified_exports->at(idx);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   104
      ClassLoaderData* cld = module_idx->loader();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   105
      if (cld->is_unloading()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   106
        _qualified_exports->delete_at(idx);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   107
      }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   108
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   109
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   110
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   111
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   112
void PackageEntry::delete_qualified_exports() {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   113
  assert(SafepointSynchronize::is_at_safepoint(), "must be at safepoint");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   114
  if (_exported_pending_delete != NULL) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   115
    // If a transition occurred from qualified to unqualified, the _qualified_exports
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   116
    // field should have been NULL'ed out.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   117
    assert(_qualified_exports == NULL, "Package's exported pending delete, exported list should not be active");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   118
    delete _exported_pending_delete;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   119
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   120
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   121
  if (_qualified_exports != NULL) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   122
    delete _qualified_exports;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   123
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   124
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   125
  _exported_pending_delete = NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   126
  _qualified_exports = NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   127
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   128
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   129
PackageEntryTable::PackageEntryTable(int table_size)
38733
2b65f4db449e 8156156: Add module specific NMT MemoryType
hseigel
parents: 37503
diff changeset
   130
  : Hashtable<Symbol*, mtModule>(table_size, sizeof(PackageEntry))
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   131
{
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   132
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   133
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   134
PackageEntryTable::~PackageEntryTable() {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   135
  assert_locked_or_safepoint(Module_lock);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   136
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   137
  // Walk through all buckets and all entries in each bucket,
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   138
  // freeing each entry.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   139
  for (int i = 0; i < table_size(); ++i) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   140
    for (PackageEntry* p = bucket(i); p != NULL;) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   141
      PackageEntry* to_remove = p;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   142
      // read next before freeing.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   143
      p = p->next();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   144
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   145
      // Clean out the C heap allocated qualified exports list first before freeing the entry
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   146
      to_remove->delete_qualified_exports();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   147
      to_remove->name()->decrement_refcount();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   148
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   149
      // Unlink from the Hashtable prior to freeing
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   150
      unlink_entry(to_remove);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   151
      FREE_C_HEAP_ARRAY(char, to_remove);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   152
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   153
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   154
  assert(number_of_entries() == 0, "should have removed all entries");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   155
  assert(new_entry_free_list() == NULL, "entry present on PackageEntryTable's free list");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   156
  free_buckets();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   157
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   158
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   159
PackageEntry* PackageEntryTable::new_entry(unsigned int hash, Symbol* name, ModuleEntry* module) {
39290
0cc9f5028562 8156871: Possible concurrency issue with JVM_AddModuleExports
lfoltan
parents: 38940
diff changeset
   160
  assert(Module_lock->owned_by_self(), "should have the Module_lock");
38733
2b65f4db449e 8156156: Add module specific NMT MemoryType
hseigel
parents: 37503
diff changeset
   161
  PackageEntry* entry = (PackageEntry*) NEW_C_HEAP_ARRAY(char, entry_size(), mtModule);
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   162
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   163
  // Initialize everything BasicHashtable would
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   164
  entry->set_next(NULL);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   165
  entry->set_hash(hash);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   166
  entry->set_literal(name);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   167
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   168
  TRACE_INIT_PACKAGE_ID(entry);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   169
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   170
  // Initialize fields specific to a PackageEntry
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   171
  entry->init();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   172
  entry->name()->increment_refcount();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   173
  if (!module->is_named()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   174
    // Set the exported state to true because all packages
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   175
    // within the unnamed module are unqualifiedly exported
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   176
    entry->set_unqual_exported();
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   177
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   178
  entry->set_module(module);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   179
  return entry;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   180
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   181
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   182
void PackageEntryTable::add_entry(int index, PackageEntry* new_entry) {
39290
0cc9f5028562 8156871: Possible concurrency issue with JVM_AddModuleExports
lfoltan
parents: 38940
diff changeset
   183
  assert(Module_lock->owned_by_self(), "should have the Module_lock");
38733
2b65f4db449e 8156156: Add module specific NMT MemoryType
hseigel
parents: 37503
diff changeset
   184
  Hashtable<Symbol*, mtModule>::add_entry(index, (HashtableEntry<Symbol*, mtModule>*)new_entry);
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   185
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   186
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   187
// Create package in loader's package entry table and return the entry.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   188
// If entry already exists, return null.  Assume Module lock was taken by caller.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   189
PackageEntry* PackageEntryTable::locked_create_entry_or_null(Symbol* name, ModuleEntry* module) {
39290
0cc9f5028562 8156871: Possible concurrency issue with JVM_AddModuleExports
lfoltan
parents: 38940
diff changeset
   190
  assert(Module_lock->owned_by_self(), "should have the Module_lock");
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   191
  // Check if package already exists.  Return NULL if it does.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   192
  if (lookup_only(name) != NULL) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   193
    return NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   194
  } else {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   195
    PackageEntry* entry = new_entry(compute_hash(name), name, module);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   196
    add_entry(index_for(name), entry);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   197
    return entry;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   198
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   199
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   200
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   201
PackageEntry* PackageEntryTable::lookup(Symbol* name, ModuleEntry* module) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   202
  PackageEntry* p = lookup_only(name);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   203
  if (p != NULL) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   204
    return p;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   205
  } else {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   206
    // If not found, add to table. Grab the PackageEntryTable lock first.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   207
    MutexLocker ml(Module_lock);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   208
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   209
    // Since look-up was done lock-free, we need to check if another thread beat
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   210
    // us in the race to insert the package.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   211
    PackageEntry* test = lookup_only(name);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   212
    if (test != NULL) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   213
      // A race occurred and another thread introduced the package.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   214
      return test;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   215
    } else {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   216
      assert(module != NULL, "module should never be null");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   217
      PackageEntry* entry = new_entry(compute_hash(name), name, module);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   218
      add_entry(index_for(name), entry);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   219
      return entry;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   220
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   221
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   222
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   223
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   224
PackageEntry* PackageEntryTable::lookup_only(Symbol* name) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   225
  int index = index_for(name);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   226
  for (PackageEntry* p = bucket(index); p != NULL; p = p->next()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   227
    if (p->name()->fast_compare(name) == 0) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   228
      return p;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   229
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   230
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   231
  return NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   232
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   233
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   234
// Called when a define module for java.base is being processed.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   235
// Verify the packages loaded thus far are in java.base's package list.
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   236
void PackageEntryTable::verify_javabase_packages(GrowableArray<Symbol*> *pkg_list) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   237
  for (int i = 0; i < table_size(); i++) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   238
    for (PackageEntry* entry = bucket(i);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   239
                       entry != NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   240
                       entry = entry->next()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   241
      ModuleEntry* m = entry->module();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   242
      Symbol* module_name = (m == NULL ? NULL : m->name());
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   243
      if (module_name != NULL &&
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   244
          (module_name->fast_compare(vmSymbols::java_base()) == 0) &&
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   245
          !pkg_list->contains(entry->name())) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   246
        ResourceMark rm;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   247
        vm_exit_during_initialization("A non-java.base package was loaded prior to module system initialization", entry->name()->as_C_string());
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   248
      }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   249
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   250
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   251
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   252
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   253
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   254
// iteration of qualified exports
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   255
void PackageEntry::package_exports_do(ModuleClosure* const f) {
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   256
  assert_locked_or_safepoint(Module_lock);
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   257
  assert(f != NULL, "invariant");
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   258
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   259
  if (has_qual_exports_list()) {
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   260
    int qe_len = _qualified_exports->length();
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   261
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   262
    for (int i = 0; i < qe_len; ++i) {
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   263
      f->do_module(_qualified_exports->at(i));
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   264
    }
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   265
  }
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   266
}
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   267
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   268
// Remove dead entries from all packages' exported list
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   269
void PackageEntryTable::purge_all_package_exports() {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   270
  assert(SafepointSynchronize::is_at_safepoint(), "must be at safepoint");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   271
  for (int i = 0; i < table_size(); i++) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   272
    for (PackageEntry* entry = bucket(i);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   273
                       entry != NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   274
                       entry = entry->next()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   275
      if (entry->exported_pending_delete()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   276
        // exported list is pending deletion due to a transition
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   277
        // from qualified to unqualified
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   278
        entry->delete_qualified_exports();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   279
      } else if (entry->is_qual_exported()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   280
        entry->purge_qualified_exports();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   281
      }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   282
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   283
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   284
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   285
37503
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   286
void PackageEntryTable::print(outputStream* st) {
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   287
  st->print_cr("Package Entry Table (table_size=%d, entries=%d)",
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   288
               table_size(), number_of_entries());
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   289
  for (int i = 0; i < table_size(); i++) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   290
    for (PackageEntry* probe = bucket(i);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   291
                       probe != NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   292
                       probe = probe->next()) {
37503
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   293
      probe->print(st);
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   294
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   295
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   296
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   297
37503
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   298
void PackageEntry::print(outputStream* st) {
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   299
  ResourceMark rm;
37503
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   300
  st->print_cr("package entry "PTR_FORMAT" name %s module %s classpath_index "
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   301
               INT32_FORMAT " is_exported_unqualified %d is_exported_allUnnamed %d " "next "PTR_FORMAT,
37503
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   302
               p2i(this), name()->as_C_string(),
77531df4dad3 8152845: Improve PackageEntry and ModuleEntry print methods for future logging
rprotacio
parents: 36508
diff changeset
   303
               (module()->is_named() ? module()->name()->as_C_string() : UNNAMED_MODULE),
38940
7de797f32b5f 8152404: Stabilize PackageEntry::package_exports_do
rprotacio
parents: 38733
diff changeset
   304
               _classpath_index, _is_exported_unqualified, _is_exported_allUnnamed, p2i(next()));
36508
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   305
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   306
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   307
void PackageEntryTable::verify() {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   308
  int element_count = 0;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   309
  for (int index = 0; index < table_size(); index++) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   310
    for (PackageEntry* probe = bucket(index);
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   311
                              probe != NULL;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   312
                              probe = probe->next()) {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   313
      probe->verify();
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   314
      element_count++;
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   315
    }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   316
  }
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   317
  guarantee(number_of_entries() == element_count,
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   318
            "Verify of Package Entry Table failed");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   319
  debug_only(verify_lookup_length((double)number_of_entries() / table_size()));
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   320
}
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   321
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   322
void PackageEntry::verify() {
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   323
  guarantee(name() != NULL, "A package entry must have a corresponding symbol name.");
5f9eee6b383b 8142968: Module System implementation
alanb
parents:
diff changeset
   324
}