hotspot/test/runtime/modules/AccessCheck/AccessReadTwice.java
author alanb
Fri, 07 Apr 2017 08:04:46 +0000
changeset 44520 0553e129e0ec
parent 43665 4bb003cad9b9
permissions -rw-r--r--
8177530: Module system implementation refresh (4/2017) Reviewed-by: lfoltan, sspitsyn Contributed-by: alan.bateman@oracle.com, harold.seigel@oracle.com, mandy.chung@oracle.com
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     1
/*
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     2
 * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     4
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     7
 * published by the Free Software Foundation.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     8
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    13
 * accompanied this code).
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    14
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    18
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    21
 * questions.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    22
 */
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    23
/*
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    24
 * @test
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    25
 * @summary Class p1.c1 in module first_mod cannot read p2.c2 in module second_mod,
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    26
 *          even after a read edge is added between first_mod and second_mod.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    27
 *          Ensures constant access check answers when not accessible due to readability.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    28
 * @library /test/lib
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    29
 * @modules java.base/jdk.internal.misc
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    30
 * @modules java.base/jdk.internal.module
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    31
 * @compile p2/c2.java
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    32
 * @compile p1/c1.java
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    33
 * @compile p4/c4.java
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    34
 * @run main/othervm AccessReadTwice
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    35
 */
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    36
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    37
import static jdk.test.lib.Asserts.*;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    38
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    39
import java.lang.module.Configuration;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    40
import java.lang.module.ModuleDescriptor;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    41
import java.lang.module.ModuleFinder;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    42
import java.util.HashMap;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    43
import java.util.Map;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    44
import java.util.Set;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    45
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    46
//
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    47
// ClassLoader1 --> defines first_mod --> packages p1, p4
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    48
//                  defines second_mod --> package p2
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    49
//
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    50
// package p2 in second_mod is exported to first_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    51
//
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    52
// class p1.c1 defined in first_mod tries to access p2.c2 defined in second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    53
// Access is not allowed, even after a read edge is added between first_mod and second_mod.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    54
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    55
public class AccessReadTwice {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    56
44520
0553e129e0ec 8177530: Module system implementation refresh (4/2017)
alanb
parents: 43665
diff changeset
    57
    // Create a layer over the boot layer.
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    58
    // Define modules within this layer to test access between
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    59
    // publicly defined classes within packages of those modules.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    60
    public void createLayerOnBoot() throws Throwable {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    61
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    62
        // Define module:     first_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    63
        // Can read:          java.base
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    64
        // Packages:          p1, p4
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    65
        // Packages exported: none
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    66
        ModuleDescriptor descriptor_first_mod =
43665
4bb003cad9b9 8173393: Module system implementation refresh (2/2017)
alanb
parents: 43444
diff changeset
    67
                ModuleDescriptor.newModule("first_mod")
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    68
                        .requires("java.base")
43665
4bb003cad9b9 8173393: Module system implementation refresh (2/2017)
alanb
parents: 43444
diff changeset
    69
                        .packages(Set.of("p1", "p4"))
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    70
                        .build();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    71
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    72
        // Define module:     second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    73
        // Can read:          java.base
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    74
        // Packages:          p2
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    75
        // Packages exported: p2 is exported to first_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    76
        ModuleDescriptor descriptor_second_mod =
43665
4bb003cad9b9 8173393: Module system implementation refresh (2/2017)
alanb
parents: 43444
diff changeset
    77
                ModuleDescriptor.newModule("second_mod")
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    78
                        .requires("java.base")
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    79
                        .exports("p2", Set.of("first_mod"))
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    80
                        .build();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    81
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    82
        // Set up a ModuleFinder containing all modules for this layer
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    83
        ModuleFinder finder = ModuleLibrary.of(descriptor_first_mod, descriptor_second_mod);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    84
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    85
        // Resolves "first_mod" and "second_mod"
44520
0553e129e0ec 8177530: Module system implementation refresh (4/2017)
alanb
parents: 43665
diff changeset
    86
        Configuration cf = ModuleLayer.boot()
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    87
                .configuration()
43665
4bb003cad9b9 8173393: Module system implementation refresh (2/2017)
alanb
parents: 43444
diff changeset
    88
                .resolve(finder, ModuleFinder.of(), Set.of("first_mod", "second_mod"));
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    89
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    90
        // Map each module to this class loader
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    91
        Map<String, ClassLoader> map = new HashMap<>();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    92
        ClassLoader loader = AccessReadTwice.class.getClassLoader();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    93
        map.put("first_mod", loader);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    94
        map.put("second_mod", loader);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    95
44520
0553e129e0ec 8177530: Module system implementation refresh (4/2017)
alanb
parents: 43665
diff changeset
    96
        // Create layer that contains first_mod & second_mod
0553e129e0ec 8177530: Module system implementation refresh (4/2017)
alanb
parents: 43665
diff changeset
    97
        ModuleLayer layer = ModuleLayer.boot().defineModules(cf, map::get);
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    98
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    99
        assertTrue(layer.findLoader("first_mod") == loader);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   100
        assertTrue(layer.findLoader("second_mod") == loader);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   101
        assertTrue(layer.findLoader("java.base") == null);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   102
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   103
        Class p2_c2_class = loader.loadClass("p2.c2");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   104
        Class p1_c1_class = loader.loadClass("p1.c1");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   105
        Class p4_c4_class = loader.loadClass("p4.c4");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   106
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   107
        Module first_mod = p1_c1_class.getModule();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   108
        Module second_mod = p2_c2_class.getModule();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   109
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   110
        // Export first_mod/p1 and first_mod/p4 to all unnamed modules so that
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   111
        // this test can use them
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   112
        jdk.internal.module.Modules.addExportsToAllUnnamed(first_mod, "p1");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   113
        jdk.internal.module.Modules.addExportsToAllUnnamed(first_mod, "p4");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   114
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   115
        // First access check for p1.c1
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   116
        try {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   117
            p1_c1_class.newInstance();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   118
            throw new RuntimeException("Test Failed, module first_mod should not have access to p2.c2");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   119
        } catch (IllegalAccessError e) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   120
            String message = e.getMessage();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   121
            if (!(message.contains("cannot access") &&
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   122
                  message.contains("because module first_mod does not read module second_mod"))) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   123
                throw new RuntimeException("Wrong message: " + message);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   124
            } else {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   125
                System.out.println("Test Succeeded at attempt #1");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   126
            }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   127
        }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   128
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   129
        // Add a read edge from p4/c4's module (first_mod) to second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   130
        p4.c4 c4_obj = new p4.c4();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   131
        c4_obj.addReads(second_mod);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   132
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   133
        // Second access check for p1.c1, should have same result as first
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   134
        try {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   135
            p1_c1_class.newInstance();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   136
            throw new RuntimeException("Test Failed, access should have been cached above");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   137
        } catch (IllegalAccessError e) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   138
            String message = e.getMessage();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   139
            if (!(message.contains("cannot access") &&
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   140
                  message.contains("because module first_mod does not read module second_mod"))) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   141
                throw new RuntimeException("Wrong message: " + message);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   142
            } else {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   143
                System.out.println("Test Succeeded at attempt #2");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   144
            }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   145
        }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   146
    }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   147
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   148
    public static void main(String args[]) throws Throwable {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   149
      AccessReadTwice test = new AccessReadTwice();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   150
      test.createLayerOnBoot();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   151
    }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   152
}