author | dlong |
Thu, 14 Nov 2019 12:21:00 -0800 | |
changeset 59095 | 03fbcd06b4c0 |
parent 58877 | aec7bf35d6f5 |
permissions | -rw-r--r-- |
43972 | 1 |
/* |
54084 | 2 |
* Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved. |
43972 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
20 |
* or visit www.oracle.com if you need additional information or have any |
|
21 |
* questions. |
|
22 |
*/ |
|
50858 | 23 |
|
24 |
||
43972 | 25 |
package org.graalvm.compiler.hotspot.test; |
26 |
||
27 |
import java.lang.reflect.Method; |
|
28 |
import java.util.ArrayList; |
|
29 |
import java.util.Arrays; |
|
30 |
import java.util.Collection; |
|
31 |
import java.util.Collections; |
|
50609 | 32 |
import java.util.Formatter; |
43972 | 33 |
import java.util.List; |
50609 | 34 |
import java.util.ServiceLoader; |
43972 | 35 |
import java.util.Set; |
36 |
import java.util.TreeSet; |
|
37 |
import java.util.stream.Collectors; |
|
38 |
||
49873 | 39 |
import jdk.internal.vm.compiler.collections.EconomicMap; |
40 |
import jdk.internal.vm.compiler.collections.MapCursor; |
|
43972 | 41 |
import org.graalvm.compiler.api.test.Graal; |
42 |
import org.graalvm.compiler.hotspot.GraalHotSpotVMConfig; |
|
43 |
import org.graalvm.compiler.hotspot.HotSpotGraalRuntimeProvider; |
|
57537 | 44 |
import org.graalvm.compiler.hotspot.meta.HotSpotGraphBuilderPlugins; |
43972 | 45 |
import org.graalvm.compiler.hotspot.meta.HotSpotProviders; |
46 |
import org.graalvm.compiler.nodes.graphbuilderconf.GraphBuilderConfiguration.Plugins; |
|
47 |
import org.graalvm.compiler.nodes.graphbuilderconf.InvocationPlugin; |
|
48 |
import org.graalvm.compiler.nodes.graphbuilderconf.InvocationPlugins; |
|
46459 | 49 |
import org.graalvm.compiler.nodes.graphbuilderconf.InvocationPlugins.Binding; |
43972 | 50 |
import org.graalvm.compiler.runtime.RuntimeProvider; |
54084 | 51 |
import org.graalvm.compiler.serviceprovider.JavaVersionUtil; |
43972 | 52 |
import org.graalvm.compiler.test.GraalTest; |
46459 | 53 |
import org.junit.Test; |
43972 | 54 |
|
50858 | 55 |
import jdk.vm.ci.aarch64.AArch64; |
50609 | 56 |
import jdk.vm.ci.amd64.AMD64; |
57 |
import jdk.vm.ci.code.Architecture; |
|
43972 | 58 |
import jdk.vm.ci.hotspot.HotSpotVMConfigStore; |
59 |
import jdk.vm.ci.hotspot.VMIntrinsicMethod; |
|
60 |
import jdk.vm.ci.meta.MetaAccessProvider; |
|
46459 | 61 |
import jdk.vm.ci.meta.MetaUtil; |
43972 | 62 |
import jdk.vm.ci.meta.MethodHandleAccessProvider.IntrinsicMethod; |
63 |
import jdk.vm.ci.meta.ResolvedJavaMethod; |
|
58533 | 64 |
import jdk.vm.ci.sparc.SPARC; |
43972 | 65 |
|
66 |
/** |
|
46459 | 67 |
* Checks the intrinsics implemented by Graal against the set of intrinsics declared by HotSpot. The |
68 |
* purpose of this test is to detect when new intrinsics are added to HotSpot and process them |
|
50609 | 69 |
* appropriately in Graal. This will be achieved by working through {@link #toBeInvestigated} and |
70 |
* either implementing the intrinsic or moving it to {@link #ignore} . |
|
43972 | 71 |
*/ |
72 |
public class CheckGraalIntrinsics extends GraalTest { |
|
73 |
||
46459 | 74 |
public static boolean match(String type, Binding binding, VMIntrinsicMethod intrinsic) { |
75 |
if (intrinsic.name.equals(binding.name)) { |
|
76 |
if (intrinsic.descriptor.startsWith(binding.argumentsDescriptor)) { |
|
77 |
if (type.equals(intrinsic.declaringClass)) { |
|
43972 | 78 |
return true; |
79 |
} |
|
80 |
} |
|
81 |
} |
|
82 |
return false; |
|
83 |
} |
|
84 |
||
46459 | 85 |
public static InvocationPlugin findPlugin(EconomicMap<String, List<Binding>> bindings, VMIntrinsicMethod intrinsic) { |
86 |
MapCursor<String, List<Binding>> cursor = bindings.getEntries(); |
|
87 |
while (cursor.advance()) { |
|
88 |
// Match format of VMIntrinsicMethod.declaringClass |
|
89 |
String type = MetaUtil.internalNameToJava(cursor.getKey(), true, false).replace('.', '/'); |
|
90 |
for (Binding binding : cursor.getValue()) { |
|
91 |
if (match(type, binding, intrinsic)) { |
|
92 |
return binding.plugin; |
|
93 |
} |
|
43972 | 94 |
} |
95 |
} |
|
96 |
return null; |
|
97 |
} |
|
98 |
||
46459 | 99 |
public static ResolvedJavaMethod resolveIntrinsic(MetaAccessProvider metaAccess, VMIntrinsicMethod intrinsic) throws ClassNotFoundException { |
46807 | 100 |
Class<?> c; |
101 |
try { |
|
102 |
c = Class.forName(intrinsic.declaringClass.replace('/', '.'), false, CheckGraalIntrinsics.class.getClassLoader()); |
|
103 |
} catch (ClassNotFoundException ex) { |
|
104 |
try { |
|
105 |
Class.forName("javax.naming.Reference"); |
|
106 |
} catch (ClassNotFoundException coreNamingMissing) { |
|
107 |
// if core JDK classes aren't found, we are probably running in a |
|
108 |
// JDK9 java.base environment and then missing class is OK |
|
109 |
return null; |
|
110 |
} |
|
111 |
throw ex; |
|
112 |
} |
|
43972 | 113 |
for (Method javaMethod : c.getDeclaredMethods()) { |
114 |
if (javaMethod.getName().equals(intrinsic.name)) { |
|
115 |
ResolvedJavaMethod method = metaAccess.lookupJavaMethod(javaMethod); |
|
116 |
if (intrinsic.descriptor.equals("*")) { |
|
117 |
// Signature polymorphic method - name match is enough |
|
118 |
return method; |
|
119 |
} else { |
|
120 |
if (method.getSignature().toMethodDescriptor().equals(intrinsic.descriptor)) { |
|
121 |
return method; |
|
122 |
} |
|
123 |
} |
|
124 |
} |
|
125 |
} |
|
126 |
return null; |
|
127 |
} |
|
128 |
||
129 |
/** |
|
50609 | 130 |
* The HotSpot intrinsics that: |
131 |
* <ul> |
|
132 |
* <li>will never implemented by Graal (comments must explain why)</li> |
|
133 |
* <li>are implemented without {@link InvocationPlugin}s, or</li> |
|
134 |
* <li>whose {@link InvocationPlugin} registration is guarded by a condition that is false in |
|
135 |
* the current VM context.</li> |
|
136 |
* </ul> |
|
43972 | 137 |
*/ |
50609 | 138 |
public final Set<String> ignore = new TreeSet<>(); |
43972 | 139 |
|
140 |
/** |
|
50609 | 141 |
* The HotSpot intrinsics whose {@link InvocationPlugin} registration is guarded by a condition |
142 |
* too complex to duplicate here. |
|
143 |
* </ul> |
|
43972 | 144 |
*/ |
50609 | 145 |
public final Set<String> complexGuard = new TreeSet<>(); |
146 |
||
147 |
/** |
|
148 |
* The HotSpot intrinsics implemented downstream. |
|
149 |
* </ul> |
|
150 |
*/ |
|
151 |
public final Set<String> downstream = new TreeSet<>(); |
|
152 |
||
153 |
/** |
|
154 |
* The HotSpot intrinsics yet to be implemented or moved to {@link #ignore}. |
|
155 |
*/ |
|
156 |
public final Set<String> toBeInvestigated = new TreeSet<>(); |
|
43972 | 157 |
|
158 |
private static Collection<String> add(Collection<String> c, String... elements) { |
|
159 |
String[] sorted = elements.clone(); |
|
160 |
Arrays.sort(sorted); |
|
59095 | 161 |
if (!Arrays.equals(elements, sorted)) { |
162 |
int width = 2 + Arrays.asList(elements).stream().map(String::length).reduce(0, Integer::max); |
|
163 |
Formatter fmt = new Formatter(); |
|
164 |
fmt.format("%-" + width + "s | sorted%n", "original"); |
|
165 |
fmt.format("%s%n", new String(new char[width * 2 + 2]).replace('\0', '=')); |
|
166 |
for (int i = 0; i < elements.length; i++) { |
|
167 |
fmt.format("%-" + width + "s | %s%n", elements[i], sorted[i]); |
|
43972 | 168 |
} |
59095 | 169 |
fail("Elements not sorted alphabetically:%n%s", fmt); |
43972 | 170 |
} |
171 |
c.addAll(Arrays.asList(elements)); |
|
172 |
return c; |
|
173 |
} |
|
174 |
||
50609 | 175 |
public final HotSpotGraalRuntimeProvider rt = (HotSpotGraalRuntimeProvider) Graal.getRequiredCapability(RuntimeProvider.class); |
176 |
public final Architecture arch = rt.getHostBackend().getTarget().arch; |
|
177 |
public final GraalHotSpotVMConfig config = rt.getVMConfig(); |
|
178 |
||
179 |
public CheckGraalIntrinsics() { |
|
48190 | 180 |
// These are dead |
50609 | 181 |
add(ignore, |
43972 | 182 |
"java/lang/Math.atan2(DD)D", |
48190 | 183 |
"jdk/internal/misc/Unsafe.park(ZJ)V", |
184 |
"jdk/internal/misc/Unsafe.unpark(Ljava/lang/Object;)V", |
|
43972 | 185 |
"sun/misc/Unsafe.park(ZJ)V", |
186 |
"sun/misc/Unsafe.prefetchRead(Ljava/lang/Object;J)V", |
|
187 |
"sun/misc/Unsafe.prefetchReadStatic(Ljava/lang/Object;J)V", |
|
188 |
"sun/misc/Unsafe.prefetchWrite(Ljava/lang/Object;J)V", |
|
189 |
"sun/misc/Unsafe.prefetchWriteStatic(Ljava/lang/Object;J)V", |
|
190 |
"sun/misc/Unsafe.unpark(Ljava/lang/Object;)V"); |
|
191 |
||
48190 | 192 |
// These only exist to assist escape analysis in C2 |
50609 | 193 |
add(ignore, |
48190 | 194 |
"java/lang/Throwable.fillInStackTrace()Ljava/lang/Throwable;"); |
195 |
||
196 |
// These are only used for the security handling during stack walking |
|
50609 | 197 |
add(ignore, |
48190 | 198 |
"java/lang/reflect/Method.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;"); |
199 |
||
200 |
// These are marker intrinsic ids only |
|
50609 | 201 |
add(ignore, |
48190 | 202 |
"java/lang/invoke/MethodHandle.<compiledLambdaForm>*", |
203 |
"java/lang/invoke/MethodHandle.invoke*"); |
|
204 |
||
205 |
// These are implemented through lowering |
|
50609 | 206 |
add(ignore, |
48190 | 207 |
"java/lang/ref/Reference.get()Ljava/lang/Object;"); |
208 |
||
209 |
// These are only used by C1 |
|
50609 | 210 |
add(ignore, |
48190 | 211 |
"java/nio/Buffer.checkIndex(I)I"); |
212 |
||
213 |
// These do general compiler optimizations and convert min/max to cmov instructions. We are |
|
214 |
// ignoring them as cmovs are not necessarily beneficial. |
|
50609 | 215 |
add(ignore, |
48190 | 216 |
"java/lang/Math.max(II)I", |
217 |
"java/lang/Math.min(II)I"); |
|
218 |
||
219 |
// These are known to be implemented down stream |
|
50609 | 220 |
add(downstream, |
43972 | 221 |
"java/lang/Integer.toString(I)Ljava/lang/String;", |
222 |
"java/lang/String.<init>(Ljava/lang/String;)V", |
|
223 |
"java/lang/StringBuffer.<init>()V", |
|
224 |
"java/lang/StringBuffer.<init>(I)V", |
|
225 |
"java/lang/StringBuffer.<init>(Ljava/lang/String;)V", |
|
226 |
"java/lang/StringBuffer.append(C)Ljava/lang/StringBuffer;", |
|
227 |
"java/lang/StringBuffer.append(I)Ljava/lang/StringBuffer;", |
|
228 |
"java/lang/StringBuffer.append(Ljava/lang/String;)Ljava/lang/StringBuffer;", |
|
229 |
"java/lang/StringBuffer.toString()Ljava/lang/String;", |
|
230 |
"java/lang/StringBuilder.<init>()V", |
|
231 |
"java/lang/StringBuilder.<init>(I)V", |
|
232 |
"java/lang/StringBuilder.<init>(Ljava/lang/String;)V", |
|
233 |
"java/lang/StringBuilder.append(C)Ljava/lang/StringBuilder;", |
|
234 |
"java/lang/StringBuilder.append(I)Ljava/lang/StringBuilder;", |
|
235 |
"java/lang/StringBuilder.append(Ljava/lang/String;)Ljava/lang/StringBuilder;", |
|
236 |
"java/lang/StringBuilder.toString()Ljava/lang/String;", |
|
237 |
"java/util/Arrays.copyOf([Ljava/lang/Object;ILjava/lang/Class;)[Ljava/lang/Object;", |
|
48190 | 238 |
"java/util/Arrays.copyOfRange([Ljava/lang/Object;IILjava/lang/Class;)[Ljava/lang/Object;"); |
43972 | 239 |
|
50609 | 240 |
add(complexGuard, |
43972 | 241 |
"java/lang/Integer.bitCount(I)I", |
242 |
"java/lang/Integer.numberOfLeadingZeros(I)I", |
|
243 |
"java/lang/Integer.numberOfTrailingZeros(I)I", |
|
244 |
"java/lang/Long.bitCount(J)I", |
|
245 |
"java/lang/Long.numberOfLeadingZeros(J)I", |
|
246 |
"java/lang/Long.numberOfTrailingZeros(J)I"); |
|
247 |
||
48190 | 248 |
// Relevant for Java flight recorder |
50609 | 249 |
add(toBeInvestigated, |
48190 | 250 |
"oracle/jrockit/jfr/Timing.counterTime()J", |
251 |
"oracle/jrockit/jfr/VMJFR.classID0(Ljava/lang/Class;)J", |
|
252 |
"oracle/jrockit/jfr/VMJFR.threadID()I"); |
|
253 |
||
50609 | 254 |
add(toBeInvestigated, |
48190 | 255 |
// Similar to addExact |
256 |
"java/lang/Math.negateExact(I)I", |
|
257 |
// Similar to addExact |
|
258 |
"java/lang/Math.negateExact(J)J", |
|
259 |
// HotSpot MacroAssembler-based intrinsic |
|
260 |
"java/lang/String.indexOf(Ljava/lang/String;)I", |
|
261 |
// Can share most implementation parts with with |
|
262 |
// Unsafe.allocateUninitializedArray0 |
|
263 |
"java/lang/reflect/Array.newArray(Ljava/lang/Class;I)Ljava/lang/Object;", |
|
264 |
// HotSpot MacroAssembler-based intrinsic |
|
265 |
"sun/nio/cs/ISO_8859_1$Encoder.encodeISOArray([CI[BII)I", |
|
54084 | 266 |
// We have implemented implCompressMultiBlock0 on JDK9+. Does it worth |
267 |
// backporting as corresponding HotSpot stubs are only generated on SPARC? |
|
48190 | 268 |
"sun/security/provider/DigestBase.implCompressMultiBlock([BII)I"); |
269 |
||
52578 | 270 |
// See JDK-8207146. |
271 |
String oopName = isJDK12OrHigher() ? "Reference" : "Object"; |
|
272 |
||
48190 | 273 |
if (isJDK9OrHigher()) { |
274 |
// Relevant for Java flight recorder |
|
50609 | 275 |
add(toBeInvestigated, |
48190 | 276 |
"jdk/jfr/internal/JVM.counterTime()J", |
277 |
"jdk/jfr/internal/JVM.getBufferWriter()Ljava/lang/Object;", |
|
278 |
"jdk/jfr/internal/JVM.getClassId(Ljava/lang/Class;)J"); |
|
279 |
||
50609 | 280 |
add(toBeInvestigated, |
48190 | 281 |
// Just check if the argument is a compile time constant |
282 |
"java/lang/invoke/MethodHandleImpl.isCompileConstant(Ljava/lang/Object;)Z", |
|
283 |
// Only used as a marker for vectorization? |
|
284 |
"java/util/stream/Streams$RangeIntSpliterator.forEachRemaining(Ljava/util/function/IntConsumer;)V", |
|
285 |
// Only implemented on non-AMD64 platforms (some logic and runtime call) |
|
286 |
"java/util/zip/Adler32.updateByteBuffer(IJII)I", |
|
287 |
// Only implemented on non-AMD64 platforms (some logic and runtime call) |
|
288 |
"java/util/zip/Adler32.updateBytes(I[BII)I", |
|
289 |
// Emits a slow and a fast path and some dispatching logic |
|
290 |
"jdk/internal/misc/Unsafe.allocateUninitializedArray0(Ljava/lang/Class;I)Ljava/lang/Object;", |
|
291 |
||
292 |
// Control flow, deopts, and a cast |
|
293 |
"jdk/internal/util/Preconditions.checkIndex(IILjava/util/function/BiFunction;)I", |
|
294 |
// HotSpot MacroAssembler-based intrinsic |
|
54084 | 295 |
"sun/nio/cs/ISO_8859_1$Encoder.implEncodeISOArray([CI[BII)I"); |
50609 | 296 |
|
48190 | 297 |
/* |
298 |
* Per default, all these operations are mapped to some generic method for which we |
|
299 |
* already have compiler intrinsics. Performance-wise it would be better to support them |
|
300 |
* explicitly as the more generic method might be more restrictive and therefore slower |
|
301 |
* than necessary. |
|
302 |
*/ |
|
52578 | 303 |
|
50609 | 304 |
add(toBeInvestigated, |
48190 | 305 |
// Mapped to compareAndExchange* |
306 |
"jdk/internal/misc/Unsafe.compareAndExchangeByteAcquire(Ljava/lang/Object;JBB)B", |
|
307 |
"jdk/internal/misc/Unsafe.compareAndExchangeByteRelease(Ljava/lang/Object;JBB)B", |
|
308 |
"jdk/internal/misc/Unsafe.compareAndExchangeIntAcquire(Ljava/lang/Object;JII)I", |
|
309 |
"jdk/internal/misc/Unsafe.compareAndExchangeIntRelease(Ljava/lang/Object;JII)I", |
|
310 |
"jdk/internal/misc/Unsafe.compareAndExchangeLongAcquire(Ljava/lang/Object;JJJ)J", |
|
311 |
"jdk/internal/misc/Unsafe.compareAndExchangeLongRelease(Ljava/lang/Object;JJJ)J", |
|
52578 | 312 |
"jdk/internal/misc/Unsafe.compareAndExchange" + oopName + "Acquire(Ljava/lang/Object;JLjava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;", |
313 |
"jdk/internal/misc/Unsafe.compareAndExchange" + oopName + "Release(Ljava/lang/Object;JLjava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;", |
|
48190 | 314 |
"jdk/internal/misc/Unsafe.compareAndExchangeShortAcquire(Ljava/lang/Object;JSS)S", |
315 |
"jdk/internal/misc/Unsafe.compareAndExchangeShortRelease(Ljava/lang/Object;JSS)S", |
|
316 |
||
317 |
// Mapped to compareAndSet* |
|
318 |
"jdk/internal/misc/Unsafe.weakCompareAndSetByte(Ljava/lang/Object;JBB)Z", |
|
319 |
"jdk/internal/misc/Unsafe.weakCompareAndSetByteAcquire(Ljava/lang/Object;JBB)Z", |
|
320 |
"jdk/internal/misc/Unsafe.weakCompareAndSetBytePlain(Ljava/lang/Object;JBB)Z", |
|
321 |
"jdk/internal/misc/Unsafe.weakCompareAndSetByteRelease(Ljava/lang/Object;JBB)Z", |
|
322 |
"jdk/internal/misc/Unsafe.weakCompareAndSetInt(Ljava/lang/Object;JII)Z", |
|
323 |
"jdk/internal/misc/Unsafe.weakCompareAndSetIntAcquire(Ljava/lang/Object;JII)Z", |
|
324 |
"jdk/internal/misc/Unsafe.weakCompareAndSetIntPlain(Ljava/lang/Object;JII)Z", |
|
325 |
"jdk/internal/misc/Unsafe.weakCompareAndSetIntRelease(Ljava/lang/Object;JII)Z", |
|
326 |
"jdk/internal/misc/Unsafe.weakCompareAndSetLong(Ljava/lang/Object;JJJ)Z", |
|
327 |
"jdk/internal/misc/Unsafe.weakCompareAndSetLongAcquire(Ljava/lang/Object;JJJ)Z", |
|
328 |
"jdk/internal/misc/Unsafe.weakCompareAndSetLongPlain(Ljava/lang/Object;JJJ)Z", |
|
329 |
"jdk/internal/misc/Unsafe.weakCompareAndSetLongRelease(Ljava/lang/Object;JJJ)Z", |
|
52578 | 330 |
"jdk/internal/misc/Unsafe.weakCompareAndSet" + oopName + "(Ljava/lang/Object;JLjava/lang/Object;Ljava/lang/Object;)Z", |
331 |
"jdk/internal/misc/Unsafe.weakCompareAndSet" + oopName + "Acquire(Ljava/lang/Object;JLjava/lang/Object;Ljava/lang/Object;)Z", |
|
332 |
"jdk/internal/misc/Unsafe.weakCompareAndSet" + oopName + "Plain(Ljava/lang/Object;JLjava/lang/Object;Ljava/lang/Object;)Z", |
|
333 |
"jdk/internal/misc/Unsafe.weakCompareAndSet" + oopName + "Release(Ljava/lang/Object;JLjava/lang/Object;Ljava/lang/Object;)Z", |
|
48190 | 334 |
"jdk/internal/misc/Unsafe.weakCompareAndSetShort(Ljava/lang/Object;JSS)Z", |
335 |
"jdk/internal/misc/Unsafe.weakCompareAndSetShortAcquire(Ljava/lang/Object;JSS)Z", |
|
336 |
"jdk/internal/misc/Unsafe.weakCompareAndSetShortPlain(Ljava/lang/Object;JSS)Z", |
|
337 |
"jdk/internal/misc/Unsafe.weakCompareAndSetShortRelease(Ljava/lang/Object;JSS)Z"); |
|
338 |
||
339 |
// Compact string support - HotSpot MacroAssembler-based intrinsic or complex C2 logic. |
|
50609 | 340 |
add(toBeInvestigated, |
48190 | 341 |
"java/lang/StringCoding.hasNegatives([BII)Z", |
54084 | 342 |
"java/lang/StringCoding.implEncodeISOArray([BI[BII)I"); |
343 |
add(ignore, |
|
344 |
// handled through an intrinsic for String.equals itself |
|
345 |
"java/lang/StringLatin1.equals([B[B)Z", |
|
346 |
||
347 |
// handled by an intrinsic for StringLatin1.indexOf([BI[BII)I |
|
48190 | 348 |
"java/lang/StringLatin1.indexOf([B[B)I", |
54084 | 349 |
|
350 |
// handled through an intrinsic for String.equals itself |
|
351 |
"java/lang/StringUTF16.equals([B[B)Z", |
|
352 |
||
353 |
// handled by an intrinsic for StringUTF16.indexOfUnsafe |
|
48190 | 354 |
"java/lang/StringUTF16.indexOf([BI[BII)I", |
355 |
"java/lang/StringUTF16.indexOf([B[B)I", |
|
54084 | 356 |
|
357 |
// handled by an intrinsic for StringUTF16.indexOfCharUnsafe |
|
48190 | 358 |
"java/lang/StringUTF16.indexOfChar([BIII)I", |
54084 | 359 |
|
360 |
// handled by an intrinsic for StringUTF16.indexOfLatin1Unsafe |
|
48190 | 361 |
"java/lang/StringUTF16.indexOfLatin1([BI[BII)I", |
54084 | 362 |
"java/lang/StringUTF16.indexOfLatin1([B[B)I"); |
363 |
||
364 |
if (!config.useAESCTRIntrinsics) { |
|
365 |
add(ignore, |
|
366 |
"com/sun/crypto/provider/CounterMode.implCrypt([BII[BI)I"); |
|
367 |
} |
|
368 |
if (!config.useGHASHIntrinsics()) { |
|
369 |
add(ignore, |
|
370 |
"com/sun/crypto/provider/GHASH.processBlocks([BII[J[J)V"); |
|
371 |
} |
|
54914 | 372 |
if (!config.useFMAIntrinsics) { |
373 |
add(ignore, |
|
374 |
"java/lang/Math.fma(DDD)D", |
|
375 |
"java/lang/Math.fma(FFF)F"); |
|
58533 | 376 |
} else if (arch instanceof SPARC) { |
54914 | 377 |
add(toBeInvestigated, |
378 |
"java/lang/Math.fma(DDD)D", |
|
379 |
"java/lang/Math.fma(FFF)F"); |
|
380 |
} |
|
48190 | 381 |
} |
382 |
||
48861 | 383 |
if (isJDK10OrHigher()) { |
50609 | 384 |
add(toBeInvestigated, |
54084 | 385 |
"java/lang/Math.multiplyHigh(JJ)J"); |
48861 | 386 |
} |
387 |
||
50330 | 388 |
if (isJDK11OrHigher()) { |
389 |
// Relevant for Java flight recorder |
|
50609 | 390 |
add(toBeInvestigated, |
55509 | 391 |
"java/lang/CharacterDataLatin1.isDigit(I)Z", |
392 |
"java/lang/CharacterDataLatin1.isLowerCase(I)Z", |
|
393 |
"java/lang/CharacterDataLatin1.isUpperCase(I)Z", |
|
394 |
"java/lang/CharacterDataLatin1.isWhitespace(I)Z", |
|
50330 | 395 |
"jdk/jfr/internal/JVM.getEventWriter()Ljava/lang/Object;"); |
54601 | 396 |
if (!config.useBase64Intrinsics()) { |
397 |
add(ignore, |
|
398 |
"java/util/Base64$Encoder.encodeBlock([BII[BIZ)V"); |
|
399 |
} |
|
50330 | 400 |
} |
401 |
||
53081
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
402 |
if (isJDK13OrHigher()) { |
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
403 |
add(toBeInvestigated, |
54750 | 404 |
"java/lang/Math.abs(I)I", |
405 |
"java/lang/Math.abs(J)J", |
|
53081
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
406 |
"java/lang/Math.max(DD)D", |
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
407 |
"java/lang/Math.max(FF)F", |
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
408 |
"java/lang/Math.min(DD)D", |
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
409 |
"java/lang/Math.min(FF)F"); |
57804 | 410 |
add(toBeInvestigated, |
411 |
"jdk/internal/misc/Unsafe.writeback0(J)V", |
|
412 |
"jdk/internal/misc/Unsafe.writebackPostSync0()V", |
|
413 |
"jdk/internal/misc/Unsafe.writebackPreSync0()V"); |
|
53081
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
414 |
} |
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
415 |
|
57831
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
416 |
if (isJDK14OrHigher()) { |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
417 |
add(toBeInvestigated, |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
418 |
"com/sun/crypto/provider/ElectronicCodeBook.implECBDecrypt([BII[BI)I", |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
419 |
"com/sun/crypto/provider/ElectronicCodeBook.implECBEncrypt([BII[BI)I"); |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
420 |
} |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
421 |
|
50609 | 422 |
if (!config.inlineNotify()) { |
423 |
add(ignore, "java/lang/Object.notify()V"); |
|
424 |
} |
|
425 |
if (!config.inlineNotifyAll()) { |
|
426 |
add(ignore, "java/lang/Object.notifyAll()V"); |
|
427 |
} |
|
428 |
||
429 |
if (!(arch instanceof AMD64)) { |
|
48190 | 430 |
// Can we implement these on non-AMD64 platforms? C2 seems to. |
50609 | 431 |
add(toBeInvestigated, |
432 |
"java/lang/String.compareTo(Ljava/lang/String;)I", |
|
54084 | 433 |
"java/lang/StringLatin1.indexOf([B[B)I", |
52578 | 434 |
"java/lang/StringLatin1.inflate([BI[BII)V", |
435 |
"java/lang/StringLatin1.inflate([BI[CII)V", |
|
436 |
"java/lang/StringUTF16.compress([BI[BII)I", |
|
437 |
"java/lang/StringUTF16.compress([CI[BII)I", |
|
54084 | 438 |
"java/lang/StringUTF16.indexOf([BI[BII)I", |
439 |
"java/lang/StringUTF16.indexOf([B[B)I", |
|
440 |
"java/lang/StringUTF16.indexOfChar([BIII)I", |
|
441 |
"java/lang/StringUTF16.indexOfLatin1([BI[BII)I", |
|
442 |
"java/lang/StringUTF16.indexOfLatin1([B[B)I", |
|
50609 | 443 |
"jdk/internal/misc/Unsafe.compareAndExchangeByte(Ljava/lang/Object;JBB)B", |
444 |
"jdk/internal/misc/Unsafe.compareAndExchangeShort(Ljava/lang/Object;JSS)S", |
|
445 |
"jdk/internal/misc/Unsafe.compareAndSetByte(Ljava/lang/Object;JBB)Z", |
|
446 |
"jdk/internal/misc/Unsafe.compareAndSetShort(Ljava/lang/Object;JSS)Z", |
|
447 |
"jdk/internal/misc/Unsafe.getAndAddByte(Ljava/lang/Object;JB)B", |
|
448 |
"jdk/internal/misc/Unsafe.getAndAddShort(Ljava/lang/Object;JS)S", |
|
449 |
"jdk/internal/misc/Unsafe.getAndSetByte(Ljava/lang/Object;JB)B", |
|
450 |
"jdk/internal/misc/Unsafe.getAndSetShort(Ljava/lang/Object;JS)S", |
|
48190 | 451 |
"sun/misc/Unsafe.getAndAddInt(Ljava/lang/Object;JI)I", |
452 |
"sun/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J", |
|
453 |
"sun/misc/Unsafe.getAndSetInt(Ljava/lang/Object;JI)I", |
|
454 |
"sun/misc/Unsafe.getAndSetLong(Ljava/lang/Object;JJ)J", |
|
52578 | 455 |
"sun/misc/Unsafe.getAndSet" + oopName + "(Ljava/lang/Object;JLjava/lang/Object;)Ljava/lang/Object;"); |
48190 | 456 |
|
457 |
if (isJDK9OrHigher()) { |
|
50858 | 458 |
if (!(arch instanceof AArch64)) { |
459 |
add(toBeInvestigated, |
|
460 |
"java/lang/StringLatin1.compareTo([B[B)I", |
|
461 |
"java/lang/StringLatin1.compareToUTF16([B[B)I", |
|
462 |
"java/lang/StringUTF16.compareTo([B[B)I", |
|
463 |
"java/lang/StringUTF16.compareToLatin1([B[B)I", |
|
464 |
"jdk/internal/misc/Unsafe.getAndAddInt(Ljava/lang/Object;JI)I", |
|
465 |
"jdk/internal/misc/Unsafe.getAndAddLong(Ljava/lang/Object;JJ)J", |
|
466 |
"jdk/internal/misc/Unsafe.getAndSetInt(Ljava/lang/Object;JI)I", |
|
467 |
"jdk/internal/misc/Unsafe.getAndSetLong(Ljava/lang/Object;JJ)J", |
|
52578 | 468 |
"jdk/internal/misc/Unsafe.getAndSet" + oopName + "(Ljava/lang/Object;JLjava/lang/Object;)Ljava/lang/Object;"); |
50858 | 469 |
} |
50609 | 470 |
add(toBeInvestigated, |
54084 | 471 |
"com/sun/crypto/provider/CounterMode.implCrypt([BII[BI)I", |
52956 | 472 |
"java/lang/Thread.onSpinWait()V", |
54084 | 473 |
"java/util/ArraysSupport.vectorizedMismatch(Ljava/lang/Object;JLjava/lang/Object;JII)I", |
48190 | 474 |
"jdk/internal/misc/Unsafe.getCharUnaligned(Ljava/lang/Object;J)C", |
475 |
"jdk/internal/misc/Unsafe.getIntUnaligned(Ljava/lang/Object;J)I", |
|
476 |
"jdk/internal/misc/Unsafe.getLongUnaligned(Ljava/lang/Object;J)J", |
|
477 |
"jdk/internal/misc/Unsafe.getShortUnaligned(Ljava/lang/Object;J)S", |
|
478 |
"jdk/internal/misc/Unsafe.putCharUnaligned(Ljava/lang/Object;JC)V", |
|
479 |
"jdk/internal/misc/Unsafe.putIntUnaligned(Ljava/lang/Object;JI)V", |
|
480 |
"jdk/internal/misc/Unsafe.putLongUnaligned(Ljava/lang/Object;JJ)V", |
|
481 |
"jdk/internal/misc/Unsafe.putShortUnaligned(Ljava/lang/Object;JS)V"); |
|
482 |
} |
|
54084 | 483 |
if (isJDK10OrHigher()) { |
484 |
add(toBeInvestigated, |
|
485 |
"jdk/internal/util/ArraysSupport.vectorizedMismatch(Ljava/lang/Object;JLjava/lang/Object;JII)I"); |
|
486 |
} |
|
48190 | 487 |
} |
488 |
||
489 |
/* |
|
490 |
* The intrinsics down here are known to be implemented but they are not always enabled on |
|
491 |
* the HotSpot side (e.g., because they require certain CPU features). So, we are ignoring |
|
492 |
* them if the HotSpot config tells us that they can't be used. |
|
493 |
*/ |
|
494 |
||
495 |
// CRC32 intrinsics |
|
43972 | 496 |
if (!config.useCRC32Intrinsics) { |
50609 | 497 |
add(ignore, "java/util/zip/CRC32.update(II)I"); |
48190 | 498 |
if (isJDK9OrHigher()) { |
50609 | 499 |
add(ignore, |
48190 | 500 |
"java/util/zip/CRC32.updateByteBuffer0(IJII)I", |
501 |
"java/util/zip/CRC32.updateBytes0(I[BII)I"); |
|
502 |
} else { |
|
50609 | 503 |
add(ignore, |
43972 | 504 |
"java/util/zip/CRC32.updateByteBuffer(IJII)I", |
505 |
"java/util/zip/CRC32.updateBytes(I[BII)I"); |
|
506 |
} |
|
507 |
} |
|
508 |
||
48398 | 509 |
// CRC32C intrinsics |
510 |
if (!config.useCRC32CIntrinsics) { |
|
50609 | 511 |
add(ignore, |
48398 | 512 |
"java/util/zip/CRC32C.updateBytes(I[BII)I", |
513 |
"java/util/zip/CRC32C.updateDirectByteBuffer(IJII)I"); |
|
514 |
} |
|
515 |
||
58877 | 516 |
String cbcEncryptName = HotSpotGraphBuilderPlugins.lookupIntrinsicName(config, "com/sun/crypto/provider/CipherBlockChaining", "implEncrypt", "encrypt"); |
517 |
String cbcDecryptName = HotSpotGraphBuilderPlugins.lookupIntrinsicName(config, "com/sun/crypto/provider/CipherBlockChaining", "implDecrypt", "decrypt"); |
|
518 |
String aesEncryptName = HotSpotGraphBuilderPlugins.lookupIntrinsicName(config, "com/sun/crypto/provider/AESCrypt", "implEncryptBlock", "encryptBlock"); |
|
519 |
String aesDecryptName = HotSpotGraphBuilderPlugins.lookupIntrinsicName(config, "com/sun/crypto/provider/AESCrypt", "implDecryptBlock", "decryptBlock"); |
|
57537 | 520 |
|
48190 | 521 |
// AES intrinsics |
43972 | 522 |
if (!config.useAESIntrinsics) { |
57537 | 523 |
add(ignore, |
59095 | 524 |
"com/sun/crypto/provider/AESCrypt." + aesDecryptName + "([BI[BI)V", |
58877 | 525 |
"com/sun/crypto/provider/AESCrypt." + aesEncryptName + "([BI[BI)V", |
57537 | 526 |
"com/sun/crypto/provider/CipherBlockChaining." + cbcDecryptName + "([BII[BI)I", |
527 |
"com/sun/crypto/provider/CipherBlockChaining." + cbcEncryptName + "([BII[BI)I"); |
|
48190 | 528 |
} |
529 |
||
530 |
// BigInteger intrinsics |
|
531 |
if (!config.useMultiplyToLenIntrinsic()) { |
|
532 |
if (isJDK9OrHigher()) { |
|
50609 | 533 |
add(ignore, "java/math/BigInteger.implMultiplyToLen([II[II[I)[I"); |
43972 | 534 |
} else { |
50609 | 535 |
add(ignore, "java/math/BigInteger.multiplyToLen([II[II[I)[I"); |
43972 | 536 |
} |
537 |
} |
|
48190 | 538 |
if (!config.useMulAddIntrinsic()) { |
50609 | 539 |
add(ignore, "java/math/BigInteger.implMulAdd([I[IIII)I"); |
48190 | 540 |
} |
541 |
if (!config.useMontgomeryMultiplyIntrinsic()) { |
|
50609 | 542 |
add(ignore, "java/math/BigInteger.implMontgomeryMultiply([I[I[IIJ[I)[I"); |
48190 | 543 |
} |
544 |
if (!config.useMontgomerySquareIntrinsic()) { |
|
50609 | 545 |
add(ignore, "java/math/BigInteger.implMontgomerySquare([I[IIJ[I)[I"); |
48190 | 546 |
} |
547 |
if (!config.useSquareToLenIntrinsic()) { |
|
50609 | 548 |
add(ignore, "java/math/BigInteger.implSquareToLen([II[II)[I"); |
48190 | 549 |
} |
58877 | 550 |
// DigestBase intrinsics |
551 |
if (HotSpotGraphBuilderPlugins.isIntrinsicName(config, "sun/security/provider/DigestBase", "implCompressMultiBlock0") && |
|
552 |
!(config.useSHA1Intrinsics() || config.useSHA256Intrinsics() || config.useSHA512Intrinsics())) { |
|
553 |
add(ignore, "sun/security/provider/DigestBase.implCompressMultiBlock0([BII)I"); |
|
554 |
} |
|
48190 | 555 |
// SHA intrinsics |
58877 | 556 |
String shaCompressName = HotSpotGraphBuilderPlugins.lookupIntrinsicName(config, "sun/security/provider/SHA", "implCompress0", "implCompress"); |
48190 | 557 |
if (!config.useSHA1Intrinsics()) { |
58877 | 558 |
add(ignore, "sun/security/provider/SHA." + shaCompressName + "([BI)V"); |
43972 | 559 |
} |
48190 | 560 |
if (!config.useSHA256Intrinsics()) { |
58877 | 561 |
add(ignore, "sun/security/provider/SHA2." + shaCompressName + "([BI)V"); |
48190 | 562 |
} |
563 |
if (!config.useSHA512Intrinsics()) { |
|
58877 | 564 |
add(ignore, "sun/security/provider/SHA5." + shaCompressName + "([BI)V"); |
48190 | 565 |
} |
566 |
} |
|
567 |
||
568 |
private static boolean isJDK9OrHigher() { |
|
55509 | 569 |
return JavaVersionUtil.JAVA_SPEC >= 9; |
43972 | 570 |
} |
571 |
||
48861 | 572 |
private static boolean isJDK10OrHigher() { |
55509 | 573 |
return JavaVersionUtil.JAVA_SPEC >= 10; |
48861 | 574 |
} |
575 |
||
50330 | 576 |
private static boolean isJDK11OrHigher() { |
55509 | 577 |
return JavaVersionUtil.JAVA_SPEC >= 11; |
50330 | 578 |
} |
579 |
||
52578 | 580 |
private static boolean isJDK12OrHigher() { |
55509 | 581 |
return JavaVersionUtil.JAVA_SPEC >= 12; |
52578 | 582 |
} |
583 |
||
53081
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
584 |
private static boolean isJDK13OrHigher() { |
55509 | 585 |
return JavaVersionUtil.JAVA_SPEC >= 13; |
53081
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
586 |
} |
3791fee4df3b
8215687: [Graal] unit test CheckGraalIntrinsics failed after 8212043
kvn
parents:
53000
diff
changeset
|
587 |
|
57831
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
588 |
private static boolean isJDK14OrHigher() { |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
589 |
return JavaVersionUtil.JAVA_SPEC >= 14; |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
590 |
} |
d41c18a68257
8229848: [Graal] missing Graal intrinsics for Electronic Code Book (ECB) encryption
kvn
parents:
57804
diff
changeset
|
591 |
|
50609 | 592 |
public interface Refiner { |
593 |
void refine(CheckGraalIntrinsics checker); |
|
43972 | 594 |
} |
595 |
||
596 |
@Test |
|
597 |
@SuppressWarnings("try") |
|
598 |
public void test() throws ClassNotFoundException { |
|
599 |
HotSpotProviders providers = rt.getHostBackend().getProviders(); |
|
600 |
Plugins graphBuilderPlugins = providers.getGraphBuilderPlugins(); |
|
601 |
InvocationPlugins invocationPlugins = graphBuilderPlugins.getInvocationPlugins(); |
|
602 |
||
50609 | 603 |
HotSpotVMConfigStore store = config.getStore(); |
43972 | 604 |
List<VMIntrinsicMethod> intrinsics = store.getIntrinsics(); |
605 |
||
50609 | 606 |
for (Refiner refiner : ServiceLoader.load(Refiner.class)) { |
607 |
refiner.refine(this); |
|
608 |
} |
|
609 |
||
43972 | 610 |
List<String> missing = new ArrayList<>(); |
50609 | 611 |
List<String> mischaracterizedAsToBeInvestigated = new ArrayList<>(); |
612 |
List<String> mischaracterizedAsIgnored = new ArrayList<>(); |
|
46459 | 613 |
EconomicMap<String, List<Binding>> bindings = invocationPlugins.getBindings(true); |
43972 | 614 |
for (VMIntrinsicMethod intrinsic : intrinsics) { |
46459 | 615 |
InvocationPlugin plugin = findPlugin(bindings, intrinsic); |
50609 | 616 |
String m = String.format("%s.%s%s", intrinsic.declaringClass, intrinsic.name, intrinsic.descriptor); |
46459 | 617 |
if (plugin == null) { |
618 |
ResolvedJavaMethod method = resolveIntrinsic(providers.getMetaAccess(), intrinsic); |
|
43972 | 619 |
if (method != null) { |
46459 | 620 |
IntrinsicMethod intrinsicMethod = providers.getConstantReflection().getMethodHandleAccess().lookupMethodHandleIntrinsic(method); |
43972 | 621 |
if (intrinsicMethod != null) { |
622 |
continue; |
|
623 |
} |
|
624 |
} |
|
50609 | 625 |
if (!toBeInvestigated.contains(m) && !ignore.contains(m) && !complexGuard.contains(m) && !downstream.contains(m)) { |
43972 | 626 |
missing.add(m); |
627 |
} |
|
50609 | 628 |
} else { |
629 |
if (toBeInvestigated.contains(m)) { |
|
630 |
mischaracterizedAsToBeInvestigated.add(m); |
|
631 |
} else if (ignore.contains(m)) { |
|
632 |
mischaracterizedAsIgnored.add(m); |
|
633 |
} |
|
43972 | 634 |
} |
635 |
} |
|
636 |
||
50609 | 637 |
Formatter errorMsgBuf = new Formatter(); |
43972 | 638 |
if (!missing.isEmpty()) { |
639 |
Collections.sort(missing); |
|
640 |
String missingString = missing.stream().collect(Collectors.joining(String.format("%n "))); |
|
50609 | 641 |
errorMsgBuf.format("missing Graal intrinsics for:%n %s%n", missingString); |
642 |
} |
|
643 |
if (!mischaracterizedAsToBeInvestigated.isEmpty()) { |
|
644 |
Collections.sort(mischaracterizedAsToBeInvestigated); |
|
645 |
String missingString = mischaracterizedAsToBeInvestigated.stream().collect(Collectors.joining(String.format("%n "))); |
|
646 |
errorMsgBuf.format("found plugins for intrinsics characterized as toBeInvestigated:%n %s%n", missingString); |
|
647 |
} |
|
648 |
if (!mischaracterizedAsIgnored.isEmpty()) { |
|
649 |
Collections.sort(mischaracterizedAsIgnored); |
|
650 |
String missingString = mischaracterizedAsIgnored.stream().collect(Collectors.joining(String.format("%n "))); |
|
651 |
errorMsgBuf.format("found plugins for intrinsics characterized as IGNORED:%n %s%n", missingString); |
|
652 |
} |
|
653 |
String errorMsg = errorMsgBuf.toString(); |
|
654 |
if (!errorMsg.isEmpty()) { |
|
655 |
fail(errorMsg); |
|
43972 | 656 |
} |
657 |
} |
|
658 |
} |