8012292: optimized build with GCC broken
Summary: Some #ifndef PRODUCT should be #ifdef ASSERT
Reviewed-by: kvn, twisti
Contributed-by: gdub <duboscq@ssw.jku.at>
--- a/hotspot/make/jprt.properties Fri May 03 09:32:50 2013 +0200
+++ b/hotspot/make/jprt.properties Wed Apr 24 14:26:09 2013 +0200
@@ -134,14 +134,14 @@
jprt.build.targets.standard= \
${jprt.my.solaris.sparc}-{product|fastdebug}, \
- ${jprt.my.solaris.sparcv9}-{product|fastdebug}, \
+ ${jprt.my.solaris.sparcv9}-{product|fastdebug|optimized}, \
${jprt.my.solaris.i586}-{product|fastdebug}, \
${jprt.my.solaris.x64}-{product|fastdebug}, \
${jprt.my.linux.i586}-{product|fastdebug}, \
- ${jprt.my.linux.x64}-{product|fastdebug}, \
+ ${jprt.my.linux.x64}-{product|fastdebug|optimized}, \
${jprt.my.macosx.x64}-{product|fastdebug}, \
${jprt.my.windows.i586}-{product|fastdebug}, \
- ${jprt.my.windows.x64}-{product|fastdebug}, \
+ ${jprt.my.windows.x64}-{product|fastdebug|optimized}, \
${jprt.my.linux.armvh}-{product|fastdebug}
jprt.build.targets.open= \
--- a/hotspot/src/share/vm/classfile/classFileParser.cpp Fri May 03 09:32:50 2013 +0200
+++ b/hotspot/src/share/vm/classfile/classFileParser.cpp Wed Apr 24 14:26:09 2013 +0200
@@ -3046,7 +3046,7 @@
}
-#ifndef PRODUCT
+#ifdef ASSERT
static void parseAndPrintGenericSignatures(
instanceKlassHandle this_klass, TRAPS) {
assert(ParseAllGenericSignatures == true, "Shouldn't call otherwise");
@@ -3071,7 +3071,7 @@
}
}
}
-#endif // ndef PRODUCT
+#endif // def ASSERT
instanceKlassHandle ClassFileParser::parse_super_class(int super_class_index,
--- a/hotspot/src/share/vm/classfile/vmSymbols.cpp Fri May 03 09:32:50 2013 +0200
+++ b/hotspot/src/share/vm/classfile/vmSymbols.cpp Wed Apr 24 14:26:09 2013 +0200
@@ -49,7 +49,7 @@
}
}
-#ifndef PRODUCT
+#ifdef ASSERT
#define VM_SYMBOL_ENUM_NAME_BODY(name, string) #name "\0"
static const char* vm_symbol_enum_names =
VM_SYMBOLS_DO(VM_SYMBOL_ENUM_NAME_BODY, VM_ALIAS_IGNORE)
@@ -64,7 +64,7 @@
}
return string;
}
-#endif //PRODUCT
+#endif //ASSERT
// Put all the VM symbol strings in one place.
// Makes for a more compact libjvm.
--- a/hotspot/src/share/vm/opto/runtime.cpp Fri May 03 09:32:50 2013 +0200
+++ b/hotspot/src/share/vm/opto/runtime.cpp Wed Apr 24 14:26:09 2013 +0200
@@ -126,17 +126,15 @@
// This should be called in an assertion at the start of OptoRuntime routines
// which are entered from compiled code (all of them)
-#ifndef PRODUCT
+#ifdef ASSERT
static bool check_compiled_frame(JavaThread* thread) {
assert(thread->last_frame().is_runtime_frame(), "cannot call runtime directly from compiled code");
-#ifdef ASSERT
RegisterMap map(thread, false);
frame caller = thread->last_frame().sender(&map);
assert(caller.is_compiled_frame(), "not being called from compiled like code");
-#endif /* ASSERT */
return true;
}
-#endif
+#endif // ASSERT
#define gen(env, var, type_func_gen, c_func, fancy_jump, pass_tls, save_arg_regs, return_pc) \
--- a/hotspot/src/share/vm/utilities/quickSort.cpp Fri May 03 09:32:50 2013 +0200
+++ b/hotspot/src/share/vm/utilities/quickSort.cpp Wed Apr 24 14:26:09 2013 +0200
@@ -32,6 +32,7 @@
#include "utilities/quickSort.hpp"
#include <stdlib.h>
+#ifdef ASSERT
static int test_comparator(int a, int b) {
if (a == b) {
return 0;
@@ -41,6 +42,7 @@
}
return 1;
}
+#endif // ASSERT
static int test_even_odd_comparator(int a, int b) {
bool a_is_odd = (a % 2) == 1;