7097771: setEnabled does not work for components in disabled containers.
Reviewed-by: art, anthony
--- a/jdk/src/solaris/classes/sun/awt/X11/XComponentPeer.java Tue Apr 10 19:09:48 2012 +0300
+++ b/jdk/src/solaris/classes/sun/awt/X11/XComponentPeer.java Tue Apr 10 22:09:58 2012 +0400
@@ -82,7 +82,7 @@
boolean paintPending = false;
boolean isLayouting = false;
- boolean enabled;
+ private boolean enabled;
// Actually used only by XDecoratedPeer
protected int boundsOperation;
@@ -128,9 +128,6 @@
}
void postInit(XCreateWindowParams params) {
super.postInit(params);
- Color c;
- Font f;
- Cursor cursor;
pSetCursor(target.getCursor());
@@ -143,19 +140,7 @@
reshape(r.x, r.y, r.width, r.height);
}
- enabled = target.isEnabled();
-
- // If any of our heavyweight ancestors are disable, we should be too
- // See 6176875 for more information
- Component comp = target;
- while( !(comp == null || comp instanceof Window) ) {
- comp = comp.getParent();
- if( comp != null && !comp.isEnabled() && !comp.isLightweight() ){
- setEnabled(false);
- break;
- }
- }
- enableLog.fine("Initial enable state: {0}", Boolean.valueOf(enabled));
+ setEnabled(target.isEnabled());
if (target.isVisible()) {
setVisible(true);
@@ -384,45 +369,48 @@
setVisible(false);
}
-
/**
* @see java.awt.peer.ComponentPeer
*/
- public void setEnabled(boolean value) {
- enableLog.fine("{0}ing {1}", (value?"Enabl":"Disabl"), this);
- boolean repaintNeeded = (enabled != value);
- enabled = value;
+ public void setEnabled(final boolean value) {
+ if (enableLog.isLoggable(PlatformLogger.FINE)) {
+ enableLog.fine("{0}ing {1}", (value ? "Enabl" : "Disabl"), this);
+ }
+ boolean status = value;
+ // If any of our heavyweight ancestors are disable, we should be too
+ // See 6176875 for more information
+ final Container cp = SunToolkit.getNativeContainer(target);
+ if (cp != null) {
+ status &= ((XComponentPeer) cp.getPeer()).isEnabled();
+ }
+ synchronized (getStateLock()) {
+ if (enabled == status) {
+ return;
+ }
+ enabled = status;
+ }
+
if (target instanceof Container) {
- Component list[] = ((Container)target).getComponents();
- for (int i = 0; i < list.length; ++i) {
- boolean childEnabled = list[i].isEnabled();
- ComponentPeer p = list[i].getPeer();
- if ( p != null ) {
- p.setEnabled(value && childEnabled);
+ final Component[] list = ((Container) target).getComponents();
+ for (final Component child : list) {
+ final ComponentPeer p = child.getPeer();
+ if (p != null) {
+ p.setEnabled(status && child.isEnabled());
}
}
}
- if (repaintNeeded) {
- repaint();
- }
+ repaint();
}
//
// public so aw/Window can call it
//
- public boolean isEnabled() {
- return enabled;
+ public final boolean isEnabled() {
+ synchronized (getStateLock()) {
+ return enabled;
+ }
}
-
-
- public void enable() {
- setEnabled(true);
- }
-
- public void disable() {
- setEnabled(false);
- }
@Override
public void paint(final Graphics g) {
super.paint(g);
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/java/awt/Component/7097771/bug7097771.java Tue Apr 10 22:09:58 2012 +0400
@@ -0,0 +1,81 @@
+/*
+ * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+import sun.awt.SunToolkit;
+import test.java.awt.regtesthelpers.Util;
+
+import java.awt.AWTException;
+import java.awt.Button;
+import java.awt.Frame;
+import java.awt.Robot;
+import java.awt.Toolkit;
+import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
+
+/*
+ @test
+ @bug 7097771
+ @summary setEnabled does not work for components in disabled containers.
+ @author sergey.bylokhov@oracle.com: area=awt.component
+ @library ../../regtesthelpers
+ @build Util
+ @run main bug7097771
+*/
+public final class bug7097771 extends Frame implements ActionListener {
+
+ private static volatile boolean action;
+
+ public static void main(final String[] args) throws AWTException {
+ final bug7097771 frame = new bug7097771();
+ frame.setSize(300, 300);
+ frame.setLocationRelativeTo(null);
+ final Button button = new Button();
+ button.addActionListener(frame);
+ frame.add(button);
+ frame.setVisible(true);
+ sleep();
+ frame.setEnabled(false);
+ button.setEnabled(false);
+ button.setEnabled(true);
+ sleep();
+ Util.clickOnComp(button, new Robot());
+ sleep();
+ frame.dispose();
+ if (action) {
+ throw new RuntimeException("Button is not disabled.");
+ }
+ }
+
+ @Override
+ public void actionPerformed(final ActionEvent e) {
+ action = true;
+ }
+
+ private static void sleep() {
+ ((SunToolkit) Toolkit.getDefaultToolkit()).realSync();
+ try {
+ Thread.sleep(1000);
+ } catch (InterruptedException ignored) {
+ }
+ }
+}