http-client-branch: review comment - several tests should be setting NO_PROXY when testing without proxy
--- a/test/jdk/java/net/httpclient/InvalidInputStreamSubscriptionRequest.java Fri Apr 13 14:59:22 2018 +0100
+++ b/test/jdk/java/net/httpclient/InvalidInputStreamSubscriptionRequest.java Fri Apr 13 15:06:50 2018 +0100
@@ -202,6 +202,7 @@
HttpClient newHttpClient() {
return HttpClient.newBuilder()
+ .proxy(HttpClient.Builder.NO_PROXY)
.executor(executor)
.sslContext(sslContext)
.build();
--- a/test/jdk/java/net/httpclient/InvalidSubscriptionRequest.java Fri Apr 13 14:59:22 2018 +0100
+++ b/test/jdk/java/net/httpclient/InvalidSubscriptionRequest.java Fri Apr 13 15:06:50 2018 +0100
@@ -146,6 +146,7 @@
HttpClient newHttpClient() {
return HttpClient.newBuilder()
+ .proxy(HttpClient.Builder.NO_PROXY)
.executor(executor)
.sslContext(sslContext)
.build();
--- a/test/jdk/java/net/httpclient/ThrowingPublishers.java Fri Apr 13 14:59:22 2018 +0100
+++ b/test/jdk/java/net/httpclient/ThrowingPublishers.java Fri Apr 13 15:06:50 2018 +0100
@@ -223,6 +223,7 @@
private HttpClient makeNewClient() {
clientCount.incrementAndGet();
return TRACKER.track(HttpClient.newBuilder()
+ .proxy(HttpClient.Builder.NO_PROXY)
.executor(executor)
.sslContext(sslContext)
.build());
--- a/test/jdk/java/net/httpclient/ThrowingPushPromises.java Fri Apr 13 14:59:22 2018 +0100
+++ b/test/jdk/java/net/httpclient/ThrowingPushPromises.java Fri Apr 13 15:06:50 2018 +0100
@@ -205,6 +205,7 @@
private HttpClient makeNewClient() {
clientCount.incrementAndGet();
return TRACKER.track(HttpClient.newBuilder()
+ .proxy(HttpClient.Builder.NO_PROXY)
.executor(executor)
.sslContext(sslContext)
.build());
--- a/test/jdk/java/net/httpclient/ThrowingSubscribers.java Fri Apr 13 14:59:22 2018 +0100
+++ b/test/jdk/java/net/httpclient/ThrowingSubscribers.java Fri Apr 13 15:06:50 2018 +0100
@@ -214,6 +214,7 @@
private HttpClient makeNewClient() {
clientCount.incrementAndGet();
HttpClient client = HttpClient.newBuilder()
+ .proxy(HttpClient.Builder.NO_PROXY)
.executor(executor)
.sslContext(sslContext)
.build();