8012933: Test closed/java/awt/Dialog/DialogAnotherThread/JaWSTest.java fails since jdk 7u25 b07
Summary: Do not mark context as disposed until we've posted all the events
Reviewed-by: art
--- a/jdk/src/share/classes/sun/awt/AppContext.java Thu May 02 11:42:44 2013 -0400
+++ b/jdk/src/share/classes/sun/awt/AppContext.java Mon May 06 16:12:55 2013 +0400
@@ -190,10 +190,16 @@
public static final String DISPOSED_PROPERTY_NAME = "disposed";
public static final String GUI_DISPOSED = "guidisposed";
- private volatile boolean isDisposed = false; // true if AppContext is disposed
+ private enum State {
+ VALID,
+ BEING_DISPOSED,
+ DISPOSED
+ };
+
+ private volatile State state = State.VALID;
public boolean isDisposed() {
- return isDisposed;
+ return state == State.DISPOSED;
}
/*
@@ -393,10 +399,11 @@
}
synchronized(this) {
- if (this.isDisposed) {
- return; // If already disposed, bail.
+ if (this.state != State.VALID) {
+ return; // If already disposed or being disposed, bail.
}
- this.isDisposed = true;
+
+ this.state = State.BEING_DISPOSED;
}
final PropertyChangeSupport changeSupport = this.changeSupport;
@@ -466,6 +473,11 @@
} catch (InterruptedException e) { }
}
+ // We are done with posting events, so change the state to disposed
+ synchronized(this) {
+ this.state = State.DISPOSED;
+ }
+
// Next, we interrupt all Threads in the ThreadGroup
this.threadGroup.interrupt();
// Note, the EventDispatchThread we've interrupted may dump an
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/sun/awt/AppContext/8012933/Test8012933.java Mon May 06 16:12:55 2013 +0400
@@ -0,0 +1,92 @@
+/*
+ * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8012933
+ * @summary Tests (although somewhat indirectly) that createNewAppContext()
+ * immediately followed by dispose() works correctly
+ * @author Leonid Romanov
+ */
+
+import sun.awt.SunToolkit;
+import sun.awt.AppContext;
+
+public class Test8012933 {
+ private AppContext appContext = null;
+ final ThreadGroup threadGroup = new ThreadGroup("test thread group");
+ final Object lock = new Object();
+ boolean isCreated = false;
+
+ public static void main(String[] args) throws Exception {
+ SunToolkit.createNewAppContext();
+ new Test8012933().test();
+ }
+
+ private void test() throws Exception {
+ createAppContext();
+ long startTime = System.currentTimeMillis();
+ appContext.dispose();
+ long endTime = System.currentTimeMillis();
+
+ // In case of the bug, calling dispose() when there is no EQ
+ // dispatch thread running fails to create it, so it takes
+ // almost 10 sec to return from dispose(), which is spent
+ // waiting on the notificationLock.
+ if ((endTime - startTime) > 9000) {
+ throw new RuntimeException("Returning from dispose() took too much time, probably a bug");
+ }
+ }
+
+ private void createAppContext() {
+ isCreated = false;
+ final Runnable runnable = new Runnable() {
+ public void run() {
+ appContext = SunToolkit.createNewAppContext();
+ synchronized (lock) {
+ isCreated = true;
+ lock.notifyAll();
+ }
+ }
+ };
+
+ final Thread thread = new Thread(threadGroup, runnable, "creates app context");
+ synchronized (lock) {
+ thread.start();
+ while (!isCreated) {
+ try {
+ lock.wait();
+ } catch (InterruptedException ie) {
+ ie.printStackTrace();
+ }
+ }
+ }
+
+ if (appContext == null) {
+ throw new RuntimeException("failed to create app context.");
+ } else {
+ System.out.println("app context was created.");
+ }
+ }
+
+}