8167281: IIOMetadataNode bugs in getElementsByTagName and NodeList.item methods
Reviewed-by: prr, pnarayanan
--- a/jdk/src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadataNode.java Mon Oct 17 10:14:38 2016 +0300
+++ b/jdk/src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadataNode.java Mon Oct 17 13:04:33 2016 +0530
@@ -122,7 +122,7 @@
}
public Node item(int index) {
- if (index < 0 || index > nodes.size()) {
+ if (index < 0 || index >= nodes.size()) {
return null;
}
return nodes.get(index);
@@ -882,7 +882,7 @@
}
private void getElementsByTagName(String name, List<Node> l) {
- if (nodeName.equals(name)) {
+ if (nodeName.equals(name) || "*".equals(name)) {
l.add(this);
}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/javax/imageio/metadata/GetElementsByTagNameTest.java Mon Oct 17 13:04:33 2016 +0530
@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8167281
+ * @summary Test verifies that Element.getElementsByTagName("*") is not empty
+ * for valid image.
+ * @run main GetElementsByTagNameTest
+ */
+
+import java.awt.image.BufferedImage;
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import javax.imageio.ImageIO;
+import javax.imageio.ImageReader;
+import javax.imageio.metadata.IIOMetadata;
+import javax.imageio.metadata.IIOMetadataFormatImpl;
+import javax.imageio.stream.ImageInputStream;
+import javax.imageio.stream.MemoryCacheImageInputStream;
+import org.w3c.dom.Element;
+
+public class GetElementsByTagNameTest {
+
+ public static void main(String[] args) throws IOException {
+ // Generate some trivial image and save it to a temporary array
+ ByteArrayOutputStream tmp = new ByteArrayOutputStream();
+ ImageIO.write(new BufferedImage(1, 1, BufferedImage.TYPE_INT_RGB),
+ "gif", tmp);
+
+ // Read the stream
+ ImageInputStream in = new MemoryCacheImageInputStream(
+ new ByteArrayInputStream(tmp.toByteArray()));
+ ImageReader reader = ImageIO.getImageReaders(in).next();
+ reader.setInput(in);
+
+ // Retrieve standard image metadata tree
+ IIOMetadata meta = reader.getImageMetadata(0);
+ if (meta == null || !meta.isStandardMetadataFormatSupported()) {
+ throw new Error("Test failure: Missing metadata");
+ }
+ Element root = (Element) meta.
+ getAsTree(IIOMetadataFormatImpl.standardMetadataFormatName);
+
+ // Test getElementsByTagName("*")
+ if (root.getElementsByTagName("*").getLength() == 0) {
+ throw new RuntimeException("getElementsByTagName(\"*\") returns"
+ + " nothing");
+ }
+ }
+}
+
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/javax/imageio/metadata/NthItemNodeListTest.java Mon Oct 17 13:04:33 2016 +0530
@@ -0,0 +1,77 @@
+/*
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8167281
+ * @summary Test verifies that accessing nth item in NodeList doesn't throw
+ * IndexOutOfBoundsException.
+ * @run main NthItemNodeListTest
+ */
+
+import java.awt.image.BufferedImage;
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import javax.imageio.ImageIO;
+import javax.imageio.ImageReader;
+import javax.imageio.metadata.IIOMetadata;
+import javax.imageio.metadata.IIOMetadataFormatImpl;
+import javax.imageio.stream.ImageInputStream;
+import javax.imageio.stream.MemoryCacheImageInputStream;
+import org.w3c.dom.Element;
+import org.w3c.dom.Node;
+import org.w3c.dom.NodeList;
+
+public class NthItemNodeListTest {
+
+ public static void main(String[] args) throws IOException {
+ // Generate some trivial image and save it to a temporary array
+ ByteArrayOutputStream tmp = new ByteArrayOutputStream();
+ ImageIO.write(new BufferedImage(1, 1, BufferedImage.TYPE_INT_RGB),
+ "gif", tmp);
+
+ // Read it back in
+ ImageInputStream in = new MemoryCacheImageInputStream(
+ new ByteArrayInputStream(tmp.toByteArray()));
+ ImageReader reader = ImageIO.getImageReaders(in).next();
+ reader.setInput(in);
+
+ // Retrieve standard image metadata tree
+ IIOMetadata meta = reader.getImageMetadata(0);
+ if (meta == null || !meta.isStandardMetadataFormatSupported()) {
+ throw new Error("Test failure: Missing metadata");
+ }
+ Element root = (Element) meta.
+ getAsTree(IIOMetadataFormatImpl.standardMetadataFormatName);
+
+ NodeList nodeList = root.
+ getElementsByTagName(root.getFirstChild().getNodeName());
+ /*
+ * Accessing the nth node should return null and not throw
+ * IndexOutOfBoundsException.
+ */
+ Node n = (nodeList.item(nodeList.getLength()));
+ }
+}
+