8219685: Startup failure: assert(!Universe::is_module_initialized()) failed: Incorrect java.lang.Module pre module system initialization
Reviewed-by: lfoltan, redestad
--- a/src/hotspot/share/classfile/javaClasses.cpp Fri Mar 08 17:45:40 2019 -0500
+++ b/src/hotspot/share/classfile/javaClasses.cpp Sun Mar 10 18:53:55 2019 -0400
@@ -834,8 +834,8 @@
if (module.is_null()) {
// During startup, the module may be NULL only if java.base has not been defined yet.
// Put the class on the fixup_module_list to patch later when the java.lang.Module
- // for java.base is known.
- assert(!Universe::is_module_initialized(), "Incorrect java.lang.Module pre module system initialization");
+ // for java.base is known. But note that since we captured the NULL module another
+ // thread may have completed that initialization.
bool javabase_was_defined = false;
{