--- a/src/hotspot/os/aix/os_aix.cpp Tue Jul 16 16:01:10 2019 +0200
+++ b/src/hotspot/os/aix/os_aix.cpp Wed Jul 17 15:40:27 2019 +0200
@@ -487,8 +487,7 @@
if (::shmctl(shmid, SHM_PAGESIZE, &shm_buf) != 0) {
const int en = errno;
::shmctl(shmid, IPC_RMID, NULL); // As early as possible!
- trcVerbose("shmctl(SHM_PAGESIZE) failed with errno=%n",
- errno);
+ trcVerbose("shmctl(SHM_PAGESIZE) failed with errno=%d", errno);
} else {
// Attach and double check pageisze.
void* p = ::shmat(shmid, NULL, 0);
@@ -496,7 +495,7 @@
guarantee0(p != (void*) -1); // Should always work.
const size_t real_pagesize = os::Aix::query_pagesize(p);
if (real_pagesize != pagesize) {
- trcVerbose("real page size (0x%llX) differs.", real_pagesize);
+ trcVerbose("real page size (" SIZE_FORMAT_HEX ") differs.", real_pagesize);
} else {
can_use = true;
}
@@ -1888,12 +1887,12 @@
if (!contains_range(p, s)) {
trcVerbose("[" PTR_FORMAT " - " PTR_FORMAT "] is not a sub "
"range of [" PTR_FORMAT " - " PTR_FORMAT "].",
- p, p + s, addr, addr + size);
+ p2i(p), p2i(p + s), p2i(addr), p2i(addr + size));
guarantee0(false);
}
if (!is_aligned_to(p, pagesize) || !is_aligned_to(p + s, pagesize)) {
trcVerbose("range [" PTR_FORMAT " - " PTR_FORMAT "] is not"
- " aligned to pagesize (%lu)", p, p + s, (unsigned long) pagesize);
+ " aligned to pagesize (%lu)", p2i(p), p2i(p + s), (unsigned long) pagesize);
guarantee0(false);
}
}
@@ -1964,7 +1963,7 @@
trcVerbose("reserve_shmated_memory " UINTX_FORMAT " bytes, wishaddress "
PTR_FORMAT ", alignment_hint " UINTX_FORMAT "...",
- bytes, requested_addr, alignment_hint);
+ bytes, p2i(requested_addr), alignment_hint);
// Either give me wish address or wish alignment but not both.
assert0(!(requested_addr != NULL && alignment_hint != 0));
@@ -1973,7 +1972,7 @@
// BRK because that may cause malloc OOM.
if (requested_addr != NULL && is_close_to_brk((address)requested_addr)) {
trcVerbose("Wish address " PTR_FORMAT " is too close to the BRK segment. "
- "Will attach anywhere.", requested_addr);
+ "Will attach anywhere.", p2i(requested_addr));
// Act like the OS refused to attach there.
requested_addr = NULL;
}
@@ -2025,7 +2024,7 @@
// Handle shmat error. If we failed to attach, just return.
if (addr == (char*)-1) {
- trcVerbose("Failed to attach segment at " PTR_FORMAT " (%d).", requested_addr, errno_shmat);
+ trcVerbose("Failed to attach segment at " PTR_FORMAT " (%d).", p2i(requested_addr), errno_shmat);
return NULL;
}
@@ -2033,15 +2032,15 @@
// work (see above), the system may have given us something other then 4K (LDR_CNTRL).
const size_t real_pagesize = os::Aix::query_pagesize(addr);
if (real_pagesize != shmbuf.shm_pagesize) {
- trcVerbose("pagesize is, surprisingly, %h.", real_pagesize);
+ trcVerbose("pagesize is, surprisingly, " SIZE_FORMAT, real_pagesize);
}
if (addr) {
trcVerbose("shm-allocated " PTR_FORMAT " .. " PTR_FORMAT " (" UINTX_FORMAT " bytes, " UINTX_FORMAT " %s pages)",
- addr, addr + size - 1, size, size/real_pagesize, describe_pagesize(real_pagesize));
+ p2i(addr), p2i(addr + size - 1), size, size/real_pagesize, describe_pagesize(real_pagesize));
} else {
if (requested_addr != NULL) {
- trcVerbose("failed to shm-allocate " UINTX_FORMAT " bytes at with address " PTR_FORMAT ".", size, requested_addr);
+ trcVerbose("failed to shm-allocate " UINTX_FORMAT " bytes at with address " PTR_FORMAT ".", size, p2i(requested_addr));
} else {
trcVerbose("failed to shm-allocate " UINTX_FORMAT " bytes at any address.", size);
}
@@ -2057,7 +2056,7 @@
static bool release_shmated_memory(char* addr, size_t size) {
trcVerbose("release_shmated_memory [" PTR_FORMAT " - " PTR_FORMAT "].",
- addr, addr + size - 1);
+ p2i(addr), p2i(addr + size - 1));
bool rc = false;
@@ -2073,12 +2072,12 @@
static bool uncommit_shmated_memory(char* addr, size_t size) {
trcVerbose("uncommit_shmated_memory [" PTR_FORMAT " - " PTR_FORMAT "].",
- addr, addr + size - 1);
+ p2i(addr), p2i(addr + size - 1));
const bool rc = my_disclaim64(addr, size);
if (!rc) {
- trcVerbose("my_disclaim64(" PTR_FORMAT ", " UINTX_FORMAT ") failed.\n", addr, size);
+ trcVerbose("my_disclaim64(" PTR_FORMAT ", " UINTX_FORMAT ") failed.\n", p2i(addr), size);
return false;
}
return true;
@@ -2095,11 +2094,11 @@
static char* reserve_mmaped_memory(size_t bytes, char* requested_addr, size_t alignment_hint) {
trcVerbose("reserve_mmaped_memory " UINTX_FORMAT " bytes, wishaddress " PTR_FORMAT ", "
"alignment_hint " UINTX_FORMAT "...",
- bytes, requested_addr, alignment_hint);
+ bytes, p2i(requested_addr), alignment_hint);
// If a wish address is given, but not aligned to 4K page boundary, mmap will fail.
if (requested_addr && !is_aligned_to(requested_addr, os::vm_page_size()) != 0) {
- trcVerbose("Wish address " PTR_FORMAT " not aligned to page boundary.", requested_addr);
+ trcVerbose("Wish address " PTR_FORMAT " not aligned to page boundary.", p2i(requested_addr));
return NULL;
}
@@ -2107,7 +2106,7 @@
// BRK because that may cause malloc OOM.
if (requested_addr != NULL && is_close_to_brk((address)requested_addr)) {
trcVerbose("Wish address " PTR_FORMAT " is too close to the BRK segment. "
- "Will attach anywhere.", requested_addr);
+ "Will attach anywhere.", p2i(requested_addr));
// Act like the OS refused to attach there.
requested_addr = NULL;
}
@@ -2154,7 +2153,7 @@
PROT_READ|PROT_WRITE|PROT_EXEC, flags, -1, 0);
if (addr == MAP_FAILED) {
- trcVerbose("mmap(" PTR_FORMAT ", " UINTX_FORMAT ", ..) failed (%d)", requested_addr, size, errno);
+ trcVerbose("mmap(" PTR_FORMAT ", " UINTX_FORMAT ", ..) failed (%d)", p2i(requested_addr), size, errno);
return NULL;
}
@@ -2173,10 +2172,10 @@
if (addr) {
trcVerbose("mmap-allocated " PTR_FORMAT " .. " PTR_FORMAT " (" UINTX_FORMAT " bytes)",
- addr, addr + bytes, bytes);
+ p2i(addr), p2i(addr + bytes), bytes);
} else {
if (requested_addr != NULL) {
- trcVerbose("failed to mmap-allocate " UINTX_FORMAT " bytes at wish address " PTR_FORMAT ".", bytes, requested_addr);
+ trcVerbose("failed to mmap-allocate " UINTX_FORMAT " bytes at wish address " PTR_FORMAT ".", bytes, p2i(requested_addr));
} else {
trcVerbose("failed to mmap-allocate " UINTX_FORMAT " bytes at any address.", bytes);
}
@@ -2196,7 +2195,7 @@
assert0(is_aligned_to(size, os::vm_page_size()));
trcVerbose("release_mmaped_memory [" PTR_FORMAT " - " PTR_FORMAT "].",
- addr, addr + size - 1);
+ p2i(addr), p2i(addr + size - 1));
bool rc = false;
if (::munmap(addr, size) != 0) {
@@ -2216,7 +2215,7 @@
assert0(is_aligned_to(size, os::vm_page_size()));
trcVerbose("uncommit_mmaped_memory [" PTR_FORMAT " - " PTR_FORMAT "].",
- addr, addr + size - 1);
+ p2i(addr), p2i(addr + size - 1));
bool rc = false;
// Uncommit mmap memory with msync MS_INVALIDATE.
@@ -2247,7 +2246,7 @@
static void warn_fail_commit_memory(char* addr, size_t size, bool exec,
int err) {
warning("INFO: os::commit_memory(" PTR_FORMAT ", " SIZE_FORMAT
- ", %d) failed; error='%s' (errno=%d)", addr, size, exec,
+ ", %d) failed; error='%s' (errno=%d)", p2i(addr), size, exec,
os::errno_name(err), err);
}
#endif
@@ -2275,7 +2274,7 @@
guarantee0(vmi);
vmi->assert_is_valid_subrange(addr, size);
- trcVerbose("commit_memory [" PTR_FORMAT " - " PTR_FORMAT "].", addr, addr + size - 1);
+ trcVerbose("commit_memory [" PTR_FORMAT " - " PTR_FORMAT "].", p2i(addr), p2i(addr + size - 1));
if (UseExplicitCommit) {
// AIX commits memory on touch. So, touch all pages to be committed.