8146653: Debug version missing in hs_err files and on internal version after Verona
Reviewed-by: dcubed, dholmes
--- a/hotspot/src/share/vm/runtime/vm_version.cpp Thu Jan 14 20:57:31 2016 -0800
+++ b/hotspot/src/share/vm/runtime/vm_version.cpp Tue Jan 19 18:39:23 2016 -0800
@@ -238,9 +238,14 @@
#define FLOAT_ARCH_STR XSTR(FLOAT_ARCH)
#endif
- return VMNAME " (" VM_RELEASE ") for " OS "-" CPU FLOAT_ARCH_STR
- " JRE (" VERSION_STRING "), built on " __DATE__ " " __TIME__
- " by " XSTR(HOTSPOT_BUILD_USER) " with " HOTSPOT_BUILD_COMPILER;
+ #define INTERNAL_VERSION_SUFFIX VM_RELEASE ")" \
+ " for " OS "-" CPU FLOAT_ARCH_STR \
+ " JRE (" VERSION_STRING "), built on " __DATE__ " " __TIME__ \
+ " by " XSTR(HOTSPOT_BUILD_USER) " with " HOTSPOT_BUILD_COMPILER
+
+ return strcmp(DEBUG_LEVEL, "release") == 0
+ ? VMNAME " (" INTERNAL_VERSION_SUFFIX
+ : VMNAME " (" DEBUG_LEVEL " " INTERNAL_VERSION_SUFFIX;
}
const char *Abstract_VM_Version::vm_build_user() {
@@ -251,6 +256,11 @@
return DEBUG_LEVEL;
}
+const char *Abstract_VM_Version::printable_jdk_debug_level() {
+ // Debug level is not printed for "release" builds
+ return strcmp(DEBUG_LEVEL, "release") == 0 ? "" : DEBUG_LEVEL " ";
+}
+
unsigned int Abstract_VM_Version::jvm_version() {
return ((Abstract_VM_Version::vm_major_version() & 0xFF) << 24) |
((Abstract_VM_Version::vm_minor_version() & 0xFF) << 16) |
--- a/hotspot/src/share/vm/runtime/vm_version.hpp Thu Jan 14 20:57:31 2016 -0800
+++ b/hotspot/src/share/vm/runtime/vm_version.hpp Tue Jan 19 18:39:23 2016 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -106,6 +106,7 @@
static const char* internal_vm_info_string();
static const char* jre_release_version();
static const char* jdk_debug_level();
+ static const char* printable_jdk_debug_level();
static uint64_t features() {
return _features;
--- a/hotspot/src/share/vm/utilities/vmError.cpp Thu Jan 14 20:57:31 2016 -0800
+++ b/hotspot/src/share/vm/utilities/vmError.cpp Tue Jan 19 18:39:23 2016 -0800
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2003, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2003, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -232,11 +232,17 @@
const char* runtime_name = JDK_Version::runtime_name() != NULL ?
JDK_Version::runtime_name() : "";
const char* runtime_version = JDK_Version::runtime_version() != NULL ?
- JDK_Version::runtime_version() : "";
- st->print_cr("# JRE version: %s (%s) (build %s)", runtime_name, buf, runtime_version);
+ JDK_Version::runtime_version() : "";
+ const char* jdk_debug_level = Abstract_VM_Version::printable_jdk_debug_level() != NULL ?
+ Abstract_VM_Version::printable_jdk_debug_level() : "";
+
+ st->print_cr("# JRE version: %s (%s) (%sbuild %s)", runtime_name, buf,
+ jdk_debug_level, runtime_version);
+
// This is the long version with some default settings added
- st->print_cr("# Java VM: %s (%s, %s%s%s%s%s, %s, %s)",
+ st->print_cr("# Java VM: %s (%s%s, %s%s%s%s%s, %s, %s)",
Abstract_VM_Version::vm_name(),
+ jdk_debug_level,
Abstract_VM_Version::vm_release(),
Abstract_VM_Version::vm_info_string(),
TieredCompilation ? ", tiered" : "",