6826780: URLClassPath should use HashMap<String, XXX> instead of HashMap<URL, XXX>
Summary: Replace URL with a String representation.
Reviewed-by: michaelm, jccollet
--- a/jdk/make/sun/net/FILES_java.gmk Thu Aug 06 19:01:59 2009 -0700
+++ b/jdk/make/sun/net/FILES_java.gmk Fri Aug 07 10:50:26 2009 +0100
@@ -41,6 +41,7 @@
sun/net/NetProperties.java \
sun/net/NetHooks.java \
sun/net/util/IPAddressUtil.java \
+ sun/net/util/URLUtil.java \
sun/net/dns/ResolverConfiguration.java \
sun/net/dns/ResolverConfigurationImpl.java \
sun/net/ftp/FtpClient.java \
--- a/jdk/src/share/classes/sun/misc/URLClassPath.java Thu Aug 06 19:01:59 2009 -0700
+++ b/jdk/src/share/classes/sun/misc/URLClassPath.java Fri Aug 07 10:50:26 2009 +0100
@@ -51,6 +51,7 @@
import java.security.PrivilegedExceptionAction;
import java.security.cert.Certificate;
import sun.misc.FileURLMapper;
+import sun.net.util.URLUtil;
/**
* This class is used to maintain a search path of URLs for loading classes
@@ -80,7 +81,7 @@
ArrayList<Loader> loaders = new ArrayList<Loader>();
/* Map of each URL opened to its corresponding Loader */
- HashMap<URL, Loader> lmap = new HashMap<URL, Loader>();
+ HashMap<String, Loader> lmap = new HashMap<String, Loader>();
/* The jar protocol handler to use when creating new URLs */
private URLStreamHandler jarHandler;
@@ -317,7 +318,8 @@
// Skip this URL if it already has a Loader. (Loader
// may be null in the case where URL has not been opened
// but is referenced by a JAR index.)
- if (lmap.containsKey(url)) {
+ String urlNoFragString = URLUtil.urlNoFragString(url);
+ if (lmap.containsKey(urlNoFragString)) {
continue;
}
// Otherwise, create a new Loader for the URL.
@@ -336,7 +338,7 @@
}
// Finally, add the Loader to the search path.
loaders.add(loader);
- lmap.put(url, loader);
+ lmap.put(urlNoFragString, loader);
}
return loaders.get(index);
}
@@ -576,7 +578,7 @@
private JarIndex index;
private MetaIndex metaIndex;
private URLStreamHandler handler;
- private HashMap<URL, Loader> lmap;
+ private HashMap<String, Loader> lmap;
private boolean closed = false;
/*
@@ -584,7 +586,7 @@
* a JAR file.
*/
JarLoader(URL url, URLStreamHandler jarHandler,
- HashMap<URL, Loader> loaderMap)
+ HashMap<String, Loader> loaderMap)
throws IOException
{
super(new URL("jar", "", -1, url + "!/", jarHandler));
@@ -663,8 +665,9 @@
try {
URL jarURL = new URL(csu, jarfiles[i]);
// If a non-null loader already exists, leave it alone.
- if (!lmap.containsKey(jarURL)) {
- lmap.put(jarURL, null);
+ String urlNoFragString = URLUtil.urlNoFragString(jarURL);
+ if (!lmap.containsKey(urlNoFragString)) {
+ lmap.put(urlNoFragString, null);
}
} catch (MalformedURLException e) {
continue;
@@ -806,7 +809,7 @@
if (index == null)
return null;
- HashSet<URL> visited = new HashSet<URL>();
+ HashSet<String> visited = new HashSet<String>();
return getResource(name, check, visited);
}
@@ -818,7 +821,7 @@
* non-existent resource
*/
Resource getResource(final String name, boolean check,
- Set<URL> visited) {
+ Set<String> visited) {
Resource res;
Object[] jarFiles;
@@ -843,7 +846,8 @@
try{
url = new URL(csu, jarName);
- if ((newLoader = (JarLoader)lmap.get(url)) == null) {
+ String urlNoFragString = URLUtil.urlNoFragString(url);
+ if ((newLoader = (JarLoader)lmap.get(urlNoFragString)) == null) {
/* no loader has been set up for this jar file
* before
*/
@@ -867,7 +871,7 @@
}
/* put it in the global hashtable */
- lmap.put(url, newLoader);
+ lmap.put(urlNoFragString, newLoader);
}
} catch (java.security.PrivilegedActionException pae) {
continue;
@@ -879,7 +883,7 @@
/* Note that the addition of the url to the list of visited
* jars incorporates a check for presence in the hashmap
*/
- boolean visitedURL = !visited.add(url);
+ boolean visitedURL = !visited.add(URLUtil.urlNoFragString(url));
if (!visitedURL) {
try {
newLoader.ensureOpen();
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/src/share/classes/sun/net/util/URLUtil.java Fri Aug 07 10:50:26 2009 +0100
@@ -0,0 +1,80 @@
+/*
+ * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation. Sun designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Sun in the LICENSE file that accompanied this code.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+package sun.net.util;
+
+import java.net.URL;
+
+/**
+ * URL Utility class.
+ */
+public class URLUtil {
+ /**
+ * Returns a string form of the url suitable for use as a key in HashMap/Sets.
+ *
+ * The string form should be behave in the same manner as the URL when
+ * compared for equality in a HashMap/Set, except that no nameservice
+ * lookup is done on the hostname (only string comparison), and the fragment
+ * is not considered.
+ *
+ * @see java.net.URLStreamHandler.sameFile(java.net.URL)
+ */
+ public static String urlNoFragString(URL url) {
+ StringBuilder strForm = new StringBuilder();
+
+ String protocol = url.getProtocol();
+ if (protocol != null) {
+ /* protocol is compared case-insensitive, so convert to lowercase */
+ protocol = protocol.toLowerCase();
+ strForm.append(protocol);
+ strForm.append("://");
+ }
+
+ String host = url.getHost();
+ if (host != null) {
+ /* host is compared case-insensitive, so convert to lowercase */
+ host = host.toLowerCase();
+ strForm.append(host);
+
+ int port = url.getPort();
+ if (port == -1) {
+ /* if no port is specificed then use the protocols
+ * default, if there is one */
+ port = url.getDefaultPort();
+ }
+ if (port != -1) {
+ strForm.append(":").append(port);
+ }
+ }
+
+ String file = url.getFile();
+ if (file != null) {
+ strForm.append(file);
+ }
+
+ return strForm.toString();
+ }
+}
+