8144964: JVMCI compilations need to be disabled until the module system is initialized
Reviewed-by: kvn
--- a/hotspot/src/share/vm/classfile/systemDictionary.cpp Thu Mar 31 09:16:49 2016 -0700
+++ b/hotspot/src/share/vm/classfile/systemDictionary.cpp Thu Mar 31 15:52:07 2016 -1000
@@ -2063,7 +2063,18 @@
int sid = (info >> CEIL_LG_OPTION_LIMIT);
Symbol* symbol = vmSymbols::symbol_at((vmSymbols::SID)sid);
InstanceKlass** klassp = &_well_known_klasses[id];
- bool must_load = (init_opt < SystemDictionary::Opt);
+
+ bool must_load;
+#if INCLUDE_JVMCI
+ if (EnableJVMCI) {
+ // If JVMCI is enabled we require its classes to be found.
+ must_load = (init_opt < SystemDictionary::Opt) || (init_opt == SystemDictionary::Jvmci);
+ } else
+#endif
+ {
+ must_load = (init_opt < SystemDictionary::Opt);
+ }
+
if ((*klassp) == NULL) {
Klass* k;
if (must_load) {
--- a/hotspot/src/share/vm/classfile/systemDictionary.hpp Thu Mar 31 09:16:49 2016 -0700
+++ b/hotspot/src/share/vm/classfile/systemDictionary.hpp Thu Mar 31 15:52:07 2016 -1000
@@ -241,7 +241,7 @@
Opt, // preload tried; NULL if not present
#if INCLUDE_JVMCI
- Jvmci, // preload tried; error if not present, use only with JVMCI
+ Jvmci, // preload tried; error if not present if JVMCI enabled
#endif
OPTION_LIMIT,
CEIL_LG_OPTION_LIMIT = 2 // OPTION_LIMIT <= (1<<CEIL_LG_OPTION_LIMIT)
--- a/hotspot/src/share/vm/compiler/compileBroker.cpp Thu Mar 31 09:16:49 2016 -0700
+++ b/hotspot/src/share/vm/compiler/compileBroker.cpp Thu Mar 31 15:52:07 2016 -1000
@@ -386,13 +386,16 @@
task = CompilationPolicy::policy()->select_task(this);
}
- // Save method pointers across unlock safepoint. The task is removed from
- // the compilation queue, which is walked during RedefineClasses.
- save_method = methodHandle(task->method());
- save_hot_method = methodHandle(task->hot_method());
+ if (task != NULL) {
+ // Save method pointers across unlock safepoint. The task is removed from
+ // the compilation queue, which is walked during RedefineClasses.
+ save_method = methodHandle(task->method());
+ save_hot_method = methodHandle(task->hot_method());
- remove(task);
- purge_stale_tasks(); // may temporarily release MCQ lock
+ remove(task);
+ purge_stale_tasks(); // may temporarily release MCQ lock
+ }
+
return task;
}
@@ -1781,7 +1784,8 @@
bool is_osr = (osr_bci != standard_entry_bci);
bool should_log = (thread->log() != NULL);
bool should_break = false;
- int task_level = task->comp_level();
+ const int task_level = task->comp_level();
+ AbstractCompiler* comp = task->compiler();
DirectiveSet* directive;
{
@@ -1793,7 +1797,7 @@
assert(!method->is_native(), "no longer compile natives");
// Look up matching directives
- directive = DirectivesStack::getMatchingDirective(method, compiler(task_level));
+ directive = DirectivesStack::getMatchingDirective(method, comp);
// Save information about this method in case of failure.
set_last_compile(thread, method, is_osr, task_level);
@@ -1812,13 +1816,13 @@
int compilable = ciEnv::MethodCompilable;
const char* failure_reason = NULL;
const char* retry_message = NULL;
- AbstractCompiler *comp = compiler(task_level);
int system_dictionary_modification_counter;
{
MutexLocker locker(Compile_lock, thread);
system_dictionary_modification_counter = SystemDictionary::number_of_modifications();
}
+
#if INCLUDE_JVMCI
if (UseJVMCICompiler && comp != NULL && comp->is_jvmci()) {
JVMCICompiler* jvmci = (JVMCICompiler*) comp;
--- a/hotspot/src/share/vm/compiler/compileTask.cpp Thu Mar 31 09:16:49 2016 -0700
+++ b/hotspot/src/share/vm/compiler/compileTask.cpp Thu Mar 31 15:52:07 2016 -1000
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1998, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -122,6 +122,13 @@
_next = NULL;
}
+/**
+ * Returns the compiler for this task.
+ */
+AbstractCompiler* CompileTask::compiler() {
+ return CompileBroker::compiler(_comp_level);
+}
+
// ------------------------------------------------------------------
// CompileTask::code/set_code
//
--- a/hotspot/src/share/vm/compiler/compileTask.hpp Thu Mar 31 09:16:49 2016 -0700
+++ b/hotspot/src/share/vm/compiler/compileTask.hpp Thu Mar 31 15:52:07 2016 -1000
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1998, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -115,6 +115,8 @@
int comp_level() { return _comp_level;}
void set_comp_level(int comp_level) { _comp_level = comp_level;}
+ AbstractCompiler* compiler();
+
int num_inlined_bytecodes() const { return _num_inlined_bytecodes; }
void set_num_inlined_bytecodes(int n) { _num_inlined_bytecodes = n; }
--- a/hotspot/src/share/vm/runtime/simpleThresholdPolicy.cpp Thu Mar 31 09:16:49 2016 -0700
+++ b/hotspot/src/share/vm/runtime/simpleThresholdPolicy.cpp Thu Mar 31 15:52:07 2016 -1000
@@ -233,6 +233,14 @@
if (level == CompLevel_none) {
return;
}
+
+#if INCLUDE_JVMCI
+ // We can't compile with a JVMCI compiler until the module system is initialized.
+ if (level == CompLevel_full_optimization && UseJVMCICompiler && !Universe::is_module_initialized()) {
+ return;
+ }
+#endif
+
// Check if the method can be compiled. If it cannot be compiled with C1, continue profiling
// in the interpreter and then compile with C2 (the transition function will request that,
// see common() ). If the method cannot be compiled with C2 but still can with C1, compile it with