6994322: Remove the is_tlab and is_noref / is_large_noref parameters from the CollectedHeap
Summary: Remove two unused parameters from the mem_allocate() method and update its uses accordingly.
Reviewed-by: stefank, johnc
--- a/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -829,12 +829,8 @@
HeapWord*
G1CollectedHeap::mem_allocate(size_t word_size,
- bool is_noref,
- bool is_tlab,
bool* gc_overhead_limit_was_exceeded) {
assert_heap_not_locked_and_not_at_safepoint();
- assert(!is_tlab, "mem_allocate() this should not be called directly "
- "to allocate TLABs");
// Loop until the allocation is satisified, or unsatisfied after GC.
for (int try_count = 1; /* we'll return */; try_count += 1) {
@@ -2622,11 +2618,6 @@
}
}
-size_t G1CollectedHeap::large_typearray_limit() {
- // FIXME
- return HeapRegion::GrainBytes/HeapWordSize;
-}
-
size_t G1CollectedHeap::max_capacity() const {
return _g1_reserved.byte_size();
}
--- a/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -446,8 +446,7 @@
// * All allocation requests for new TLABs should go to
// allocate_new_tlab().
//
- // * All non-TLAB allocation requests should go to mem_allocate()
- // and mem_allocate() should never be called with is_tlab == true.
+ // * All non-TLAB allocation requests should go to mem_allocate().
//
// * If either call cannot satisfy the allocation request using the
// current allocating region, they will try to get a new one. If
@@ -467,8 +466,6 @@
virtual HeapWord* allocate_new_tlab(size_t word_size);
virtual HeapWord* mem_allocate(size_t word_size,
- bool is_noref,
- bool is_tlab, /* expected to be false */
bool* gc_overhead_limit_was_exceeded);
// The following three methods take a gc_count_before_ret
@@ -1304,10 +1301,6 @@
return true;
}
- // The boundary between a "large" and "small" array of primitives, in
- // words.
- virtual size_t large_typearray_limit();
-
// Returns "true" iff the given word_size is "very large".
static bool isHumongous(size_t word_size) {
// Note this has to be strictly greater-than as the TLABs
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -386,8 +386,6 @@
// we rely on the size_policy object to force a bail out.
HeapWord* ParallelScavengeHeap::mem_allocate(
size_t size,
- bool is_noref,
- bool is_tlab,
bool* gc_overhead_limit_was_exceeded) {
assert(!SafepointSynchronize::is_at_safepoint(), "should not be at safepoint");
assert(Thread::current() != (Thread*)VMThread::vm_thread(), "should not be in vm thread");
@@ -398,7 +396,7 @@
// limit is being exceeded as checked below.
*gc_overhead_limit_was_exceeded = false;
- HeapWord* result = young_gen()->allocate(size, is_tlab);
+ HeapWord* result = young_gen()->allocate(size);
uint loop_count = 0;
uint gc_count = 0;
@@ -419,7 +417,7 @@
MutexLocker ml(Heap_lock);
gc_count = Universe::heap()->total_collections();
- result = young_gen()->allocate(size, is_tlab);
+ result = young_gen()->allocate(size);
// (1) If the requested object is too large to easily fit in the
// young_gen, or
@@ -433,21 +431,13 @@
if (result != NULL) {
return result;
}
- if (!is_tlab &&
- size >= (young_gen()->eden_space()->capacity_in_words(Thread::current()) / 2)) {
- result = old_gen()->allocate(size, is_tlab);
+ if (size >= (young_gen()->eden_space()->capacity_in_words(Thread::current()) / 2)) {
+ result = old_gen()->allocate(size);
if (result != NULL) {
return result;
}
}
if (GC_locker::is_active_and_needs_gc()) {
- // GC is locked out. If this is a TLAB allocation,
- // return NULL; the requestor will retry allocation
- // of an idividual object at a time.
- if (is_tlab) {
- return NULL;
- }
-
// If this thread is not in a jni critical section, we stall
// the requestor until the critical section has cleared and
// GC allowed. When the critical section clears, a GC is
@@ -472,7 +462,7 @@
if (result == NULL) {
// Generate a VM operation
- VM_ParallelGCFailedAllocation op(size, is_tlab, gc_count);
+ VM_ParallelGCFailedAllocation op(size, gc_count);
VMThread::execute(&op);
// Did the VM operation execute? If so, return the result directly.
@@ -526,7 +516,7 @@
if ((result == NULL) && (QueuedAllocationWarningCount > 0) &&
(loop_count % QueuedAllocationWarningCount == 0)) {
warning("ParallelScavengeHeap::mem_allocate retries %d times \n\t"
- " size=%d %s", loop_count, size, is_tlab ? "(TLAB)" : "");
+ " size=%d", loop_count, size);
}
}
@@ -539,7 +529,7 @@
// time over limit here, that is the responsibility of the heap specific
// collection methods. This method decides where to attempt allocations,
// and when to attempt collections, but no collection specific policy.
-HeapWord* ParallelScavengeHeap::failed_mem_allocate(size_t size, bool is_tlab) {
+HeapWord* ParallelScavengeHeap::failed_mem_allocate(size_t size) {
assert(SafepointSynchronize::is_at_safepoint(), "should be at safepoint");
assert(Thread::current() == (Thread*)VMThread::vm_thread(), "should be in vm thread");
assert(!Universe::heap()->is_gc_active(), "not reentrant");
@@ -553,7 +543,7 @@
// First level allocation failure, scavenge and allocate in young gen.
GCCauseSetter gccs(this, GCCause::_allocation_failure);
PSScavenge::invoke();
- HeapWord* result = young_gen()->allocate(size, is_tlab);
+ HeapWord* result = young_gen()->allocate(size);
// Second level allocation failure.
// Mark sweep and allocate in young generation.
@@ -562,28 +552,28 @@
// Don't mark sweep twice if so.
if (mark_sweep_invocation_count == total_invocations()) {
invoke_full_gc(false);
- result = young_gen()->allocate(size, is_tlab);
+ result = young_gen()->allocate(size);
}
}
// Third level allocation failure.
// After mark sweep and young generation allocation failure,
// allocate in old generation.
- if (result == NULL && !is_tlab) {
- result = old_gen()->allocate(size, is_tlab);
+ if (result == NULL) {
+ result = old_gen()->allocate(size);
}
// Fourth level allocation failure. We're running out of memory.
// More complete mark sweep and allocate in young generation.
if (result == NULL) {
invoke_full_gc(true);
- result = young_gen()->allocate(size, is_tlab);
+ result = young_gen()->allocate(size);
}
// Fifth level allocation failure.
// After more complete mark sweep, allocate in old generation.
- if (result == NULL && !is_tlab) {
- result = old_gen()->allocate(size, is_tlab);
+ if (result == NULL) {
+ result = old_gen()->allocate(size);
}
return result;
@@ -761,7 +751,7 @@
}
HeapWord* ParallelScavengeHeap::allocate_new_tlab(size_t size) {
- return young_gen()->allocate(size, true);
+ return young_gen()->allocate(size);
}
void ParallelScavengeHeap::accumulate_statistics_all_tlabs() {
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2001, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -165,12 +165,13 @@
// an excessive amount of time is being spent doing collections
// and caused a NULL to be returned. If a NULL is not returned,
// "gc_time_limit_was_exceeded" has an undefined meaning.
+ HeapWord* mem_allocate(size_t size,
+ bool* gc_overhead_limit_was_exceeded);
- HeapWord* mem_allocate(size_t size,
- bool is_noref,
- bool is_tlab,
- bool* gc_overhead_limit_was_exceeded);
- HeapWord* failed_mem_allocate(size_t size, bool is_tlab);
+ // Allocation attempt(s) during a safepoint. It should never be called
+ // to allocate a new TLAB as this allocation might be satisfied out
+ // of the old generation.
+ HeapWord* failed_mem_allocate(size_t size);
HeapWord* permanent_mem_allocate(size_t size);
HeapWord* failed_permanent_mem_allocate(size_t size);
@@ -194,8 +195,6 @@
inline void invoke_scavenge();
inline void invoke_full_gc(bool maximum_compaction);
- size_t large_typearray_limit() { return FastAllocateSizeLimit; }
-
bool supports_inline_contig_alloc() const { return !UseNUMA; }
HeapWord** top_addr() const { return !UseNUMA ? young_gen()->top_addr() : (HeapWord**)-1; }
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -182,12 +182,12 @@
// Allocation. We report all successful allocations to the size policy
// Note that the perm gen does not use this method, and should not!
-HeapWord* PSOldGen::allocate(size_t word_size, bool is_tlab) {
+HeapWord* PSOldGen::allocate(size_t word_size) {
assert_locked_or_safepoint(Heap_lock);
- HeapWord* res = allocate_noexpand(word_size, is_tlab);
+ HeapWord* res = allocate_noexpand(word_size);
if (res == NULL) {
- res = expand_and_allocate(word_size, is_tlab);
+ res = expand_and_allocate(word_size);
}
// Allocations in the old generation need to be reported
@@ -199,13 +199,12 @@
return res;
}
-HeapWord* PSOldGen::expand_and_allocate(size_t word_size, bool is_tlab) {
- assert(!is_tlab, "TLAB's are not supported in PSOldGen");
+HeapWord* PSOldGen::expand_and_allocate(size_t word_size) {
expand(word_size*HeapWordSize);
if (GCExpandToAllocateDelayMillis > 0) {
os::sleep(Thread::current(), GCExpandToAllocateDelayMillis, false);
}
- return allocate_noexpand(word_size, is_tlab);
+ return allocate_noexpand(word_size);
}
HeapWord* PSOldGen::expand_and_cas_allocate(size_t word_size) {
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -60,9 +60,8 @@
// Used when initializing the _name field.
static inline const char* select_name();
- HeapWord* allocate_noexpand(size_t word_size, bool is_tlab) {
+ HeapWord* allocate_noexpand(size_t word_size) {
// We assume the heap lock is held here.
- assert(!is_tlab, "Does not support TLAB allocation");
assert_locked_or_safepoint(Heap_lock);
HeapWord* res = object_space()->allocate(word_size);
if (res != NULL) {
@@ -89,7 +88,7 @@
return (res == NULL) ? expand_and_cas_allocate(word_size) : res;
}
- HeapWord* expand_and_allocate(size_t word_size, bool is_tlab);
+ HeapWord* expand_and_allocate(size_t word_size);
HeapWord* expand_and_cas_allocate(size_t word_size);
void expand(size_t bytes);
bool expand_by(size_t bytes);
@@ -164,7 +163,7 @@
// Allocation. We report all successful allocations to the size policy
// Note that the perm gen does not use this method, and should not!
- HeapWord* allocate(size_t word_size, bool is_tlab);
+ HeapWord* allocate(size_t word_size);
// Iteration.
void oop_iterate(OopClosure* cl) { object_space()->oop_iterate(cl); }
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -46,10 +46,10 @@
HeapWord* PSPermGen::allocate_permanent(size_t size) {
assert_locked_or_safepoint(Heap_lock);
- HeapWord* obj = allocate_noexpand(size, false);
+ HeapWord* obj = allocate_noexpand(size);
if (obj == NULL) {
- obj = expand_and_allocate(size, false);
+ obj = expand_and_allocate(size);
}
return obj;
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/psYoungGen.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/psYoungGen.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -157,7 +157,7 @@
}
// Allocation
- HeapWord* allocate(size_t word_size, bool is_tlab) {
+ HeapWord* allocate(size_t word_size) {
HeapWord* result = eden_space()->cas_allocate(word_size);
return result;
}
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -33,10 +33,9 @@
// The following methods are used by the parallel scavenge collector
VM_ParallelGCFailedAllocation::VM_ParallelGCFailedAllocation(size_t size,
- bool is_tlab, unsigned int gc_count) :
+ unsigned int gc_count) :
VM_GC_Operation(gc_count, GCCause::_allocation_failure),
_size(size),
- _is_tlab(is_tlab),
_result(NULL)
{
}
@@ -48,7 +47,7 @@
assert(heap->kind() == CollectedHeap::ParallelScavengeHeap, "must be a ParallelScavengeHeap");
GCCauseSetter gccs(heap, _gc_cause);
- _result = heap->failed_mem_allocate(_size, _is_tlab);
+ _result = heap->failed_mem_allocate(_size);
if (_result == NULL && GC_locker::is_active_and_needs_gc()) {
set_gc_locked();
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2007, 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -32,12 +32,10 @@
class VM_ParallelGCFailedAllocation: public VM_GC_Operation {
private:
size_t _size;
- bool _is_tlab;
HeapWord* _result;
public:
- VM_ParallelGCFailedAllocation(size_t size, bool is_tlab,
- unsigned int gc_count);
+ VM_ParallelGCFailedAllocation(size_t size, unsigned int gc_count);
virtual VMOp_Type type() const {
return VMOp_ParallelGCFailedAllocation;
--- a/hotspot/src/share/vm/gc_interface/collectedHeap.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_interface/collectedHeap.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2001, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -93,7 +93,7 @@
// pure virtual.
void pre_initialize();
- // Create a new tlab
+ // Create a new tlab. All TLAB allocations must go through this.
virtual HeapWord* allocate_new_tlab(size_t size);
// Accumulate statistics on all tlabs.
@@ -109,11 +109,11 @@
// Allocate an uninitialized block of the given size, or returns NULL if
// this is impossible.
- inline static HeapWord* common_mem_allocate_noinit(size_t size, bool is_noref, TRAPS);
+ inline static HeapWord* common_mem_allocate_noinit(size_t size, TRAPS);
// Like allocate_init, but the block returned by a successful allocation
// is guaranteed initialized to zeros.
- inline static HeapWord* common_mem_allocate_init(size_t size, bool is_noref, TRAPS);
+ inline static HeapWord* common_mem_allocate_init(size_t size, TRAPS);
// Same as common_mem version, except memory is allocated in the permanent area
// If there is no permanent area, revert to common_mem_allocate_noinit
@@ -322,7 +322,6 @@
// General obj/array allocation facilities.
inline static oop obj_allocate(KlassHandle klass, int size, TRAPS);
inline static oop array_allocate(KlassHandle klass, int size, int length, TRAPS);
- inline static oop large_typearray_allocate(KlassHandle klass, int size, int length, TRAPS);
// Special obj/array allocation facilities.
// Some heaps may want to manage "permanent" data uniquely. These default
@@ -345,16 +344,12 @@
// Raw memory allocation facilities
// The obj and array allocate methods are covers for these methods.
// The permanent allocation method should default to mem_allocate if
- // permanent memory isn't supported.
+ // permanent memory isn't supported. mem_allocate() should never be
+ // called to allocate TLABs, only individual objects.
virtual HeapWord* mem_allocate(size_t size,
- bool is_noref,
- bool is_tlab,
bool* gc_overhead_limit_was_exceeded) = 0;
virtual HeapWord* permanent_mem_allocate(size_t size) = 0;
- // The boundary between a "large" and "small" array of primitives, in words.
- virtual size_t large_typearray_limit() = 0;
-
// Utilities for turning raw memory into filler objects.
//
// min_fill_size() is the smallest region that can be filled.
--- a/hotspot/src/share/vm/gc_interface/collectedHeap.inline.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/gc_interface/collectedHeap.inline.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -122,7 +122,7 @@
post_allocation_notify(klass, (oop)obj);
}
-HeapWord* CollectedHeap::common_mem_allocate_noinit(size_t size, bool is_noref, TRAPS) {
+HeapWord* CollectedHeap::common_mem_allocate_noinit(size_t size, TRAPS) {
// Clear unhandled oops for memory allocation. Memory allocation might
// not take out a lock if from tlab, so clear here.
@@ -133,7 +133,6 @@
return NULL; // caller does a CHECK_0 too
}
- // We may want to update this, is_noref objects might not be allocated in TLABs.
HeapWord* result = NULL;
if (UseTLAB) {
result = CollectedHeap::allocate_from_tlab(THREAD, size);
@@ -145,8 +144,6 @@
}
bool gc_overhead_limit_was_exceeded = false;
result = Universe::heap()->mem_allocate(size,
- is_noref,
- false,
&gc_overhead_limit_was_exceeded);
if (result != NULL) {
NOT_PRODUCT(Universe::heap()->
@@ -183,8 +180,8 @@
}
}
-HeapWord* CollectedHeap::common_mem_allocate_init(size_t size, bool is_noref, TRAPS) {
- HeapWord* obj = common_mem_allocate_noinit(size, is_noref, CHECK_NULL);
+HeapWord* CollectedHeap::common_mem_allocate_init(size_t size, TRAPS) {
+ HeapWord* obj = common_mem_allocate_noinit(size, CHECK_NULL);
init_obj(obj, size);
return obj;
}
@@ -255,7 +252,7 @@
debug_only(check_for_valid_allocation_state());
assert(!Universe::heap()->is_gc_active(), "Allocation during gc not allowed");
assert(size >= 0, "int won't convert to size_t");
- HeapWord* obj = common_mem_allocate_init(size, false, CHECK_NULL);
+ HeapWord* obj = common_mem_allocate_init(size, CHECK_NULL);
post_allocation_setup_obj(klass, obj, size);
NOT_PRODUCT(Universe::heap()->check_for_bad_heap_word_value(obj, size));
return (oop)obj;
@@ -268,20 +265,7 @@
debug_only(check_for_valid_allocation_state());
assert(!Universe::heap()->is_gc_active(), "Allocation during gc not allowed");
assert(size >= 0, "int won't convert to size_t");
- HeapWord* obj = common_mem_allocate_init(size, false, CHECK_NULL);
- post_allocation_setup_array(klass, obj, size, length);
- NOT_PRODUCT(Universe::heap()->check_for_bad_heap_word_value(obj, size));
- return (oop)obj;
-}
-
-oop CollectedHeap::large_typearray_allocate(KlassHandle klass,
- int size,
- int length,
- TRAPS) {
- debug_only(check_for_valid_allocation_state());
- assert(!Universe::heap()->is_gc_active(), "Allocation during gc not allowed");
- assert(size >= 0, "int won't convert to size_t");
- HeapWord* obj = common_mem_allocate_init(size, true, CHECK_NULL);
+ HeapWord* obj = common_mem_allocate_init(size, CHECK_NULL);
post_allocation_setup_array(klass, obj, size, length);
NOT_PRODUCT(Universe::heap()->check_for_bad_heap_word_value(obj, size));
return (oop)obj;
--- a/hotspot/src/share/vm/memory/collectorPolicy.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/memory/collectorPolicy.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -750,10 +750,6 @@
return NULL;
}
-size_t GenCollectorPolicy::large_typearray_limit() {
- return FastAllocateSizeLimit;
-}
-
// Return true if any of the following is true:
// . the allocation won't fit into the current young gen heap
// . gc locker is occupied (jni critical section)
--- a/hotspot/src/share/vm/memory/collectorPolicy.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/memory/collectorPolicy.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2001, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -280,9 +280,6 @@
HeapWord *satisfy_failed_allocation(size_t size, bool is_tlab);
- // The size that defines a "large array".
- virtual size_t large_typearray_limit();
-
// Adaptive size policy
virtual void initialize_size_policy(size_t init_eden_size,
size_t init_promo_size,
--- a/hotspot/src/share/vm/memory/genCollectedHeap.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/memory/genCollectedHeap.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -434,11 +434,9 @@
}
HeapWord* GenCollectedHeap::mem_allocate(size_t size,
- bool is_large_noref,
- bool is_tlab,
bool* gc_overhead_limit_was_exceeded) {
return collector_policy()->mem_allocate_work(size,
- is_tlab,
+ false /* is_tlab */,
gc_overhead_limit_was_exceeded);
}
@@ -1120,11 +1118,9 @@
HeapWord* GenCollectedHeap::allocate_new_tlab(size_t size) {
bool gc_overhead_limit_was_exceeded;
- HeapWord* result = mem_allocate(size /* size */,
- false /* is_large_noref */,
- true /* is_tlab */,
- &gc_overhead_limit_was_exceeded);
- return result;
+ return collector_policy()->mem_allocate_work(size /* size */,
+ true /* is_tlab */,
+ &gc_overhead_limit_was_exceeded);
}
// Requires "*prev_ptr" to be non-NULL. Deletes and a block of minimal size
@@ -1179,10 +1175,6 @@
}
}
-size_t GenCollectedHeap::large_typearray_limit() {
- return gen_policy()->large_typearray_limit();
-}
-
class GenPrepareForVerifyClosure: public GenCollectedHeap::GenClosure {
void do_generation(Generation* gen) {
gen->prepare_for_verify();
--- a/hotspot/src/share/vm/memory/genCollectedHeap.hpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/memory/genCollectedHeap.hpp Thu Jun 16 15:51:57 2011 -0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2000, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2011, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -161,8 +161,6 @@
size_t max_capacity() const;
HeapWord* mem_allocate(size_t size,
- bool is_large_noref,
- bool is_tlab,
bool* gc_overhead_limit_was_exceeded);
// We may support a shared contiguous allocation area, if the youngest
@@ -315,8 +313,6 @@
// contributed as it needs.
void release_scratch();
- size_t large_typearray_limit();
-
// Ensure parsability: override
virtual void ensure_parsability(bool retire_tlabs);
--- a/hotspot/src/share/vm/oops/typeArrayKlass.cpp Wed Jun 15 10:18:04 2011 -0700
+++ b/hotspot/src/share/vm/oops/typeArrayKlass.cpp Thu Jun 16 15:51:57 2011 -0400
@@ -84,11 +84,7 @@
KlassHandle h_k(THREAD, as_klassOop());
typeArrayOop t;
CollectedHeap* ch = Universe::heap();
- if (size < ch->large_typearray_limit()) {
- t = (typeArrayOop)CollectedHeap::array_allocate(h_k, (int)size, length, CHECK_NULL);
- } else {
- t = (typeArrayOop)CollectedHeap::large_typearray_allocate(h_k, (int)size, length, CHECK_NULL);
- }
+ t = (typeArrayOop)CollectedHeap::array_allocate(h_k, (int)size, length, CHECK_NULL);
assert(t->is_parsable(), "Don't publish unless parsable");
return t;
} else {