--- a/langtools/src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java Wed Feb 09 18:26:08 2011 -0800
+++ b/langtools/src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java Thu Feb 10 14:24:26 2011 -0800
@@ -49,16 +49,13 @@
public static void preRegister(final Context context) {
context.put(FSInfo.class, new Context.Factory<FSInfo>() {
public FSInfo make() {
- if (singleton == null)
- singleton = new CacheFSInfo();
- context.put(FSInfo.class, singleton);
- return singleton;
+ FSInfo instance = new CacheFSInfo();
+ context.put(FSInfo.class, instance);
+ return instance;
}
});
}
- static CacheFSInfo singleton;
-
public void clearCache() {
cache.clear();
}
--- a/langtools/src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Wed Feb 09 18:26:08 2011 -0800
+++ b/langtools/src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Thu Feb 10 14:24:26 2011 -0800
@@ -55,6 +55,7 @@
import com.sun.tools.javac.api.JavacTrees;
import com.sun.tools.javac.code.*;
import com.sun.tools.javac.code.Symbol.*;
+import com.sun.tools.javac.file.FSInfo;
import com.sun.tools.javac.file.JavacFileManager;
import com.sun.tools.javac.jvm.*;
import com.sun.tools.javac.main.JavaCompiler;
@@ -1069,6 +1070,10 @@
if (tl != null)
next.put(TaskListener.class, tl);
+ FSInfo fsInfo = context.get(FSInfo.class);
+ if (fsInfo != null)
+ next.put(FSInfo.class, fsInfo);
+
JavaFileManager jfm = context.get(JavaFileManager.class);
Assert.checkNonNull(jfm);
next.put(JavaFileManager.class, jfm);
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/langtools/test/tools/javac/file/T7018098.java Thu Feb 10 14:24:26 2011 -0800
@@ -0,0 +1,121 @@
+/*
+ * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * @test
+ * @bug 7018098
+ * @summary CacheFSInfo persists too long
+ * @library ../lib
+ * @build JavacTestingAbstractProcessor T7018098
+ * @run main T7018098
+ */
+
+import java.io.*;
+import java.util.*;
+import javax.annotation.processing.RoundEnvironment;
+import javax.annotation.processing.SupportedOptions;
+import javax.lang.model.element.TypeElement;
+import javax.tools.Diagnostic;
+
+import com.sun.tools.javac.file.FSInfo;
+import com.sun.tools.javac.processing.JavacProcessingEnvironment;
+import com.sun.tools.javac.util.Context;
+
+@SupportedOptions("expect")
+public class T7018098 extends JavacTestingAbstractProcessor {
+ public static void main(String... args) throws Exception {
+ new T7018098().run();
+ }
+
+ static File testDir = new File("T7018098.dir");
+
+ void run() throws Exception {
+ String myName = T7018098.class.getSimpleName();
+ File testSrc = new File(System.getProperty("test.src"));
+ File file = new File(testSrc, myName + ".java");
+
+ _assert(!testDir.exists());
+
+ compile(
+ "-proc:only",
+ "-processor", myName,
+ "-Aexpect=false",
+ file.getPath());
+
+ testDir.mkdirs();
+ _assert(testDir.exists());
+
+ compile(
+ "-proc:only",
+ "-processor", myName,
+ "-Aexpect=true",
+ file.getPath());
+ }
+
+ void _assert(boolean cond) {
+ if (!cond)
+ throw new AssertionError();
+ }
+
+ void compile(String... args) throws Exception {
+ StringWriter sw = new StringWriter();
+ PrintWriter pw = new PrintWriter(sw);
+ int rc = com.sun.tools.javac.Main.compile(args, pw);
+ pw.close();
+ String out = sw.toString();
+ if (!out.isEmpty())
+ System.err.println(out);
+ if (rc != 0)
+ throw new Exception("compilation failed unexpectedly: rc=" + rc);
+ }
+
+ //---------------
+
+ @Override
+ public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
+ Context context = ((JavacProcessingEnvironment) processingEnv).getContext();
+ FSInfo fsInfo = context.get(FSInfo.class);
+
+ round++;
+ if (round == 1) {
+ boolean expect = Boolean.valueOf(options.get("expect"));
+ checkEqual("cache result", fsInfo.isDirectory(testDir), expect);
+ initialFSInfo = fsInfo;
+ } else {
+ checkEqual("fsInfo", fsInfo, initialFSInfo);
+ }
+
+ return true;
+ }
+
+ <T> void checkEqual(String label, T actual, T expected) {
+ if (actual != expected)
+ messager.printMessage(Diagnostic.Kind.ERROR,
+ "Unexpected value for " + label
+ + "; expected: " + expected
+ + "; found: " + actual);
+ }
+
+ int round = 0;
+ FSInfo initialFSInfo;
+}