8039975: SIGSEGV in MethodData::next_data(ProfileData*)
Summary: profiling code in interpreter broken when argument profiling is off.
Reviewed-by: iveresov, kvn
--- a/hotspot/src/cpu/sparc/vm/interp_masm_sparc.cpp Thu Apr 17 18:54:09 2014 +0400
+++ b/hotspot/src/cpu/sparc/vm/interp_masm_sparc.cpp Fri Apr 18 14:25:21 2014 +0200
@@ -2003,7 +2003,7 @@
}
} else {
assert(MethodData::profile_return(), "either profile call args or call ret");
- update_mdp_by_constant(in_bytes(ReturnTypeEntry::size()));
+ update_mdp_by_constant(in_bytes(TypeEntriesAtCall::return_only_size()));
}
// mdp points right after the end of the
--- a/hotspot/src/cpu/x86/vm/interp_masm_x86.cpp Thu Apr 17 18:54:09 2014 +0400
+++ b/hotspot/src/cpu/x86/vm/interp_masm_x86.cpp Fri Apr 18 14:25:21 2014 +0200
@@ -137,7 +137,7 @@
movptr(Address(rbp, frame::interpreter_frame_mdx_offset * wordSize), mdp);
} else {
assert(MethodData::profile_return(), "either profile call args or call ret");
- update_mdp_by_constant(mdp, in_bytes(ReturnTypeEntry::size()));
+ update_mdp_by_constant(mdp, in_bytes(TypeEntriesAtCall::return_only_size()));
}
// mdp points right after the end of the
--- a/hotspot/src/share/vm/c1/c1_LIRGenerator.cpp Thu Apr 17 18:54:09 2014 +0400
+++ b/hotspot/src/share/vm/c1/c1_LIRGenerator.cpp Fri Apr 18 14:25:21 2014 +0200
@@ -3188,8 +3188,8 @@
#ifdef ASSERT
Bytecodes::Code code = x->method()->raw_code_at_bci(x->bci_of_invoke());
int n = x->nb_profiled_args();
- assert(MethodData::profile_parameters() && x->inlined() &&
- ((code == Bytecodes::_invokedynamic && n <= 1) || (code == Bytecodes::_invokehandle && n <= 2)),
+ assert(MethodData::profile_parameters() && (MethodData::profile_arguments_jsr292_only() ||
+ (x->inlined() && ((code == Bytecodes::_invokedynamic && n <= 1) || (code == Bytecodes::_invokehandle && n <= 2)))),
"only at JSR292 bytecodes");
#endif
}
--- a/hotspot/src/share/vm/oops/methodData.hpp Thu Apr 17 18:54:09 2014 +0400
+++ b/hotspot/src/share/vm/oops/methodData.hpp Fri Apr 18 14:25:21 2014 +0200
@@ -1012,6 +1012,11 @@
static ByteSize argument_type_offset(int i) {
return in_ByteSize(argument_type_local_offset(i) * DataLayout::cell_size);
}
+
+ static ByteSize return_only_size() {
+ return ReturnTypeEntry::size() + in_ByteSize(header_cell_count() * DataLayout::cell_size);
+ }
+
};
// CallTypeData
@@ -2143,7 +2148,6 @@
static bool profile_jsr292(methodHandle m, int bci);
static int profile_arguments_flag();
- static bool profile_arguments_jsr292_only();
static bool profile_all_arguments();
static bool profile_arguments_for_invoke(methodHandle m, int bci);
static int profile_return_flag();
@@ -2442,6 +2446,7 @@
static bool profile_parameters_for_method(methodHandle m);
static bool profile_arguments();
+ static bool profile_arguments_jsr292_only();
static bool profile_return();
static bool profile_parameters();
static bool profile_return_jsr292_only();