8233387: Shenandoah: passive mode should disable pacing ergonomically
Reviewed-by: zgu
--- a/src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp Fri Nov 01 10:04:49 2019 -0400
+++ b/src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp Fri Nov 01 16:16:05 2019 +0100
@@ -29,11 +29,6 @@
#include "logging/log.hpp"
#include "logging/logTag.hpp"
-ShenandoahPassiveHeuristics::ShenandoahPassiveHeuristics() : ShenandoahHeuristics() {
- // Passive runs with max speed for allocation, because GC is always STW
- SHENANDOAH_ERGO_DISABLE_FLAG(ShenandoahPacing);
-}
-
bool ShenandoahPassiveHeuristics::should_start_gc() const {
// Never do concurrent GCs.
return false;
--- a/src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.hpp Fri Nov 01 10:04:49 2019 -0400
+++ b/src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.hpp Fri Nov 01 16:16:05 2019 +0100
@@ -28,8 +28,6 @@
class ShenandoahPassiveHeuristics : public ShenandoahHeuristics {
public:
- ShenandoahPassiveHeuristics();
-
virtual bool should_start_gc() const;
virtual bool should_process_references();
--- a/src/hotspot/share/gc/shenandoah/shenandoahPassiveMode.cpp Fri Nov 01 10:04:49 2019 -0400
+++ b/src/hotspot/share/gc/shenandoah/shenandoahPassiveMode.cpp Fri Nov 01 16:16:05 2019 +0100
@@ -32,8 +32,8 @@
FLAG_SET_DEFAULT(ExplicitGCInvokesConcurrent, false);
FLAG_SET_DEFAULT(ShenandoahImplicitGCInvokesConcurrent, false);
- // Passive runs with max speed, reacts on allocation failure.
- FLAG_SET_DEFAULT(ShenandoahPacing, false);
+ // Passive runs with max speed for allocation, because GC is always STW
+ SHENANDOAH_ERGO_DISABLE_FLAG(ShenandoahPacing);
// No need for evacuation reserve with Full GC, only for Degenerated GC.
if (!ShenandoahDegeneratedGC) {