6868548: remove spurious ';' from after constant pool entries
Reviewed-by: ksrini
--- a/langtools/src/share/classes/com/sun/tools/javap/CodeWriter.java Thu Aug 06 20:24:08 2009 -0700
+++ b/langtools/src/share/classes/com/sun/tools/javap/CodeWriter.java Sat Aug 08 17:50:57 2009 -0700
@@ -140,7 +140,7 @@
}
public Void visitConstantPoolRef(Instruction instr, int index, Void p) {
- print("#" + index + ";");
+ print("#" + index);
tab();
print("// ");
printConstant(index);
@@ -148,7 +148,7 @@
}
public Void visitConstantPoolRefAndValue(Instruction instr, int index, int value, Void p) {
- print("#" + index + ", " + value + ";");
+ print("#" + index + ", " + value);
tab();
print("// ");
printConstant(index);
@@ -170,7 +170,7 @@
print("{ // " + npairs);
indent(+1);
for (int i = 0; i < npairs; i++) {
- print("\n" + matches[i] + ": " + (pc + offsets[i]) + ";");
+ print("\n" + matches[i] + ": " + (pc + offsets[i]));
}
print("\ndefault: " + (pc + default_) + " }");
indent(-1);
@@ -182,7 +182,7 @@
print("{ //" + low + " to " + high);
indent(+1);
for (int i = 0; i < offsets.length; i++) {
- print("\n" + (low + i) + ": " + (pc + offsets[i]) + ";");
+ print("\n" + (low + i) + ": " + (pc + offsets[i]));
}
print("\ndefault: " + (pc + default_) + " }");
indent(-1);
--- a/langtools/src/share/classes/com/sun/tools/javap/ConstantWriter.java Thu Aug 06 20:24:08 2009 -0700
+++ b/langtools/src/share/classes/com/sun/tools/javap/ConstantWriter.java Sat Aug 08 17:50:57 2009 -0700
@@ -62,69 +62,69 @@
protected void writeConstantPool(ConstantPool constant_pool) {
ConstantPool.Visitor<Integer, Void> v = new ConstantPool.Visitor<Integer,Void>() {
public Integer visitClass(CONSTANT_Class_info info, Void p) {
- print("#" + info.name_index + ";");
+ print("#" + info.name_index);
tab();
println("// " + stringValue(info));
return 1;
}
public Integer visitDouble(CONSTANT_Double_info info, Void p) {
- println(stringValue(info) + ";");
+ println(stringValue(info));
return 2;
}
public Integer visitFieldref(CONSTANT_Fieldref_info info, Void p) {
- print("#" + info.class_index + ".#" + info.name_and_type_index + ";");
+ print("#" + info.class_index + ".#" + info.name_and_type_index);
tab();
println("// " + stringValue(info));
return 1;
}
public Integer visitFloat(CONSTANT_Float_info info, Void p) {
- println(stringValue(info) + ";");
+ println(stringValue(info));
return 1;
}
public Integer visitInteger(CONSTANT_Integer_info info, Void p) {
- println(stringValue(info) + ";");
+ println(stringValue(info));
return 1;
}
public Integer visitInterfaceMethodref(CONSTANT_InterfaceMethodref_info info, Void p) {
- print("#" + info.class_index + ".#" + info.name_and_type_index + ";");
+ print("#" + info.class_index + ".#" + info.name_and_type_index);
tab();
println("// " + stringValue(info));
return 1;
}
public Integer visitLong(CONSTANT_Long_info info, Void p) {
- println(stringValue(info) + ";");
+ println(stringValue(info));
return 2;
}
public Integer visitNameAndType(CONSTANT_NameAndType_info info, Void p) {
- print("#" + info.name_index + ":#" + info.type_index + ";");
+ print("#" + info.name_index + ":#" + info.type_index);
tab();
println("// " + stringValue(info));
return 1;
}
public Integer visitMethodref(CONSTANT_Methodref_info info, Void p) {
- print("#" + info.class_index + ".#" + info.name_and_type_index + ";");
+ print("#" + info.class_index + ".#" + info.name_and_type_index);
tab();
println("// " + stringValue(info));
return 1;
}
public Integer visitString(CONSTANT_String_info info, Void p) {
- print("#" + info.string_index + ";");
+ print("#" + info.string_index);
tab();
println("// " + stringValue(info));
return 1;
}
public Integer visitUtf8(CONSTANT_Utf8_info info, Void p) {
- println(stringValue(info) + ";");
+ println(stringValue(info));
return 1;
}
--- a/langtools/test/tools/javac/code/ArrayClone.java Thu Aug 06 20:24:08 2009 -0700
+++ b/langtools/test/tools/javac/code/ArrayClone.java Sat Aug 08 17:50:57 2009 -0700
@@ -48,7 +48,7 @@
System.out.println(out);
for (String line: out.split("\n")) {
- String match = "[ \t]+[0-9]+:[ \t]+invokevirtual[ \t]+#[0-9]+;[ \t]+// Method \"\\[Ljava/lang/String;\".clone:\\(\\)Ljava/lang/Object;";
+ String match = "[ \t]+[0-9]+:[ \t]+invokevirtual[ \t]+#[0-9]+[ \t]+// Method \"\\[Ljava/lang/String;\".clone:\\(\\)Ljava/lang/Object;";
if (line.matches(match))
return;
}