6806876: ClassCastException occurs in assignment expressions without any heap pollutions
Summary: intersection types should be considered as non-reifiable by javac
Reviewed-by: jjg
--- a/langtools/src/share/classes/com/sun/tools/javac/code/Types.java Sat Aug 08 17:56:37 2009 -0700
+++ b/langtools/src/share/classes/com/sun/tools/javac/code/Types.java Tue Aug 11 01:11:37 2009 +0100
@@ -1247,14 +1247,18 @@
@Override
public Boolean visitClassType(ClassType t, Void ignored) {
- if (!t.isParameterized())
+ if (t.isCompound())
+ return false;
+ else {
+ if (!t.isParameterized())
+ return true;
+
+ for (Type param : t.allparams()) {
+ if (!param.isUnbound())
+ return false;
+ }
return true;
-
- for (Type param : t.allparams()) {
- if (!param.isUnbound())
- return false;
}
- return true;
}
@Override
--- a/langtools/src/share/classes/com/sun/tools/javac/resources/compiler.properties Sat Aug 08 17:56:37 2009 -0700
+++ b/langtools/src/share/classes/com/sun/tools/javac/resources/compiler.properties Tue Aug 11 01:11:37 2009 +0100
@@ -761,7 +761,7 @@
found: {3}
compiler.warn.unchecked.generic.array.creation=\
- [unchecked] unchecked generic array creation of type {0} for varargs parameter
+ [unchecked] unchecked generic array creation for varargs parameter of type {0}
compiler.warn.missing.deprecated.annotation=\
[dep-ann] deprecated item is not annotated with @Deprecated
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/langtools/test/tools/javac/varargs/6806876/T6806876.java Tue Aug 11 01:11:37 2009 +0100
@@ -0,0 +1,40 @@
+/*
+ * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+/*
+ * @test
+ * @bug 6806876
+ * @author mcimadamore
+ * @summary ClassCastException occurs in assignment expressions without any heap pollutions
+ * @compile/fail/ref=T6806876.out -Xlint:unchecked -Werror -XDrawDiagnostics T6806876.java
+ */
+
+class T6806876 {
+ void test(Integer i, Long l) {
+ Comparable<?>[] res = m(i, l);
+ }
+
+ <T> T[] m(T...a) {
+ return null;
+ }
+}
\ No newline at end of file
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/langtools/test/tools/javac/varargs/6806876/T6806876.out Tue Aug 11 01:11:37 2009 +0100
@@ -0,0 +1,4 @@
+T6806876.java:34:32: compiler.warn.unchecked.generic.array.creation: java.lang.Number&java.lang.Comparable<? extends java.lang.Number&java.lang.Comparable<?>>[]
+- compiler.err.warnings.and.werror
+1 error
+1 warning