7170010: conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows
authordcubed
Fri, 18 May 2012 09:15:15 -0700
changeset 12737 98520449d94c
parent 12736 ebf1dbf96b24
child 12738 40076a753bfa
child 12765 3e1b42265329
7170010: conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows Summary: Always disable ZIP_DEBUGINFO_FILES on Windows. Reviewed-by: acorn
hotspot/make/windows/makefiles/defs.make
--- a/hotspot/make/windows/makefiles/defs.make	Wed May 16 12:47:27 2012 -0700
+++ b/hotspot/make/windows/makefiles/defs.make	Fri May 18 09:15:15 2012 -0700
@@ -145,7 +145,12 @@
 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
   # Disable ZIP_DEBUGINFO_FILES by default because various tests are
   # failing in nightly when the debug info files are ZIP'ed.
-  ZIP_DEBUGINFO_FILES ?= 0
+  #ZIP_DEBUGINFO_FILES ?= 0
+  # The above conditional setting logic is unreliable on Windows for
+  # unknown reasons. We force ZIP_DEBUGINFO_FILES to be disabled on
+  # Windows until we figure out why the various tests are failing
+  # AND why the conditional setting logic is unreliable.
+  ZIP_DEBUGINFO_FILES=0
 else
   ZIP_DEBUGINFO_FILES=0
 endif