8210962: Deprecate jdk-variant
authorihse
Thu, 20 Sep 2018 20:54:19 +0200
changeset 51824 9777d724ace8
parent 51823 2a51125b2794
child 51825 e3632b4706c4
8210962: Deprecate jdk-variant Reviewed-by: shade, erikj
make/autoconf/basics.m4
make/autoconf/configure.ac
make/autoconf/jdk-options.m4
make/autoconf/spec.gmk.in
--- a/make/autoconf/basics.m4	Tue Sep 18 21:47:14 2018 -0700
+++ b/make/autoconf/basics.m4	Thu Sep 20 20:54:19 2018 +0200
@@ -862,7 +862,7 @@
     # Create a default ./build/target-variant-debuglevel output root.
     if test "x${CONF_NAME}" = x; then
       AC_MSG_RESULT([in default location])
-      CONF_NAME="${OPENJDK_TARGET_OS}-${OPENJDK_TARGET_CPU}-${JDK_VARIANT}-${JVM_VARIANTS_WITH_AND}-${DEBUG_LEVEL}"
+      CONF_NAME="${OPENJDK_TARGET_OS}-${OPENJDK_TARGET_CPU}-${JVM_VARIANTS_WITH_AND}-${DEBUG_LEVEL}"
     else
       AC_MSG_RESULT([in build directory with custom name])
     fi
--- a/make/autoconf/configure.ac	Tue Sep 18 21:47:14 2018 -0700
+++ b/make/autoconf/configure.ac	Thu Sep 20 20:54:19 2018 +0200
@@ -91,7 +91,6 @@
 JDKOPT_SETUP_OPEN_OR_CUSTOM
 
 # These are needed to be able to create a configuration name (and thus the output directory)
-JDKOPT_SETUP_JDK_VARIANT
 JDKOPT_SETUP_DEBUG_LEVEL
 HOTSPOT_SETUP_JVM_VARIANTS
 
--- a/make/autoconf/jdk-options.m4	Tue Sep 18 21:47:14 2018 -0700
+++ b/make/autoconf/jdk-options.m4	Thu Sep 20 20:54:19 2018 +0200
@@ -33,19 +33,8 @@
 # modules to compile into the JDK.
 AC_DEFUN_ONCE([JDKOPT_SETUP_JDK_VARIANT],
 [
-  AC_MSG_CHECKING([which variant of the JDK to build])
-  AC_ARG_WITH([jdk-variant], [AS_HELP_STRING([--with-jdk-variant],
-      [JDK variant to build (normal) @<:@normal@:>@])])
-
-  if test "x$with_jdk_variant" = xnormal || test "x$with_jdk_variant" = x; then
-    JDK_VARIANT="normal"
-  else
-    AC_MSG_ERROR([The available JDK variants are: normal])
-  fi
-
-  AC_SUBST(JDK_VARIANT)
-
-  AC_MSG_RESULT([$JDK_VARIANT])
+  # Deprecated in JDK 12
+  BASIC_DEPRECATED_ARG_WITH([jdk-variant])
 ])
 
 ###############################################################################
--- a/make/autoconf/spec.gmk.in	Tue Sep 18 21:47:14 2018 -0700
+++ b/make/autoconf/spec.gmk.in	Thu Sep 20 20:54:19 2018 +0200
@@ -254,10 +254,6 @@
 DEBUG_LEVEL:=@DEBUG_LEVEL@
 HOTSPOT_DEBUG_LEVEL:=@HOTSPOT_DEBUG_LEVEL@
 
-# This is the JDK variant to build.
-# The JDK variant is a name for a specific set of modules to be compiled for the JDK.
-JDK_VARIANT:=@JDK_VARIANT@
-
 # Which JVM variants to build (space-separated list)
 JVM_VARIANTS := @JVM_VARIANTS@
 JVM_VARIANT_MAIN := @JVM_VARIANT_MAIN@