6963870: NPE in CompoundBorder.getInsets()
Reviewed-by: alexp
Contributed-by: jon.vanalten@redhat.com
--- a/jdk/src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java Tue Jun 22 20:36:55 2010 +0400
+++ b/jdk/src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java Tue Jun 29 14:42:30 2010 +0400
@@ -1440,10 +1440,6 @@
}
}
- public Insets getBorderInsets(Component c) {
- return getBorderInsets(c, null);
- }
-
public Insets getBorderInsets(Component c, Insets i) {
SynthContext context = getContext(c);
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/com/sun/java/swing/plaf/gtk/Test6963870.java Tue Jun 29 14:42:30 2010 +0400
@@ -0,0 +1,72 @@
+/*
+ * Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+/* @test
+ @bug 6963870
+ @summary Tests that GTKPainter.ListTableFocusBorder.getBorderInsets()
+ doesn't return null
+ @author Peter Zhelezniakov
+ @run main Test6963870
+*/
+
+import java.awt.Insets;
+import javax.swing.SwingUtilities;
+import javax.swing.UIManager;
+import javax.swing.border.Border;
+
+public class Test6963870 implements Runnable {
+
+ final static String[] UI_NAMES = {
+ "List.focusCellHighlightBorder",
+ "List.focusSelectedCellHighlightBorder",
+ "List.noFocusBorder",
+ "Table.focusCellHighlightBorder",
+ "Table.focusSelectedCellHighlightBorder",
+ };
+
+ public void run() {
+ for (String uiName: UI_NAMES) {
+ test(uiName);
+ }
+ }
+
+ void test(String uiName) {
+ Border b = UIManager.getBorder(uiName);
+ Insets i = b.getBorderInsets(null);
+ if (i == null) {
+ throw new RuntimeException("getBorderInsets() returns null for " + uiName);
+ }
+ }
+
+ public static void main(String[] args) throws Exception {
+ try {
+ UIManager.setLookAndFeel("com.sun.java.swing.plaf.gtk.GTKLookAndFeel");
+ } catch (Exception e) {
+ System.out.println("GTKLookAndFeel cannot be set, skipping this test");
+ return;
+ }
+
+ SwingUtilities.invokeAndWait(new Test6963870());
+ }
+}
+