--- a/hotspot/make/bsd/makefiles/gcc.make Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/make/bsd/makefiles/gcc.make Thu Mar 14 12:49:05 2013 -0400
@@ -168,12 +168,12 @@
# conversions which might affect the values. To avoid that, we need to turn
# it off explicitly.
ifneq "$(shell expr \( $(CC_VER_MAJOR) \> 4 \) \| \( \( $(CC_VER_MAJOR) = 4 \) \& \( $(CC_VER_MINOR) \>= 3 \) \))" "0"
-ACCEPTABLE_WARNINGS = -Wpointer-arith -Wsign-compare
+WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef
else
-ACCEPTABLE_WARNINGS = -Wpointer-arith -Wconversion -Wsign-compare
+WARNING_FLAGS = -Wpointer-arith -Wconversion -Wsign-compare -Wundef
endif
-CFLAGS_WARN/DEFAULT = $(WARNINGS_ARE_ERRORS) $(ACCEPTABLE_WARNINGS)
+CFLAGS_WARN/DEFAULT = $(WARNINGS_ARE_ERRORS) $(WARNING_FLAGS)
# Special cases
CFLAGS_WARN/BYFILE = $(CFLAGS_WARN/$@)$(CFLAGS_WARN/DEFAULT$(CFLAGS_WARN/$@))
# XXXDARWIN: for _dyld_bind_fully_image_containing_address
--- a/hotspot/make/excludeSrc.make Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/make/excludeSrc.make Thu Mar 14 12:49:05 2013 -0400
@@ -69,7 +69,7 @@
CXXFLAGS += -DINCLUDE_CDS=0
CFLAGS += -DINCLUDE_CDS=0
- Src_Files_EXCLUDE += metaspaceShared.cpp
+ Src_Files_EXCLUDE += filemap.cpp metaspaceShared.cpp
endif
ifeq ($(INCLUDE_ALL_GCS), false)
--- a/hotspot/make/linux/makefiles/gcc.make Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/make/linux/makefiles/gcc.make Thu Mar 14 12:49:05 2013 -0400
@@ -131,12 +131,12 @@
# conversions which might affect the values. To avoid that, we need to turn
# it off explicitly.
ifneq "$(shell expr \( $(CC_VER_MAJOR) \> 4 \) \| \( \( $(CC_VER_MAJOR) = 4 \) \& \( $(CC_VER_MINOR) \>= 3 \) \))" "0"
-ACCEPTABLE_WARNINGS = -Wpointer-arith -Wsign-compare
+WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef
else
-ACCEPTABLE_WARNINGS = -Wpointer-arith -Wconversion -Wsign-compare
+WARNING_FLAGS = -Wpointer-arith -Wconversion -Wsign-compare -Wundef
endif
-CFLAGS_WARN/DEFAULT = $(WARNINGS_ARE_ERRORS) $(ACCEPTABLE_WARNINGS)
+CFLAGS_WARN/DEFAULT = $(WARNINGS_ARE_ERRORS) $(WARNING_FLAGS)
# Special cases
CFLAGS_WARN/BYFILE = $(CFLAGS_WARN/$@)$(CFLAGS_WARN/DEFAULT$(CFLAGS_WARN/$@))
--- a/hotspot/make/solaris/makefiles/gcc.make Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/make/solaris/makefiles/gcc.make Thu Mar 14 12:49:05 2013 -0400
@@ -118,8 +118,8 @@
# Compiler warnings are treated as errors
WARNINGS_ARE_ERRORS = -Werror
# Enable these warnings. See 'info gcc' about details on these options
-ADDITIONAL_WARNINGS = -Wpointer-arith -Wconversion -Wsign-compare
-CFLAGS_WARN/DEFAULT = $(WARNINGS_ARE_ERRORS) $(ADDITIONAL_WARNINGS)
+WARNING_FLAGS = -Wpointer-arith -Wconversion -Wsign-compare -Wundef
+CFLAGS_WARN/DEFAULT = $(WARNINGS_ARE_ERRORS) $(WARNING_FLAGS)
# Special cases
CFLAGS_WARN/BYFILE = $(CFLAGS_WARN/$@)$(CFLAGS_WARN/DEFAULT$(CFLAGS_WARN/$@))
--- a/hotspot/src/cpu/x86/vm/frame_x86.cpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/cpu/x86/vm/frame_x86.cpp Thu Mar 14 12:49:05 2013 -0400
@@ -356,7 +356,7 @@
// Verifies the calculated original PC of a deoptimization PC for the
// given unextended SP. The unextended SP might also be the saved SP
// for MethodHandle call sites.
-#if ASSERT
+#ifdef ASSERT
void frame::verify_deopt_original_pc(nmethod* nm, intptr_t* unextended_sp, bool is_method_handle_return) {
frame fr;
--- a/hotspot/src/cpu/x86/vm/frame_x86.hpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/cpu/x86/vm/frame_x86.hpp Thu Mar 14 12:49:05 2013 -0400
@@ -170,7 +170,7 @@
return (intptr_t*) addr_at(offset);
}
-#if ASSERT
+#ifdef ASSERT
// Used in frame::sender_for_{interpreter,compiled}_frame
static void verify_deopt_original_pc( nmethod* nm, intptr_t* unextended_sp, bool is_method_handle_return = false);
static void verify_deopt_mh_original_pc(nmethod* nm, intptr_t* unextended_sp) {
--- a/hotspot/src/share/vm/c1/c1_LIR.hpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/c1/c1_LIR.hpp Thu Mar 14 12:49:05 2013 -0400
@@ -2375,7 +2375,7 @@
// collects all register operands of the instruction
void visit(LIR_Op* op);
-#if ASSERT
+#ifdef ASSERT
// check that an operation has no operands
bool no_operands(LIR_Op* op);
#endif
--- a/hotspot/src/share/vm/ci/ciTypeFlow.cpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/ci/ciTypeFlow.cpp Thu Mar 14 12:49:05 2013 -0400
@@ -2540,7 +2540,7 @@
} else if (innermost->head() == blk) {
// If loop header, complete the tree pointers
if (blk->loop() != innermost) {
-#if ASSERT
+#ifdef ASSERT
assert(blk->loop()->head() == innermost->head(), "same head");
Loop* dl;
for (dl = innermost; dl != NULL && dl != blk->loop(); dl = dl->parent());
--- a/hotspot/src/share/vm/code/compressedStream.cpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/code/compressedStream.cpp Thu Mar 14 12:49:05 2013 -0400
@@ -195,7 +195,7 @@
// for this block (a matching directive turns it back on later).
// These directives can be removed once the MS VS.NET 2005
// compiler stack overflow is fixed.
-#if _MSC_VER >=1400 && !defined(_WIN64)
+#if defined(_MSC_VER) && _MSC_VER >=1400 && !defined(_WIN64)
#pragma optimize("", off)
#pragma warning(disable: 4748)
#endif
@@ -276,7 +276,7 @@
guarantee(fails == 0, "test failures");
}
-#if _MSC_VER >=1400 && !defined(_WIN64)
+#if defined(_MSC_VER) &&_MSC_VER >=1400 && !defined(_WIN64)
#pragma warning(default: 4748)
#pragma optimize("", on)
#endif
--- a/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp Thu Mar 14 12:49:05 2013 -0400
@@ -1310,11 +1310,6 @@
_markStack.expand();
}
-#if VERIFY_OBJS_PROCESSED
- _scan_obj_cl.objs_processed = 0;
- ThreadLocalObjQueue::objs_enqueued = 0;
-#endif
-
// Statistics
double now = os::elapsedTime();
_remark_mark_times.add((mark_work_end - start) * 1000.0);
@@ -2555,17 +2550,6 @@
guarantee(satb_mq_set.completed_buffers_num() == 0, "invariant");
print_stats();
-
-#if VERIFY_OBJS_PROCESSED
- if (_scan_obj_cl.objs_processed != ThreadLocalObjQueue::objs_enqueued) {
- gclog_or_tty->print_cr("Processed = %d, enqueued = %d.",
- _scan_obj_cl.objs_processed,
- ThreadLocalObjQueue::objs_enqueued);
- guarantee(_scan_obj_cl.objs_processed ==
- ThreadLocalObjQueue::objs_enqueued,
- "Different number of objs processed and enqueued.");
- }
-#endif
}
#ifndef PRODUCT
--- a/hotspot/src/share/vm/memory/filemap.hpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/memory/filemap.hpp Thu Mar 14 12:49:05 2013 -0400
@@ -112,12 +112,19 @@
char* region_base(int i) { return _header._space[i]._base; }
struct FileMapHeader* header() { return &_header; }
- static void set_current_info(FileMapInfo* info) { _current_info = info; }
- static FileMapInfo* current_info() { return _current_info; }
+ static void set_current_info(FileMapInfo* info) {
+ CDS_ONLY(_current_info = info;)
+ }
+
+ static FileMapInfo* current_info() {
+ CDS_ONLY(return _current_info;)
+ NOT_CDS(return NULL;)
+ }
+
static void assert_mark(bool check);
// File manipulation.
- bool initialize();
+ bool initialize() NOT_CDS_RETURN_(false);
bool open_for_read();
void open_for_write();
void write_header();
@@ -141,7 +148,7 @@
void fail_continue(const char *msg, ...);
// Return true if given address is in the mapped shared space.
- bool is_in_shared_space(const void* p);
+ bool is_in_shared_space(const void* p) NOT_CDS_RETURN_(false);
};
#endif // SHARE_VM_MEMORY_FILEMAP_HPP
--- a/hotspot/src/share/vm/prims/jvmtiImpl.cpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/prims/jvmtiImpl.cpp Thu Mar 14 12:49:05 2013 -0400
@@ -890,7 +890,7 @@
tty->print("Suspended Threads: [");
for (JavaThread *thread = Threads::first(); thread != NULL; thread = thread->next()) {
-#if JVMTI_TRACE
+#ifdef JVMTI_TRACE
const char *name = JvmtiTrace::safe_get_thread_name(thread);
#else
const char *name = "";
--- a/hotspot/src/share/vm/prims/jvmtiTrace.hpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/prims/jvmtiTrace.hpp Thu Mar 14 12:49:05 2013 -0400
@@ -43,10 +43,10 @@
// Support tracing except in product build on the client compiler
#ifndef PRODUCT
-#define JVMTI_TRACE 1
+#define JVMTI_TRACE
#else
#ifdef COMPILER2
-#define JVMTI_TRACE 1
+#define JVMTI_TRACE
#endif
#endif
--- a/hotspot/src/share/vm/runtime/arguments.cpp Wed Mar 13 17:34:29 2013 -0400
+++ b/hotspot/src/share/vm/runtime/arguments.cpp Thu Mar 14 12:49:05 2013 -0400
@@ -2273,10 +2273,12 @@
}
#if !INCLUDE_JVMTI
if ((strcmp(name, "hprof") == 0) || (strcmp(name, "jdwp") == 0)) {
- warning("profiling and debugging agents are not supported in this VM");
- } else
+ jio_fprintf(defaultStream::error_stream(),
+ "Profiling and debugging agents are not supported in this VM\n");
+ return JNI_ERR;
+ }
#endif // !INCLUDE_JVMTI
- add_init_library(name, options);
+ add_init_library(name, options);
}
// -agentlib and -agentpath
} else if (match_option(option, "-agentlib:", &tail) ||
@@ -2293,16 +2295,19 @@
}
#if !INCLUDE_JVMTI
if ((strcmp(name, "hprof") == 0) || (strcmp(name, "jdwp") == 0)) {
- warning("profiling and debugging agents are not supported in this VM");
- } else
+ jio_fprintf(defaultStream::error_stream(),
+ "Profiling and debugging agents are not supported in this VM\n");
+ return JNI_ERR;
+ }
#endif // !INCLUDE_JVMTI
add_init_agent(name, options, is_absolute_path);
-
}
// -javaagent
} else if (match_option(option, "-javaagent:", &tail)) {
#if !INCLUDE_JVMTI
- warning("Instrumentation agents are not supported in this VM");
+ jio_fprintf(defaultStream::error_stream(),
+ "Instrumentation agents are not supported in this VM\n");
+ return JNI_ERR;
#else
if(tail != NULL) {
char *options = strcpy(NEW_C_HEAP_ARRAY(char, strlen(tail) + 1, mtInternal), tail);
@@ -2443,8 +2448,9 @@
#if INCLUDE_FPROF
_has_profile = true;
#else // INCLUDE_FPROF
- // do we have to exit?
- warning("Flat profiling is not supported in this VM.");
+ jio_fprintf(defaultStream::error_stream(),
+ "Flat profiling is not supported in this VM.\n");
+ return JNI_ERR;
#endif // INCLUDE_FPROF
// -Xaprof
} else if (match_option(option, "-Xaprof", &tail)) {
@@ -2478,8 +2484,9 @@
#if INCLUDE_MANAGEMENT
FLAG_SET_CMDLINE(bool, ManagementServer, true);
#else
- vm_exit_during_initialization(
- "-Dcom.sun.management is not supported in this VM.", NULL);
+ jio_fprintf(defaultStream::output_stream(),
+ "-Dcom.sun.management is not supported in this VM.\n");
+ return JNI_ERR;
#endif
}
// -Xint
@@ -2492,16 +2499,10 @@
} else if (match_option(option, "-Xcomp", &tail)) {
// for testing the compiler; turn off all flags that inhibit compilation
set_mode_flags(_comp);
-
// -Xshare:dump
} else if (match_option(option, "-Xshare:dump", &tail)) {
-#if !INCLUDE_CDS
- vm_exit_during_initialization(
- "Dumping a shared archive is not supported in this VM.", NULL);
-#else
FLAG_SET_CMDLINE(bool, DumpSharedSpaces, true);
set_mode_flags(_int); // Prevent compilation, which creates objects
-#endif
// -Xshare:on
} else if (match_option(option, "-Xshare:on", &tail)) {
FLAG_SET_CMDLINE(bool, UseSharedSpaces, true);
@@ -2514,7 +2515,6 @@
} else if (match_option(option, "-Xshare:off", &tail)) {
FLAG_SET_CMDLINE(bool, UseSharedSpaces, false);
FLAG_SET_CMDLINE(bool, RequireSharedSpaces, false);
-
// -Xverify
} else if (match_option(option, "-Xverify", &tail)) {
if (strcmp(tail, ":all") == 0 || strcmp(tail, "") == 0) {
@@ -2828,8 +2828,9 @@
FLAG_SET_CMDLINE(bool, UseVMInterruptibleIO, true);
#if !INCLUDE_MANAGEMENT
} else if (match_option(option, "-XX:+ManagementServer", &tail)) {
- vm_exit_during_initialization(
- "ManagementServer is not supported in this VM.", NULL);
+ jio_fprintf(defaultStream::error_stream(),
+ "ManagementServer is not supported in this VM.\n");
+ return JNI_ERR;
#endif // INCLUDE_MANAGEMENT
} else if (match_option(option, "-XX:", &tail)) { // -XX:xxxx
// Skip -XX:Flags= since that case has already been handled
@@ -3135,7 +3136,9 @@
#if INCLUDE_NMT
MemTracker::init_tracking_options(tail);
#else
- warning("Native Memory Tracking is not supported in this VM");
+ jio_fprintf(defaultStream::error_stream(),
+ "Native Memory Tracking is not supported in this VM\n");
+ return JNI_ERR;
#endif
}
@@ -3254,6 +3257,16 @@
force_serial_gc();
#endif // INCLUDE_ALL_GCS
#if !INCLUDE_CDS
+ if (DumpSharedSpaces || RequireSharedSpaces) {
+ jio_fprintf(defaultStream::error_stream(),
+ "Shared spaces are not supported in this VM\n");
+ return JNI_ERR;
+ }
+ if ((UseSharedSpaces && FLAG_IS_CMDLINE(UseSharedSpaces)) || PrintSharedSpaces) {
+ warning("Shared spaces are not supported in this VM");
+ FLAG_SET_DEFAULT(UseSharedSpaces, false);
+ FLAG_SET_DEFAULT(PrintSharedSpaces, false);
+ }
no_shared_spaces();
#endif // INCLUDE_CDS