8086057: Crash with "modified node is not on IGVN._worklist" when running with -XX:-SplitIfBlocks
Summary: Pre-loop Opaque1 node 'pre_opaq' should be put on the IGVN worklist after modification.
Reviewed-by: kvn
--- a/hotspot/src/share/vm/opto/superword.cpp Mon Apr 25 10:51:44 2016 +0200
+++ b/hotspot/src/share/vm/opto/superword.cpp Mon Apr 25 10:53:42 2016 +0200
@@ -3230,8 +3230,7 @@
: (Node*) new MaxINode(lim, orig_limit);
_igvn.register_new_node_with_optimizer(constrained);
_phase->set_ctrl(constrained, pre_ctrl);
- _igvn.hash_delete(pre_opaq);
- pre_opaq->set_req(1, constrained);
+ _igvn.replace_input_of(pre_opaq, 1, constrained);
}
//----------------------------get_pre_loop_end---------------------------
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/hotspot/test/compiler/loopopts/TestSplitIfBlocksDisabled.java Mon Apr 25 10:53:42 2016 +0200
@@ -0,0 +1,37 @@
+/*
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ *
+ */
+
+/**
+ * @test TestSplitIfBlocksDisabled
+ * @bug 8086057
+ * @summary Verifies that loop optimizations work if SplitIfBlocks is disabled.
+ * @run main/othervm -XX:+IgnoreUnrecognizedVMOptions -Xcomp -XX:-SplitIfBlocks TestSplitIfBlocksDisabled
+ */
+public class TestSplitIfBlocksDisabled {
+
+ public static void main(String[] args) {
+ System.out.println("Passed");
+ }
+}
+