7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows
Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows.
Reviewed-by: acorn, sspitsyn
--- a/hotspot/make/solaris/makefiles/defs.make Tue Apr 24 15:20:40 2012 -0700
+++ b/hotspot/make/solaris/makefiles/defs.make Wed Apr 25 15:06:51 2012 -0700
@@ -109,12 +109,18 @@
# overridden in some situations, e.g., a BUILD_FLAVOR != product
# build.
+ # Disable FULL_DEBUG_SYMBOLS by default because dtrace tests are
+ # failing in nightly when the debug info files are ZIP'ed. On
+ # Solaris debug info files need to be ZIP'ed to reduce the impact
+ # on disk space footprint.
+ FULL_DEBUG_SYMBOLS ?= 0
ifeq ($(BUILD_FLAVOR), product)
- FULL_DEBUG_SYMBOLS ?= 1
+ # FULL_DEBUG_SYMBOLS ?= 1
ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
else
# debug variants always get Full Debug Symbols (if available)
- ENABLE_FULL_DEBUG_SYMBOLS = 1
+ # ENABLE_FULL_DEBUG_SYMBOLS = 1
+ ENABLE_FULL_DEBUG_SYMBOLS = $(FULL_DEBUG_SYMBOLS)
endif
_JUNK_ := $(shell \
echo >&2 "INFO: ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)")
@@ -172,7 +178,9 @@
_JUNK_ := $(shell \
echo >&2 "INFO: STRIP_POLICY=$(STRIP_POLICY)")
- ZIP_DEBUGINFO_FILES ?= 1
+ # Disable ZIP_DEBUGINFO_FILES by default because dtrace tests are
+ # failing in nightly when the debug info files are ZIP'ed.
+ ZIP_DEBUGINFO_FILES ?= 0
_JUNK_ := $(shell \
echo >&2 "INFO: ZIP_DEBUGINFO_FILES=$(ZIP_DEBUGINFO_FILES)")
--- a/hotspot/make/windows/makefiles/defs.make Tue Apr 24 15:20:40 2012 -0700
+++ b/hotspot/make/windows/makefiles/defs.make Wed Apr 25 15:06:51 2012 -0700
@@ -143,7 +143,9 @@
MAKE_ARGS += ENABLE_FULL_DEBUG_SYMBOLS=$(ENABLE_FULL_DEBUG_SYMBOLS)
ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
- ZIP_DEBUGINFO_FILES ?= 1
+ # Disable ZIP_DEBUGINFO_FILES by default because various tests are
+ # failing in nightly when the debug info files are ZIP'ed.
+ ZIP_DEBUGINFO_FILES ?= 0
else
ZIP_DEBUGINFO_FILES=0
endif