8157236: attach on ARMv7 fails with com.sun.tools.attach.AttachNotSupportedException: Unable to open socket file
Summary: Add more diagnostic to attach code
Reviewed-by: dholmes, alanb
--- a/hotspot/src/os/aix/vm/attachListener_aix.cpp Tue Aug 16 09:56:18 2016 -0400
+++ b/hotspot/src/os/aix/vm/attachListener_aix.cpp Thu Aug 18 14:07:00 2016 +0300
@@ -494,7 +494,7 @@
if (ret == 0) {
ret = ::unlink(fn);
if (ret == -1) {
- debug_only(warning("failed to remove stale attach pid file at %s", fn));
+ log_debug(attach)("Failed to remove stale attach pid file at %s", fn);
}
}
}
@@ -537,16 +537,23 @@
struct stat64 st;
RESTARTABLE(::stat64(fn, &st), ret);
if (ret == -1) {
+ log_trace(attach)("Failed to find attach file: %s, trying alternate", fn);
snprintf(fn, sizeof(fn), "%s/.attach_pid%d",
os::get_temp_directory(), os::current_process_id());
RESTARTABLE(::stat64(fn, &st), ret);
+ if (ret == -1) {
+ log_debug(attach)("Failed to find attach file: %s", fn);
+ }
}
if (ret == 0) {
// simple check to avoid starting the attach mechanism when
// a bogus user creates the file
if (st.st_uid == geteuid()) {
init();
+ log_trace(attach)("Attach trigerred by %s", fn);
return true;
+ } else {
+ log_debug(attach)("File %s has wrong user id %d (vs %d). Attach is not triggered", fn, st.st_uid, geteuid());
}
}
return false;
--- a/hotspot/src/os/bsd/vm/attachListener_bsd.cpp Tue Aug 16 09:56:18 2016 -0400
+++ b/hotspot/src/os/bsd/vm/attachListener_bsd.cpp Thu Aug 18 14:07:00 2016 +0300
@@ -456,7 +456,7 @@
if (ret == 0) {
ret = ::unlink(fn);
if (ret == -1) {
- debug_only(warning("failed to remove stale attach pid file at %s", fn));
+ log_debug(attach)("Failed to remove stale attach pid file at %s", fn);
}
}
}
@@ -493,19 +493,25 @@
if (init_at_startup() || is_initialized()) {
return false; // initialized at startup or already initialized
}
- char path[PATH_MAX + 1];
+ char fn[PATH_MAX + 1];
int ret;
struct stat st;
- snprintf(path, PATH_MAX + 1, "%s/.attach_pid%d",
+ snprintf(fn, PATH_MAX + 1, "%s/.attach_pid%d",
os::get_temp_directory(), os::current_process_id());
- RESTARTABLE(::stat(path, &st), ret);
+ RESTARTABLE(::stat(fn, &st), ret);
+ if (ret == -1) {
+ log_debug(attach)("Failed to find attach file: %s", fn);
+ }
if (ret == 0) {
// simple check to avoid starting the attach mechanism when
// a bogus user creates the file
if (st.st_uid == geteuid()) {
init();
+ log_trace(attach)("Attach trigerred by %s", fn);
return true;
+ } else {
+ log_debug(attach)("File %s has wrong user id %d (vs %d). Attach is not triggered", fn, st.st_uid, geteuid());
}
}
return false;
--- a/hotspot/src/os/linux/vm/attachListener_linux.cpp Tue Aug 16 09:56:18 2016 -0400
+++ b/hotspot/src/os/linux/vm/attachListener_linux.cpp Thu Aug 18 14:07:00 2016 +0300
@@ -453,7 +453,7 @@
if (ret == 0) {
ret = ::unlink(fn);
if (ret == -1) {
- debug_only(warning("failed to remove stale attach pid file at %s", fn));
+ log_debug(attach)("Failed to remove stale attach pid file at %s", fn);
}
}
}
@@ -496,16 +496,23 @@
struct stat64 st;
RESTARTABLE(::stat64(fn, &st), ret);
if (ret == -1) {
+ log_trace(attach)("Failed to find attach file: %s, trying alternate", fn);
snprintf(fn, sizeof(fn), "%s/.attach_pid%d",
os::get_temp_directory(), os::current_process_id());
RESTARTABLE(::stat64(fn, &st), ret);
+ if (ret == -1) {
+ log_debug(attach)("Failed to find attach file: %s", fn);
+ }
}
if (ret == 0) {
// simple check to avoid starting the attach mechanism when
// a bogus user creates the file
if (st.st_uid == geteuid()) {
init();
+ log_trace(attach)("Attach trigerred by %s", fn);
return true;
+ } else {
+ log_debug(attach)("File %s has wrong user id %d (vs %d). Attach is not trigerred", fn, st.st_uid, geteuid());
}
}
return false;
--- a/hotspot/src/os/solaris/vm/attachListener_solaris.cpp Tue Aug 16 09:56:18 2016 -0400
+++ b/hotspot/src/os/solaris/vm/attachListener_solaris.cpp Thu Aug 18 14:07:00 2016 +0300
@@ -394,7 +394,7 @@
snprintf(initial_path, sizeof(initial_path), "%s.tmp", door_path);
RESTARTABLE(::creat(initial_path, S_IRUSR | S_IWUSR), fd);
if (fd == -1) {
- debug_only(warning("attempt to create %s failed", initial_path));
+ log_debug(attach)("attempt to create door file %s failed (%d)", initial_path, errno);
::door_revoke(dd);
return -1;
}
@@ -409,6 +409,7 @@
res = ::fattach(dd, initial_path);
}
if (res == -1) {
+ log_debug(attach)("unable to create door - fattach failed (%d)", errno);
::door_revoke(dd);
dd = -1;
}
@@ -419,12 +420,14 @@
if (::rename(initial_path, door_path) == -1) {
::close(dd);
::fdetach(initial_path);
+ log_debug(attach)("unable to create door - rename %s to %s failed (%d)", errno);
dd = -1;
}
}
if (dd >= 0) {
set_door_descriptor(dd);
set_door_path(door_path);
+ log_trace(attach)("door file %s created succesfully", door_path);
} else {
// unable to create door, attach it to file, or rename file into place
::unlink(initial_path);
@@ -602,7 +605,7 @@
if (ret == 0) {
ret = ::unlink(fn);
if (ret == -1) {
- debug_only(warning("failed to remove stale attach pid file at %s", fn));
+ log_debug(attach)("Failed to remove stale attach pid file at %s", fn);
}
}
}
@@ -645,9 +648,13 @@
struct stat64 st;
RESTARTABLE(::stat64(fn, &st), ret);
if (ret == -1) {
+ log_trace(attach)("Failed to find attach file: %s, trying alternate", fn);
snprintf(fn, sizeof(fn), "%s/.attach_pid%d",
os::get_temp_directory(), os::current_process_id());
RESTARTABLE(::stat64(fn, &st), ret);
+ if (ret == -1) {
+ log_debug(attach)("Failed to find attach file: %s", fn);
+ }
}
if (ret == 0) {
// simple check to avoid starting the attach mechanism when
--- a/hotspot/src/share/vm/logging/logTag.hpp Tue Aug 16 09:56:18 2016 -0400
+++ b/hotspot/src/share/vm/logging/logTag.hpp Thu Aug 18 14:07:00 2016 +0300
@@ -35,8 +35,9 @@
LOG_TAG(add) \
LOG_TAG(age) \
LOG_TAG(alloc) \
+ LOG_TAG(annotation) \
LOG_TAG(arguments) \
- LOG_TAG(annotation) \
+ LOG_TAG(attach) \
LOG_TAG(barrier) \
LOG_TAG(biasedlocking) \
LOG_TAG(bot) \