8005958: invoking a function through INVOKESTATIC with more arguments than it declares resulted in malformed bytecode being generated
Reviewed-by: lagergren, jlaskey
--- a/nashorn/src/jdk/nashorn/internal/codegen/CodeGenerator.java Tue Jan 15 13:10:20 2013 +0100
+++ b/nashorn/src/jdk/nashorn/internal/codegen/CodeGenerator.java Tue Jan 15 17:09:44 2013 +0100
@@ -506,15 +506,15 @@
int n = 0;
final Type[] params = signature == null ? null : Type.getMethodArguments(signature);
for (final Node arg : args) {
+ if (n >= argCount) {
+ break;
+ }
assert arg != null;
load(arg);
if (params != null) {
method.convert(params[n]);
}
n++;
- if (n >= argCount) {
- break;
- }
}
while (n < argCount) {
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/nashorn/test/script/basic/JDK-8005958.js Tue Jan 15 17:09:44 2013 +0100
@@ -0,0 +1,32 @@
+/*
+ * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * JDK-8005958 : invoking a function through INVOKESTATIC with more
+ * arguments than it declares resulted in malformed bytecode being
+ * generated.
+ *
+ * @test
+ * @run
+ */
+(function() {})(2)