8184286: print_tracing_info() does not use Unified Logging for output
Reviewed-by: ehelin, sangheki
--- a/src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp Thu Sep 21 14:32:05 2017 +0200
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2001, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2001, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -574,16 +574,10 @@
}
void ParallelScavengeHeap::print_tracing_info() const {
- if (TraceYoungGenTime) {
- double time = PSScavenge::accumulated_time()->seconds();
- tty->print_cr("[Accumulated GC generation 0 time %3.7f secs]", time);
- }
- if (TraceOldGenTime) {
- double time = UseParallelOldGC ? PSParallelCompact::accumulated_time()->seconds() : PSMarkSweep::accumulated_time()->seconds();
- tty->print_cr("[Accumulated GC generation 1 time %3.7f secs]", time);
- }
-
AdaptiveSizePolicyOutput::print();
+ log_debug(gc, heap, exit)("Accumulated young generation GC time %3.7f secs", PSScavenge::accumulated_time()->seconds());
+ log_debug(gc, heap, exit)("Accumulated old generation GC time %3.7f secs",
+ UseParallelOldGC ? PSParallelCompact::accumulated_time()->seconds() : PSMarkSweep::accumulated_time()->seconds());
}
--- a/src/hotspot/share/gc/parallel/psMarkSweep.cpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/gc/parallel/psMarkSweep.cpp Thu Sep 21 14:32:05 2017 +0200
@@ -173,7 +173,9 @@
TraceCollectorStats tcs(counters());
TraceMemoryManagerStats tms(true /* Full GC */,gc_cause);
- if (TraceOldGenTime) accumulated_time()->start();
+ if (log_is_enabled(Debug, gc, heap, exit)) {
+ accumulated_time()->start();
+ }
// Let the size policy know we're starting
size_policy->major_collection_begin();
@@ -342,7 +344,9 @@
// We collected the heap, recalculate the metaspace capacity
MetaspaceGC::compute_new_size();
- if (TraceOldGenTime) accumulated_time()->stop();
+ if (log_is_enabled(Debug, gc, heap, exit)) {
+ accumulated_time()->stop();
+ }
young_gen->print_used_change(young_gen_prev_used);
old_gen->print_used_change(old_gen_prev_used);
--- a/src/hotspot/share/gc/parallel/psParallelCompact.cpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/gc/parallel/psParallelCompact.cpp Thu Sep 21 14:32:05 2017 +0200
@@ -1778,7 +1778,9 @@
TraceCollectorStats tcs(counters());
TraceMemoryManagerStats tms(true /* Full GC */,gc_cause);
- if (TraceOldGenTime) accumulated_time()->start();
+ if (log_is_enabled(Debug, gc, heap, exit)) {
+ accumulated_time()->start();
+ }
// Let the size policy know we're starting
size_policy->major_collection_begin();
@@ -1897,7 +1899,7 @@
// Resize the metaspace capacity after a collection
MetaspaceGC::compute_new_size();
- if (TraceOldGenTime) {
+ if (log_is_enabled(Debug, gc, heap, exit)) {
accumulated_time()->stop();
}
--- a/src/hotspot/share/gc/parallel/psScavenge.cpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/gc/parallel/psScavenge.cpp Thu Sep 21 14:32:05 2017 +0200
@@ -306,7 +306,9 @@
TraceCollectorStats tcs(counters());
TraceMemoryManagerStats tms(false /* not full GC */,gc_cause);
- if (TraceYoungGenTime) accumulated_time()->start();
+ if (log_is_enabled(Debug, gc, heap, exit)) {
+ accumulated_time()->start();
+ }
// Let the size policy know we're starting
size_policy->minor_collection_begin();
@@ -607,7 +609,9 @@
CardTableExtension::verify_all_young_refs_imprecise();
}
- if (TraceYoungGenTime) accumulated_time()->stop();
+ if (log_is_enabled(Debug, gc, heap, exit)) {
+ accumulated_time()->stop();
+ }
young_gen->print_used_change(pre_gc_values.young_gen_used());
old_gen->print_used_change(pre_gc_values.old_gen_used());
--- a/src/hotspot/share/gc/shared/genCollectedHeap.cpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/gc/shared/genCollectedHeap.cpp Thu Sep 21 14:32:05 2017 +0200
@@ -1157,11 +1157,10 @@
}
void GenCollectedHeap::print_tracing_info() const {
- if (TraceYoungGenTime) {
- _young_gen->print_summary_info();
- }
- if (TraceOldGenTime) {
- _old_gen->print_summary_info();
+ if (log_is_enabled(Debug, gc, heap, exit)) {
+ LogStreamHandle(Debug, gc, heap, exit) lsh;
+ _young_gen->print_summary_info_on(&lsh);
+ _old_gen->print_summary_info_on(&lsh);
}
}
--- a/src/hotspot/share/gc/shared/generation.cpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/gc/shared/generation.cpp Thu Sep 21 14:32:05 2017 +0200
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -94,22 +94,14 @@
p2i(_virtual_space.high_boundary()));
}
-void Generation::print_summary_info() { print_summary_info_on(tty); }
-
void Generation::print_summary_info_on(outputStream* st) {
StatRecord* sr = stat_record();
double time = sr->accumulated_time.seconds();
- // I didn't want to change the logging when removing the level concept,
- // but I guess this logging could say young/old or something instead of 0/1.
- uint level;
- if (GenCollectedHeap::heap()->is_young_gen(this)) {
- level = 0;
- } else {
- level = 1;
- }
- st->print_cr("[Accumulated GC generation %d time %3.7f secs, "
- "%u GC's, avg GC time %3.7f]",
- level, time, sr->invocations,
+ st->print_cr("Accumulated %s generation GC time %3.7f secs, "
+ "%u GC's, avg GC time %3.7f",
+ GenCollectedHeap::heap()->is_young_gen(this) ? "young" : "old" ,
+ time,
+ sr->invocations,
sr->invocations > 0 ? time / sr->invocations : 0.0);
}
--- a/src/hotspot/share/gc/shared/generation.hpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/gc/shared/generation.hpp Thu Sep 21 14:32:05 2017 +0200
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2017, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -549,7 +549,6 @@
public:
StatRecord* stat_record() { return &_stat_record; }
- virtual void print_summary_info();
virtual void print_summary_info_on(outputStream* st);
// Performance Counter support
--- a/src/hotspot/share/runtime/globals.hpp Tue Sep 26 19:31:06 2017 -0700
+++ b/src/hotspot/share/runtime/globals.hpp Thu Sep 21 14:32:05 2017 +0200
@@ -2344,12 +2344,6 @@
range(30*K, max_uintx/BytesPerWord) \
constraint(InitialBootClassLoaderMetaspaceSizeConstraintFunc, AfterErgo)\
\
- product(bool, TraceYoungGenTime, false, \
- "Trace accumulated time for young collection") \
- \
- product(bool, TraceOldGenTime, false, \
- "Trace accumulated time for old collection") \
- \
product(bool, PrintHeapAtSIGBREAK, true, \
"Print heap layout in response to SIGBREAK") \
\