8166483: gtest fmw should be updated to support null detection on SS >= 12u4
authoriignatyev
Thu, 22 Sep 2016 15:40:35 +0300
changeset 41262 4bb69cdad04b
parent 41043 1cff7bfbf525
child 41263 c48dd6fb2680
child 41266 287d428e24a8
8166483: gtest fmw should be updated to support null detection on SS >= 12u4 Reviewed-by: dholmes, kzhaldyb
test/fmw/gtest/include/gtest/internal/gtest-port.h
--- a/test/fmw/gtest/include/gtest/internal/gtest-port.h	Fri Sep 16 10:57:17 2016 -0700
+++ b/test/fmw/gtest/include/gtest/internal/gtest-port.h	Thu Sep 22 15:40:35 2016 +0300
@@ -1586,12 +1586,13 @@
 GTEST_API_ size_t GetThreadCount();
 
 // Passing non-POD classes through ellipsis (...) crashes the ARM
-// compiler and generates a warning in Sun Studio.  The Nokia Symbian
+// compiler and generates a warning in Sun Studio before 12u4. The Nokia Symbian
 // and the IBM XL C/C++ compiler try to instantiate a copy constructor
 // for objects passed through ellipsis (...), failing for uncopyable
 // objects.  We define this to ensure that only POD is passed through
 // ellipsis on these systems.
-#if defined(__SYMBIAN32__) || defined(__IBMCPP__) || defined(__SUNPRO_CC)
+#if defined(__SYMBIAN32__) || defined(__IBMCPP__) || \
+     (defined(__SUNPRO_CC) && __SUNPRO_CC < 0x5130)
 // We lose support for NULL detection where the compiler doesn't like
 // passing non-POD classes through ellipsis (...).
 # define GTEST_ELLIPSIS_NEEDS_POD_ 1