7148143: PropertyChangeSupport.addPropertyChangeListener can throw ClassCastException
Reviewed-by: rupashka
--- a/jdk/src/share/classes/java/beans/ChangeListenerMap.java Mon Mar 05 16:46:38 2012 +0400
+++ b/jdk/src/share/classes/java/beans/ChangeListenerMap.java Mon Mar 05 18:01:13 2012 +0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2007, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -237,12 +237,5 @@
*
* @return a real listener
*/
- public final L extract(L listener) {
- while (listener instanceof EventListenerProxy) {
- @SuppressWarnings("unchecked")
- EventListenerProxy<L> proxy = (EventListenerProxy<L>) listener;
- listener = proxy.getListener();
- }
- return listener;
- }
+ public abstract L extract(L listener);
}
--- a/jdk/src/share/classes/java/beans/PropertyChangeSupport.java Mon Mar 05 16:46:38 2012 +0400
+++ b/jdk/src/share/classes/java/beans/PropertyChangeSupport.java Mon Mar 05 18:01:13 2012 +0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1996, 2008, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2012, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -533,5 +533,15 @@
protected PropertyChangeListener newProxy(String name, PropertyChangeListener listener) {
return new PropertyChangeListenerProxy(name, listener);
}
+
+ /**
+ * {@inheritDoc}
+ */
+ public final PropertyChangeListener extract(PropertyChangeListener listener) {
+ while (listener instanceof PropertyChangeListenerProxy) {
+ listener = ((PropertyChangeListenerProxy) listener).getListener();
+ }
+ return listener;
+ }
}
}
--- a/jdk/src/share/classes/java/beans/VetoableChangeSupport.java Mon Mar 05 16:46:38 2012 +0400
+++ b/jdk/src/share/classes/java/beans/VetoableChangeSupport.java Mon Mar 05 18:01:13 2012 +0400
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1996, 2011, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1996, 2012, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -522,5 +522,15 @@
protected VetoableChangeListener newProxy(String name, VetoableChangeListener listener) {
return new VetoableChangeListenerProxy(name, listener);
}
+
+ /**
+ * {@inheritDoc}
+ */
+ public final VetoableChangeListener extract(VetoableChangeListener listener) {
+ while (listener instanceof VetoableChangeListenerProxy) {
+ listener = ((VetoableChangeListenerProxy) listener).getListener();
+ }
+ return listener;
+ }
}
}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/java/beans/PropertyChangeSupport/Test7148143.java Mon Mar 05 18:01:13 2012 +0400
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 7148143
+ * @summary Tests ClassCastException for the PropertyChangeSupport class
+ * @author Sergey Malenkov
+ */
+
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import java.beans.PropertyChangeSupport;
+import java.util.EventListener;
+import java.util.EventListenerProxy;
+
+public class Test7148143 {
+
+ private static class CustomProxy
+ extends EventListenerProxy<EventListener>
+ implements PropertyChangeListener {
+
+ public CustomProxy() {
+ super(new EventListener() {
+ });
+ }
+
+ public void propertyChange(PropertyChangeEvent event) {
+ }
+ }
+
+ public static void main(String[] args) {
+ PropertyChangeListener listener = new CustomProxy();
+ PropertyChangeSupport support = new PropertyChangeSupport(listener);
+ support.addPropertyChangeListener(listener);
+ support.addPropertyChangeListener("foo", listener); // cast class exception
+ }
+}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/java/beans/VetoableChangeSupport/Test7148143.java Mon Mar 05 18:01:13 2012 +0400
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 7148143
+ * @summary Tests ClassCastException for the VetoableChangeSupport class
+ * @author Sergey Malenkov
+ */
+
+import java.beans.PropertyChangeEvent;
+import java.beans.VetoableChangeListener;
+import java.beans.VetoableChangeSupport;
+import java.util.EventListener;
+import java.util.EventListenerProxy;
+
+public class Test7148143 {
+
+ private static class CustomProxy
+ extends EventListenerProxy<EventListener>
+ implements VetoableChangeListener {
+
+ public CustomProxy() {
+ super(new EventListener() {
+ });
+ }
+
+ public void vetoableChange(PropertyChangeEvent event) {
+ }
+ }
+
+ public static void main(String[] args) {
+ VetoableChangeListener listener = new CustomProxy();
+ VetoableChangeSupport support = new VetoableChangeSupport(listener);
+ support.addVetoableChangeListener(listener);
+ support.addVetoableChangeListener("foo", listener); // cast class exception
+ }
+}