8212913: (Nested)ThreadsListHandleInErrorHandlingTest need to disable ShowRegistersOnAssert
authorstuefe
Wed, 24 Oct 2018 14:59:21 +0200
changeset 52270 487bd00f4ea8
parent 52269 a083dbe558f7
child 52271 1587306fe23f
child 52519 e202d04f4973
8212913: (Nested)ThreadsListHandleInErrorHandlingTest need to disable ShowRegistersOnAssert Reviewed-by: dholmes, mdoerr
test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java
test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java
--- a/test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java	Wed Oct 24 16:29:25 2018 +0530
+++ b/test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java	Wed Oct 24 14:59:21 2018 +0200
@@ -49,11 +49,15 @@
   public static void main(String[] args) throws Exception {
 
     // The -XX:ErrorHandlerTest=N option requires debug bits.
+    // Need to disable ShowRegistersOnAssert: that flag causes registers to be shown, which calls os::print_location,
+    // which - as part of its checks - will iterate the threads list under a ThreadListHandle, changing the max nesting
+    // counters and confusing this test.
     ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
         "-XX:+UnlockDiagnosticVMOptions",
         "-Xmx100M",
         "-XX:ErrorHandlerTest=17",
         "-XX:-CreateCoredumpOnCrash",
+        "-XX:-ShowRegistersOnAssert",
         "-version");
 
     OutputAnalyzer output_detail = new OutputAnalyzer(pb.start());
--- a/test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java	Wed Oct 24 16:29:25 2018 +0530
+++ b/test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java	Wed Oct 24 14:59:21 2018 +0200
@@ -49,11 +49,15 @@
   public static void main(String[] args) throws Exception {
 
     // The -XX:ErrorHandlerTest=N option requires debug bits.
+    // Need to disable ShowRegistersOnAssert: that flag causes registers to be shown, which calls os::print_location,
+    // which - as part of its checks - will iterate the threads list under a ThreadListHandle, changing the max nesting
+    // counters and confusing this test.
     ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(
         "-XX:+UnlockDiagnosticVMOptions",
         "-Xmx100M",
         "-XX:ErrorHandlerTest=16",
         "-XX:-CreateCoredumpOnCrash",
+        "-XX:-ShowRegistersOnAssert",
         "-version");
 
     OutputAnalyzer output_detail = new OutputAnalyzer(pb.start());