8011872: Include Bit Map addresses in the hs_err files
Reviewed-by: brutisso, jmasa
--- a/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -2809,6 +2809,23 @@
}
}
+
+void
+CMSCollector::print_on_error(outputStream* st) {
+ CMSCollector* collector = ConcurrentMarkSweepGeneration::_collector;
+ if (collector != NULL) {
+ CMSBitMap* bitmap = &collector->_markBitMap;
+ st->print_cr("Marking Bits: (CMSBitMap*) " PTR_FORMAT, bitmap);
+ bitmap->print_on_error(st, " Bits: ");
+
+ st->cr();
+
+ CMSBitMap* mut_bitmap = &collector->_modUnionTable;
+ st->print_cr("Mod Union Table: (CMSBitMap*) " PTR_FORMAT, mut_bitmap);
+ mut_bitmap->print_on_error(st, " Bits: ");
+ }
+}
+
////////////////////////////////////////////////////////
// CMS Verification Support
////////////////////////////////////////////////////////
@@ -6531,6 +6548,10 @@
}
}
+void CMSBitMap::print_on_error(outputStream* st, const char* prefix) const {
+ _bm.print_on_error(st, prefix);
+}
+
#ifndef PRODUCT
void CMSBitMap::assert_locked() const {
CMSLockVerifier::assert_locked(lock());
--- a/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -151,6 +151,8 @@
size_t heapWordToOffset(HeapWord* addr) const;
size_t heapWordDiffToOffsetDiff(size_t diff) const;
+ void print_on_error(outputStream* st, const char* prefix) const;
+
// debugging
// is this address range covered by the bit-map?
NOT_PRODUCT(
@@ -984,6 +986,8 @@
CMSAdaptiveSizePolicy* size_policy();
CMSGCAdaptivePolicyCounters* gc_adaptive_policy_counters();
+ static void print_on_error(outputStream* st);
+
// debugging
void verify();
bool verify_after_remark();
--- a/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -101,6 +101,10 @@
}
#endif
+void CMBitMapRO::print_on_error(outputStream* st, const char* prefix) const {
+ _bm.print_on_error(st, prefix);
+}
+
bool CMBitMap::allocate(ReservedSpace heap_rs) {
_bmStartWord = (HeapWord*)(heap_rs.base());
_bmWordSize = heap_rs.size()/HeapWordSize; // heap_rs.size() is in bytes
@@ -3277,6 +3281,13 @@
}
}
+void ConcurrentMark::print_on_error(outputStream* st) const {
+ st->print_cr("Marking Bits (Prev, Next): (CMBitMap*) " PTR_FORMAT ", (CMBitMap*) " PTR_FORMAT,
+ _prevMarkBitMap, _nextMarkBitMap);
+ _prevMarkBitMap->print_on_error(st, " Prev Bits: ");
+ _nextMarkBitMap->print_on_error(st, " Next Bits: ");
+}
+
// We take a break if someone is trying to stop the world.
bool ConcurrentMark::do_yield_check(uint worker_id) {
if (should_yield()) {
--- a/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -113,6 +113,8 @@
return res;
}
+ void print_on_error(outputStream* st, const char* prefix) const;
+
// debugging
NOT_PRODUCT(bool covers(ReservedSpace rs) const;)
};
@@ -829,6 +831,8 @@
void print_worker_threads_on(outputStream* st) const;
+ void print_on_error(outputStream* st) const;
+
// The following indicate whether a given verbose level has been
// set. Notice that anything above stats is conditional to
// _MARKING_VERBOSE_ having been set to 1
--- a/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -3427,6 +3427,15 @@
heap_region_iterate(&blk);
}
+void G1CollectedHeap::print_on_error(outputStream* st) const {
+ this->CollectedHeap::print_on_error(st);
+
+ if (_cm != NULL) {
+ st->cr();
+ _cm->print_on_error(st);
+ }
+}
+
void G1CollectedHeap::print_gc_threads_on(outputStream* st) const {
if (G1CollectedHeap::use_parallel_gc_threads()) {
workers()->print_worker_threads_on(st);
--- a/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -1575,6 +1575,7 @@
virtual void verify(bool silent);
virtual void print_on(outputStream* st) const;
virtual void print_extended_on(outputStream* st) const;
+ virtual void print_on_error(outputStream* st) const;
virtual void print_gc_threads_on(outputStream* st) const;
virtual void gc_threads_do(ThreadClosure* tc) const;
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -173,6 +173,12 @@
void reset_counters();
#endif // #ifndef PRODUCT
+ void print_on_error(outputStream* st) const {
+ st->print_cr("Marking Bits: (ParMarkBitMap*) " PTR_FORMAT, this);
+ _beg_bits.print_on_error(st, " Begin Bits: ");
+ _end_bits.print_on_error(st, " End Bits: ");
+ }
+
#ifdef ASSERT
void verify_clear() const;
inline void verify_bit(idx_t bit) const;
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -648,6 +648,15 @@
MetaspaceAux::print_on(st);
}
+void ParallelScavengeHeap::print_on_error(outputStream* st) const {
+ this->CollectedHeap::print_on_error(st);
+
+ if (UseParallelOldGC) {
+ st->cr();
+ PSParallelCompact::print_on_error(st);
+ }
+}
+
void ParallelScavengeHeap::gc_threads_do(ThreadClosure* tc) const {
PSScavenge::gc_task_manager()->threads_do(tc);
}
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -220,6 +220,7 @@
void prepare_for_verify();
virtual void print_on(outputStream* st) const;
+ virtual void print_on_error(outputStream* st) const;
virtual void print_gc_threads_on(outputStream* st) const;
virtual void gc_threads_do(ThreadClosure* tc) const;
virtual void print_tracing_info() const;
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -165,6 +165,10 @@
#endif // #ifdef ASSERT
+void PSParallelCompact::print_on_error(outputStream* st) {
+ _mark_bitmap.print_on_error(st);
+}
+
#ifndef PRODUCT
const char* PSParallelCompact::space_names[] = {
"old ", "eden", "from", "to "
--- a/hotspot/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -1163,6 +1163,8 @@
// Time since last full gc (in milliseconds).
static jlong millis_since_last_gc();
+ static void print_on_error(outputStream* st);
+
#ifndef PRODUCT
// Debugging support.
static const char* space_names[last_space_id];
--- a/hotspot/src/share/vm/gc_interface/collectedHeap.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/gc_interface/collectedHeap.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -567,6 +567,14 @@
print_on(st);
}
+ virtual void print_on_error(outputStream* st) const {
+ st->print_cr("Heap:");
+ print_extended_on(st);
+ st->cr();
+
+ _barrier_set->print_on(st);
+ }
+
// Print all GC threads (other than the VM thread)
// used by this heap.
virtual void print_gc_threads_on(outputStream* st) const = 0;
--- a/hotspot/src/share/vm/memory/genCollectedHeap.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/memory/genCollectedHeap.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -1133,6 +1133,17 @@
#endif // INCLUDE_ALL_GCS
}
+void GenCollectedHeap::print_on_error(outputStream* st) const {
+ this->CollectedHeap::print_on_error(st);
+
+#if INCLUDE_ALL_GCS
+ if (UseConcMarkSweepGC) {
+ st->cr();
+ CMSCollector::print_on_error(st);
+ }
+#endif // INCLUDE_ALL_GCS
+}
+
void GenCollectedHeap::print_tracing_info() const {
if (TraceGen0Time) {
get_gen(0)->print_summary_info();
--- a/hotspot/src/share/vm/memory/genCollectedHeap.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/memory/genCollectedHeap.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -344,6 +344,7 @@
virtual void print_gc_threads_on(outputStream* st) const;
virtual void gc_threads_do(ThreadClosure* tc) const;
virtual void print_tracing_info() const;
+ virtual void print_on_error(outputStream* st) const;
// PrintGC, PrintGCDetails support
void print_heap_change(size_t prev_used) const;
--- a/hotspot/src/share/vm/utilities/bitMap.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/utilities/bitMap.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -516,6 +516,10 @@
return sum;
}
+void BitMap::print_on_error(outputStream* st, const char* prefix) const {
+ st->print_cr("%s[" PTR_FORMAT ", " PTR_FORMAT ")",
+ prefix, map(), (char*)map() + (size() >> LogBitsPerByte));
+}
#ifndef PRODUCT
--- a/hotspot/src/share/vm/utilities/bitMap.hpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/utilities/bitMap.hpp Wed Apr 10 14:26:49 2013 +0200
@@ -262,6 +262,7 @@
bool is_full() const;
bool is_empty() const;
+ void print_on_error(outputStream* st, const char* prefix) const;
#ifndef PRODUCT
public:
--- a/hotspot/src/share/vm/utilities/vmError.cpp Wed Apr 10 13:27:35 2013 +0200
+++ b/hotspot/src/share/vm/utilities/vmError.cpp Wed Apr 10 14:26:49 2013 +0200
@@ -685,13 +685,7 @@
STEP(190, "(printing heap information)" )
if (_verbose && Universe::is_fully_initialized()) {
- // Print heap information before vm abort. As we'd like as much
- // information as possible in the report we ask for the
- // extended (i.e., more detailed) version.
- Universe::print_on(st, true /* extended */);
- st->cr();
-
- Universe::heap()->barrier_set()->print_on(st);
+ Universe::heap()->print_on_error(st);
st->cr();
st->print_cr("Polling page: " INTPTR_FORMAT, os::get_polling_page());