Mercurial Mercurial > jdk-sandbox / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8017571: JSR292: JVM crashing on assert "cast to instanceKlass" while producing MethodHandle for array methods with MethodHandle.findVirtual
authortwisti
Tue, 02 Jul 2013 20:27:00 -0700
changeset 18508 3b95160639d8
parent 18506 af8765fafc07
child 18509 cde003d396e1
8017571: JSR292: JVM crashing on assert "cast to instanceKlass" while producing MethodHandle for array methods with MethodHandle.findVirtual Reviewed-by: kvn
hotspot/src/share/vm/prims/methodHandles.cpp file | annotate | diff | comparison | revisions
hotspot/src/share/vm/runtime/reflection.cpp file | annotate | diff | comparison | revisions 
--- a/hotspot/src/share/vm/prims/methodHandles.cpp	Tue Jul 02 07:51:31 2013 +0200
+++ b/hotspot/src/share/vm/prims/methodHandles.cpp	Tue Jul 02 20:27:00 2013 -0700
@@ -1137,7 +1137,12 @@
   if (VerifyMethodHandles && caller_jh != NULL &&
       java_lang_invoke_MemberName::clazz(mname()) != NULL) {
     Klass* reference_klass = java_lang_Class::as_Klass(java_lang_invoke_MemberName::clazz(mname()));
-    if (reference_klass != NULL) {
+    if (reference_klass != NULL && reference_klass->oop_is_objArray()) {
+      reference_klass = ObjArrayKlass::cast(reference_klass)->bottom_klass();
+    }
+
+    // Reflection::verify_class_access can only handle instance classes.
+    if (reference_klass != NULL && reference_klass->oop_is_instance()) {
       // Emulate LinkResolver::check_klass_accessability.
       Klass* caller = java_lang_Class::as_Klass(JNIHandles::resolve_non_null(caller_jh));
       if (!Reflection::verify_class_access(caller,
--- a/hotspot/src/share/vm/runtime/reflection.cpp	Tue Jul 02 07:51:31 2013 +0200
+++ b/hotspot/src/share/vm/runtime/reflection.cpp	Tue Jul 02 20:27:00 2013 -0700
@@ -458,7 +458,7 @@
   // doesn't have a classloader.
   if ((current_class == NULL) ||
       (current_class == new_class) ||
-      (InstanceKlass::cast(new_class)->is_public()) ||
+      (new_class->is_public()) ||
       is_same_class_package(current_class, new_class)) {
     return true;
   }
jdk-sandbox