--- a/hotspot/test/gc/arguments/TestSurvivorAlignmentInBytesOption.java Mon Dec 22 10:41:57 2014 -0800
+++ b/hotspot/test/gc/arguments/TestSurvivorAlignmentInBytesOption.java Mon Dec 22 14:35:40 2014 -0800
@@ -51,8 +51,13 @@
// Verify that without -XX:+UnlockExperimentalVMOptions usage of
// SurvivorAlignmentInBytes option will cause JVM startup failure
// with the warning message saying that that option is experimental.
+ String shouldFailMessage = String.format("JVM option '%s' is "
+ + "experimental.%nJVM startup should fail without "
+ + "-XX:+UnlockExperimentalVMOptions option", optionName);
CommandLineOptionTest.verifyJVMStartup(
- new String[]{optionIsExperimental}, null, ExitCode.FAIL, false,
+ new String[]{optionIsExperimental}, null,
+ shouldFailMessage, shouldFailMessage,
+ ExitCode.FAIL, false,
"-XX:-UnlockExperimentalVMOptions",
CommandLineOptionTest.prepareBooleanFlag(
unlockExperimentalVMOpts, false),
@@ -61,17 +66,28 @@
// Verify that with -XX:+UnlockExperimentalVMOptions passed to JVM
// usage of SurvivorAlignmentInBytes option won't cause JVM startup
// failure.
+ String shouldPassMessage = String.format("JVM option '%s' is "
+ + "experimental.%nJVM startup should pass with "
+ + "-XX:+UnlockExperimentalVMOptions option", optionName);
+ String noWarningMessage = "There should be no warnings when use "
+ + "with -XX:+UnlockExperimentalVMOptions option";
CommandLineOptionTest.verifyJVMStartup(
- null, new String[]{optionIsExperimental}, ExitCode.OK, false,
+ null, new String[]{optionIsExperimental},
+ shouldPassMessage, noWarningMessage,
+ ExitCode.OK, false,
CommandLineOptionTest.prepareBooleanFlag(
unlockExperimentalVMOpts, true),
CommandLineOptionTest.prepareNumericFlag(optionName, 64));
- // Verify that if specified SurvivorAlignmentInBytes is lower then
+ // Verify that if specified SurvivorAlignmentInBytes is lower than
// ObjectAlignmentInBytes, then the JVM startup will fail with
// appropriate error message.
+ shouldFailMessage = String.format("JVM startup should fail with "
+ + "'%s' option value lower than ObjectAlignmentInBytes", optionName);
CommandLineOptionTest.verifyJVMStartup(
- new String[]{valueIsTooSmall}, null, ExitCode.FAIL, false,
+ new String[]{valueIsTooSmall}, null,
+ shouldFailMessage, shouldFailMessage,
+ ExitCode.FAIL, false,
CommandLineOptionTest.prepareBooleanFlag(
unlockExperimentalVMOpts, true),
CommandLineOptionTest.prepareNumericFlag(optionName, 2));
@@ -79,16 +95,25 @@
// Verify that if specified SurvivorAlignmentInBytes value is not
// a power of 2 then the JVM startup will fail with appropriate error
// message.
+ shouldFailMessage = String.format("JVM startup should fail with "
+ + "'%s' option value is not a power of 2", optionName);
CommandLineOptionTest.verifyJVMStartup(
- new String[]{mustBePowerOf2}, null, ExitCode.FAIL, false,
+ new String[]{mustBePowerOf2}, null,
+ shouldFailMessage, shouldFailMessage,
+ ExitCode.FAIL, false,
CommandLineOptionTest.prepareBooleanFlag(
unlockExperimentalVMOpts, true),
CommandLineOptionTest.prepareNumericFlag(optionName, 127));
// Verify that if SurvivorAlignmentInBytes has correct value, then
// the JVM will be started without errors.
+ shouldPassMessage = String.format("JVM startup should pass with "
+ + "correct '%s' option value", optionName);
+ noWarningMessage = String.format("There should be no warnings when use "
+ + "correct '%s' option value", optionName);
CommandLineOptionTest.verifyJVMStartup(
null, new String[]{".*SurvivorAlignmentInBytes.*"},
+ shouldPassMessage, noWarningMessage,
ExitCode.OK, false,
CommandLineOptionTest.prepareBooleanFlag(
unlockExperimentalVMOpts, true),
@@ -96,8 +121,10 @@
// Verify that we can setup different SurvivorAlignmentInBytes values.
for (int alignment = 32; alignment <= 128; alignment *= 2) {
+ shouldPassMessage = String.format("JVM startup should pass with "
+ + "'%s' = %d", optionName, alignment);
CommandLineOptionTest.verifyOptionValue(optionName,
- Integer.toString(alignment),
+ Integer.toString(alignment), shouldPassMessage,
CommandLineOptionTest.prepareBooleanFlag(
unlockExperimentalVMOpts, true),
CommandLineOptionTest.prepareNumericFlag(