7127524: P11TlsPrfGenerator has anonymous inner class with serialVersionUID
authorxuelei
Thu, 01 Aug 2013 07:34:30 -0700
changeset 19186 2b66b27d9ea9
parent 19185 34aa83720203
child 19187 5aa85bc92303
7127524: P11TlsPrfGenerator has anonymous inner class with serialVersionUID Reviewed-by: vinnie
jdk/src/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java
--- a/jdk/src/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java	Mon Jul 29 12:35:42 2013 +0400
+++ b/jdk/src/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java	Thu Aug 01 07:34:30 2013 -0700
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, 2011, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2013, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -96,10 +96,15 @@
         }
     }
 
-    // SecretKeySpec does not allow zero length keys, so we define our own class.
+    // SecretKeySpec does not allow zero length keys, so we define our
+    // own class.
+    //
+    // As an anonymous class cannot make any guarantees about serialization
+    // compatibility, it is nonsensical for an anonymous class to define a
+    // serialVersionUID. Suppress warnings relative to missing serialVersionUID
+    // field in the anonymous subclass of serializable SecretKey.
+    @SuppressWarnings("serial")
     private static final SecretKey NULL_KEY = new SecretKey() {
-        private static final long serialVersionUID = -8090049519656411362L;
-
         public byte[] getEncoded() {
             return new byte[0];
         }