8159156: [TESTBUG] ReserveMemory test is not useful on Aix.
authorgoetz
Thu, 09 Jun 2016 15:17:18 +0200
changeset 39279 2a8201076dd6
parent 39278 f3f298ae1023
child 39281 84e5f0fc2112
8159156: [TESTBUG] ReserveMemory test is not useful on Aix. Reviewed-by: dholmes
hotspot/test/runtime/memory/ReserveMemory.java
--- a/hotspot/test/runtime/memory/ReserveMemory.java	Wed Jun 08 13:24:36 2016 +0200
+++ b/hotspot/test/runtime/memory/ReserveMemory.java	Thu Jun 09 15:17:18 2016 +0200
@@ -21,10 +21,12 @@
  * questions.
  */
 
+// Aix commits on touch, so this test won't work.
 /*
  * @test
  * @key regression
  * @bug 8012015
+ * @requires !(os.family == "aix")
  * @summary Make sure reserved (but uncommitted) memory is not accessible
  * @library /testlibrary /test/lib
  * @modules java.base/jdk.internal.misc
@@ -36,18 +38,11 @@
  */
 
 import jdk.test.lib.*;
+import jdk.test.lib.Platform;
 
 import sun.hotspot.WhiteBox;
 
 public class ReserveMemory {
-  private static boolean isWindows() {
-    return System.getProperty("os.name").toLowerCase().startsWith("win");
-  }
-
-  private static boolean isOsx() {
-    return System.getProperty("os.name").toLowerCase().startsWith("mac");
-  }
-
   public static void main(String args[]) throws Exception {
     if (args.length > 0) {
       WhiteBox.getWhiteBox().readReservedMemory();
@@ -66,9 +61,9 @@
           "test");
 
     OutputAnalyzer output = new OutputAnalyzer(pb.start());
-    if (isWindows()) {
+    if (Platform.isWindows()) {
       output.shouldContain("EXCEPTION_ACCESS_VIOLATION");
-    } else if (isOsx()) {
+    } else if (Platform.isOSX()) {
       output.shouldContain("SIGBUS");
     } else {
       output.shouldContain("SIGSEGV");