8034768: [parfait] JNI exception pending in jdk/src/macosx/native/sun/awt/JavaTextAccessibility.m
Summary: handle possible JNI Exceptions
Reviewed-by: prr, serb
Contributed-by: peter.brunet@oracle.com
--- a/jdk/src/macosx/native/sun/awt/JavaTextAccessibility.m Fri Mar 28 16:40:00 2014 -0500
+++ b/jdk/src/macosx/native/sun/awt/JavaTextAccessibility.m Fri Mar 28 17:19:10 2014 -0500
@@ -40,6 +40,11 @@
*/
NSValue *javaIntArrayToNSRangeValue(JNIEnv* env, jintArray array) {
jint *values = (*env)->GetIntArrayElements(env, array, 0);
+ if (values == NULL) {
+ // Note: Java will not be on the stack here so a java exception can't happen and no need to call ExceptionCheck.
+ NSLog(@"%s failed calling GetIntArrayElements", __FUNCTION__);
+ return nil;
+ };
NSValue *value = [NSValue valueWithRange:NSMakeRange(values[0], values[1] - values[0])];
(*env)->ReleaseIntArrayElements(env, array, values, 0);
return value;
@@ -285,6 +290,11 @@
// We cheat because we know that the array is 4 elements long (x, y, width, height)
jdouble *values = (*env)->GetDoubleArrayElements(env, axBounds, 0);
+ if (values == NULL) {
+ // Note: Java will not be on the stack here so a java exception can't happen and no need to call ExceptionCheck.
+ NSLog(@"%s failed calling GetDoubleArrayElements", __FUNCTION__);
+ return nil;
+ };
NSRect bounds;
bounds.origin.x = values[0];
bounds.origin.y = [[[[self view] window] screen] frame].size.height - values[1] - values[3]; //values[1] is y-coord from top-left of screen. Flip. Account for the height (values[3]) when flipping