Mercurial Mercurial > jdk-sandbox / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6969569: assert(is_static() && is_constant()) failed: illegal call to constant_value()
authorkvn
Fri, 23 Jul 2010 10:07:46 -0700
changeset 6177 12835feea156
parent 6065 26016b8ed869
child 6178 bfbfaacd23e5
6969569: assert(is_static() && is_constant()) failed: illegal call to constant_value() Summary: Add missing is_static guard. Reviewed-by: twisti
hotspot/src/share/vm/ci/ciField.cpp file | annotate | diff | comparison | revisions
hotspot/src/share/vm/opto/macro.cpp file | annotate | diff | comparison | revisions 
--- a/hotspot/src/share/vm/ci/ciField.cpp	Thu Jul 22 15:29:22 2010 -0700
+++ b/hotspot/src/share/vm/ci/ciField.cpp	Fri Jul 23 10:07:46 2010 -0700
@@ -339,7 +339,7 @@
   if (_type != NULL) _type->print_name();
   else               tty->print("(reference)");
   tty->print(" is_constant=%s", bool_to_str(_is_constant));
-  if (_is_constant) {
+  if (_is_constant && is_static()) {
     tty->print(" constant_value=");
     _constant_value.print();
   }
--- a/hotspot/src/share/vm/opto/macro.cpp	Thu Jul 22 15:29:22 2010 -0700
+++ b/hotspot/src/share/vm/opto/macro.cpp	Fri Jul 23 10:07:46 2010 -0700
@@ -720,7 +720,7 @@
       if (basic_elem_type == T_OBJECT || basic_elem_type == T_ARRAY) {
         if (!elem_type->is_loaded()) {
           field_type = TypeInstPtr::BOTTOM;
-        } else if (field != NULL && field->is_constant()) {
+        } else if (field != NULL && field->is_constant() && field->is_static()) {
           // This can happen if the constant oop is non-perm.
           ciObject* con = field->constant_value().as_object();
           // Do not "join" in the previous type; it doesn't add value,
jdk-sandbox