6887895: CONSTANT_Class_info getBaseName does not handle arrays of primitives correctly
Reviewed-by: ksrini
--- a/langtools/src/share/classes/com/sun/tools/classfile/ConstantPool.java Mon Sep 28 16:48:30 2009 -0700
+++ b/langtools/src/share/classes/com/sun/tools/classfile/ConstantPool.java Tue Oct 13 14:02:53 2009 -0700
@@ -369,14 +369,33 @@
return 3;
}
+ /**
+ * Get the raw value of the class referenced by this constant pool entry.
+ * This will either be the name of the class, in internal form, or a
+ * descriptor for an array class.
+ * @return the raw value of the class
+ */
public String getName() throws ConstantPoolException {
return cp.getUTF8Value(name_index);
}
+ /**
+ * If this constant pool entry identifies either a class or interface type,
+ * or a possibly multi-dimensional array of a class of interface type,
+ * return the name of the class or interface in internal form. Otherwise,
+ * (i.e. if this is a possibly multi-dimensional array of a primitive type),
+ * return null.
+ * @return the base class or interface name
+ */
public String getBaseName() throws ConstantPoolException {
String name = getName();
- int index = name.indexOf("[L") + 1;
- return name.substring(index);
+ if (name.startsWith("[")) {
+ int index = name.indexOf("[L");
+ if (index == -1)
+ return null;
+ return name.substring(index + 2, name.length() - 1);
+ } else
+ return name;
}
public int getDimensionCount() throws ConstantPoolException {
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/langtools/test/tools/javap/classfile/T6887895.java Tue Oct 13 14:02:53 2009 -0700
@@ -0,0 +1,121 @@
+/*
+ * Copyright 2009 Sun Microsystems, Inc. All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+/*
+ * @test
+ * @bug 6887895
+ * @summary CONSTANT_Class_info getBaseName does not handle arrays of primitives correctly
+ */
+
+import java.io.*;
+import java.net.*;
+import java.util.*;
+import com.sun.tools.classfile.*;
+import com.sun.tools.classfile.ConstantPool.*;
+
+public class T6887895 {
+ public static void main(String[] args) throws Exception {
+ new T6887895().run();
+ }
+
+ void run() throws Exception {
+ Set<String> found = new TreeSet<String>();
+
+ ClassFile cf = getClassFile("T6887895$Test.class");
+ for (CPInfo cpInfo: cf.constant_pool.entries()) {
+ if (cpInfo instanceof CONSTANT_Class_info) {
+ CONSTANT_Class_info info = (CONSTANT_Class_info) cpInfo;
+ String name = info.getName();
+ String baseName = info.getBaseName();
+ System.out.println("found: " + name + " " + baseName);
+ if (baseName != null)
+ found.add(baseName);
+ }
+ }
+
+ String[] expectNames = {
+ "java/lang/Object",
+ "java/lang/String",
+ "T6887895",
+ "T6887895$Test"
+ };
+
+ Set<String> expect = new TreeSet<String>(Arrays.asList(expectNames));
+ if (!found.equals(expect)) {
+ System.err.println("found: " + found);
+ System.err.println("expect: " + expect);
+ throw new Exception("unexpected values found");
+ }
+ }
+
+ ClassFile getClassFile(String name) throws IOException, ConstantPoolException {
+ URL url = getClass().getResource(name);
+ InputStream in = url.openStream();
+ try {
+ return ClassFile.read(in);
+ } finally {
+ in.close();
+ }
+ }
+
+ class Test {
+ void m() {
+ boolean[] az = new boolean[0];
+ boolean[][] aaz = new boolean[0][];
+ boolean[][][] aaaz = new boolean[0][][];
+
+ byte[] ab = new byte[0];
+ byte[][] aab = new byte[0][];
+ byte[][][] aaab = new byte[0][][];
+
+ char[] ac = new char[0];
+ char[][] aac = new char[0][];
+ char[][][] aaac = new char[0][][];
+
+ double[] ad = new double[0];
+ double[][] aad = new double[0][];
+ double[][][] aaad = new double[0][][];
+
+ float[] af = new float[0];
+ float[][] aaf = new float[0][];
+ float[][][] aaaf = new float[0][][];
+
+ int[] ai = new int[0];
+ int[][] aai = new int[0][];
+ int[][][] aaai = new int[0][][];
+
+ long[] al = new long[0];
+ long[][] aal = new long[0][];
+ long[][][] aaal = new long[0][][];
+
+ short[] as = new short[0];
+ short[][] aas = new short[0][];
+ short[][][] aaas = new short[0][][];
+
+ String[] aS = new String[0];
+ String[][] aaS = new String[0][];
+ String[][][] aaaS = new String[0][][];
+ }
+ }
+}
+