8212595: Remove unused size_helper() in oop_oop_iterate* in instanceKlass.inline.hpp
Reviewed-by: shade, pliden
--- a/src/hotspot/share/oops/instanceKlass.hpp Thu Oct 18 00:56:38 2018 -0700
+++ b/src/hotspot/share/oops/instanceKlass.hpp Thu Oct 18 11:23:54 2018 +0200
@@ -1195,7 +1195,7 @@
// Iterate over all oop fields and metadata.
template <typename T, class OopClosureType>
- inline int oop_oop_iterate(oop obj, OopClosureType* closure);
+ inline void oop_oop_iterate(oop obj, OopClosureType* closure);
// Iterate over all oop fields in one oop map.
template <typename T, class OopClosureType>
@@ -1205,7 +1205,7 @@
// Reverse iteration
// Iterate over all oop fields and metadata.
template <typename T, class OopClosureType>
- inline int oop_oop_iterate_reverse(oop obj, OopClosureType* closure);
+ inline void oop_oop_iterate_reverse(oop obj, OopClosureType* closure);
private:
// Iterate over all oop fields in the oop maps.
@@ -1225,7 +1225,7 @@
// Iterate over all oop fields and metadata.
template <typename T, class OopClosureType>
- inline int oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr);
+ inline void oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr);
private:
// Iterate over all oop fields in one oop map.
--- a/src/hotspot/share/oops/instanceKlass.inline.hpp Thu Oct 18 00:56:38 2018 -0700
+++ b/src/hotspot/share/oops/instanceKlass.inline.hpp Thu Oct 18 11:23:54 2018 +0200
@@ -130,28 +130,24 @@
}
template <typename T, class OopClosureType>
-ALWAYSINLINE int InstanceKlass::oop_oop_iterate(oop obj, OopClosureType* closure) {
+ALWAYSINLINE void InstanceKlass::oop_oop_iterate(oop obj, OopClosureType* closure) {
if (Devirtualizer::do_metadata(closure)) {
Devirtualizer::do_klass(closure, this);
}
oop_oop_iterate_oop_maps<T>(obj, closure);
-
- return size_helper();
}
template <typename T, class OopClosureType>
-ALWAYSINLINE int InstanceKlass::oop_oop_iterate_reverse(oop obj, OopClosureType* closure) {
+ALWAYSINLINE void InstanceKlass::oop_oop_iterate_reverse(oop obj, OopClosureType* closure) {
assert(!Devirtualizer::do_metadata(closure),
"Code to handle metadata is not implemented");
oop_oop_iterate_oop_maps_reverse<T>(obj, closure);
-
- return size_helper();
}
template <typename T, class OopClosureType>
-ALWAYSINLINE int InstanceKlass::oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr) {
+ALWAYSINLINE void InstanceKlass::oop_oop_iterate_bounded(oop obj, OopClosureType* closure, MemRegion mr) {
if (Devirtualizer::do_metadata(closure)) {
if (mr.contains(obj)) {
Devirtualizer::do_klass(closure, this);
@@ -159,8 +155,6 @@
}
oop_oop_iterate_oop_maps_bounded<T>(obj, closure, mr);
-
- return size_helper();
}
#endif // SHARE_VM_OOPS_INSTANCEKLASS_INLINE_HPP