8000989: smaller code changes to make future JSR 292 backports easier
Reviewed-by: jrose
--- a/jdk/src/share/classes/java/lang/invoke/BoundMethodHandle.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/BoundMethodHandle.java Fri Oct 19 17:04:35 2012 -0700
@@ -79,7 +79,7 @@
default : throw new InternalError("unexpected xtype: " + xtype);
}
} catch (Throwable t) {
- throw new InternalError(t);
+ throw newInternalError(t);
}
}
@@ -97,7 +97,7 @@
case 'D': return cloneExtendD(type, form, (double) x);
}
} catch (Throwable t) {
- throw new InternalError(t);
+ throw newInternalError(t);
}
throw new InternalError("unexpected type: " + xtype);
}
@@ -115,7 +115,7 @@
try {
return clone(srcType, form);
} catch (Throwable t) {
- throw new InternalError(t);
+ throw newInternalError(t);
}
}
@@ -124,7 +124,7 @@
try {
return clone(newType, form.permuteArguments(1, reorder, basicTypes(newType.parameterList())));
} catch (Throwable t) {
- throw new InternalError(t);
+ throw newInternalError(t);
}
}
@@ -166,7 +166,7 @@
case 'J': return argJ(i);
}
} catch (Throwable ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
throw new InternalError("unexpected type: " + speciesData().types+"."+i);
}
@@ -192,7 +192,7 @@
try {
return (MethodHandle) argL(0);
} catch (Throwable ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
@@ -464,7 +464,7 @@
}
}
} catch (Throwable e) {
- throw new InternalError(e);
+ throw newInternalError(e);
}
for (SpeciesData d : CACHE.values()) {
@@ -748,7 +748,7 @@
try {
return LOOKUP.findGetter(cbmhClass, fieldName, fieldType);
} catch (NoSuchFieldException | IllegalAccessException e) {
- throw new InternalError(e);
+ throw newInternalError(e);
}
}
@@ -776,7 +776,7 @@
Field F_SPECIES_DATA = cbmh.getDeclaredField("SPECIES_DATA");
return (SpeciesData) F_SPECIES_DATA.get(null);
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
@@ -802,7 +802,7 @@
try {
return linkConstructor(LOOKUP.findConstructor(cbmh, MethodType.fromMethodDescriptorString(makeSignature(types, true), null)));
} catch (NoSuchMethodException | IllegalAccessException | IllegalArgumentException | TypeNotPresentException e) {
- throw new InternalError(e);
+ throw newInternalError(e);
}
}
@@ -833,7 +833,7 @@
linkerMN = MemberName.getFactory().resolveOrFail(REF_invokeStatic, linkerMN, null, NoSuchMethodException.class);
assert(linkerMN.isStatic());
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
// extend arguments array
Object[] newArgs = Arrays.copyOf(initName.arguments, initName.arguments.length + 1);
--- a/jdk/src/share/classes/java/lang/invoke/CallSite.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/CallSite.java Fri Oct 19 17:04:35 2012 -0700
@@ -222,7 +222,7 @@
GET_TARGET = IMPL_LOOKUP.
findVirtual(CallSite.class, "getTarget", MethodType.methodType(MethodHandle.class));
} catch (ReflectiveOperationException e) {
- throw new InternalError(e);
+ throw newInternalError(e);
}
}
--- a/jdk/src/share/classes/java/lang/invoke/DirectMethodHandle.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/DirectMethodHandle.java Fri Oct 19 17:04:35 2012 -0700
@@ -218,7 +218,7 @@
try {
linker = IMPL_NAMES.resolveOrFail(REF_invokeStatic, linker, null, NoSuchMethodException.class);
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
final int DMH_THIS = 0;
final int ARG_BASE = 1;
@@ -554,7 +554,7 @@
try {
linker = IMPL_NAMES.resolveOrFail(REF_invokeVirtual, linker, null, NoSuchMethodException.class);
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
// What is the external type of the lambda form?
@@ -653,7 +653,7 @@
nf.resolve();
}
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
}
--- a/jdk/src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Fri Oct 19 17:04:35 2012 -0700
@@ -138,7 +138,7 @@
DUMP_CLASS_FILES_DIR = dumpDir;
System.out.println("Dumping class files to "+DUMP_CLASS_FILES_DIR+"/...");
} catch (Exception e) {
- throw new InternalError(e);
+ throw newInternalError(e);
}
} else {
DUMP_CLASS_FILES_COUNTERS = null;
@@ -162,7 +162,7 @@
file.close();
return null;
} catch (IOException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
});
@@ -279,7 +279,7 @@
try {
member = MEMBERNAME_FACTORY.resolveOrFail(REF_invokeStatic, member, HOST_CLASS, ReflectiveOperationException.class);
} catch (ReflectiveOperationException e) {
- throw new InternalError(e);
+ throw newInternalError(e);
}
//System.out.println("resolveInvokerMember => "+member);
return member;
--- a/jdk/src/share/classes/java/lang/invoke/Invokers.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/Invokers.java Fri Oct 19 17:04:35 2012 -0700
@@ -27,6 +27,7 @@
import java.util.Arrays;
import sun.invoke.empty.Empty;
+import static java.lang.invoke.MethodHandleStatics.*;
import static java.lang.invoke.MethodHandleNatives.Constants.*;
import static java.lang.invoke.MethodHandles.Lookup.IMPL_LOOKUP;
import static java.lang.invoke.LambdaForm.*;
@@ -128,9 +129,8 @@
try {
//Lookup.findVirtual(MethodHandle.class, name, type);
return IMPL_LOOKUP.resolveOrFail(REF_invokeVirtual, MethodHandle.class, name, type);
-
} catch (ReflectiveOperationException ex) {
- throw new InternalError("JVM cannot find invoker for "+type, ex);
+ throw newInternalError("JVM cannot find invoker for "+type, ex);
}
}
@@ -176,7 +176,7 @@
.findVirtual(MethodHandle.class, "asSpreader",
MethodType.methodType(MethodHandle.class, Class.class, int.class));
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
makeSpreader = MethodHandles.insertArguments(makeSpreader, 1, Object[].class, spreadArgCount);
vaInvoker = MethodHandles.filterArgument(arrayInvoker, 0, makeSpreader);
@@ -215,7 +215,7 @@
.findStatic(CallSite.class, "uninitializedCallSite",
MethodType.methodType(Empty.class));
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
invoker = MethodHandles.explicitCastArguments(invoker, MethodType.methodType(targetType.returnType()));
@@ -389,7 +389,7 @@
form.genericInvoker = gamh;
return gamh;
} catch (Exception ex) {
- throw new InternalError("Exception while resolving inexact invoke", ex);
+ throw newInternalError("Exception while resolving inexact invoke", ex);
}
}
@@ -456,7 +456,7 @@
NF_getCallSiteTarget.resolve();
// bound
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
--- a/jdk/src/share/classes/java/lang/invoke/LambdaForm.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/LambdaForm.java Fri Oct 19 17:04:35 2012 -0700
@@ -457,7 +457,7 @@
isCompiled = true;
return vmentry;
} catch (Error | Exception ex) {
- throw new InternalError(this.toString(), ex);
+ throw newInternalError(this.toString(), ex);
}
}
@@ -1547,7 +1547,7 @@
try {
zmem = IMPL_NAMES.resolveOrFail(REF_invokeStatic, zmem, null, NoSuchMethodException.class);
} catch (IllegalAccessException|NoSuchMethodException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
NamedFunction zcon = new NamedFunction(zmem);
Name n = new Name(zcon).newIndex(0);
--- a/jdk/src/share/classes/java/lang/invoke/MemberName.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/MemberName.java Fri Oct 19 17:04:35 2012 -0700
@@ -558,7 +558,7 @@
try {
return (MemberName) super.clone();
} catch (CloneNotSupportedException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
--- a/jdk/src/share/classes/java/lang/invoke/MethodHandle.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/MethodHandle.java Fri Oct 19 17:04:35 2012 -0700
@@ -1372,7 +1372,7 @@
NF_reinvokerTarget = new LambdaForm.NamedFunction(MethodHandle.class
.getDeclaredMethod("reinvokerTarget"));
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
@@ -1397,7 +1397,7 @@
try {
FORM_OFFSET = UNSAFE.objectFieldOffset(MethodHandle.class.getDeclaredField("form"));
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
}
--- a/jdk/src/share/classes/java/lang/invoke/MethodHandleImpl.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/MethodHandleImpl.java Fri Oct 19 17:04:35 2012 -0700
@@ -478,7 +478,7 @@
.getDeclaredMethod("checkSpreadArgument", Object.class, int.class));
NF_checkSpreadArgument.resolve();
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
}
--- a/jdk/src/share/classes/java/lang/invoke/MethodHandleStatics.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/java/lang/invoke/MethodHandleStatics.java Fri Oct 19 17:04:35 2012 -0700
@@ -93,6 +93,12 @@
}
// handy shared exception makers (they simplify the common case code)
+ /*non-public*/ static InternalError newInternalError(String message, Throwable cause) {
+ return new InternalError(message, cause);
+ }
+ /*non-public*/ static InternalError newInternalError(Throwable cause) {
+ return new InternalError(cause);
+ }
/*non-public*/ static RuntimeException newIllegalStateException(String message) {
return new IllegalStateException(message);
}
@@ -109,7 +115,7 @@
return new IllegalArgumentException(message(message, obj, obj2));
}
/*non-public*/ static Error uncaughtException(Exception ex) {
- throw new InternalError("uncaught exception", ex);
+ throw newInternalError("uncaught exception", ex);
}
static Error NYI() {
throw new AssertionError("NYI");
--- a/jdk/src/share/classes/sun/invoke/util/ValueConversions.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/src/share/classes/sun/invoke/util/ValueConversions.java Fri Oct 19 17:04:35 2012 -0700
@@ -475,7 +475,7 @@
.findStatic(THIS_CLASS, "fillNewTypedArray",
MethodType.methodType(Object[].class, Object[].class, Integer.class, Object[].class));
} catch (NoSuchMethodException | IllegalAccessException ex) {
- throw new InternalError("uncaught exception", ex);
+ throw newInternalError("uncaught exception", ex);
}
}
@@ -489,7 +489,7 @@
COPY_AS_PRIMITIVE_ARRAY = IMPL_LOOKUP.findStatic(THIS_CLASS, "copyAsPrimitiveArray", MethodType.methodType(Object.class, Wrapper.class, Object[].class));
MAKE_LIST = IMPL_LOOKUP.findStatic(THIS_CLASS, "makeList", MethodType.methodType(List.class, Object[].class));
} catch (ReflectiveOperationException ex) {
- throw new InternalError("uncaught exception", ex);
+ throw newInternalError("uncaught exception", ex);
}
}
}
@@ -527,9 +527,8 @@
MethodHandle.class, int.class, MethodHandle.class);
m.setAccessible(true);
mh = IMPL_LOOKUP.unreflect(m);
-
} catch (ReflectiveOperationException | SecurityException ex) {
- throw new InternalError(ex);
+ throw newInternalError(ex);
}
COLLECT_ARGUMENTS = mh;
}
@@ -1209,4 +1208,12 @@
private static MethodHandle buildVarargsList(int nargs) {
return MethodHandles.filterReturnValue(varargsArray(nargs), LazyStatics.MAKE_LIST);
}
+
+ // handy shared exception makers (they simplify the common case code)
+ private static InternalError newInternalError(String message, Throwable cause) {
+ return new InternalError(message, cause);
+ }
+ private static InternalError newInternalError(Throwable cause) {
+ return new InternalError(cause);
+ }
}
--- a/jdk/test/java/lang/invoke/BigArityTest.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/test/java/lang/invoke/BigArityTest.java Fri Oct 19 17:04:35 2012 -0700
@@ -70,7 +70,7 @@
MethodHandles.lookup().unreflect(
BigArityTest.class.getDeclaredMethod("hashArguments", Object[].class));
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw new Error(ex);
}
}
static MethodHandle MH_hashArguments(int arity) {
--- a/jdk/test/java/lang/invoke/PrivateInvokeTest.java Thu Oct 18 11:09:00 2012 -0700
+++ b/jdk/test/java/lang/invoke/PrivateInvokeTest.java Fri Oct 19 17:04:35 2012 -0700
@@ -145,21 +145,21 @@
MH_DEBUG_STRING = DIRECT_INVOKER_LOOKUP
.findVirtual(MethodHandle.class, "debugString", methodType(String.class));
} catch (ReflectiveOperationException ex) {
- throw new InternalError(ex);
+ throw new Error(ex);
}
}
private Object internalMemberName(MethodHandle mh) {
try {
return MH_INTERNAL_MEMBER_NAME.invokeExact(mh);
} catch (Throwable ex) {
- throw new InternalError(ex);
+ throw new Error(ex);
}
}
private String debugString(MethodHandle mh) {
try {
return (String) MH_DEBUG_STRING.invokeExact(mh);
} catch (Throwable ex) {
- throw new InternalError(ex);
+ throw new Error(ex);
}
}
private static MethodHandle directInvoker(int refKind, MethodType mtype) {