6800586: -XX:+PrintGCDateStamps is using mt-unsafe localtime function
Summary: replaced localtime() with localtime_r() on Solaris and Linux.
Reviewed-by: apetrusenko, dholmes, jmasa
--- a/hotspot/src/os/linux/vm/os_linux.cpp Mon Feb 09 17:33:06 2009 +0300
+++ b/hotspot/src/os/linux/vm/os_linux.cpp Mon Feb 09 12:26:05 2009 -0800
@@ -1432,6 +1432,10 @@
return buf;
}
+struct tm* os::localtime_pd(const time_t* clock, struct tm* res) {
+ return localtime_r(clock, res);
+}
+
////////////////////////////////////////////////////////////////////////////////
// runtime exit support
--- a/hotspot/src/os/solaris/vm/os_solaris.cpp Mon Feb 09 17:33:06 2009 +0300
+++ b/hotspot/src/os/solaris/vm/os_solaris.cpp Mon Feb 09 12:26:05 2009 -0800
@@ -323,6 +323,10 @@
return (size_t)(base - bottom);
}
+struct tm* os::localtime_pd(const time_t* clock, struct tm* res) {
+ return localtime_r(clock, res);
+}
+
// interruptible infrastructure
// setup_interruptible saves the thread state before going into an
--- a/hotspot/src/os/windows/vm/os_windows.cpp Mon Feb 09 17:33:06 2009 +0300
+++ b/hotspot/src/os/windows/vm/os_windows.cpp Mon Feb 09 12:26:05 2009 -0800
@@ -327,6 +327,14 @@
return sz;
}
+struct tm* os::localtime_pd(const time_t* clock, struct tm* res) {
+ const struct tm* time_struct_ptr = localtime(clock);
+ if (time_struct_ptr != NULL) {
+ *res = *time_struct_ptr;
+ return res;
+ }
+ return NULL;
+}
LONG WINAPI topLevelExceptionFilter(struct _EXCEPTION_POINTERS* exceptionInfo);
--- a/hotspot/src/share/vm/runtime/os.cpp Mon Feb 09 17:33:06 2009 +0300
+++ b/hotspot/src/share/vm/runtime/os.cpp Mon Feb 09 12:26:05 2009 -0800
@@ -74,13 +74,11 @@
const int milliseconds_after_second =
milliseconds_since_19700101 % milliseconds_per_microsecond;
// Convert the time value to a tm and timezone variable
- const struct tm *time_struct_temp = localtime(&seconds_since_19700101);
- if (time_struct_temp == NULL) {
- assert(false, "Failed localtime");
+ struct tm time_struct;
+ if (localtime_pd(&seconds_since_19700101, &time_struct) == NULL) {
+ assert(false, "Failed localtime_pd");
return NULL;
}
- // Save the results of localtime
- const struct tm time_struct = *time_struct_temp;
const time_t zone = timezone;
// If daylight savings time is in effect,
@@ -93,10 +91,10 @@
UTC_to_local = UTC_to_local - seconds_per_hour;
}
// Compute the time zone offset.
- // localtime(3C) sets timezone to the difference (in seconds)
+ // localtime_pd() sets timezone to the difference (in seconds)
// between UTC and and local time.
// ISO 8601 says we need the difference between local time and UTC,
- // we change the sign of the localtime(3C) result.
+ // we change the sign of the localtime_pd() result.
const time_t local_to_UTC = -(UTC_to_local);
// Then we have to figure out if if we are ahead (+) or behind (-) UTC.
char sign_local_to_UTC = '+';
--- a/hotspot/src/share/vm/runtime/os.hpp Mon Feb 09 17:33:06 2009 +0300
+++ b/hotspot/src/share/vm/runtime/os.hpp Mon Feb 09 12:26:05 2009 -0800
@@ -120,7 +120,8 @@
// Return current local time in a string (YYYY-MM-DD HH:MM:SS).
// It is MT safe, but not async-safe, as reading time zone
// information may require a lock on some platforms.
- static char* local_time_string(char *buf, size_t buflen);
+ static char* local_time_string(char *buf, size_t buflen);
+ static struct tm* localtime_pd (const time_t* clock, struct tm* res);
// Fill in buffer with current local time as an ISO-8601 string.
// E.g., YYYY-MM-DDThh:mm:ss.mmm+zzzz.
// Returns buffer, or NULL if it failed.