# HG changeset patch # User attila # Date 1415723264 -3600 # Node ID f34b84c9f880a642578934ec489ffb7c16a18ec0 # Parent 6d06a5827cf003b2ee80b9ab8d6263bad90fbe99 8062799: Binary logical expressions can have numeric types Reviewed-by: lagergren, sundar diff -r 6d06a5827cf0 -r f34b84c9f880 nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/ir/BinaryNode.java --- a/nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/ir/BinaryNode.java Tue Nov 11 16:17:37 2014 +0100 +++ b/nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/ir/BinaryNode.java Tue Nov 11 17:27:44 2014 +0100 @@ -264,6 +264,10 @@ case COMMARIGHT: { return rhs.getType(localVariableTypes); } + case AND: + case OR:{ + return Type.widestReturnType(lhs.getType(localVariableTypes), rhs.getType(localVariableTypes)); + } default: if (isComparison()) { return Type.BOOLEAN; diff -r 6d06a5827cf0 -r f34b84c9f880 nashorn/test/script/basic/JDK-8062799.js --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/nashorn/test/script/basic/JDK-8062799.js Tue Nov 11 17:27:44 2014 +0100 @@ -0,0 +1,103 @@ +/* + * Copyright (c) 2014 Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8062799: Binary logical expressions can have numeric types + * + * @test + * @run + */ + +(function() { + var inspect = Java.type("jdk.nashorn.test.tools.StaticTypeInspector").inspect; + + var b = true; + var i = 1; + var l = 4294967296; + var d = 2.1; + var o = "foo"; + + print(inspect(b || b, "b || b")); + print(inspect(b || i, "b || i")); + print(inspect(b || l, "b || l")); + print(inspect(b || d, "b || d")); + print(inspect(b || o, "b || o")); + + print(inspect(i || b, "i || b")); + print(inspect(i || i, "i || i")); + print(inspect(i || l, "i || l")); + print(inspect(i || d, "i || d")); + print(inspect(i || o, "i || o")); + + print(inspect(l || b, "l || b")); + print(inspect(l || i, "l || i")); + print(inspect(l || l, "l || l")); + print(inspect(l || d, "l || d")); + print(inspect(l || o, "l || o")); + + print(inspect(d || b, "d || b")); + print(inspect(d || i, "d || i")); + print(inspect(d || l, "d || l")); + print(inspect(d || d, "d || d")); + print(inspect(d || o, "d || o")); + + print(inspect(o || b, "o || b")); + print(inspect(o || i, "o || i")); + print(inspect(o || l, "o || l")); + print(inspect(o || d, "o || d")); + print(inspect(o || o, "o || o")); + + print(inspect(b && b, "b && b")); + print(inspect(b && i, "b && i")); + print(inspect(b && l, "b && l")); + print(inspect(b && d, "b && d")); + print(inspect(b && o, "b && o")); + + print(inspect(i && b, "i && b")); + print(inspect(i && i, "i && i")); + print(inspect(i && l, "i && l")); + print(inspect(i && d, "i && d")); + print(inspect(i && o, "i && o")); + + print(inspect(l && b, "l && b")); + print(inspect(l && i, "l && i")); + print(inspect(l && l, "l && l")); + print(inspect(l && d, "l && d")); + print(inspect(l && o, "l && o")); + + print(inspect(d && b, "d && b")); + print(inspect(d && i, "d && i")); + print(inspect(d && l, "d && l")); + print(inspect(d && d, "d && d")); + print(inspect(d && o, "d && o")); + + print(inspect(o && b, "o && b")); + print(inspect(o && i, "o && i")); + print(inspect(o && l, "o && l")); + print(inspect(o && d, "o && d")); + print(inspect(o && o, "o && o")); +})(); + + + + \ No newline at end of file diff -r 6d06a5827cf0 -r f34b84c9f880 nashorn/test/script/basic/JDK-8062799.js.EXPECTED --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/nashorn/test/script/basic/JDK-8062799.js.EXPECTED Tue Nov 11 17:27:44 2014 +0100 @@ -0,0 +1,50 @@ +b || b: boolean +b || i: boolean +b || l: boolean +b || d: boolean +b || o: boolean +i || b: int +i || i: int +i || l: long +i || d: double +i || o: int +l || b: long +l || i: long +l || l: long +l || d: double +l || o: long +d || b: double +d || i: double +d || l: double +d || d: double +d || o: double +o || b: object +o || i: object +o || l: object +o || d: object +o || o: object +b && b: boolean +b && i: int +b && l: long +b && d: double +b && o: object +i && b: boolean +i && i: int +i && l: long +i && d: double +i && o: object +l && b: boolean +l && i: long +l && l: long +l && d: double +l && o: object +d && b: boolean +d && i: double +d && l: double +d && d: double +d && o: object +o && b: boolean +o && i: int +o && l: long +o && d: double +o && o: object